[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/386 Ok cool if we're all ok with the new features then I'm satisfied. Code looked good as well VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/386 @newkek I understand. I like the `@value` concept -- its the JSON sub-object for creating the object (defined by `@type`). VOTE +1. --- If your project is set up for it, you can reply to

[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/386 I'm waiting to hear back from marko on the points he brought up to cast my vote :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/386 All tests pass with `docker/build.sh -t -n -i` - still going through code though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/386 I just pushed corrected docs, and renamed everything "domain" to "namespace". Waiting for more consensus to change the default gremlin namespace. --- If your project is set up for it, you can

[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/386 Still reviewing I would like to finish going through the code :) will try and do this later in the day. But looking good so far --- If your project is set up for it, you can reply to this

[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/386 is that an official +1 from you @PommeVerte or are you still reviewing ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/386 I'm liking how this has turned out. I personally don't have much of an opinion in regards to assuming gremlin is the default namespace and getting rid of `g:` though it does have the merit

[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/386 I think I agree with @newkek to push that off until we can get his massive PR reviewed/merged. Let's see if we can solve that separately. --- If your project is set up for it, you can reply

[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/386 A remark: @okram requested `TraversalExplanation` to be included in the list of Graph objects. I've noticed that the current `TraversalExplanation` Graphson serializer serializes a `Traversal`. In

[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]

Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/386 *NB: the conflicts for merge are caused by the CHANGELOG* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not