[GitHub] tinkerpop issue #456: TINKERPOP-1493 Groovy project doesn't build on Windows

[pauljackson]

Github user pauljackson commented on the issue:

https://github.com/apache/tinkerpop/pull/456
  
OK, sorry about that. I closed it now.

-Paul


From: Jason Plurad [mailto:notificati...@github.com]
Sent: Monday, October 31, 2016 12:13 PM
To: apache/tinkerpop
Cc: Paul A. Jackson; Mention
Subject: Re: [apache/tinkerpop] TINKERPOP-1493 Groovy project doesn't build 
on Windows (#456)


I meant that this pull request 
#456 can be closed 
@pauljackson. We'll work with the other one 
#457.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #456: TINKERPOP-1493 Groovy project doesn't build on Windows

[pluradj]

Github user pluradj commented on the issue:

https://github.com/apache/tinkerpop/pull/456
  
I meant that this pull request #456 can be closed @pauljackson. We'll work 
with the other one #457.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #456: TINKERPOP-1493 Groovy project doesn't build on Windows

[pluradj]

Github user pluradj commented on the issue:

https://github.com/apache/tinkerpop/pull/456
  
I think this one can be closed @pauljackson, and we'll use the other one to 
merge to all the branches. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #456: TINKERPOP-1493 Groovy project doesn't build on Windows

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/456
  
@pluradj are you going to have votes for these PRs sometime soon? i was 
sorta waiting for you to be the first to test this out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #456: TINKERPOP-1493 Groovy project doesn't build on Windows

[pauljackson]

Github user pauljackson commented on the issue:

https://github.com/apache/tinkerpop/pull/456
  
There’s more differences than just the comments at the head of these 
files, so you could copy them from 3.2.3 if you are ok with those changes.


From: Jason Plurad [mailto:notificati...@github.com]
Sent: Wednesday, October 12, 2016 12:27 PM
To: apache/tinkerpop
Cc: Paul A. Jackson; Author
Subject: Re: [apache/tinkerpop] TINKERPOP-1493 Groovy project doesn't build 
on Windows (#456)


One problem I'm seeing is that RAT doesn't like these files on Windows:

Unapproved licenses:



  bin/gremlin.sh

  gremlin-console/bin/gremlin.sh

No complaints from Linux/Mac since they resolve OK with the 
symlinks. On Windows, they get 
extracted as files with content:

../gremlin-console/bin/gremlin.sh




../target/apache-tinkerpop-gremlin-console-3.2.3-SNAPSHOT-standalone/bin/gremlin.sh

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #456: TINKERPOP-1493 Groovy project doesn't build on Windows

[pluradj]

Github user pluradj commented on the issue:

https://github.com/apache/tinkerpop/pull/456
  
Let's get 3.1.x fixed also. I don't see why not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #456: TINKERPOP-1493 Groovy project doesn't build on Windows

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/456
  
Not sure if it matters, but if we only bring this change to master, 3.1.x 
won't build on windows and the process will have diverged. not sure if we 
should let that happen. @pluradj do you have an opinion? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---