[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-22 Thread jorgebay 
Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
Nice! lgtm

VOTE +1


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-22 Thread spmallette 
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
Once I realized that the failure was not preventing the build it was easy 
to spot the problem. Just pushed a fix. 


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-22 Thread spmallette 
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
Interesting. Those errors don't seem to affect the build though - it still 
passes. I guess it's because we don't run any tests against those particular 
graphs on the "secure" server? or is it failing and i'm misinterpreting the 
build output?


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-21 Thread dkuppitz 
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
VOTE: +1


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-20 Thread jorgebay 
Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
@robertdale thanks for looking into it.

I'm running `mvn clean install -DskipTests` followed by a `mvn clean 
install -pl :gremlin-dotnet-tests -P gremlin-dotnet 
-DskipIntegrationTests=false` on a macOS Sierra.

This is the output for `mvn clean install -pl :gremlin-dotnet-tests -P 
gremlin-dotnet -DskipIntegrationTests=false`: 
https://gist.github.com/jorgebay/834b28c49290038bf59df11a32ec61ad


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-17 Thread robertdale 
Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
@jorgebay On which OS do you get the test errors?


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-17 Thread spmallette 
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
yeah - i'm just realizing how i flubbed a bunch of things on the last 
commit. i was so focused on your .net problems i only ran tests for .net 
:disappointed: 



---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-15 Thread spmallette 
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
This is strange. That command works for me. I'm not sure what could be 
wrong.


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-15 Thread jorgebay 
Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
I'm getting a path related issue on Gremlin.Net - Test module, while 
executing:
```
mvn clean install -pl :gremlin-dotnet-tests -P gremlin-dotnet 
-DskipIntegrationTests=false
```
From the root directory, I get:
```
[INFO] Starting Gremlin Server instances for native testing of Apache 
TinkerPop :: Gremlin.Net - Tests
[INFO] Configured Metrics Slf4jReporter configured with interval=18ms 
and loggerName=org.apache.tinkerpop.gremlin.server.Settings$Slf4jReporterMetrics
[INFO] Graph [graph] was successfully configured via 
[/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/tinkergraph-empty.properties].
[INFO] Graph [classic] was successfully configured via 
[/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/tinkergraph-empty.properties].
[INFO] Graph [modern] was successfully configured via 
[/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/tinkergraph-empty.properties].
[INFO] Graph [crew] was successfully configured via 
[/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/tinkergraph-empty.properties].
[INFO] Graph [grateful] was successfully configured via 
[/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/tinkergraph-empty.properties].
[INFO] Initialized Gremlin thread pool.  Threads in pool named with pattern 
gremlin-*
[INFO] Loaded gremlin-groovy ScriptEngine
[INFO] Initialized gremlin-groovy ScriptEngine with 
/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/generate-all.groovy
[INFO] Initialized GremlinExecutor and preparing GremlinScriptEngines 
instances.
[INFO] Initialized gremlin-groovy GremlinScriptEngine and registered metrics
[INFO] A GraphTraversalSource is now bound to [ggraph] with 
graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
[INFO] A GraphTraversalSource is now bound to [g] with 
graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
[INFO] A GraphTraversalSource is now bound to [gmodern] with 
graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
[INFO] A GraphTraversalSource is now bound to [gclassic] with 
graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
[INFO] A GraphTraversalSource is now bound to [gcrew] with 
graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
[INFO] A GraphTraversalSource is now bound to [ggrateful] with 
graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
[INFO] Adding the standard OpProcessor.
[INFO] Adding the control OpProcessor.
[INFO] Adding the session OpProcessor.
[INFO] Adding the traversal OpProcessor.
[INFO] Initialized cache for TraversalOpProcessor with size 1000 and 
expiration time of 60 ms
[INFO] Executing start up LifeCycleHook
[INFO] Configured application/vnd.gremlin-v1.0+gryo with 
org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV1d0
[WARNING] The 
org.apache.tinkerpop.gremlin.driver.ser.GryoLiteMessageSerializerV1d0 
serialization class is deprecated.
[INFO] Configured application/vnd.gremlin-v1.0+gryo-lite with 
org.apache.tinkerpop.gremlin.driver.ser.GryoLiteMessageSerializerV1d0
[INFO] Configured application/vnd.gremlin-v1.0+gryo-stringd with 
org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV1d0
[INFO] Configured application/vnd.gremlin-v1.0+json with 
org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV1d0
[INFO] Configured application/vnd.gremlin-v2.0+json with 
org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV2d0
[INFO] Configured application/json with 
org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV1d0
[INFO] Gremlin Server configured with worker thread pool of 1, gremlin pool 
of 8 and boss thread pool of 1.
[INFO] Channel started at port 45940.
[INFO] Gremlin Server with no authentication started on port 45940
[WARNING] Graph [graph] configured at [conf/tinkergraph-empty.properties] 
could not be instantiated and will not be available in Gremlin Server.  
GraphFactory message: The location configuration must resolve to a file and 
[conf/tinkergraph-empty.properties] does not
java.lang.IllegalArgumentException: The location configuration must resolve 
to a file and [conf/tinkergraph-empty.properties] does not
at 
org.apache.tinkerpop.gremlin.structure.util.GraphFactory.getConfiguration(GraphFactory.java:121)
```

The same issue appears for `classic`, `modern`, `crew`, ... graphs.


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-14 Thread jorgebay 
Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
Ah, I see its possible to run integration test using:

```
mvn clean install -pl :gremlin-dotnet-source,:gremlin-dotnet-tests -P 
gremlin-dotnet -DskipIntegrationTests=false
```

I don't think its necessary to allow builds from a subdir, so don't mind... 
as there is a way to build the projects themselves with a profile that includes 
integration tests

Thanks, my maven-fu is not strong at all.


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-14 Thread spmallette 
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
I think that there are a lot of path issues when building from outside of 
the root directory - gremlin-dotnet is not the only one. i typically just do 
this:

```text
mvn clean install -pl :gremlin-dotnet-source,:gremlin-dotnet-tests 
-DskipIntegrationTests=false
```

If you think it's important to fix the path problems you get when running 
from a sub-directory, I think it's best to create an issue in JIRA and I can 
come back to it later.


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-14 Thread jorgebay 
Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
hm... with the new server start scripts, when running from within a 
directory like:

```
cd gremlin-dotnet
mvn clean install -P gremlin-dotnet
```

I get the following issues:
```
[INFO] Using Groovy 2.4.11 to perform execute.
[INFO] Starting Gremlin Server instances for native testing of Apache 
TinkerPop :: Gremlin.Net - Tests
[INFO] Configured Metrics Slf4jReporter configured with interval=18ms 
and loggerName=org.apache.tinkerpop.gremlin.server.Settings$Slf4jReporterMetrics
[INFO] Graph [graph] was successfully configured via 
[/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/tinkergraph-empty.properties].
[INFO] Graph [classic] was successfully configured via 
[/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/tinkergraph-empty.properties].
[INFO] Graph [modern] was successfully configured via 
[/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/tinkergraph-empty.properties].
[INFO] Graph [crew] was successfully configured via 
[/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/tinkergraph-empty.properties].
[INFO] Graph [grateful] was successfully configured via 
[/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/tinkergraph-empty.properties].
[INFO] Initialized Gremlin thread pool.  Threads in pool named with pattern 
gremlin-*
[INFO] Loaded gremlin-groovy ScriptEngine
[INFO] Initialized gremlin-groovy ScriptEngine with 
/Users/jorge/workspace/tinkerpop/gremlin-server/src/test/scripts/generate-all.groovy
[INFO] Initialized GremlinExecutor and preparing GremlinScriptEngines 
instances.
[INFO] Initialized gremlin-groovy GremlinScriptEngine and registered metrics
[INFO] A GraphTraversalSource is now bound to [gclassic] with 
graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
[INFO] A GraphTraversalSource is now bound to [gcrew] with 
graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
[INFO] A GraphTraversalSource is now bound to [ggraph] with 
graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
[INFO] A GraphTraversalSource is now bound to [g] with 
graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
[INFO] A GraphTraversalSource is now bound to [gmodern] with 
graphtraversalsource[tinkergraph[vertices:0 edges:0], standard]
[INFO] Adding the standard OpProcessor.
[INFO] Adding the control OpProcessor.
[INFO] Adding the session OpProcessor.
[INFO] Adding the traversal OpProcessor.
[INFO] Initialized cache for TraversalOpProcessor with size 1000 and 
expiration time of 60 ms
[INFO] Executing start up LifeCycleHook
[INFO] Configured application/vnd.gremlin-v1.0+gryo with 
org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV1d0
[WARNING] The 
org.apache.tinkerpop.gremlin.driver.ser.GryoLiteMessageSerializerV1d0 
serialization class is deprecated.
[INFO] Configured application/vnd.gremlin-v1.0+gryo-lite with 
org.apache.tinkerpop.gremlin.driver.ser.GryoLiteMessageSerializerV1d0
[INFO] Configured application/vnd.gremlin-v1.0+gryo-stringd with 
org.apache.tinkerpop.gremlin.driver.ser.GryoMessageSerializerV1d0
[INFO] Configured application/vnd.gremlin-v1.0+json with 
org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV1d0
[INFO] Configured application/vnd.gremlin-v2.0+json with 
org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerGremlinV2d0
[INFO] Configured application/json with 
org.apache.tinkerpop.gremlin.driver.ser.GraphSONMessageSerializerV1d0
[INFO] Gremlin Server configured with worker thread pool of 1, gremlin pool 
of 8 and boss thread pool of 1.
[INFO] Channel started at port 45940.
[INFO] Gremlin Server with no authentication started on port 45940
[WARNING] Graph [graph] configured at [conf/tinkergraph-empty.properties] 
could not be instantiated and will not be available in Gremlin Server.  
GraphFactory message: The location configuration must resolve to a file and 
[conf/tinkergraph-empty.properties] does not
java.lang.IllegalArgumentException: The location configuration must resolve 
to a file and [conf/tinkergraph-empty.properties] does not
at 
org.apache.tinkerpop.gremlin.structure.util.GraphFactory.getConfiguration(GraphFactory.java:121)
at 
org.apache.tinkerpop.gremlin.structure.util.GraphFactory.open(GraphFactory.java:104)
at  ...
[WARNING] Graph [classic] configured at [conf/tinkergraph-empty.properties] 
could not be instantiated and will not be available in Gremlin Server.  
GraphFactory message: The location configuration must resolve to a file and 
[conf/tinkergraph-empty.properties] does not
java.lang.IllegalArgumentException: The location configuration must resolve 
to a file and

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay 
Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
`docker/build.sh -t -n -i` succeeds and tests pass.

VOTE: +1


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread jorgebay 
Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
Fixes look good to me!
I'm running integration tests locally on docker and I'll come back to give 
my plus one.


---

[GitHub] tinkerpop issue #747: TINKERPOP-1784 GLV Test Framework

2017-11-13 Thread spmallette 
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/747
  
@jorgebay fixed all the nits - thanks.


---