[GitHub] tinkerpop issue #775: TINKERPOP-1867 union() can produce extra traversers

2018-01-18 Thread robertdale
Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/775
  
VOTE +1


---


[GitHub] tinkerpop issue #775: TINKERPOP-1867 union() can produce extra traversers

2018-01-16 Thread spmallette
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/775
  
I was hoping I could come up with some other form of testing for this 
change, but I can't seem to think of anything...

VOTE +1 (pending changelog entry)


---


[GitHub] tinkerpop issue #775: TINKERPOP-1867 union() can produce extra traversers

2018-01-10 Thread dkuppitz
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/775
  
I've merged this branch into `master/` (locally), but it didn't change 
anything (which is actually a good thing, as I don't like surprises after a 
merge :)). We still get the kinda unexpected empty list in OLTP and the whole 
bunch of empty lists in OLAP:

```
gremlin> g = 
TinkerFactory.createModern().traversal().withoutStrategies(StandardVerificationStrategy)
==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
gremlin> 
g.V(1).repeat(aggregate("a").fold().store("x").unfold().both().where(without("a")).dedup()).cap("x").next()
==>[]
==>[v[1]]
==>[v[3],v[2],v[4]]
==>[v[6],v[5]]
gremlin> g = 
TinkerFactory.createModern().traversal().withComputer().withoutStrategies(StandardVerificationStrategy)
==>graphtraversalsource[tinkergraph[vertices:6 edges:6], graphcomputer]
gremlin> 
g.V(1).repeat(aggregate("a").fold().store("x").unfold().both().where(without("a")).dedup()).cap("x").next()
==>[v[1]]
==>[]
==>[]
==>[]
==>[]
==>[]
==>[v[2],v[4],v[3]]
==>[v[5],v[6]]
```

The results are the same in `tp32/` and `master/`, nothing's changed.

So, although the issue looks similar, it's probably a whole different thing 
that just happens to produce the same kind of unexpected result entries.


---


[GitHub] tinkerpop issue #775: TINKERPOP-1867 union() can produce extra traversers

2018-01-10 Thread dkuppitz
Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/775
  
I was hoping so, but no, it doesn't. At least not in `tp32/`. Maybe we're 
gonna be surprised once it's merged into `master/`.


---