Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/777
Great, thanks. I haven't been able to work on this recently but having that
merged will help. I'll check it out and update my test as well as fix the git
history of the branch for this and #772.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/777
#794 and #795 have both merged now. @PBGraff you now have a test graph with
a single simple self-loop subgraph that you can use (and obviously add other
test subgraphs as needed). hope that
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/777
I just added the new toy graph infrastructure on #794 - as soon as that
merges then we can finish this one up.
@PBGraff something still sorta looks fishy here with the commit history.
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/777
Thanks, @spmallette. Regarding the re-basing, I think I just managed that...
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/777
dar - a new graph - serious yak shaving going on with pull requests lately.
perhaps we create a "TEST" graph that can contain many disconnected
subgraphs that we can add to and adjust
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/777
I'll look, but I was also particularly interested in having a self-loop
edge to make sure that those are handled correctly as well.
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/777
I'm posting this to all open PRs of current relevance - this PR needs to
be rebased against the branch it is targeted against given a broken python
dependency that was published to pypi a day
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/777
The tests don't require spark. You just need to run the integration tests.
with docker it's as easy as: `docker/build.sh -t -i`. in a local maven
environment, you can `mvn verify -pl
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/777
When I run the integration tests with `docker/build.sh -t -i` I get some
failures in spark - do they fail for you too @PBGraff ?
```text
[ERROR] Tests run: 619, Failures: 0,
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/777
Tests pass now, good to go from me.
---
Github user PBGraff commented on the issue:
https://github.com/apache/tinkerpop/pull/777
@spmallette Updated PR from https://github.com/apache/tinkerpop/pull/770
---
11 matches
Mail list logo
