[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...

2018-02-20 Thread davebshow
Github user davebshow commented on the issue:

https://github.com/apache/tinkerpop/pull/796
  
sweet



---


[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...

2018-02-20 Thread spmallette
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/796
  
i think we can just CTR this in - it's pretty simple. i'll just cherry pick 
to tp32 and merge from there, then manually close this


---


[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...

2018-02-20 Thread davebshow
Github user davebshow commented on the issue:

https://github.com/apache/tinkerpop/pull/796
  
Yes this affects both 32 and master


---


[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...

2018-02-20 Thread spmallette
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/796
  
@davebshow this should target tp32 is that correct? 


---


[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...

2018-02-12 Thread spmallette
Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/796
  
@dancollins34 sorry it took me a while to take a look at this - thanks for 
submitting it. is this also a problem on 3.2.x? if so, this pull request should 
be re-targeted at the tp32 branch.


---


[GitHub] tinkerpop issue #796: Added correct setting of future exceptions, pursuant t...

2018-02-05 Thread davebshow
Github user davebshow commented on the issue:

https://github.com/apache/tinkerpop/pull/796
  
LGTM 

VOTE +1


---