[GitHub] tinkerpop issue #800: TINKERPOP-1726 Added idleReadLimit and idleWriteLimit ...

2018-02-21 Thread jorgebay
Github user jorgebay commented on the issue: https://github.com/apache/tinkerpop/pull/800 VOTE +1 ---

[GitHub] tinkerpop issue #800: TINKERPOP-1726 Added idleReadLimit and idleWriteLimit ...

2018-02-20 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/800 Yes, manually. I was surprised too. In practice, I don't think it's a big deal. The only reason I could see even using server-side keep-alive is because client-side keep-alive was sufficient.

[GitHub] tinkerpop issue #800: TINKERPOP-1726 Added idleReadLimit and idleWriteLimit ...

2018-02-20 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/800 I didn't notice that. I would have expected the client ping to reset the `keepAliveInterval` as the server would have to write a pong back to the client (i.e. the write should reset the

[GitHub] tinkerpop issue #800: TINKERPOP-1726 Added idleReadLimit and idleWriteLimit ...

2018-02-20 Thread robertdale
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/800 The only thing I don't like is that the client keep-alive doesn't seem to reset the 'write idle time' so the server still sends ping requests to the client even though the client is

[GitHub] tinkerpop issue #800: TINKERPOP-1726 Added idleReadLimit and idleWriteLimit ...

2018-02-20 Thread spmallette
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/800 I think I've incorporated all the suggested changes. Please take a look around and see if I missed anything. I will re-run tests on my side. ---