[GitHub] tinkerpop issue #812: TINKERPOP-1911 Refactored JavaTranslator

[jorgebay]

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/812
  
lgtm, VOTE +1


---

[GitHub] tinkerpop issue #812: TINKERPOP-1911 Refactored JavaTranslator

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/812
  
The local cache is specific to the `GraphTraversalSource` that's passed 
into the `of()` construction method. As the `GraphTraversalSource` is specific 
to the instance and is not known until construction I figured it was better if 
it were managed local to the `JavaTranslator` instance


---

[GitHub] tinkerpop issue #812: TINKERPOP-1911 Refactored JavaTranslator

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/812
  
What's the difference between the global method cache and the local method 
cache?


---

[GitHub] tinkerpop issue #812: TINKERPOP-1911 Refactored JavaTranslator

[BrynCooke]

Github user BrynCooke commented on the issue:

https://github.com/apache/tinkerpop/pull/812
  
+1 (Non binding)


---