[GitHub] tinkerpop pull request #690: TINKERPOP-1744 Unwrap AggregateException for sy...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/690 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #690: TINKERPOP-1744 Unwrap AggregateException for sy...
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/690#discussion_r132183072 --- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs --- @@ -0,0 +1,55 @@ +#region License + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#endregion + +using System; +using System.Runtime.ExceptionServices; +using System.Threading.Tasks; + +namespace Gremlin.Net.Structure --- End diff -- I've changed to `Gremlin.Net.Process` :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #690: TINKERPOP-1744 Unwrap AggregateException for sy...
Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/690#discussion_r132157746 --- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs --- @@ -0,0 +1,55 @@ +#region License + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#endregion + +using System; +using System.Runtime.ExceptionServices; +using System.Threading.Tasks; + +namespace Gremlin.Net.Structure --- End diff -- I still think that it fits better in `Process` as `Structure` only contains the Graph elements and the `IO` related stuff, but that's basically a question of personal taste. So I'll give this my +1 vote independently of this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #690: TINKERPOP-1744 Unwrap AggregateException for sy...
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/690#discussion_r132156425
--- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs ---
@@ -0,0 +1,55 @@
+#region License
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#endregion
+
+using System;
+using System.Runtime.ExceptionServices;
+using System.Threading.Tasks;
+
+namespace Gremlin.Net.Structure
+{
+///
+/// Contains useful methods that can be reused across the project.
+///
+internal static class Utils
+{
+///
+/// Waits the completion of the provided Task.
+/// When an AggregateException is thrown, the inner exception is
thrown.
+///
+public static void WaitUnwrap(this Task task)
+{
+try
+{
+task.Wait();
+}
+catch (AggregateException ex)
+{
+if (ex.InnerExceptions.Count == 1)
--- End diff --
Of course, you're right, the iteration only makes sense in the
documentation because they don't rethrow their `CustomException`. I didn't
really think that through when writing the comment...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #690: TINKERPOP-1744 Unwrap AggregateException for sy...
Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/690#discussion_r132153295 --- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs --- @@ -0,0 +1,55 @@ +#region License + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#endregion + +using System; +using System.Runtime.ExceptionServices; +using System.Threading.Tasks; + +namespace Gremlin.Net.Structure --- End diff -- It's being used in both `Gremlin.Net.Driver` and `Gremlin.Net.Process` namespaces. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #690: TINKERPOP-1744 Unwrap AggregateException for sy...
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/690#discussion_r132153059
--- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs ---
@@ -0,0 +1,55 @@
+#region License
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#endregion
+
+using System;
+using System.Runtime.ExceptionServices;
+using System.Threading.Tasks;
+
+namespace Gremlin.Net.Structure
+{
+///
+/// Contains useful methods that can be reused across the project.
+///
+internal static class Utils
+{
+///
+/// Waits the completion of the provided Task.
+/// When an AggregateException is thrown, the inner exception is
thrown.
+///
+public static void WaitUnwrap(this Task task)
+{
+try
+{
+task.Wait();
+}
+catch (AggregateException ex)
+{
+if (ex.InnerExceptions.Count == 1)
--- End diff --
Its not possible to throw more than 1 exception, once you throw the
following code is unreachable.
The `if` block is to be future proof, but its not required for now: all
`AggregateException` instances thrown have just 1 inner exception, as those are
caused by using `await` (not multiple parallel ops).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #690: TINKERPOP-1744 Unwrap AggregateException for sy...
Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/690#discussion_r132149297 --- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs --- @@ -0,0 +1,55 @@ +#region License + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#endregion + +using System; +using System.Runtime.ExceptionServices; +using System.Threading.Tasks; + +namespace Gremlin.Net.Structure --- End diff -- Wouldn't it make more sense to put this in `Gremlin.Net.Process` as all users of this are in that namespace? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #690: TINKERPOP-1744 Unwrap AggregateException for sy...
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/690#discussion_r132150241
--- Diff: gremlin-dotnet/src/Gremlin.Net/Structure/Utils.cs ---
@@ -0,0 +1,55 @@
+#region License
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#endregion
+
+using System;
+using System.Runtime.ExceptionServices;
+using System.Threading.Tasks;
+
+namespace Gremlin.Net.Structure
+{
+///
+/// Contains useful methods that can be reused across the project.
+///
+internal static class Utils
+{
+///
+/// Waits the completion of the provided Task.
+/// When an AggregateException is thrown, the inner exception is
thrown.
+///
+public static void WaitUnwrap(this Task task)
+{
+try
+{
+task.Wait();
+}
+catch (AggregateException ex)
+{
+if (ex.InnerExceptions.Count == 1)
--- End diff --
Why not iterating over the `InnerExceptions` and then rethrowing all of
them? That's done for example in the first listing here:
https://docs.microsoft.com/en-us/dotnet/standard/parallel-programming/exception-handling-task-parallel-library
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
