[jira] [Commented] (TINKERPOP-1280) VertexPrograms should declare traverser requirements
[
https://issues.apache.org/jira/browse/TINKERPOP-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492973#comment-15492973
]
ASF GitHub Bot commented on TINKERPOP-1280:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/404
> VertexPrograms should declare traverser requirements
>
>
> Key: TINKERPOP-1280
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1280
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
> Fix For: 3.2.3
>
>
> VertexPrograms should declare their {{TraverserRequirement}} which can then
> be propagated by the {{program()}} step. Most VPs (at least the ones I have
> written so far) rely on (labeled) path information and thus will fail if the
> actual traversal doesn't use any other steps with the same traverser
> requirements. I keep running into this issue whenever I write a new VP.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1280) VertexPrograms should declare traverser requirements
[
https://issues.apache.org/jira/browse/TINKERPOP-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492091#comment-15492091
]
ASF GitHub Bot commented on TINKERPOP-1280:
---
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/404
Most excellent and good tests.
VOTE: +1
> VertexPrograms should declare traverser requirements
>
>
> Key: TINKERPOP-1280
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1280
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
> Fix For: 3.2.3
>
>
> VertexPrograms should declare their {{TraverserRequirement}} which can then
> be propagated by the {{program()}} step. Most VPs (at least the ones I have
> written so far) rely on (labeled) path information and thus will fail if the
> actual traversal doesn't use any other steps with the same traverser
> requirements. I keep running into this issue whenever I write a new VP.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1280) VertexPrograms should declare traverser requirements
[
https://issues.apache.org/jira/browse/TINKERPOP-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487629#comment-15487629
]
ASF GitHub Bot commented on TINKERPOP-1280:
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/404
You mean `VertexProgram.getTraverserRequirements()`? [It already has its
JavaDoc](https://github.com/apache/tinkerpop/pull/404/files#diff-ca108f45ec7b5a288dfce8019f1a6813R188).
> VertexPrograms should declare traverser requirements
>
>
> Key: TINKERPOP-1280
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1280
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
> Fix For: 3.2.3
>
>
> VertexPrograms should declare their {{TraverserRequirement}} which can then
> be propagated by the {{program()}} step. Most VPs (at least the ones I have
> written so far) rely on (labeled) path information and thus will fail if the
> actual traversal doesn't use any other steps with the same traverser
> requirements. I keep running into this issue whenever I write a new VP.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1280) VertexPrograms should declare traverser requirements
[
https://issues.apache.org/jira/browse/TINKERPOP-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487459#comment-15487459
]
ASF GitHub Bot commented on TINKERPOP-1280:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/404
Very well done code. In other words, in full arrogance and conceit, this is
exactly how I would have done it thus, you work is perfect.
And like me, I would have skimped on the JavaDoc. Can you please add
JavaDoc to `VertexProperty.getTraverserRequirements()` before merging to master.
VOTE +1.
> VertexPrograms should declare traverser requirements
>
>
> Key: TINKERPOP-1280
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1280
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
> Fix For: 3.2.3
>
>
> VertexPrograms should declare their {{TraverserRequirement}} which can then
> be propagated by the {{program()}} step. Most VPs (at least the ones I have
> written so far) rely on (labeled) path information and thus will fail if the
> actual traversal doesn't use any other steps with the same traverser
> requirements. I keep running into this issue whenever I write a new VP.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1280) VertexPrograms should declare traverser requirements
[
https://issues.apache.org/jira/browse/TINKERPOP-1280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15483709#comment-15483709
]
ASF GitHub Bot commented on TINKERPOP-1280:
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/404
TINKERPOP-1280 VertexPrograms should declare traverser requirements
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1280
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/404.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #404
commit b3258693f8af76ec73fd76154523d45f606f2bfa
Author: Daniel Kuppitz
Date: 2016-09-12T08:43:39Z
Allow VertexPrograms to declare their traverser requirements.
> VertexPrograms should declare traverser requirements
>
>
> Key: TINKERPOP-1280
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1280
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
> Fix For: 3.2.3
>
>
> VertexPrograms should declare their {{TraverserRequirement}} which can then
> be propagated by the {{program()}} step. Most VPs (at least the ones I have
> written so far) rely on (labeled) path information and thus will fail if the
> actual traversal doesn't use any other steps with the same traverser
> requirements. I keep running into this issue whenever I write a new VP.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
