[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439334#comment-16439334
 ] 

ASF GitHub Bot commented on TINKERPOP-1410:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/831


> mvn install -Dmaven.test.skip=true doesn't work on a clean machine
> --
>
> Key: TINKERPOP-1410
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1410
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>
> {noformat}mvn install -Dmaven.test.skip=true{noformat}
> gives 
> {noformat}
> Failed to execute goal on project spark-gremlin: Could not resolve 
> dependencies for project 
> org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: Could not find 
> artifact org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in 
> apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] {noformat}
> The reason for this is that skipping tests also skips creating the test jar 
> artefact for hadoop-gremlin.
> https://issues.apache.org/jira/browse/MJAR-138
> Really the prefferred way for creating test jars is to have them as a 
> separate project:
> https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16437981#comment-16437981
 ] 

ASF GitHub Bot commented on TINKERPOP-1410:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/831
  
VOTE +1


> mvn install -Dmaven.test.skip=true doesn't work on a clean machine
> --
>
> Key: TINKERPOP-1410
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1410
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>
> {noformat}mvn install -Dmaven.test.skip=true{noformat}
> gives 
> {noformat}
> Failed to execute goal on project spark-gremlin: Could not resolve 
> dependencies for project 
> org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: Could not find 
> artifact org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in 
> apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] {noformat}
> The reason for this is that skipping tests also skips creating the test jar 
> artefact for hadoop-gremlin.
> https://issues.apache.org/jira/browse/MJAR-138
> Really the prefferred way for creating test jars is to have them as a 
> separate project:
> https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428962#comment-16428962
 ] 

ASF GitHub Bot commented on TINKERPOP-1410:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/831
  
VOTE: +1


> mvn install -Dmaven.test.skip=true doesn't work on a clean machine
> --
>
> Key: TINKERPOP-1410
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1410
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>
> {noformat}mvn install -Dmaven.test.skip=true{noformat}
> gives 
> {noformat}
> Failed to execute goal on project spark-gremlin: Could not resolve 
> dependencies for project 
> org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: Could not find 
> artifact org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in 
> apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] {noformat}
> The reason for this is that skipping tests also skips creating the test jar 
> artefact for hadoop-gremlin.
> https://issues.apache.org/jira/browse/MJAR-138
> Really the prefferred way for creating test jars is to have them as a 
> separate project:
> https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428767#comment-16428767
 ] 

ASF GitHub Bot commented on TINKERPOP-1410:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/831

TINKERPOP-1410 Removed test artifact of hadoop-gremlin

https://issues.apache.org/jira/browse/TINKERPOP-1410

The hadoop-gremlin test artifact allowed us to re-use some classes in spark 
and giraph testing, but (1) we probably shouldn't have done that in the first 
place as it's not a great practice and (2) we no longer have giraph and there 
really aren't any providers that rely on these classes that I'm aware of. I 
moved around a few classes to get this to all work which is described in more 
detail in upgrade docs. All the test still execute as they did before.

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1410

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/831.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #831


commit 7eec250a45a4a65bec87364d2c6ca8d895c7cb10
Author: Stephen Mallette 
Date:   2018-04-06T17:10:22Z

TINKERPOP-1410 Removed test artifact of hadoop-gremlin

The hadoop-gremlin test artifact allowed us to re-use some classes in spark 
and giraph testing, but (1) we probably shouldn't have done that in the first 
place as it's not a great practice and (2) we no longer have giraph and there 
really aren't any providers that rely on these classes that I'm aware of. I 
moved around a few classes to get this to all work which is described in more 
detail in upgrade docs. All the test still execute as they did before.




> mvn install -Dmaven.test.skip=true doesn't work on a clean machine
> --
>
> Key: TINKERPOP-1410
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1410
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: build-release
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
>  Labels: breaking
> Fix For: 3.4.0
>
>
> {noformat}mvn install -Dmaven.test.skip=true{noformat}
> gives 
> {noformat}
> Failed to execute goal on project spark-gremlin: Could not resolve 
> dependencies for project 
> org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: Could not find 
> artifact org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in 
> apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] {noformat}
> The reason for this is that skipping tests also skips creating the test jar 
> artefact for hadoop-gremlin.
> https://issues.apache.org/jira/browse/MJAR-138
> Really the prefferred way for creating test jars is to have them as a 
> separate project:
> https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856625#comment-15856625
 ] 

stephen mallette commented on TINKERPOP-1410:
-

I don't know why you would get that if you already ran {{mvn clean install}} 
successfully.

> mvn install -Dmaven.test.skip=true doesn't work on a clean machine
> --
>
> Key: TINKERPOP-1410
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1410
> Project: TinkerPop
>  Issue Type: Bug
>  Components: build-release
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>
> {noformat}mvn install -Dmaven.test.skip=true{noformat}
> gives 
> {noformat}
> Failed to execute goal on project spark-gremlin: Could not resolve 
> dependencies for project 
> org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: Could not find 
> artifact org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in 
> apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] {noformat}
> The reason for this is that skipping tests also skips creating the test jar 
> artefact for hadoop-gremlin.
> https://issues.apache.org/jira/browse/MJAR-138
> Really the prefferred way for creating test jars is to have them as a 
> separate project:
> https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[Prachi Shirish Khadke (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856557#comment-15856557
 ] 

Prachi Shirish Khadke commented on TINKERPOP-1410:
--

[~spmallette] I am getting this error

`Failed to execute goal on project spark-gremlin: Could not resolve 
dependencies for project org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: 
Could not find artifact 
org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in 
apache.snapshots`

while running `mvn deploy` to upload TinkerPop to Artifactory.

> mvn install -Dmaven.test.skip=true doesn't work on a clean machine
> --
>
> Key: TINKERPOP-1410
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1410
> Project: TinkerPop
>  Issue Type: Bug
>  Components: build-release
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>
> {noformat}mvn install -Dmaven.test.skip=true{noformat}
> gives 
> {noformat}
> Failed to execute goal on project spark-gremlin: Could not resolve 
> dependencies for project 
> org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: Could not find 
> artifact org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in 
> apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] {noformat}
> The reason for this is that skipping tests also skips creating the test jar 
> artefact for hadoop-gremlin.
> https://issues.apache.org/jira/browse/MJAR-138
> Really the prefferred way for creating test jars is to have them as a 
> separate project:
> https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1410) mvn install -Dmaven.test.skip=true doesn't work on a clean machine

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583041#comment-15583041
 ] 

stephen mallette commented on TINKERPOP-1410:
-

I really want this to change - causes extra hassles during release because you 
have to re-run tests you wouldn't otherwise run after you bump versions.

> mvn install -Dmaven.test.skip=true doesn't work on a clean machine
> --
>
> Key: TINKERPOP-1410
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1410
> Project: TinkerPop
>  Issue Type: Bug
>  Components: build-release
>Affects Versions: 3.2.1
>Reporter: Bryn Cooke
>
> {noformat}mvn install -Dmaven.test.skip=true{noformat}
> gives 
> {noformat}
> Failed to execute goal on project spark-gremlin: Could not resolve 
> dependencies for project 
> org.apache.tinkerpop:spark-gremlin:jar:3.2.2-SNAPSHOT: Could not find 
> artifact org.apache.tinkerpop:hadoop-gremlin:jar:tests:3.2.2-SNAPSHOT in 
> apache.snapshots (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] {noformat}
> The reason for this is that skipping tests also skips creating the test jar 
> artefact for hadoop-gremlin.
> https://issues.apache.org/jira/browse/MJAR-138
> Really the prefferred way for creating test jars is to have them as a 
> separate project:
> https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)