[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472861#comment-16472861 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/766 > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez >Priority: Major > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472836#comment-16472836 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 nice @dkuppitz - i can finally VOTE +1:1st_place_medal: better merge it through fast before someone sees a problem! :smiling_imp: > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez >Priority: Major > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471006#comment-16471006 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 Ok - the issue is related to how the `tabs.css` is in there: ```html ``` if that were a relative url like everything else, we'd have it. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez >Priority: Major > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470613#comment-16470613 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 i guess i will try again. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez >Priority: Major > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470604#comment-16470604 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/766 ![image](https://user-images.githubusercontent.com/572377/39879742-7f5ff648-5430-11e8-8afc-97dd669f6709.png) Worked well for me. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez >Priority: Major > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469144#comment-16469144 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 I just generated docs locally on this branch and i didn't get the tabs - it showed radio buttons. something wrong with the stylesheet after rebase maybe? > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez >Priority: Major > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452323#comment-16452323 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/766 It does scale to up to 4 tabs. Should we ever have more, we only need to tweak the [maxTabs](https://github.com/apache/tinkerpop/pull/766/files#diff-c362bf9cce8980393d4230e56c86a655R31) property and regenerate the CSS. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez >Priority: Major > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452035#comment-16452035 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 I was hoping to see us merge this for next release, but now that we have to release this patch because of the groovy bug, there won't be a lot of time to do much with the cool changes you have here. I was hoping we'd be able to see at least some GLV code translation in place for an actual release. Maybe that doesn't matter, in which case I guess we can merge this. Your call in that respect. A question though about the tab system...the tabs look good with two options as shown in your screenshot, but we have Console, Groovy, Java (maybe we wouldn't do that), Python, Javascript and .NET - how does it look when we have all those? Does the tab system scale that way? > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez >Priority: Major > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394558#comment-16394558 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/766 I have no problem pushing it off. It's unlikely that any other PR is going to affect the changes in this PR, so rebasing should be a no-brainer at any time. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez >Priority: Major > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393599#comment-16393599 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 wow - thanks to @robertdale with https://github.com/apache/tinkerpop/commit/34f924e50db3a20a3ba538c4e16bbfcfa9e7b873 because i can finally generate these docs with docker. i guess the question now is whether we rush to immediately look to merge this or push off until next release. i kinda feel like we should do the latter and not be hasty. I'd like some time to put in some other code in certain places and play around with it a bit before we get this on to a release branch and i don't know that i will have time for such things between now and first week of april when 3.2.8/3.3.2 are going out the door. any thoughts to the contrary? > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez >Priority: Major > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331443#comment-16331443 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 I'm posting this to all open PRs of current relevance - this PR needs to be rebased against the branch it is targeted against given a broken python dependency that was published to pypi a day or so ago. I've pushed a fix on tp32 and master at this point and David Brown is working on getting an issue raised with the project that initiated the problem. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez >Priority: Major > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319426#comment-16319426 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 @spmallette delete all of your images and then rebuild everything with `docker/build.sh -d |tee /tmp/console.log` and send me that output file. I wonder if it's choking on some python download. I've had that problem before. I just rebuilt everything from scratch and it still works. (I think I use master to build the image because I can override the maven url in `.travis.install-maven.sh`) > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316719#comment-16316719 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 don't have any of that stuff from my last attempt. what are you looking for exactly? i could fire it up again > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316460#comment-16316460 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 @spmallette did you save your console log? > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314890#comment-16314890 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 tried again using images from this branch and died the same way. so weird when stuff like this happens with docker. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313761#comment-16313761 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/766 I rebuilt my containers using this branch and `docker/build.sh -d` just finished `gremlin-variants.asciidoc`. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312251#comment-16312251 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 i deleted both when i did it, but i didn't rebuild from master - i built from this branch i guess > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312230#comment-16312230 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 Hmm.. there doesn't seem to be much difference. Are you deleting both the hadoop and base images? > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1631#comment-1631 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 Try rebuilding the docker images using master. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312209#comment-16312209 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/766 I saw some problems using docker above to generate docsis that still an issue? I'm getting this: ```text * source: /usr/src/tinkerpop/docs/src/reference/gremlin-variants.asciidoc target: /usr/src/tinkerpop/target/postprocess-asciidoc/reference/gremlin-variants.asciidoc progress: [==> ] 46%ImportError: No module named six in
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310123#comment-16310123 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 Excellent! VOTE +1 > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309568#comment-16309568 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 In the 'Console' tab, muli-line statements work. They have the `\` continuation after the callout. However, on the 'language' tab, these seem to be lost thus copy-paste multi-line statements do not work. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307236#comment-16307236 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 @dkuppitz I pushed a CTR fix for invisibility to tp32/master. This fixes the screen from being rendered to pixels wide. It didn't help the code block language popup though. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306374#comment-16306374 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 @dkuppitz my css skills are close to nil. what little i did play with it, i'm not sure it looks any better. and in the course of doing so, I've grown accustomed to it. In any case, one outstanding issue it the `Loading with BulkLoaderVertexProgram` tabs. The docker image uses awk 4.0.1. The result is that the tab sequence is 4,1,2,3. I'm not entirely sure what the cause is. It works correctly in awk 4.1. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305628#comment-16305628 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/766 @robertdale I like the look :) Do you want to give it a try and tweak the CSS? I just took it from [here](https://codepen.io/JamieKDonnelly/pen/wBQQPK), changed some colors and that's it. Maybe I just like the current look, because it just worked and I didn't have to mess too much with the CSS stuff. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304796#comment-16304796 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 Just what I was afraid of... the tabs look just like they do in the screenshots. And I don't mean that in a good way :smile: Seriously, this is fantastic. Multi-line works too. My issues: - [ ] I prefer the nice, thin border that was previously used - [ ] I'd like to see lighter-weight, less glaring tabs - See also https://thrift.apache.org/ (Example) - [ ] actually reading some of the finer details, the `WARNING` under `Mutating the Graph` states that 'JAVA' or 'GROOVY' should appear in the code blocks. This doesn't work for me in this PR or 3.2.7 docs. Looks like something introduced in 3.2.6 causes the screen to be super extra wide. - [ ] Under `SparkGraphComputer` -> `Loading with BulkLoaderVertexProgram` there are multiple tabs that don't seem to work correctly. It's also interesting in that we can now see what's rendered via console vs. hardcoded. Might need to revisit some of these sections and test for correctness. BTW, rebuilding the base image did the trick. Alternatively, it looks like I could have just installed `zip`. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304723#comment-16304723 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 @dkuppitz I did see that. There was a dep added to the image. I have that rebuilding now. Will let you know the results. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304719#comment-16304719 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/766 Hmm, this was another ticket and should be solved in this branch as I rebased it after the latest release. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304494#comment-16304494 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/766 What about for those of us unable to build it? ``` sh docker/build.sh -d * source: /usr/src/tinkermem/docs/src/recipes/olap-spark-yarn.asciidoc target: /usr/src/tinkermem/target/postprocess-asciidoc/recipes/olap-spark-yarn.asciidoc progress: [===> ] 55%java.io.FileNotFoundException: File file:/tmp/spark-gremlin.zip does not exist Type ':help' or ':h' for help. Display stack trace? [yN]pb(104); '' Last 10 lines of /usr/src/tinkermem/target/postprocess-asciidoc/recipes/olap-spark-yarn.asciidoc: at org.apache.spark.SparkContext$.getOrCreate(SparkContext.scala:2281) at org.apache.spark.SparkContext.getOrCreate(SparkContext.scala) at org.apache.tinkerpop.gremlin.spark.structure.Spark.create(Spark.java:52) at org.apache.tinkerpop.gremlin.spark.structure.Spark.create(Spark.java:60) at org.apache.tinkerpop.gremlin.spark.process.computer.SparkGraphComputer.lambda$submitWithExecutor$0(SparkGraphComputer.java:193) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748) gremlin> xargs: /usr/src/tinkermem/docs/preprocessor/preprocess-file.sh: exited with status 255; aborting ``` > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301562#comment-16301562 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user dkuppitz commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/766#discussion_r158510711 --- Diff: docs/preprocessor/preprocess-file.sh --- @@ -139,7 +140,7 @@ if [ ! ${SKIP} ] && [ $(grep -c '^\[gremlin' ${input}) -gt 0 ]; then ${lb} awk -f ${AWK_SCRIPTS}/language-variants.awk > ${output} ps=(${PIPESTATUS[@]}) - for i in {0..6}; do + for i in {0..7}; do --- End diff -- Ha, it should actually be 0 to 9, as it checks to exit code for each program in the pipe chain. Not sure when that went out of sync, but I'll fix it. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301269#comment-16301269 ] ASF GitHub Bot commented on TINKERPOP-1447: --- Github user jorgebay commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/766#discussion_r158473167 --- Diff: docs/preprocessor/preprocess-file.sh --- @@ -139,7 +140,7 @@ if [ ! ${SKIP} ] && [ $(grep -c '^\[gremlin' ${input}) -gt 0 ]; then ${lb} awk -f ${AWK_SCRIPTS}/language-variants.awk > ${output} ps=(${PIPESTATUS[@]}) - for i in {0..6}; do + for i in {0..7}; do --- End diff -- I'm not able to follow why this is a loop from 0 to 7... can we include a comment or move `7` to a constant with a name? > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300756#comment-16300756 ] ASF GitHub Bot commented on TINKERPOP-1447: --- GitHub user dkuppitz opened a pull request: https://github.com/apache/tinkerpop/pull/766 TINKERPOP-1447 Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste https://issues.apache.org/jira/browse/TINKERPOP-1447 Added automatic tab generation for all evaluated code block in all docs. A random screenshot from the generated reference docs (for those who are too lazy to build the docs): ![image](https://user-images.githubusercontent.com/572377/34280251-cc8c138c-e673-11e7-9bc8-9a1b23c7a714.png) VOTE: +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1447 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/766.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #766 commit 24dc1b7c13f1dd78dc30acbfe44e7ce0737261e8 Author: Daniel Kuppitz Date: 2017-12-15T21:30:59Z Added automatic tab generation for code snippets in asciidoc files. commit c4d71187da5945767e834d594e62c2c01b73e9c4 Author: Daniel Kuppitz Date: 2017-12-15T21:30:59Z Added automatic tab generation for code snippets in asciidoc files. commit 07cb6a3a93d7c1bc5f052893e038aae509c4832d Author: Daniel Kuppitz Date: 2017-12-21T15:16:08Z Merge branch 'TINKERPOP-1447' of https://git-wip-us.apache.org/repos/asf/tinkerpop into TINKERPOP-1447 > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1447) Add some JavaScript intelligence to the documentation so that comments and output are not copied in a copy paste
[ https://issues.apache.org/jira/browse/TINKERPOP-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490918#comment-15490918 ] Robert Dale commented on TINKERPOP-1447: Easy to do when there's a single statement. Harder to do when there are multiple statements. > Add some JavaScript intelligence to the documentation so that comments and > output are not copied in a copy paste > > > Key: TINKERPOP-1447 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1447 > Project: TinkerPop > Issue Type: Improvement > Components: documentation >Affects Versions: 3.1.4, 3.2.2 >Reporter: Marko A. Rodriguez > > [~rjbriody] was saying that it is possible to have it such that when you > copy/paste the following: > {code} > gremlin> g.V().out("created") // and example <1> > ==>blah > {code} > only {{g.V().out("created")}} is put into the clipboard. I believe he said it > was via some JavaScript magic --- beyond me, but it would be cool if we did > this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)