[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123347#comment-16123347
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/688
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123348#comment-16123348
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/687
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123132#comment-16123132
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/688
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123130#comment-16123130
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/687
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122940#comment-16122940
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/688
VOTE +1
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122941#comment-16122941
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/687
VOTE +1
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120370#comment-16120370
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/687
VOTE +1
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120373#comment-16120373
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/687
Done.
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120371#comment-16120371
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/688
VOTE +1
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119904#comment-16119904
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/687#discussion_r132184141
--- Diff:
gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/optimization/CountStrategyTest.java
---
@@ -95,6 +95,7 @@
{__.filter(__.bothE().count().is(gte(1))),
__.filter(__.bothE())},
{__.filter(__.bothE().count().is(gt(1))),
__.filter(__.bothE().limit(2).count().is(gt(1)))},
{__.filter(__.bothE().count().is(gte(2))),
__.filter(__.bothE().limit(2).count().is(gte(2)))},
+{__.and(__.out().count().is(0), __.in().count().is(0)),
__.and(__.not(__.out()), __.not(__.in()))}
});
--- End diff --
Perhaps one more test using both `and()` and `or()` and another pattern
such as `is(gt(1))`?
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119903#comment-16119903
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user okram commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/687#discussion_r132183920
--- Diff: CHANGELOG.asciidoc ---
@@ -143,6 +143,7 @@ TinkerPop 3.2.6 (Release Date: NOT OFFICIALLY RELEASED
YET)
This release also includes changes from <>.
+* Fixed a bug in `RangeByIsCountStrategy`.
--- End diff --
Can you be a bit more explicit? -- e.g. "Fixed a bug regarding
`ConnectiveSteps` in `RangeByIsCountStrategy`.
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119399#comment-16119399
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/687
`docker/build.sh -t -i` succeeded.
VOTE: +1
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118967#comment-16118967
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/688
`docker/build.sh -t -i` succeeded.
VOTE: +1
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118469#comment-16118469
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/688
TINKERPOP-1742 RangeByIsCountStrategy fails for ConnectiveSteps
https://issues.apache.org/jira/browse/TINKERPOP-1742
Fixed a bug in `RangeByIsCountStrategy`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1742
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/688.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #688
commit fde3aeb3235ea4d15f39982d836c9fb0f9f3ad53
Author: Daniel Kuppitz
Date: 2017-08-08T15:23:06Z
Fixed a bug in `RangeByIsCountStrategy`.
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1742) RangeByIsCountStrategy fails for ConnectiveSteps
[
https://issues.apache.org/jira/browse/TINKERPOP-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118467#comment-16118467
]
ASF GitHub Bot commented on TINKERPOP-1742:
---
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/687
TINKERPOP-1742 RangeByIsCountStrategy fails for ConnectiveSteps
https://issues.apache.org/jira/browse/TINKERPOP-1742
Fixed a bug in `RangeByIsCountStrategy`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1742-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/687.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #687
commit 14f03183b9507de38da5107e36f56daed609b773
Author: Daniel Kuppitz
Date: 2017-08-07T16:43:45Z
CTR: Fixed screwed Groovy test
commit fde3aeb3235ea4d15f39982d836c9fb0f9f3ad53
Author: Daniel Kuppitz
Date: 2017-08-08T15:23:06Z
Fixed a bug in `RangeByIsCountStrategy`.
commit e38df2d84cd0bc37b88e34627af353937fa1693d
Author: Daniel Kuppitz
Date: 2017-08-08T15:25:08Z
Merge branch 'TINKERPOP-1742' into TINKERPOP-1742-master
> RangeByIsCountStrategy fails for ConnectiveSteps
>
>
> Key: TINKERPOP-1742
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1742
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.5
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>
> {noformat}
> gremlin> g.V().
> ..1> and(
> ..2> out().count().is(eq(0)),
> ..3> __.in().count().is(eq(0))
> ..4> )
> Index: -1, Size: 2
> Type ':help' or ':h' for help.
> Display stack trace? [yN]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
