[jira] [Commented] (TINKERPOP-1867) union() can produce extra traversers
[
https://issues.apache.org/jira/browse/TINKERPOP-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1660#comment-1660
]
ASF GitHub Bot commented on TINKERPOP-1867:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/775
> union() can produce extra traversers
> -
>
> Key: TINKERPOP-1867
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1867
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: Daniel Kuppitz
>Priority: Major
>
> Hard to say where this bug is coming from but basically the most simple
> representation is:
> {code}
> gremlin> g.V(1,2).local(__.union(__.constant(1).count()))
> ==>1
> ==>0
> ==>1
> {code}
> Similar problems occur with {{sum()}} and other reducing barriers when used
> in this context.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1867) union() can produce extra traversers
[
https://issues.apache.org/jira/browse/TINKERPOP-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331595#comment-16331595
]
ASF GitHub Bot commented on TINKERPOP-1867:
---
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/775
VOTE +1
> union() can produce extra traversers
> -
>
> Key: TINKERPOP-1867
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1867
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: Daniel Kuppitz
>Priority: Major
>
> Hard to say where this bug is coming from but basically the most simple
> representation is:
> {code}
> gremlin> g.V(1,2).local(__.union(__.constant(1).count()))
> ==>1
> ==>0
> ==>1
> {code}
> Similar problems occur with {{sum()}} and other reducing barriers when used
> in this context.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1867) union() can produce extra traversers
[
https://issues.apache.org/jira/browse/TINKERPOP-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16327780#comment-16327780
]
ASF GitHub Bot commented on TINKERPOP-1867:
---
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/775
I was hoping I could come up with some other form of testing for this
change, but I can't seem to think of anything...
VOTE +1 (pending changelog entry)
> union() can produce extra traversers
> -
>
> Key: TINKERPOP-1867
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1867
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: Daniel Kuppitz
>Priority: Major
>
> Hard to say where this bug is coming from but basically the most simple
> representation is:
> {code}
> gremlin> g.V(1,2).local(__.union(__.constant(1).count()))
> ==>1
> ==>0
> ==>1
> {code}
> Similar problems occur with {{sum()}} and other reducing barriers when used
> in this context.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1867) union() can produce extra traversers
[
https://issues.apache.org/jira/browse/TINKERPOP-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318728#comment-16318728
]
Daniel Kuppitz commented on TINKERPOP-1867:
---
Hmm, at some point we allowed reducing barriers in {{repeat()}}, but seems it's
disallowed again in both main branches. However, allowing it produced the same
problem - empty traversers. The interesting thing about the test you've
mentioned is that it breaks if you remove just one of union's child traversals.
> union() can produce extra traversers
> -
>
> Key: TINKERPOP-1867
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1867
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>
> Hard to say where this bug is coming from but basically the most simple
> representation is:
> {code}
> gremlin> g.V(1,2).local(__.union(__.constant(1).count()))
> ==>1
> ==>0
> ==>1
> {code}
> Similar problems occur with {{sum()}} and other reducing barriers when used
> in this context.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1867) union() can produce extra traversers
[
https://issues.apache.org/jira/browse/TINKERPOP-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16318400#comment-16318400
]
stephen mallette commented on TINKERPOP-1867:
-
I don't get the full picture from TINKERPOP-1629. The issue is still open and I
don't see any code tied to it - does that mean nothing changed (or did he CTR
some changes in)? Also, do you understand what part of the reducing barrier
causes the extra traverser to show up in the output (i'm still trying to
understand that more fully)?
> union() can produce extra traversers
> -
>
> Key: TINKERPOP-1867
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1867
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>
> Hard to say where this bug is coming from but basically the most simple
> representation is:
> {code}
> gremlin> g.V(1,2).local(__.union(__.constant(1).count()))
> ==>1
> ==>0
> ==>1
> {code}
> Similar problems occur with {{sum()}} and other reducing barriers when used
> in this context.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1867) union() can produce extra traversers
[
https://issues.apache.org/jira/browse/TINKERPOP-1867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16317607#comment-16317607
]
Daniel Kuppitz commented on TINKERPOP-1867:
---
It looks similar to what we saw in
[TINKERPOP-1629|https://issues.apache.org/jira/browse/TINKERPOP-1629].
{noformat}
gremlin> __.inject(1,2).map(union(fold()).fold())
==>[[1]]
==>[[],[2]]
gremlin> __.inject(1,2).map(union(mean()).fold())
==>[1.0]
==>[NaN,2.0]
{noformat}
Marko tried hard to solve TINKERPOP-1629, but ultimately we decided to allow
reducing barriers despite the few issues that can occur. It's probably the
same thing for {{union()}}. We could write a simple strategy though, that would
wrap all reducing child traversals in a {{map()}}.
{noformat}
gremlin> __.inject(1,2).map(union(map(fold())).fold())
==>[[1]]
==>[[2]]
gremlin> __.inject(1,2).map(union(map(mean())).fold())
==>[1.0]
==>[2.0]
{noformat}
> union() can produce extra traversers
> -
>
> Key: TINKERPOP-1867
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1867
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.2.7
>Reporter: stephen mallette
>Assignee: stephen mallette
>
> Hard to say where this bug is coming from but basically the most simple
> representation is:
> {code}
> gremlin> g.V(1,2).local(__.union(__.constant(1).count()))
> ==>1
> ==>0
> ==>1
> {code}
> Similar problems occur with {{sum()}} and other reducing barriers when used
> in this context.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
