[jira] [Commented] (TINKERPOP-1883) gremlinpython future will never return
[ https://issues.apache.org/jira/browse/TINKERPOP-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370427#comment-16370427 ] ASF GitHub Bot commented on TINKERPOP-1883: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/796 > gremlinpython future will never return > -- > > Key: TINKERPOP-1883 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1883 > Project: TinkerPop > Issue Type: Bug > Components: python >Affects Versions: 3.3.1 > Environment: all >Reporter: Daniel Collins >Priority: Major > > When using the promise() method to get a future from a traversal, a call to > result() will never return if an error is thrown by result_set.all().result() > in driver_remote_connection.py on line 69. This call should be wrapped in a > try block to set the exception of future on failure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1883) gremlinpython future will never return
[ https://issues.apache.org/jira/browse/TINKERPOP-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370417#comment-16370417 ] ASF GitHub Bot commented on TINKERPOP-1883: --- Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/796 sweet > gremlinpython future will never return > -- > > Key: TINKERPOP-1883 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1883 > Project: TinkerPop > Issue Type: Bug > Components: python >Affects Versions: 3.3.1 > Environment: all >Reporter: Daniel Collins >Priority: Major > > When using the promise() method to get a future from a traversal, a call to > result() will never return if an error is thrown by result_set.all().result() > in driver_remote_connection.py on line 69. This call should be wrapped in a > try block to set the exception of future on failure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1883) gremlinpython future will never return
[ https://issues.apache.org/jira/browse/TINKERPOP-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370398#comment-16370398 ] ASF GitHub Bot commented on TINKERPOP-1883: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/796 i think we can just CTR this in - it's pretty simple. i'll just cherry pick to tp32 and merge from there, then manually close this > gremlinpython future will never return > -- > > Key: TINKERPOP-1883 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1883 > Project: TinkerPop > Issue Type: Bug > Components: python >Affects Versions: 3.3.1 > Environment: all >Reporter: Daniel Collins >Priority: Major > > When using the promise() method to get a future from a traversal, a call to > result() will never return if an error is thrown by result_set.all().result() > in driver_remote_connection.py on line 69. This call should be wrapped in a > try block to set the exception of future on failure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1883) gremlinpython future will never return
[ https://issues.apache.org/jira/browse/TINKERPOP-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370387#comment-16370387 ] ASF GitHub Bot commented on TINKERPOP-1883: --- Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/796 Yes this affects both 32 and master > gremlinpython future will never return > -- > > Key: TINKERPOP-1883 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1883 > Project: TinkerPop > Issue Type: Bug > Components: python >Affects Versions: 3.3.1 > Environment: all >Reporter: Daniel Collins >Priority: Major > > When using the promise() method to get a future from a traversal, a call to > result() will never return if an error is thrown by result_set.all().result() > in driver_remote_connection.py on line 69. This call should be wrapped in a > try block to set the exception of future on failure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1883) gremlinpython future will never return
[ https://issues.apache.org/jira/browse/TINKERPOP-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370024#comment-16370024 ] ASF GitHub Bot commented on TINKERPOP-1883: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/796 @davebshow this should target tp32 is that correct? > gremlinpython future will never return > -- > > Key: TINKERPOP-1883 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1883 > Project: TinkerPop > Issue Type: Bug > Components: python >Affects Versions: 3.3.1 > Environment: all >Reporter: Daniel Collins >Priority: Major > > When using the promise() method to get a future from a traversal, a call to > result() will never return if an error is thrown by result_set.all().result() > in driver_remote_connection.py on line 69. This call should be wrapped in a > try block to set the exception of future on failure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1883) gremlinpython future will never return
[ https://issues.apache.org/jira/browse/TINKERPOP-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360815#comment-16360815 ] ASF GitHub Bot commented on TINKERPOP-1883: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/796 @dancollins34 sorry it took me a while to take a look at this - thanks for submitting it. is this also a problem on 3.2.x? if so, this pull request should be re-targeted at the tp32 branch. > gremlinpython future will never return > -- > > Key: TINKERPOP-1883 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1883 > Project: TinkerPop > Issue Type: Bug >Affects Versions: 3.3.1 > Environment: all >Reporter: Daniel Collins >Priority: Major > > When using the promise() method to get a future from a traversal, a call to > result() will never return if an error is thrown by result_set.all().result() > in driver_remote_connection.py on line 69. This call should be wrapped in a > try block to set the exception of future on failure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1883) gremlinpython future will never return
[ https://issues.apache.org/jira/browse/TINKERPOP-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353230#comment-16353230 ] ASF GitHub Bot commented on TINKERPOP-1883: --- Github user davebshow commented on the issue: https://github.com/apache/tinkerpop/pull/796 LGTM VOTE +1 > gremlinpython future will never return > -- > > Key: TINKERPOP-1883 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1883 > Project: TinkerPop > Issue Type: Bug >Affects Versions: 3.3.1 > Environment: all >Reporter: Daniel Collins >Priority: Major > > When using the promise() method to get a future from a traversal, a call to > result() will never return if an error is thrown by result_set.all().result() > in driver_remote_connection.py on line 69. This call should be wrapped in a > try block to set the exception of future on failure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1883) gremlinpython future will never return
[ https://issues.apache.org/jira/browse/TINKERPOP-1883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351552#comment-16351552 ] ASF GitHub Bot commented on TINKERPOP-1883: --- GitHub user dancollins34 opened a pull request: https://github.com/apache/tinkerpop/pull/796 Added correct setting of future exceptions, pursuant to TINKERPOP-1883 https://issues.apache.org/jira/browse/TINKERPOP-1883 You can merge this pull request into a Git repository by running: $ git pull https://github.com/dancollins34/tinkerpop master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/796.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #796 commit 2257d951ebc11de3b3bd13c93417c970c3d5c182 Author: dancollins34 Date: 2018-02-03T22:24:44Z Added correct setting of future exceptions, pursuant to TINKERPOP-1883 https://issues.apache.org/jira/browse/TINKERPOP-1883 > gremlinpython future will never return > -- > > Key: TINKERPOP-1883 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1883 > Project: TinkerPop > Issue Type: Bug >Affects Versions: 3.3.1 > Environment: all >Reporter: Daniel Collins >Priority: Major > > When using the promise() method to get a future from a traversal, a call to > result() will never return if an error is thrown by result_set.all().result() > in driver_remote_connection.py on line 69. This call should be wrapped in a > try block to set the exception of future on failure. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
