svn commit: r1645874 - /tomcat/trunk/webapps/docs/config/cluster-valve.xml

Author: kfujino Date: Tue Dec 16 08:04:13 2014 New Revision: 1645874 URL: http://svn.apache.org/r1645874 Log: Add document of ClusterSingleSignOn. Modified: tomcat/trunk/webapps/docs/config/cluster-valve.xml Modified: tomcat/trunk/webapps/docs/config/cluster-valve.xml URL:

svn commit: r1645875 - in /tomcat/tc8.0.x/trunk/webapps/docs: changelog.xml config/cluster-valve.xml

Author: kfujino Date: Tue Dec 16 08:06:04 2014 New Revision: 1645875 URL: http://svn.apache.org/r1645875 Log: Add document of ClusterSingleSignOn. Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml tomcat/tc8.0.x/trunk/webapps/docs/config/cluster-valve.xml Modified:

svn commit: r1645876 - in /tomcat/tc7.0.x/trunk/webapps/docs: changelog.xml config/cluster-valve.xml

Author: kfujino Date: Tue Dec 16 08:07:19 2014 New Revision: 1645876 URL: http://svn.apache.org/r1645876 Log: Add document of ClusterSingleSignOn. Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml tomcat/tc7.0.x/trunk/webapps/docs/config/cluster-valve.xml Modified:

[Bug 57314] ServletRequestListener.requestInitialized() and ServletRequestListener.requestDestroyed() called in different threads

https://issues.apache.org/bugzilla/show_bug.cgi?id=57314 --- Comment #17 from Jozef Hartinger jozefhartin...@gmail.com --- Filters are not usable for this purpose as I need to be able to have my code called before other listeners. -- You are receiving this mail because: You are the assignee for

[Bug 53171] Deadlock under Java 7 / DefaultInstanceManager

https://issues.apache.org/bugzilla/show_bug.cgi?id=53171 Manoj manoj...@fisglobal.com changed: What|Removed |Added Status|RESOLVED|REOPENED

[Bug 53171] Deadlock under Java 7 / DefaultInstanceManager

https://issues.apache.org/bugzilla/show_bug.cgi?id=53171 --- Comment #3 from Manoj manoj...@fisglobal.com --- Below is my current tomcat version, Server version: Apache Tomcat/7.0.42 Server built: Jul 2 2013 08:57:41 Server number: 7.0.42.0 OS Name:Linux OS Version:

[Bug 53171] Deadlock under Java 7 / DefaultInstanceManager

https://issues.apache.org/bugzilla/show_bug.cgi?id=53171 --- Comment #5 from Manoj manoj...@fisglobal.com --- Created attachment 32294 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32294action=edit Method list -- You are receiving this mail because: You are the assignee for the bug.

[Bug 53171] Deadlock under Java 7 / DefaultInstanceManager

https://issues.apache.org/bugzilla/show_bug.cgi?id=53171 --- Comment #4 from Manoj manoj...@fisglobal.com --- Created attachment 32293 -- https://issues.apache.org/bugzilla/attachment.cgi?id=32293action=edit Monitor lock details -- You are receiving this mail because: You are the assignee for

[Bug 57338] SingleSignOnEntry cache of ClusterSingleSignOn valve is not synchronized on Tomcat startup

https://issues.apache.org/bugzilla/show_bug.cgi?id=57338 --- Comment #3 from Mark Thomas ma...@apache.org --- The biggest problem I can see with ReplicatedMap at this point as that I don't want to / can't replicated the two Maps (cache and reverse) as currently implemented since that means

svn commit: r1645903 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/catalina/startup/TomcatBaseTest.java test/org/apache/catalina/valves/rewrite/TestRewriteValve.java webapps/docs/changelog.xml

Author: rjung Date: Tue Dec 16 10:46:22 2014 New Revision: 1645903 URL: http://svn.apache.org/r1645903 Log: - Add lots of info the SnoopServlet output. - Add SnoopResult class to parse SnoopServlet response body. - Adjust TestRewriteValve to use the new SnoopServlet / SnoopResult The more

svn commit: r1645904 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/catalina/startup/TomcatBaseTest.java test/org/apache/catalina/valves/rewrite/TestRewriteValve.java webapps/docs/changelog.xml

Author: rjung Date: Tue Dec 16 10:51:26 2014 New Revision: 1645904 URL: http://svn.apache.org/r1645904 Log: Add new RequestDescriptor class which contains parsed data returned from the SnoopServlet. Adjust TestRewriteValve to use RequestDescriptor. Backport of r1645486 from trunk. Modified:

svn commit: r1645908 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/coyote/ajp/SimpleAjpClient.java test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java test/org/apache/coyote/ajp/TesterAjpMessage

Author: rjung Date: Tue Dec 16 10:58:46 2014 New Revision: 1645908 URL: http://svn.apache.org/r1645908 Log: Add more thorough tests for AJP. Unfortunately request attributes as sent by mod_jk JkEnvVars can not be tested, because request.getAttributeNames() does not return the names of Coyote

svn commit: r1645909 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Author: rjung Date: Tue Dec 16 11:04:22 2014 New Revision: 1645909 URL: http://svn.apache.org/r1645909 Log: Fix changelog. Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml URL:

svn commit: r1645913 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/catalina/startup/TomcatBaseTest.java test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java

Author: rjung Date: Tue Dec 16 11:05:27 2014 New Revision: 1645913 URL: http://svn.apache.org/r1645913 Log: Use Map instead of HashMap in RequestDescriptor. Backport of r1645743 from trunk. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1645920 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java

Author: rjung Date: Tue Dec 16 11:11:17 2014 New Revision: 1645920 URL: http://svn.apache.org/r1645920 Log: Add tests for AJP connector requiredSecret feature. Backport of r1645763 from trunk. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1645926 - in /tomcat/tc7.0.x/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java coyote/http11/TestAbstractHttp11Processor.java

Author: rjung Date: Tue Dec 16 11:40:13 2014 New Revision: 1645926 URL: http://svn.apache.org/r1645926 Log: Fix r1645628: - Remove merge markers - Replace notation - Replace try-with-resources Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

svn commit: r1645927 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml

Author: rjung Date: Tue Dec 16 11:44:28 2014 New Revision: 1645927 URL: http://svn.apache.org/r1645927 Log: - Add lots of info the SnoopServlet output. - Add SnoopResult class to parse SnoopServlet response body. - Adjust TestRewriteValve to use the new SnoopServlet / SnoopResult The more

svn commit: r1645928 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/startup/TomcatBaseTest.java webapps/docs/changelog.xml

Author: rjung Date: Tue Dec 16 11:46:50 2014 New Revision: 1645928 URL: http://svn.apache.org/r1645928 Log: Add new RequestDescriptor class which contains parsed data returned from the SnoopServlet. Adjust TestRewriteValve to use RequestDescriptor. Backport of r1645486 from trunk resp. r1645904

Early Access builds for JDK 9 b42, JDK 8 b18 JDK 7 b03 are available on java.net

Hi Mark/Mladen, Now that JDK 9 Early Access build images are modular [1], there is a fresh Early Access build for JDK 9 b42 https://jdk9.java.net/download/ available on java.net. The summary of changes are listed here http://www.java.net/download/jdk9/changes/jdk9-b42.html In addition, there

svn commit: r1645951 - /tomcat/trunk/java/org/apache/catalina/realm/GenericPrincipal.java

Author: markt Date: Tue Dec 16 13:53:06 2014 New Revision: 1645951 URL: http://svn.apache.org/r1645951 Log: Clean-up. No functional change. Modified: tomcat/trunk/java/org/apache/catalina/realm/GenericPrincipal.java Modified: tomcat/trunk/java/org/apache/catalina/realm/GenericPrincipal.java

svn commit: r1645952 - /tomcat/trunk/java/org/apache/catalina/realm/GenericPrincipal.java

Author: markt Date: Tue Dec 16 13:55:07 2014 New Revision: 1645952 URL: http://svn.apache.org/r1645952 Log: Missed some clean-up. Modified: tomcat/trunk/java/org/apache/catalina/realm/GenericPrincipal.java Modified: tomcat/trunk/java/org/apache/catalina/realm/GenericPrincipal.java URL:

svn commit: r1645953 - in /tomcat/trunk: java/org/apache/catalina/realm/ test/org/apache/catalina/realm/

Author: markt Date: Tue Dec 16 13:55:53 2014 New Revision: 1645953 URL: http://svn.apache.org/r1645953 Log: Make GenericPrincipal Serializable. Added: tomcat/trunk/test/org/apache/catalina/realm/TestGenericPrincipal.java (with props)

svn commit: r1645955 - in /tomcat/trunk: java/org/apache/catalina/ha/authenticator/ java/org/apache/catalina/ha/session/ test/org/apache/catalina/ha/

Author: markt Date: Tue Dec 16 14:08:48 2014 New Revision: 1645955 URL: http://svn.apache.org/r1645955 Log: No longer need SerializablePrincipal in Cluster code since GenericPrincipal now implements Serializable. Removed:

svn commit: r1645960 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/coyote/ajp/SimpleAjpClient.java test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java test/org/apache/coyote/ajp/TesterAjpMessage

Author: rjung Date: Tue Dec 16 14:56:34 2014 New Revision: 1645960 URL: http://svn.apache.org/r1645960 Log: Add more thorough tests for AJP. Unfortunately request attributes as sent by mod_jk JkEnvVars can not be tested, because request.getAttributeNames() does not return the names of Coyote

svn commit: r1645964 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/startup/TomcatBaseTest.java test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java

Author: rjung Date: Tue Dec 16 14:59:49 2014 New Revision: 1645964 URL: http://svn.apache.org/r1645964 Log: Use Map instead of HashMap in RequestDescriptor. Backport of r1645743 from trunk resp. r1645913 from TC 8. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1645993 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java coyote/ajp/TestAbstractAjpProcessor.java

Author: markt Date: Tue Dec 16 16:03:30 2014 New Revision: 1645993 URL: http://svn.apache.org/r1645993 Log: Fix various IDE warnings Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java tomcat/trunk/test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java

[Bug 57338] SingleSignOnEntry cache of ClusterSingleSignOn valve is not synchronized on Tomcat startup

https://issues.apache.org/bugzilla/show_bug.cgi?id=57338 --- Comment #4 from Mark Thomas ma...@apache.org --- I have a patch but it is untested. I'm working on that now and hope to be able to commit something in the next 24 hours. -- You are receiving this mail because: You are the assignee for

svn commit: r1646098 - in /tomcat/trunk/java/org/apache/catalina: authenticator/SingleSignOn.java ha/authenticator/ClusterSingleSignOn.java

Author: markt Date: Tue Dec 16 21:50:49 2014 New Revision: 1646098 URL: http://svn.apache.org/r1646098 Log: Whitespace clean-up Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java tomcat/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOn.java

svn commit: r1646100 - /tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java

Author: markt Date: Tue Dec 16 21:52:00 2014 New Revision: 1646100 URL: http://svn.apache.org/r1646100 Log: No longer need a separate lookup() method Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java Modified:

svn commit: r1646099 - /tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java

Author: markt Date: Tue Dec 16 21:51:33 2014 New Revision: 1646099 URL: http://svn.apache.org/r1646099 Log: Switch to ConcurrentHashMap and remove syncs Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java Modified:

svn commit: r1646101 - in /tomcat/trunk/java/org/apache/catalina/authenticator: SingleSignOn.java SingleSignOnEntry.java

Author: markt Date: Tue Dec 16 21:52:28 2014 New Revision: 1646101 URL: http://svn.apache.org/r1646101 Log: Refactor the sync to simply synchronize the method Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java

svn commit: r1646102 - /tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java

Author: markt Date: Tue Dec 16 21:52:54 2014 New Revision: 1646102 URL: http://svn.apache.org/r1646102 Log: Remove final so sub-classes can replace these. Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOn.java Modified:

svn commit: r1646103 - in /tomcat/trunk/java/org/apache/catalina: authenticator/SingleSignOnEntry.java ha/authenticator/ClusterSingleSignOn.java ha/authenticator/ClusterSingleSignOnListener.java ha/au

Author: markt Date: Tue Dec 16 21:53:29 2014 New Revision: 1646103 URL: http://svn.apache.org/r1646103 Log: First stab at an implementation - won't work because Map entries are not Serializable. Removed: tomcat/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOnListener.java

svn commit: r1646104 - in /tomcat/trunk/java/org/apache/catalina/authenticator: SingleSignOn.java SingleSignOnEntry.java SingleSignOnSessionKey.java

Author: markt Date: Tue Dec 16 21:53:58 2014 New Revision: 1646104 URL: http://svn.apache.org/r1646104 Log: Remove session object from SingleSignOnMaps Added: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOnSessionKey.java Modified:

svn commit: r1646105 - /tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOnEntry.java

Author: markt Date: Tue Dec 16 21:54:25 2014 New Revision: 1646105 URL: http://svn.apache.org/r1646105 Log: Make Serializable Modified: tomcat/trunk/java/org/apache/catalina/authenticator/SingleSignOnEntry.java Modified:

svn commit: r1646106 - in /tomcat/trunk/java/org/apache/catalina/authenticator: LocalStrings.properties SingleSignOn.java

Author: markt Date: Tue Dec 16 21:54:53 2014 New Revision: 1646106 URL: http://svn.apache.org/r1646106 Log: Complete the logging TODOs Modified: tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings.properties

[Bug 57338] SingleSignOnEntry cache of ClusterSingleSignOn valve is not synchronized on Tomcat startup

https://issues.apache.org/bugzilla/show_bug.cgi?id=57338 --- Comment #5 from Mark Thomas ma...@apache.org --- This is currently implemented in trunk (Tomcat 9). We need to discuss on the dev list which versions, if any, this can be back-ported to as there were a number of fairly invasive changes

Back-porting BZ57338 SSO + Cluster improvements

The fix for BZ 57338 (SSO + cluster) ended up making some fairly invasive changes so that the implementation was sensible. I'd like to discuss which - if any - of these changes we'd be happy to back-port to Tomcat 8 and Tomcat 7. [1] Make GenericPrincipal Serializable I don't see any harm in

[Bug 53171] Deadlock under Java 7 / DefaultInstanceManager

https://issues.apache.org/bugzilla/show_bug.cgi?id=53171 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED

svn commit: r1646113 - in /tomcat/sandbox/trunk-maven-layout: ./ apache-tomcat/ global-resources/ tomcat-annotations-api/ tomcat-api/ tomcat-buildutil/ tomcat-catalina-ant/ tomcat-catalina-ha/ tomcat-

Author: markt Date: Tue Dec 16 23:50:55 2014 New Revision: 1646113 URL: http://svn.apache.org/r1646113 Log: Further fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 - Updated the version of the poems to 9.0.0-SNAPSHOT - created tomcat-tests component containing all the tests - add

[Bug 56397] Establish parallel Maven-based build process

https://issues.apache.org/bugzilla/show_bug.cgi?id=56397 --- Comment #48 from Mark Thomas ma...@apache.org --- Patch applied. Sorry it took a while. I dropped this part of the source tree from my checkout because svn up was so slow. I now have a dedicated checkout for this. -- You are

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-test-apr has an issue affecting its community

[Bug 53171] Deadlock under Java 7 / DefaultInstanceManager

https://issues.apache.org/bugzilla/show_bug.cgi?id=53171 --- Comment #7 from Manoj manoj...@fisglobal.com --- Looks like this is similar to https://issues.apache.org/bugzilla/show_bug.cgi?id=53085 -- You are receiving this mail because: You are the assignee for the bug.

[Bug 53085] [perf] [concurrency] DefaultInstanceManager.annotationCache is not optimal for more threads

https://issues.apache.org/bugzilla/show_bug.cgi?id=53085 --- Comment #7 from Manoj manoj...@fisglobal.com --- Looks like the support class is only available in tomcat 8. Can we have the fix added in tomcat 7? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 53171] Deadlock under Java 7 / DefaultInstanceManager

https://issues.apache.org/bugzilla/show_bug.cgi?id=53171 --- Comment #8 from Manoj manoj...@fisglobal.com --- Concurrent hash map will solve this contention. The patch which Konstantin provided is for tomcat 8. Will it be possible to get it in tomcat 7? -- You are receiving this mail because: