svn commit: r1821306 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/buf/AbstractChunk.java java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.java

Author: markt Date: Tue Jan 16 20:35:00 2018 New Revision: 1821306 URL: http://svn.apache.org/viewvc?rev=1821306=rev Log: Pull up and align isNull and recycle Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/buf/AbstractChunk.java

svn commit: r1821327 - /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/buf/CharChunk.java

Author: markt Date: Tue Jan 16 22:04:43 2018 New Revision: 1821327 URL: http://svn.apache.org/viewvc?rev=1821327=rev Log: Fix comment merge. Align comments. Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/buf/CharChunk.java Modified:

svn commit: r1821319 [1/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/buf/AbstractChunk.java java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.ja

Author: markt Date: Tue Jan 16 21:48:41 2018 New Revision: 1821319 URL: http://svn.apache.org/viewvc?rev=1821319=rev Log: Back-port clean-up / refactoring / alignment Added: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/buf/AbstractChunk.java - copied, changed from r1821304,

svn commit: r1821319 [2/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/buf/AbstractChunk.java java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.ja

Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/buf/CharChunk.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/buf/CharChunk.java?rev=1821319=1821318=1821319=diff == ---

svn commit: r1821320 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/buf/CharChunk.java test/org/apache/tomcat/util/buf/TestCharChunk.java

Author: markt Date: Tue Jan 16 21:49:38 2018 New Revision: 1821320 URL: http://svn.apache.org/viewvc?rev=1821320=rev Log: Fix bug searching for single character Strings (search would always fail) Bug found during comparison of indexOf() implementations between ByteChunk and CharChunk Modified:

Re: 8.5.25 release build

On 16/01/18 17:24, Konstantin Kolinko wrote: > 2018-01-16 16:53 GMT+03:00 Mark Thomas : >> >> Our friendly Symantec (well, Digicert now) contact has got the issue >> fixed. I'll have the 8.5.26 RC out later today. > > > Reviewing the commits for 8.5.25, there is a copy-paste

[Bug 61916] AddDefaultCharsetFilter wouldn't work when setting response header through response.setHeader()

https://bz.apache.org/bugzilla/show_bug.cgi?id=61916 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED

svn commit: r1821308 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.java

Author: markt Date: Tue Jan 16 20:36:27 2018 New Revision: 1821308 URL: http://svn.apache.org/viewvc?rev=1821308=rev Log: Formatting / comment alignment Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

svn commit: r1821310 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.java

Author: markt Date: Tue Jan 16 20:44:50 2018 New Revision: 1821310 URL: http://svn.apache.org/viewvc?rev=1821310=rev Log: Clean up - No functional change Align comments and variable names, re-order methods, etc. to minimise diff between ByteChunk and CharChunk Modified:

svn commit: r1821316 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/buf/ test/org/apache/tomcat/util/buf/ webapps/docs/

Author: markt Date: Tue Jan 16 21:21:08 2018 New Revision: 1821316 URL: http://svn.apache.org/viewvc?rev=1821316=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61993 Improve handling for ByteChunk and CharChunk instances that grow close to the maximum size allowed by the JRE.

[Bug 61993] org.apache.tomcat.util.ByteChunk throws NegativeArray SizeException

https://bz.apache.org/bugzilla/show_bug.cgi?id=61993 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1821331 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/filters/AddDefaultCharsetFilter.java

Author: markt Date: Tue Jan 16 22:32:03 2018 New Revision: 1821331 URL: http://svn.apache.org/viewvc?rev=1821331=rev Log: Correct a regression in the previous fix for BZ 61916 that meant that any call to addHeader() would have been replaced with a call to setHeader() for all requests mapped to

svn commit: r1821330 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/filters/AddDefaultCharsetFilter.java

Author: markt Date: Tue Jan 16 22:31:31 2018 New Revision: 1821330 URL: http://svn.apache.org/viewvc?rev=1821330=rev Log: Correct a regression in the previous fix for BZ 61916 that meant that any call to addHeader() would have been replaced with a call to setHeader() for all requests mapped to

svn commit: r1821305 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/buf/AbstractChunk.java java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.java

Author: markt Date: Tue Jan 16 20:33:24 2018 New Revision: 1821305 URL: http://svn.apache.org/viewvc?rev=1821305=rev Log: Pull up and align start (a.k.a. offset), end and hashcode Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1821322 [2/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/buf/ test/org/apache/tomcat/util/buf/ webapps/docs/

Modified: tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/buf/TestByteChunk.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/buf/TestByteChunk.java?rev=1821322=1821321=1821322=diff

svn commit: r1821322 [1/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/buf/ test/org/apache/tomcat/util/buf/ webapps/docs/

Author: markt Date: Tue Jan 16 21:56:18 2018 New Revision: 1821322 URL: http://svn.apache.org/viewvc?rev=1821322=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61993 Improve handling for ByteChunk and CharChunk instances that grow close to the maximum size allowed by the JRE.

svn commit: r1821328 - in /tomcat/trunk: java/org/apache/catalina/filters/AddDefaultCharsetFilter.java webapps/docs/changelog.xml

Author: markt Date: Tue Jan 16 22:28:51 2018 New Revision: 1821328 URL: http://svn.apache.org/viewvc?rev=1821328=rev Log: Correct a regression in the previous fix for BZ 61916 that meant that any call to addHeader() would have been replaced with a call to setHeader() for all requests mapped to

svn commit: r1821307 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.java

Author: markt Date: Tue Jan 16 20:35:44 2018 New Revision: 1821307 URL: http://svn.apache.org/viewvc?rev=1821307=rev Log: Reduce diff between ByteChunk and CharChunk No functional change Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1821314 - in /tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

Author: markt Date: Tue Jan 16 21:02:48 2018 New Revision: 1821314 URL: http://svn.apache.org/viewvc?rev=1821314=rev Log: Review remaining diff between 9.0.x and 8.5.x and back-port remaining changes. Modified: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

svn commit: r1821304 - in /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/buf: AbstractChunk.java ByteChunk.java CharChunk.java

Author: markt Date: Tue Jan 16 20:31:16 2018 New Revision: 1821304 URL: http://svn.apache.org/viewvc?rev=1821304=rev Log: Add a base class with a view to aligning and pulling up the common code where possible. Added: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/buf/AbstractChunk.java

svn commit: r1821309 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.java

Author: markt Date: Tue Jan 16 20:40:34 2018 New Revision: 1821309 URL: http://svn.apache.org/viewvc?rev=1821309=rev Log: More alignment. Comment differences. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

svn commit: r1821313 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/buf/AbstractChunk.java java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.java

Author: markt Date: Tue Jan 16 20:47:00 2018 New Revision: 1821313 URL: http://svn.apache.org/viewvc?rev=1821313=rev Log: Align indexOf(String, int, int, int) implementations and pull up. Use ByteChunnks implementation as it is shorter. Modified: tomcat/tc8.0.x/trunk/ (props changed)

svn commit: r1821317 - in /tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

Author: markt Date: Tue Jan 16 21:24:25 2018 New Revision: 1821317 URL: http://svn.apache.org/viewvc?rev=1821317=rev Log: Back-port preparation. Fix formatting. No functional change. Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

svn commit: r1821321 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/buf/AbstractChunk.java java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.java

Author: markt Date: Tue Jan 16 21:50:48 2018 New Revision: 1821321 URL: http://svn.apache.org/viewvc?rev=1821321=rev Log: Align indexOf(String, int, int, int) implementations and pull up. Use ByteChunks implementation as it is shorter. Modified: tomcat/tc7.0.x/trunk/ (props changed)

svn commit: r1821329 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/filters/AddDefaultCharsetFilter.java webapps/docs/changelog.xml

Author: markt Date: Tue Jan 16 22:30:31 2018 New Revision: 1821329 URL: http://svn.apache.org/viewvc?rev=1821329=rev Log: Correct a regression in the previous fix for BZ 61916 that meant that any call to addHeader() would have been replaced with a call to setHeader() for all requests mapped to

Re: [VOTE] Release Apache Tomcat 9.0.3

Hi, The proposed 9.0.3 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 9.0.3 [ ] Beta - go ahead and release as 9.0.3 [ X ] Stable - go ahead and release as 9.0.3 Unit test passed, except for one UT failure when running on Java 9 [1], which I am planning to

[Bug 61999] Setting maxSavePostSize=0 won't disable saving POST data

https://bz.apache.org/bugzilla/show_bug.cgi?id=61999 --- Comment #6 from Michael --- (In reply to Remy Maucherat from comment #5) > A fix will be in 9.0.4, 8.5.25, 8.0.49 and 7.0.84. Great, thank you! With this fix our request won't fail anymore for maxSavePostSize=0. And

buildbot success in on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2968 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1821225 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

Author: markt Date: Tue Jan 16 10:14:05 2018 New Revision: 1821225 URL: http://svn.apache.org/viewvc?rev=1821225=rev Log: Revert 1821202 and add comment regarding compaction Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

/public/workspace/tomcat-native-trunk/dest-20180116/lib -Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.openssl.path=/srv

svn commit: r1821234 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

Author: markt Date: Tue Jan 16 12:10:41 2018 New Revision: 1821234 URL: http://svn.apache.org/viewvc?rev=1821234=rev Log: Clean up - No functional change Align comments and variable names, re-order methods, etc. to minimise diff between ByteChunk and CharChunk Modified:

Re: Release schedule for tomcat 7

On 16/01/18 05:05, Silambarasan Madhappan wrote: > Hi , > > Thanks for the quick response. > > Can you please clarify below, > > 1. If voting happens this week, by when we can expect the release ? Voting typically takes 72 hours. Release announcement normally follows ~24 hours after the vote

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

-Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20180116/bin/openssl

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true -Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20180116/bin/openssl -Dexecute.test.apr

Re: buildbot failure in on tomcat-trunk

On 15/01/18 22:46, build...@apache.org wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building . Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/2966 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build:

svn commit: r1821263 - in /tomcat/trunk/bin: ciphers.bat ciphers.sh

Author: kkolinko Date: Tue Jan 16 16:36:17 2018 New Revision: 1821263 URL: http://svn.apache.org/viewvc?rev=1821263=rev Log: Set svn:eol-style=native Modified: tomcat/trunk/bin/ciphers.bat (props changed) tomcat/trunk/bin/ciphers.sh (props changed) Propchange:

Re: 8.5.25 release build

On 15/01/2018 19:38, Mark Thomas wrote: > On 15/01/18 17:39, Mark Thomas wrote: >> Hi all, >> >> The Javadoc failure in the first release build has triggered further >> issues. The code signing service had already signed 8.5.25 and it won't >> sign another file with the same version. >> >> I've

svn commit: r1821252 - /tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java

Author: markt Date: Tue Jan 16 14:42:52 2018 New Revision: 1821252 URL: http://svn.apache.org/viewvc?rev=1821252=rev Log: Deprecated unused code Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java URL:

Re: 8.5.25 release build

2018-01-16 16:53 GMT+03:00 Mark Thomas : > > Our friendly Symantec (well, Digicert now) contact has got the issue > fixed. I'll have the 8.5.26 RC out later today. Reviewing the commits for 8.5.25, there is a copy-paste bug in BZ 61916 fix.

[Bug 61916] AddDefaultCharsetFilter wouldn't work when setting response header through response.setHeader()

https://bz.apache.org/bugzilla/show_bug.cgi?id=61916 Konstantin Kolinko changed: What|Removed |Added Resolution|FIXED |---

[Bug 62006] New: Windows Service Command Line Parameter JvmOptions9 is undocumented

https://bz.apache.org/bugzilla/show_bug.cgi?id=62006 Bug ID: 62006 Summary: Windows Service Command Line Parameter JvmOptions9 is undocumented Product: Tomcat 8 Version: 8.5.24 Hardware: All OS: All

svn commit: r1821303 - in /tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

Author: markt Date: Tue Jan 16 20:30:05 2018 New Revision: 1821303 URL: http://svn.apache.org/viewvc?rev=1821303=rev Log: Back-port preparation. Fix formatting. No functional change. Modified: tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java

svn commit: r1821311 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/util/buf/CharChunk.java test/org/apache/tomcat/util/buf/TestCharChunk.java

Author: markt Date: Tue Jan 16 20:45:42 2018 New Revision: 1821311 URL: http://svn.apache.org/viewvc?rev=1821311=rev Log: Fix bug searching for single character Strings (search would always fail) Bug found during comparison of indexOf() implementations between ByteChunk and CharChunk Modified:

svn commit: r1821235 - in /tomcat/trunk: java/org/apache/tomcat/util/buf/CharChunk.java test/org/apache/tomcat/util/buf/TestCharChunk.java

Author: markt Date: Tue Jan 16 12:18:30 2018 New Revision: 1821235 URL: http://svn.apache.org/viewvc?rev=1821235=rev Log: Fix bug searching for single character Strings (search would always fail) Bug found during comparison of indexOf() implementations between ByteChunk and CharChunk Modified:

svn commit: r1821251 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: AbstractChunk.java ByteChunk.java CharChunk.java

Author: markt Date: Tue Jan 16 14:39:28 2018 New Revision: 1821251 URL: http://svn.apache.org/viewvc?rev=1821251=rev Log: Align indexOf(String, int, int, int) implementations and pull up. Use ByteChunnks implementation as it is shorter. Modified:

svn commit: r1821293 - in /tomcat/trunk: java/org/apache/tomcat/util/buf/ test/org/apache/tomcat/util/buf/ webapps/docs/

Author: markt Date: Tue Jan 16 19:29:39 2018 New Revision: 1821293 URL: http://svn.apache.org/viewvc?rev=1821293=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61993 Improve handling for ByteChunk and CharChunk instances that grow close to the maximum size allowed by the JRE.

svn commit: r24244 [2/2] - in /dev/tomcat/tomcat-8/v8.5.26: ./ bin/ bin/embed/ bin/extras/ src/

Propchange: dev/tomcat/tomcat-8/v8.5.26/src/apache-tomcat-8.5.26-src.zip -- svn:mime-type = application/octet-stream Added: dev/tomcat/tomcat-8/v8.5.26/src/apache-tomcat-8.5.26-src.zip.asc

svn commit: r24244 [1/2] - in /dev/tomcat/tomcat-8/v8.5.26: ./ bin/ bin/embed/ bin/extras/ src/

Author: markt Date: Tue Jan 16 19:54:25 2018 New Revision: 24244 Log: Upload 8.5.26 for voting Added: dev/tomcat/tomcat-8/v8.5.26/ dev/tomcat/tomcat-8/v8.5.26/KEYS dev/tomcat/tomcat-8/v8.5.26/README.html dev/tomcat/tomcat-8/v8.5.26/RELEASE-NOTES

svn commit: r1821297 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/buf/AbstractChunk.java java/org/apache/tomcat/util/buf/ByteChunk.java java/org/apache/tomcat/util/buf/CharChunk.java tes

Author: markt Date: Tue Jan 16 20:01:04 2018 New Revision: 1821297 URL: http://svn.apache.org/viewvc?rev=1821297=rev Log: Clean-up prior to fixing BZ 61993 Added: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/buf/AbstractChunk.java - copied, changed from r1821197,

svn commit: r1821300 - in /tomcat/tc8.5.x/trunk: ./ build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml

Author: markt Date: Tue Jan 16 20:07:46 2018 New Revision: 1821300 URL: http://svn.apache.org/viewvc?rev=1821300=rev Log: Increment version for next development cycle Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/build.properties.default

svn commit: r1821301 - in /tomcat/tc8.5.x/trunk: java/org/apache/tomcat/util/buf/ test/org/apache/tomcat/util/buf/ webapps/docs/

Author: markt Date: Tue Jan 16 20:09:12 2018 New Revision: 1821301 URL: http://svn.apache.org/viewvc?rev=1821301=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61993 Improve handling for ByteChunk and CharChunk instances that grow close to the maximum size allowed by the JRE.