[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371 --- Comment #5 from Robert Rettig --- This effects version 8.5.31 too, which has much bigger impact to other projects! see:

[Bug 62371] New: Improve logging in AbstractProcessor.parseHost()

2018-05-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371 Bug ID: 62371 Summary: Improve logging in AbstractProcessor.parseHost() Product: Tomcat 9 Version: 9.0.7 Hardware: PC OS: Linux Status: NEW Severity:

Re: svn commit: r1830547 - in /tomcat/trunk: java/org/apache/coyote/Response.java java/org/apache/coyote/http11/Http11InputBuffer.java webapps/docs/changelog.xml

2018-05-11 Thread Rainer Jung
Am 30.04.2018 um 12:57 schrieb ma...@apache.org: Author: markt Date: Mon Apr 30 10:57:27 2018 New Revision: 1830547 URL: http://svn.apache.org/viewvc?rev=1830547=rev Log: Correct a regression in the error page handling that prevented error pages from issuing redirects or taking other action

svn commit: r1831386 - in /tomcat/tc7.0.x/trunk/test: org/apache/naming/TestEnvEntry.java webapp-3.0-fragments/WEB-INF/web.xml

2018-05-11 Thread markt
Author: markt Date: Fri May 11 06:33:48 2018 New Revision: 1831386 URL: http://svn.apache.org/viewvc?rev=1831386=rev Log: Follow-up to r1831352 Add additions to web.xml missed in original backport Correct web-app path for 7.0.x Modified:

Re: svn commit: r1830547 - in /tomcat/trunk: java/org/apache/coyote/Response.java java/org/apache/coyote/http11/Http11InputBuffer.java webapps/docs/changelog.xml

2018-05-11 Thread Mark Thomas
On 11/05/18 08:58, Rainer Jung wrote: > Am 30.04.2018 um 12:57 schrieb ma...@apache.org: >> Author: markt >> Date: Mon Apr 30 10:57:27 2018 >> New Revision: 1830547 >> >> URL: http://svn.apache.org/viewvc?rev=1830547=rev >> Log: >> Correct a regression in the error page handling that prevented

buildbot success in on tomcat-7-trunk

2018-05-11 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1089 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

svn commit: r1831390 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http11/Http11InputBuffer.java

2018-05-11 Thread markt
Author: markt Date: Fri May 11 08:34:55 2018 New Revision: 1831390 URL: http://svn.apache.org/viewvc?rev=1831390=rev Log: When the header limit is exceeded before the protocol is read (e.g. with excessive new lines before the request line), set the protocol to avoid the missing protocol

svn commit: r1831389 - /tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

2018-05-11 Thread markt
Author: markt Date: Fri May 11 08:34:21 2018 New Revision: 1831389 URL: http://svn.apache.org/viewvc?rev=1831389=rev Log: When the header limit is exceeded before the protocol is read (e.g. with excessive new lines before the request line), set the protocol to avoid the missing protocol

svn commit: r1831395 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2018-05-11 Thread violetagg
Author: violetagg Date: Fri May 11 09:42:59 2018 New Revision: 1831395 URL: http://svn.apache.org/viewvc?rev=1831395=rev Log: Update the release date for 7.0.88 Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL:

Two especially slow performance tests on trunk

2018-05-11 Thread Rainer Jung
Running the unit tests for trunk on my relatively slow Solaris machine, two of the performance tests run especially long: javax.websocket.TestContainerProviderPerformance: about 25 minutes per connector. org.apache.jasper.runtime.TestTagHandlerPoolPerformance: about 5 minutes per connector.

Re: [RESULT][VOTE] Release Apache Tomcat 7.0.88

2018-05-11 Thread Violeta Georgieva
Hi, 2018-05-07 15:06 GMT+03:00 Violeta Georgieva : > > The proposed Apache Tomcat 7.0.88 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.88/ > The Maven staging repo is: >

REMINDER: Apache EU Roadshow 2018 schedule announced!

2018-05-11 Thread sharan
Hello Apache Supporters and Enthusiasts This is a reminder that the schedule for the Apache EU Roadshow 2018 in Berlin has been announced. http://apachecon.com/euroadshow18/schedule.html Please note that we will not be running an ApacheCon in Europe this year which means that this Apache EU

Re: svn commit: r1830547 - in /tomcat/trunk: java/org/apache/coyote/Response.java java/org/apache/coyote/http11/Http11InputBuffer.java webapps/docs/changelog.xml

2018-05-11 Thread Rainer Jung
Am 11.05.2018 um 10:31 schrieb Mark Thomas: On 11/05/18 08:58, Rainer Jung wrote: Am 30.04.2018 um 12:57 schrieb ma...@apache.org: Author: markt Date: Mon Apr 30 10:57:27 2018 New Revision: 1830547 URL: http://svn.apache.org/viewvc?rev=1830547=rev Log: Correct a regression in the error page

[Bug 62343] CORS security: reflecting any origin header value when configured to * is dangerous

2018-05-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62343 --- Comment #1 from Jianjun Chen --- Hi, is there something I forget to do to advance this report? I haven't received any response yet. Thanks, Jianjun -- You are receiving this mail because: You are the assignee for the

svn commit: r26843 - /dev/tomcat/tomcat-7/v7.0.88/ /release/tomcat/tomcat-7/v7.0.88/

2018-05-11 Thread violetagg
Author: violetagg Date: Fri May 11 09:37:37 2018 New Revision: 26843 Log: Release 7.0.88 Added: release/tomcat/tomcat-7/v7.0.88/ - copied from r26842, dev/tomcat/tomcat-7/v7.0.88/ Removed: dev/tomcat/tomcat-7/v7.0.88/

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

2018-05-11 Thread koraktor
Github user koraktor commented on the issue: https://github.com/apache/tomcat/pull/108 @markt-asf I’m sorry to nag you about this, but I didn’t get any feedback since my improvements on this patch series. --- -

Re: svn commit: r1831389 - /tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

2018-05-11 Thread Mark Thomas
On 11/05/18 15:44, Christopher Schultz wrote: > Why not use something like "UNKNOWN" instead of "HTTP/1.1"? It might > be confusing to see that the protocol "is" HTTP/1.1 when it was > actually something else on the wire. Because: - neither the app nor the client ever sees it. - it needs to be

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371 --- Comment #2 from Christopher Schultz --- Hyphens (-) are allowed to be allowed in hostnames, but not in TLDs[1] I wonder if this is too restrictive for Tomcat, and whether or not it would apply (unfairly) to

Re: svn commit: r1831389 - /tomcat/trunk/java/org/apache/coyote/http11/Http11InputBuffer.java

2018-05-11 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 5/11/18 4:34 AM, ma...@apache.org wrote: > Author: markt Date: Fri May 11 08:34:21 2018 New Revision: 1831389 > > URL: http://svn.apache.org/viewvc?rev=1831389=rev Log: When > the header limit is exceeded before the protocol is read (e.g.

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371 --- Comment #1 from Luko --- I have the same issue. In my opinion the issue is in Tomcat host validation. My application DNS alias looks like this : myapp-t.my-dommain where -t is env (test) my-domain is the domain name (yes,

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

2018-05-11 Thread ChristopherSchultz
Github user ChristopherSchultz commented on the issue: https://github.com/apache/tomcat/pull/108 I'm starting to lean toward requiring this new feature to require a configuration option to enable it, and have it default to `false`. My justification is that it represents a breaking

svn commit: r1831410 - in /tomcat/trunk: java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/LocalStrings.properties webapps/docs/changelog.xml

2018-05-11 Thread markt
Author: markt Date: Fri May 11 13:08:30 2018 New Revision: 1831410 URL: http://svn.apache.org/viewvc?rev=1831410=rev Log: Remove duplicate calls when creating a replicated session to reduce the time taken to create the session and thereby reduce the chances of a subsequent session update

svn commit: r1831414 [2/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/LocalStrings.properties webapps/docs/changelog.xml

2018-05-11 Thread markt
Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/session/DeltaManager.java?rev=1831414=1831413=1831414=diff

svn commit: r1831414 [1/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/LocalStrings.properties webapps/docs/changelog.xml

2018-05-11 Thread markt
Author: markt Date: Fri May 11 13:15:13 2018 New Revision: 1831414 URL: http://svn.apache.org/viewvc?rev=1831414=rev Log: Remove duplicate calls when creating a replicated session to reduce the time taken to create the session and thereby reduce the chances of a subsequent session update

Re: Two especially slow performance tests on trunk

2018-05-11 Thread Mark Thomas
On 11/05/18 10:17, Rainer Jung wrote: > Running the unit tests for trunk on my relatively slow Solaris machine, > two of the performance tests run especially long: > > javax.websocket.TestContainerProviderPerformance: about 25 minutes per > connector. > >

svn commit: r1831411 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/LocalStrings.properties webapps/docs/changelog.xml

2018-05-11 Thread markt
Author: markt Date: Fri May 11 13:09:36 2018 New Revision: 1831411 URL: http://svn.apache.org/viewvc?rev=1831411=rev Log: Remove duplicate calls when creating a replicated session to reduce the time taken to create the session and thereby reduce the chances of a subsequent session update

svn commit: r1831413 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/ha/session/DeltaManager.java java/org/apache/catalina/ha/session/LocalStrings.properties webapps/docs/changelog.xml

2018-05-11 Thread markt
Author: markt Date: Fri May 11 13:12:08 2018 New Revision: 1831413 URL: http://svn.apache.org/viewvc?rev=1831413=rev Log: Remove duplicate calls when creating a replicated session to reduce the time taken to create the session and thereby reduce the chances of a subsequent session update

Re: JDK 11 Early Access build 12 available

2018-05-11 Thread Rory O'Donnell
Thanks Mark, that is great to hear. Rgds,Rory On 08/05/2018 14:40, Mark Thomas wrote: All, I've just tried building with Java 11 and performing a very simple smoke test (does the WebSocket snake game work). The only issue I found was that the removal of the java.xml.ws module meant that the

svn commit: r1831441 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/coyote/ajp/AbstractAjpProcessor.java webapps/docs/changelog.xml

2018-05-11 Thread markt
Author: markt Date: Fri May 11 18:40:17 2018 New Revision: 1831441 URL: http://svn.apache.org/viewvc?rev=1831441=rev Log: Log an error message if the AJP connector detects the the reverse proxy is sending AJP messages that are too large for the configured packetSize. Modified:

svn commit: r1831442 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/ajp/AjpAprProcessor.java java/org/apache/coyote/ajp/AjpNioProcessor.java java/org/apache/coyote/ajp/AjpProcessor.java webapps

2018-05-11 Thread markt
Author: markt Date: Fri May 11 18:44:51 2018 New Revision: 1831442 URL: http://svn.apache.org/viewvc?rev=1831442=rev Log: Log an error message if the AJP connector detects the the reverse proxy is sending AJP messages that are too large for the configured packetSize. Modified:

[Bug 50019] Adding JNDI "lookup-name" support In XML and Resource Annotations

2018-05-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=50019 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED

svn commit: r1831439 - in /tomcat/trunk: java/org/apache/coyote/ajp/AjpProcessor.java webapps/docs/changelog.xml

2018-05-11 Thread markt
Author: markt Date: Fri May 11 18:36:15 2018 New Revision: 1831439 URL: http://svn.apache.org/viewvc?rev=1831439=rev Log: Log an error message if the AJP connector detects the the reverse proxy is sending AJP messages that are too large for the configured packetSize. Modified:

svn commit: r1831440 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/ajp/AjpProcessor.java webapps/docs/changelog.xml

2018-05-11 Thread markt
Author: markt Date: Fri May 11 18:36:41 2018 New Revision: 1831440 URL: http://svn.apache.org/viewvc?rev=1831440=rev Log: Log an error message if the AJP connector detects the the reverse proxy is sending AJP messages that are too large for the configured packetSize. Modified:

[GitHub] tomcat issue #108: Improve undeployment in parallel deployment scenario

2018-05-11 Thread markt-asf
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/108 I agree this should configurable on the Host. It should be possible to remove the Comparator entirely if the version code is used directly in the Mapper. I'd like this to be more robust.

svn commit: r1831432 - in /tomcat/trunk: java/org/apache/catalina/realm/ test/org/apache/tomcat/util/http/parser/ webapps/docs/ webapps/docs/config/

2018-05-11 Thread markt
Author: markt Date: Fri May 11 16:39:43 2018 New Revision: 1831432 URL: http://svn.apache.org/viewvc?rev=1831432=rev Log: Add the AuthenticatedUserRealm for use with CLIENT-CERT and SPNEGO when just the authenticated user name is required. Added:

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371 --- Comment #3 from Mark Thomas --- The data on the wire will be after the punnycode encoding so the validation performed by this parser should be correct (Tomcat allows '-' in every element apart from the gTLD). To get to

[Bug 62371] Improve logging in AbstractProcessor.parseHost()

2018-05-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62371 Robert Rettig changed: What|Removed |Added CC|