adding new JMX attributes

2019-06-04 Thread Eugène Adell
Hi guys, I started to investigate how I could add 2 new JMX attributes, and that doesn't look very difficult even for someone who doesn't look at Tomcat's source code often. My suggestion would be to add these 2 new attributes (authenticationSucceeded and authenticationFailed) to all Realms,

Re: [tomcat] branch master updated: Fix rare ISE issue I see in TestAsyncFlush.NIO

2019-06-04 Thread Mark Thomas
On 04/06/2019 09:58, r...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push:

Re: [tomcat] branch master updated: Add fake parameters on two tests which (rarely) fail for me

2019-06-04 Thread Mark Thomas
On 04/06/2019 12:17, r...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push:

[tomcat] branch master updated: Revert ISE fix after review

2019-06-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 628ab62 Revert ISE fix after review 628ab62 is

[tomcat] branch master updated: Add fake parameters on two tests which (rarely) fail for me

2019-06-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 2eb2d84 Add fake parameters on two tests which

[tomcat] branch master updated: Fix one potential cause of multiple threads processing a connection.

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 2236835 Fix one potential cause of multiple

Re: Tagging 9.0.x and 8.5.x

2019-06-04 Thread Rémy Maucherat
On Mon, Jun 3, 2019 at 11:40 PM Mark Thomas wrote: > http://people.apache.org/~markt/patches/2019-06-03-h2-v1.patch I'm testing extensively, and this patch http://people.apache.org/~markt/patches/2019-06-03-h2-v2.patch looks good to me. Rémy

[tomcat] branch 8.5.x updated: Ensure flush(boolean) returns true when data remains to be written

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 9d28ac5 Ensure flush(boolean) returns true when

Re: [tomcat] branch master updated: Add fake parameters on two tests which (rarely) fail for me

2019-06-04 Thread Rémy Maucherat
On Tue, Jun 4, 2019 at 3:46 PM Mark Thomas wrote: > On 04/06/2019 12:25, Mark Thomas wrote: > > On 04/06/2019 12:17, r...@apache.org wrote: > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> remm pushed a commit to branch master > >> in repository

[tomcat] branch 7.0.x updated: Trivial commit to trigger CI

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 33d28e9 Trivial commit to trigger CI 33d28e9 is

[tomcat] branch 8.5.x updated: Clean-up

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new dacb1bc Clean-up dacb1bc is described below

[tomcat] branch 8.5.x updated: Clear waitFor earlier. Avoid multiple stream.notify() calls and timeouts

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 1174ecc Clear waitFor earlier. Avoid multiple

[tomcat] branch master updated: Clear waitFor earlier. Avoid multiple stream.notify() calls and timeouts

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8571748 Clear waitFor earlier. Avoid multiple

buildbot failure in on tomcat-85-trunk

2019-06-04 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1789 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[tomcat] branch 8.5.x updated: Revert unnecessary back-port

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new a7386ee Revert unnecessary back-port a7386ee is

Re: [tomcat] branch master updated: Add fake parameters on two tests which (rarely) fail for me

2019-06-04 Thread Mark Thomas
On 04/06/2019 15:29, Rémy Maucherat wrote: > On Tue, Jun 4, 2019 at 3:46 PM Mark Thomas > > My plan is to tackle the 5_3 issue after the async flush issue. > > Starting this now. > > > I can barely get it anymore (despite the parametrization loop), so it > will be very difficult to

buildbot success in on tomcat-7-trunk

2019-06-04 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1351 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

Re: [tomcat] branch master updated: Add fake parameters on two tests which (rarely) fail for me

2019-06-04 Thread Mark Thomas
On 04/06/2019 12:25, Mark Thomas wrote: > On 04/06/2019 12:17, r...@apache.org wrote: >> This is an automated email from the ASF dual-hosted git repository. >> >> remm pushed a commit to branch master >> in repository https://gitbox.apache.org/repos/asf/tomcat.git >> >> >> The following commit(s)

buildbot success in on tomcat-85-trunk

2019-06-04 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1790 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[tomcat] branch master updated: Correct message parameters

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 9e4fc19 Correct message parameters 9e4fc19 is

[tomcat] branch master updated: Ensure flush(boolean) returns true when data remains to be written

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 092a899 Ensure flush(boolean) returns true when

[tomcat] 03/03: Fix one potential cause of multiple threads processing a connection.

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 383a5d11cb47183d7a98e2141f69929e95d9b835 Author: Mark Thomas AuthorDate: Tue Jun 4 12:30:33 2019 +0100 Fix one

[tomcat] branch 8.5.x updated (3bc67c0 -> 383a5d1)

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 3bc67c0 Refactor Stream / Connection flow control window allocation new d121a2e Fix typo new 3428c42 Use

[tomcat] 02/03: Use NONE instead of 0.

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3428c426c37c907258b4217127409170f9ecca14 Author: remm AuthorDate: Tue Jun 4 10:58:24 2019 +0200 Use NONE instead of

[tomcat] 01/03: Fix typo

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d121a2ecf88ec65168cad82a9fc53a0474f31a21 Author: Mark Thomas AuthorDate: Tue Jun 4 09:32:43 2019 +0100 Fix typo ---

Re: adding new JMX attributes

2019-06-04 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Eugéne, On 6/4/19 08:03, Eugène Adell wrote: > Hi guys, > > I started to investigate how I could add 2 new JMX attributes, and > that doesn't look very difficult even for someone who doesn't look > at Tomcat's source code often. > > My

[tomcat] 01/01: Tag 8.5.42

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 8.5.42 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 00b711f6af57e043bf4d5d64dbc1617970a54d69 Author: Mark Thomas AuthorDate: Tue Jun 4 21:21:55 2019 +0100 Tag 8.5.42 ---

[tomcat] tag 8.5.42 created (now 00b711f)

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 8.5.42 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 00b711f (commit) This tag includes the following new commits: new 00b711f Tag 8.5.42 The 1 revisions listed

[tomcat] 01/01: Tag 9.0.21

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 9.0.21 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 5dd82367de857318b8a384c07c4414e5d55cc975 Author: Mark Thomas AuthorDate: Tue Jun 4 21:15:46 2019 +0100 Tag 9.0.21 ---

[tomcat] tag 9.0.21 created (now 5dd8236)

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 9.0.21 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 5dd8236 (commit) This tag includes the following new commits: new 5dd8236 Tag 9.0.21 The 1 revisions listed

[CONF] Apache Tomcat > Troubleshooting and Diagnostics

2019-06-04 Thread Felix Schumacher (Confluence)
Title: Message Title There's 1 new edit on this page   Troubleshooting and Diagnostics Felix Schumacher edited this page

[VOTE] Release Apache Tomcat 9.0.21

2019-06-04 Thread Mark Thomas
The proposed Apache Tomcat 9.0.21 release is now available for voting. The major changes compared to the 9.0.20 release are: - Fix various concurrency and stability issues for HTTP/2. - Add support for same-site cookie attribute. Patch provided by John Kelly. - Add an option to sort

svn commit: r34407 - in /release/tomcat: tomcat-8/v8.5.40/ tomcat-9/v9.0.19/

2019-06-04 Thread markt
Author: markt Date: Tue Jun 4 20:31:27 2019 New Revision: 34407 Log: Drop 8.5.40 and 9.0.19 from mirror network Removed: release/tomcat/tomcat-8/v8.5.40/ release/tomcat/tomcat-9/v9.0.19/ - To unsubscribe, e-mail:

svn commit: r34408 - in /dev/tomcat/tomcat-9/v9.0.21: ./ bin/ bin/embed/ src/

2019-06-04 Thread markt
Author: markt Date: Tue Jun 4 20:48:41 2019 New Revision: 34408 Log: Upload 9.0.21 for voting Added: dev/tomcat/tomcat-9/v9.0.21/ dev/tomcat/tomcat-9/v9.0.21/KEYS dev/tomcat/tomcat-9/v9.0.21/README.html dev/tomcat/tomcat-9/v9.0.21/RELEASE-NOTES

Re: [tomcat] branch master updated: Add fake parameters on two tests which (rarely) fail for me

2019-06-04 Thread Mark Thomas
On 04/06/2019 17:32, Mark Thomas wrote: > Initial testing looks good. I'm going to run through a few testing > cycles to see how things look. The unit tests runs are cleaner than they have been for a long time. I'm not seeing anything that gives me cause for concern. I'm intending to tag

Nexus: Staging Completed

2019-06-04 Thread Nexus Repository Manager
Message from: https://repository.apache.orgDeployer properties:"userAgent" = "maven-artifact/2.2.1 (Java 1.8.0_212; Windows 7 6.1)""userId" = "markt""ip" = "86.152.79.71"Details:The following artifacts have been staged/org/apache/tomcat/tomcat-i18n-de/9.0.21/tomcat-i18n-de-9.0.21.pom(SHA1:

Nexus: Staging Completed

2019-06-04 Thread Nexus Repository Manager
Message from: https://repository.apache.orgDeployer properties:"userAgent" = "maven-artifact/2.2.1 (Java 1.7.0_80; Windows 7 6.1)""userId" = "markt""ip" = "86.152.79.71"Details:The following artifacts have been staged/org/apache/tomcat/tomcat-jni/8.5.42/tomcat-jni-8.5.42.jar(SHA1:

svn commit: r34409 [1/2] - in /dev/tomcat/tomcat-8/v8.5.42: ./ bin/ bin/embed/ bin/extras/ src/

2019-06-04 Thread markt
Author: markt Date: Tue Jun 4 21:05:39 2019 New Revision: 34409 Log: Upload 8.5.42 for voting Added: dev/tomcat/tomcat-8/v8.5.42/ dev/tomcat/tomcat-8/v8.5.42/KEYS dev/tomcat/tomcat-8/v8.5.42/README.html dev/tomcat/tomcat-8/v8.5.42/RELEASE-NOTES

Fwd: Tomcat 7.0.84 vs. 7.0.91 config diff webpage not available

2019-06-04 Thread Chris Lambertus
This looks like it relies on tooling we had to disable on gitbox due to abuse of the service. You may want to point this at github’s diff system instead. I have not replied to the customer. -Chris > Begin forwarded message: > > From: proste ja > Subject: Tomcat 7.0.84 vs. 7.0.91 config

[VOTE] Release Apache Tomcat 8.5.42

2019-06-04 Thread Mark Thomas
The proposed Apache Tomcat 8.5.42 release is now available for voting. The major changes compared to the 8.5.41 release are: - Fix various concurrency and stability issues for HTTP/2. - Add support for same-site cookie attribute. Patch provided by John Kelly. - Add an option to sort

Re: Fwd: Tomcat 7.0.84 vs. 7.0.91 config diff webpage not available

2019-06-04 Thread Mark Thomas
On 04/06/2019 22:32, Chris Lambertus wrote: > This looks like it relies on tooling we had to disable on gitbox due to > abuse of the service. You may want to point this at github’s diff system > instead. Chris, Last time I checked Infra's intention was to re-enable this service on gitbox. Is

Re: [VOTE] Release Apache Tomcat 9.0.21

2019-06-04 Thread Rémy Maucherat
On Tue, Jun 4, 2019 at 10:50 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.21 release is now available for voting. > > The major changes compared to the 9.0.20 release are: > > - Fix various concurrency and stability issues for HTTP/2. > > - Add support for same-site cookie attribute.

Re: adding new JMX attributes

2019-06-04 Thread Eugène Adell
Hello, thanks for your answer. > What are the data types? When are they updated? What about meta-realms > such as LockOutRealm? How should they behave? Taking example on counters that I see else where (GlobalRequestProcessor->errorCount) integers should be enough, one of the counters would be

svn commit: r34409 [2/2] - in /dev/tomcat/tomcat-8/v8.5.42: ./ bin/ bin/embed/ bin/extras/ src/

2019-06-04 Thread markt
Added: dev/tomcat/tomcat-8/v8.5.42/src/apache-tomcat-8.5.42-src.zip.asc == --- dev/tomcat/tomcat-8/v8.5.42/src/apache-tomcat-8.5.42-src.zip.asc (added) +++ dev/tomcat/tomcat-8/v8.5.42/src/apache-tomcat-8.5.42-src.zip.asc

[tomcat] branch master updated: Fix typo

2019-06-04 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new da208a4 Fix typo da208a4 is described below

[tomcat] branch master updated: Fix rare ISE issue I see in TestAsyncFlush.NIO

2019-06-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new a98f6d0 Fix rare ISE issue I see in

[tomcat] branch master updated: Waiting for the same thing is still an error though

2019-06-04 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 71fcb34 Waiting for the same thing is still an