Re: [tomcat] branch master updated: Fix JSP compilation showing old content reported on users@ list

2019-11-07 Thread Rémy Maucherat
On Thu, Nov 7, 2019 at 12:38 PM wrote: > + * One option to resolve this issue is to use a custom URL scheme > for > + * resource URLs. This would allow us, via registration of a > + * URLStreamHandlerFactory, to control how the resources are > accessed > + * and

[tomcat] branch 8.5.x updated: Follow on to 2b0aaedd

2019-11-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 82cf2d0 Follow on to 2b0aaedd 82cf2d0 is

[Bug 63875] Tomcat 8.5.46, APR/libtcnative crashes

2019-11-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63875 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #16 from Mark

[tomcat] branch master updated: Follow on to 03e7bc84

2019-11-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new b12f3b1 Follow on to 03e7bc84 b12f3b1 is

[tomcat] branch master updated: Better cleanup in setSocketOptions

2019-11-07 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 5f4d5b3 Better cleanup in setSocketOptions

Re: [tomcat] branch master updated: Better cleanup in setSocketOptions

2019-11-07 Thread Rémy Maucherat
On Thu, Nov 7, 2019 at 11:11 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: [tomcat] branch master updated: Fix JSP compilation showing old content reported on users@ list

2019-11-07 Thread Mark Thomas
On 07/11/2019 11:50, Rémy Maucherat wrote: > On Thu, Nov 7, 2019 at 12:38 PM > wrote: > > +         * One option to resolve this issue is to use a custom URL > scheme for > +         * resource URLs. This would allow us, via registration of a > +         

[tomcat] branch 8.5.x updated: Fix JSP compilation showing old content reported on users@ list

2019-11-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 2b0aaed Fix JSP compilation showing old content

[tomcat] branch master updated: Fix JSP compilation showing old content reported on users@ list

2019-11-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 03e7bc8 Fix JSP compilation showing old content

[GitHub] [tomcat] markt-asf commented on a change in pull request #215: fixed typos and grammatical errors

2019-11-07 Thread GitBox
markt-asf commented on a change in pull request #215: fixed typos and grammatical errors URL: https://github.com/apache/tomcat/pull/215#discussion_r343616505 ## File path: CONTRIBUTING.md ## @@ -112,11 +109,7 @@ with a patch attached for review. Waiting For

[GitHub] [tomcat] markt-asf commented on a change in pull request #215: fixed typos and grammatical errors

2019-11-07 Thread GitBox
markt-asf commented on a change in pull request #215: fixed typos and grammatical errors URL: https://github.com/apache/tomcat/pull/215#discussion_r343616528 ## File path: CONTRIBUTING.md ## @@ -1,19 +1,16 @@ # Contributing to Apache Tomcat Firstly, thanks for your

[GitHub] [tomcat] markt-asf commented on a change in pull request #215: fixed typos and grammatical errors

2019-11-07 Thread GitBox
markt-asf commented on a change in pull request #215: fixed typos and grammatical errors URL: https://github.com/apache/tomcat/pull/215#discussion_r343615865 ## File path: CONTRIBUTING.md ## @@ -1,19 +1,16 @@ # Contributing to Apache Tomcat Firstly, thanks for your

Re: [tomcat] branch BZ-63905/9.0.x created (now de12b4d)

2019-11-07 Thread Rémy Maucherat
On Thu, Nov 7, 2019 at 10:22 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > michaelo pushed a change to branch BZ-63905/9.0.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git. > > > at de12b4d BZ 63905: Clean up Tomcat CSS > > This branch

Re: [tomcat] branch BZ-63905/9.0.x created (now de12b4d)

2019-11-07 Thread Michael Osipov
Am 2019-11-07 um 22:44 schrieb Rémy Maucherat: On Thu, Nov 7, 2019 at 10:22 PM wrote: This is an automated email from the ASF dual-hosted git repository. michaelo pushed a change to branch BZ-63905/9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. at de12b4d BZ

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #7 from Michael Osipov --- Please also note that TomcatCSS.TOMCAT_CSS is also used in the DefaultServlet. We either split with common parts or we stay on one and may server rules which do not apply to the error report. I would

[tomcat] branch BZ-63905/9.0.x created (now de12b4d)

2019-11-07 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a change to branch BZ-63905/9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. at de12b4d BZ 63905: Clean up Tomcat CSS This branch includes the following new commits: new de12b4d

[tomcat] 01/01: BZ 63905: Clean up Tomcat CSS

2019-11-07 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch BZ-63905/9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit de12b4dac518f3b6a7d0a5c3b6c24eb80d1699e8 Author: Michael Osipov AuthorDate: Thu Nov 7 22:21:27 2019 +0100

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #8 from Remy Maucherat --- (In reply to Mark Thomas from comment #2) > I have a preference for fixing the docs but am happy to support any > reasonable solution that means the behaviour and the docs are consistent. +1 for fixing

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #9 from Michael Osipov --- I have uploaded a branch for this, changelog edit is pending. Please have a look. It works for me in Firefox and Edge for the Valve and the DefaultServlet with listing on. -- You are receiving this mail

[Bug 63905] ErrorReportValve adds CSS even if both showReport and showServerInfo are set to false

2019-11-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63905 --- Comment #6 from Michael Osipov --- (In reply to Christopher Schultz from comment #4) > Or we could just drop the CSS because... who cares? If the response entity > is lang="??">ErrorError html> then it's fine. No styling is necessary for

Re: [tomcat] branch BZ-63905/9.0.x created (now de12b4d)

2019-11-07 Thread Konstantin Kolinko
пт, 8 нояб. 2019 г. в 00:44, Rémy Maucherat : > > On Thu, Nov 7, 2019 at 10:22 PM wrote: >> >> This is an automated email from the ASF dual-hosted git repository. >> >> michaelo pushed a change to branch BZ-63905/9.0.x >> in repository https://gitbox.apache.org/repos/asf/tomcat.git. >> >> >>

Re: [tomcat] branch BZ-63905/9.0.x created (now de12b4d)

2019-11-07 Thread Rémy Maucherat
On Thu, Nov 7, 2019 at 11:01 PM Michael Osipov wrote: > Am 2019-11-07 um 22:44 schrieb Rémy Maucherat: > > On Thu, Nov 7, 2019 at 10:22 PM wrote: > > > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> michaelo pushed a change to branch BZ-63905/9.0.x > >> in

Re: [tomcat] branch BZ-63905/9.0.x created (now de12b4d)

2019-11-07 Thread Rémy Maucherat
On Thu, Nov 7, 2019 at 11:21 PM Konstantin Kolinko wrote: > пт, 8 нояб. 2019 г. в 00:44, Rémy Maucherat : > > > > On Thu, Nov 7, 2019 at 10:22 PM wrote: > >> > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> michaelo pushed a change to branch BZ-63905/9.0.x > >>