[GitHub] [tomcat] michael-o commented on issue #225: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) an…

2019-11-27 Thread GitBox
michael-o commented on issue #225: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) an… URL: https://github.com/apache/tomcat/pull/225#issuecomment-559002699 Default method added, 8.5.x in preparation. This

[Bug 63966] New: Charset of TLS message is hardcoded to ISO-8859-1.

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63966 Bug ID: 63966 Summary: Charset of TLS message is hardcoded to ISO-8859-1. Product: Tomcat 8 Version: 8.5.32 Hardware: All OS: All Status: NEW Severity:

[tomcat] 01/01: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) and friends

2019-11-27 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch BZ-63681/9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d987d942aecf557133df9399592ebfc0b77f9968 Author: Michael Osipov AuthorDate: Wed Aug 21 23:23:19 2019 +0200

[tomcat] branch BZ-63681/9.0.x updated (9062436 -> d987d94)

2019-11-27 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a change to branch BZ-63681/9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. omit 9062436 BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) and friends add 50feb56

[Bug 63948] MultipartFile upload big files over HTTP/2 broken

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63948 --- Comment #4 from Andy Wilkinson --- Rodrigo, you can customise the Http2Protocol by adding the following bean to your Spring Boot application: @Bean public TomcatConnectorCustomizer http2ProtocolCustomizer() { return (connector) -> {

[Bug 63969] New: Stackoverflow in JSF

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63969 Bug ID: 63969 Summary: Stackoverflow in JSF Product: Tomcat 9 Version: 9.0.29 Hardware: PC Status: NEW Severity: regression Priority: P2 Component:

[Bug 63966] Charset of TLS message is hardcoded to ISO-8859-1.

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63966 --- Comment #1 from Mark Thomas --- I'm curious. What is the use case for this (other than wanting everything to be UTF-8 for $reasons)? The response is correctly signalled as ISO-8859-1 encoded and is spec compliant. To put it another way,

Re: [tomcat] branch BZ-63681/8.5.x updated (6be96eb -> a0e8d49)

2019-11-27 Thread Rémy Maucherat
On Wed, Nov 27, 2019 at 11:28 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > michaelo pushed a change to branch BZ-63681/8.5.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git. > This branch is 100% unnecessary. Please delete it instead of

[DISCUSS] Remove org.apache.catalina.servlet4preview from 8.5.x

2019-11-27 Thread Mark Thomas
Hi all, The Servlet 4 preview API in 8.5.x has been deprecated for over a year. It was also inconsistent with the final Servlet 4.0 API until I fixed it in 8.5.49 although no-one complained about the inconsistency. I'd like to propose removing the code completely. I know this is an unusual

[Bug 63937] CORS preflight request not possible on authenticated endpoints

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63937 --- Comment #4 from Mark Thomas --- Corrected attribute name noted. >From a Valve we should be able to look into the FilterChain so see if our CORS valve is present. For other implementations the user would have to set it manually. If there

Re: [DISCUSS] Remove org.apache.catalina.servlet4preview from 8.5.x

2019-11-27 Thread Rémy Maucherat
On Wed, Nov 27, 2019 at 6:06 PM Mark Thomas wrote: > Hi all, > > The Servlet 4 preview API in 8.5.x has been deprecated for over a year. > It was also inconsistent with the final Servlet 4.0 API until I fixed it > in 8.5.49 although no-one complained about the inconsistency. > > I'd like to

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

2019-11-27 Thread Rémy Maucherat
On Wed, Nov 27, 2019 at 5:35 PM Mark Thomas wrote: > On 27/11/2019 15:59, Rémy Maucherat wrote: > > On Wed, Nov 27, 2019 at 4:51 PM Mark Thomas > > wrote: > > > > I've been looking at the 9.0.x changes. > > > > What is clearer now (I think the differences were

[Bug 63969] Stackoverflow in JSF

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63969 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas

[Bug 63948] MultipartFile upload big files over HTTP/2 broken

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63948 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[tomcat] branch master updated: Fix buffering strategy inconsistency

2019-11-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new f2376d4 Fix buffering strategy inconsistency

[Bug 63968] New: ExpiresFilter: invalid cast

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63968 Bug ID: 63968 Summary: ExpiresFilter: invalid cast Product: Tomcat 8 Version: 8.5.49 Hardware: PC OS: Linux Status: NEW Severity: normal

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

2019-11-27 Thread Mark Thomas
On 27/11/2019 12:47, Rémy Maucherat wrote: > On Tue, Nov 26, 2019 at 2:36 PM Rémy Maucherat > wrote: > > It looked ok and removed a big chunk of code so I went ahead with it. > > > Status update: >   > > - This one, also the easiest one: drop >

[Bug 63937] CORS preflight request not possible on authenticated endpoints

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63937 --- Comment #5 from Michael Osipov --- (In reply to Mark Thomas from comment #4) > Corrected attribute name noted. > > From a Valve we should be able to look into the FilterChain so see if our > CORS valve is present. For other

[Bug 63966] Charset of TLS message is hardcoded to ISO-8859-1.

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63966 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

[Bug 63970] New: java.lang.ClassCastException: org.apache.catalina.webresources.CachedResource$CachedResourceURLConnection cannot be cast to java.net.JarURLConnection

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63970 Bug ID: 63970 Summary: java.lang.ClassCastException: org.apache.catalina.webresources.CachedResource$Cached ResourceURLConnection cannot be cast to

[Bug 63859] AJP cping/cpong mode failing on Tomcat 9.x

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63859 --- Comment #21 from Aurelien Pernoud --- Hi Mark, the error is not showing for 4 days. Is it possible that you or someone actually fixed something in this patch too from version 9.0.26 ?? Or Should I just wait a bit more... -- You are

[Bug 63966] Charset of TLS message is hardcoded to ISO-8859-1.

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63966 --- Comment #2 from Michael Osipov --- (In reply to Mark Thomas from comment #1) > I'm curious. What is the use case for this (other than wanting everything to > be UTF-8 for $reasons)? > > The response is correctly signalled as ISO-8859-1

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

2019-11-27 Thread Rémy Maucherat
On Wed, Nov 27, 2019 at 4:51 PM Mark Thomas wrote: > I've been looking at the 9.0.x changes. > > What is clearer now (I think the differences were always there - just > harder to see with the more complex code) is that there are some minor > differences in behaviour when all of the following are

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

2019-11-27 Thread Mark Thomas
On 27/11/2019 15:59, Rémy Maucherat wrote: > On Wed, Nov 27, 2019 at 4:51 PM Mark Thomas > wrote: > > I've been looking at the 9.0.x changes. > > What is clearer now (I think the differences were always there - just > harder to see with the more complex

[Bug 63968] ExpiresFilter: invalid cast

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63968 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63968 class cast

2019-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 979d8fa Fix

[Bug 63970] java.lang.ClassCastException: org.apache.catalina.webresources.CachedResource$CachedResourceURLConnection cannot be cast to java.net.JarURLConnection

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63970 --- Comment #1 from Mark Thomas --- Yes, this is caused by that commit. The fix looks fairly simple but we are at the limit of what the current implementation can reasonably do in terms of guaranteeing consistency. Chances are you are going

[Bug 63970] java.lang.ClassCastException: org.apache.catalina.webresources.CachedResource$CachedResourceURLConnection cannot be cast to java.net.JarURLConnection

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63970 --- Comment #2 from Dmitry Treskunov --- Thanks for the answer. Sorry, I didn't quite understand, does it mean that you are not going to fix it? -- You are receiving this mail because: You are the assignee for the bug.

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63970 cast JAR conns

2019-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 709b629 Fix

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63970 cast JAR conns

2019-11-27 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new c7e660d Fix

Re: [tomcat] branch BZ-63681/8.5.x updated (6be96eb -> a0e8d49)

2019-11-27 Thread Michael Osipov
Am 2019-11-27 um 18:05 schrieb Rémy Maucherat: On Wed, Nov 27, 2019 at 11:28 AM wrote: This is an automated email from the ASF dual-hosted git repository. michaelo pushed a change to branch BZ-63681/8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. This branch is 100%

[tomcat] branch 8.5.x updated: Fix buffering strategy inconsistency

2019-11-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 9fec9f1 Fix buffering strategy inconsistency

[Bug 63859] AJP cping/cpong mode failing on Tomcat 9.x

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63859 --- Comment #22 from Mark Thomas --- The only thing that has changed as far as I know is Tomcat no longer always does a blocking read after the CPing/CPong. I still don't see how that could have caused the error though... Could we give it

[Bug 63948] MultipartFile upload big files over HTTP/2 broken

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63948 --- Comment #6 from Rodrigo Darti da Costa --- (In reply to Andy Wilkinson from comment #4) > Rodrigo, you can customise the Http2Protocol by adding the following bean to > your Spring Boot application: > > @Bean > public

Re: [tomcat] branch BZ-63681/8.5.x updated (6be96eb -> a0e8d49)

2019-11-27 Thread Mark Thomas
On 27/11/2019 18:24, Michael Osipov wrote: > Am 2019-11-27 um 18:05 schrieb Rémy Maucherat: >> On Wed, Nov 27, 2019 at 11:28 AM wrote: >> >>> This is an automated email from the ASF dual-hosted git repository. >>> >>> michaelo pushed a change to branch BZ-63681/8.5.x >>> in repository

[Bug 63966] Charset of TLS message is hardcoded to ISO-8859-1.

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63966 --- Comment #3 from Christopher Schultz --- (In reply to Mark Thomas from comment #1) > The response is correctly signalled as ISO-8859-1 encoded and is spec > compliant. How long before we stuff the response text into a localized properties

Re: Tomcat next and Jakarta EE

2019-11-27 Thread Rémy Maucherat
On Wed, Nov 27, 2019 at 11:15 PM Mark Thomas wrote: > Hi, > > Work over at Eclipse is starting on Jakarta EE 9 where the significant > change will be the renaming of javax.* to jakarta.* > > In parallel, I'd like to start implementing those changes in Tomcat. As > I am still unsure of exactly

[Bug 63970] java.lang.ClassCastException: org.apache.catalina.webresources.CachedResource$CachedResourceURLConnection cannot be cast to java.net.JarURLConnection

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63970 --- Comment #3 from Mark Thomas --- Don't worry - I've already fixed it. I was just waiting for a couple of test builds to upload so I could point you towards them for testing. I'd like to try and avoid further regressions in the next round of

[Bug 63970] java.lang.ClassCastException: org.apache.catalina.webresources.CachedResource$CachedResourceURLConnection cannot be cast to java.net.JarURLConnection

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63970 --- Comment #4 from Mark Thomas --- OK. The upload is complete. The dev build is here: http://people.apache.org/~markt/dev/v9.0.30-dev/ If you could download, test and report back that would be very helpful. Note: - this is NOT an official

Tomcat next and Jakarta EE

2019-11-27 Thread Mark Thomas
Hi, Work over at Eclipse is starting on Jakarta EE 9 where the significant change will be the renaming of javax.* to jakarta.* In parallel, I'd like to start implementing those changes in Tomcat. As I am still unsure of exactly where I want end up (I have a few ideas I want to experiment with) I

[Bug 63966] Charset of TLS message is hardcoded to ISO-8859-1.

2019-11-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63966 Remy Maucherat changed: What|Removed |Added Severity|normal |enhancement -- You are receiving

[tomcat] branch 8.5.x updated: Simplify regular endpoint writes by removing write(Non)BlockingDirect

2019-11-27 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 7d2365d Simplify regular endpoint writes by

[tomcat] branch BZ-63681/8.5.x updated (6be96eb -> a0e8d49)

2019-11-27 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a change to branch BZ-63681/8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. discard 6be96eb Frist draft add ca38cf1 Fix indent add 5c1699a Deprecate

[tomcat] 01/01: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) and friends

2019-11-27 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch BZ-63681/8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a0e8d49197a98b92e28cf30f186f1708658d3159 Author: Michael Osipov AuthorDate: Wed Aug 21 23:23:19 2019 +0200

[GitHub] [tomcat] michael-o opened a new pull request #226: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) an…

2019-11-27 Thread GitBox
michael-o opened a new pull request #226: BZ 63681: Introduce RealmBase#authenticate(GSSName, GSSCredential) an… URL: https://github.com/apache/tomcat/pull/226 …d friends As discussed, introduced a `GSSRealm` derived from `Realm`. Tests pass as well as my local code.

Re: Drop SocketWrapperBase.write(Non)BlockingDirect methods

2019-11-27 Thread Rémy Maucherat
On Tue, Nov 26, 2019 at 2:36 PM Rémy Maucherat wrote: > It looked ok and removed a big chunk of code so I went ahead with it. > Status update: > - This one, also the easiest one: drop > SocketWrapperBase.write(Non)BlockingDirect methods > Done. Updated port list: - Remove multipoller from