Re: [VOTE] Release Apache Tomcat 8.5.58

2020-09-11 Thread Mark Thomas
On 10/09/2020 23:10, Mark Thomas wrote: > The proposed 8.5.58 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.58 Unit tests pass for NIO, NIO2 and APR/Native with Tomcat Native 1.2.25 on Windows, MacOS and Linux. Mark

Re: [VOTE] Release Apache Tomcat 9.0.38

2020-09-11 Thread Mark Thomas
On 10/09/2020 10:03, Mark Thomas wrote: > The proposed 9.0.38 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 9.0.38 Unit tests pass for NIO, NIO2 and APR/Native with Tomcat Native 1.2.25 on Windows, MacOS and Linux. Mark

Re: [VOTE] Release Apache Tomcat 8.5.58

2020-09-11 Thread Martin Grigorov
On Fri, Sep 11, 2020 at 1:10 AM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.58 release is now available for voting. > > The notable changes compared to the 8.5.57 release are: > > - For requests containing the Expect: 100-continue header, optional > support has been added to delay

[GitHub] [tomcat] martin-g commented on pull request #356: Micro optimization: replace "".equals(a) with a.isEmpty()

2020-09-11 Thread GitBox
martin-g commented on pull request #356: URL: https://github.com/apache/tomcat/pull/356#issuecomment-690909792 > It would be great just to fix all these problems at once I prefer to make one kind of change at a time. It is easier to detect regressions and impact this way.

Re: [VOTE] Release Apache Tomcat 9.0.38

2020-09-11 Thread Martin Grigorov
On Thu, Sep 10, 2020 at 12:03 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.38 release is now available for voting. > > The notable changes compared to the 9.0.37 release are: > > - For requests containing the Expect: 100-continue header, optional > support has been added to delay

[GitHub] [tomcat] martin-g commented on a change in pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-11 Thread GitBox
martin-g commented on a change in pull request #354: URL: https://github.com/apache/tomcat/pull/354#discussion_r486875285 ## File path: java/org/apache/catalina/startup/ContextConfig.java ## @@ -2136,26 +2146,98 @@ protected InputSource getWebXmlSource(String filename,

[GitHub] [tomcat] martin-g commented on a change in pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-11 Thread GitBox
martin-g commented on a change in pull request #354: URL: https://github.com/apache/tomcat/pull/354#discussion_r486870063 ## File path: java/org/apache/catalina/startup/LocalStrings_fr.properties ## @@ -69,6 +69,7 @@ contextConfig.missingRealm=Aucun royaume (realm) n'a été

[GitHub] [tomcat] stokito commented on pull request #356: Micro optimization: replace "".equals(a) with a.isEmpty()

2020-09-11 Thread GitBox
stokito commented on pull request #356: URL: https://github.com/apache/tomcat/pull/356#issuecomment-690906236 In fact Tomcat has hundreds of such places where simple, safe, and more readable optimizations can be applied. Just open sources in IntelliJ, open

Re: [VOTE] Release Apache Tomcat 10.0.0-M8

2020-09-11 Thread Martin Grigorov
On Wed, Sep 9, 2020 at 5:57 PM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0-M8 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > Applications

[GitHub] [tomcat] martin-g commented on a change in pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-11 Thread GitBox
martin-g commented on a change in pull request #354: URL: https://github.com/apache/tomcat/pull/354#discussion_r486872606 ## File path: java/org/apache/catalina/startup/ContextConfig.java ## @@ -2136,26 +2146,98 @@ protected InputSource getWebXmlSource(String filename,

[tomcat] branch 9.0.x updated: Improve the quality of the health check

2020-09-11 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 79c5de4 Improve the quality of the health check

[tomcat] branch master updated: Fix intermittent test failure

2020-09-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 6019533 Fix intermittent test failure 6019533

[GitHub] [tomcat] rmaucher commented on a change in pull request #354: Optimize Server startup time using multi-threading for annotation scanning

2020-09-11 Thread GitBox
rmaucher commented on a change in pull request #354: URL: https://github.com/apache/tomcat/pull/354#discussion_r486924037 ## File path: java/org/apache/catalina/startup/LocalStrings_fr.properties ## @@ -69,6 +69,7 @@ contextConfig.missingRealm=Aucun royaume (realm) n'a été

[tomcat] branch master updated: Improve the quality of the health check

2020-09-11 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 2ff7bba Improve the quality of the health check

[GitHub] [tomcat] martin-g commented on a change in pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-11 Thread GitBox
martin-g commented on a change in pull request #352: URL: https://github.com/apache/tomcat/pull/352#discussion_r486991509 ## File path: java/org/apache/catalina/webresources/AbstractArchiveResourceSet.java ## @@ -211,6 +216,46 @@ public final WebResource getResource(String

[tomcat] branch 8.5.x updated: Fix intermittent test failure

2020-09-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new f1c4117 Fix intermittent test failure f1c4117 is

[tomcat] branch 9.0.x updated: Fix intermittent test failure

2020-09-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new bbee5db Fix intermittent test failure bbee5db is

[GitHub] [tomcat] martin-g commented on a change in pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-11 Thread GitBox
martin-g commented on a change in pull request #352: URL: https://github.com/apache/tomcat/pull/352#discussion_r486993681 ## File path: java/org/apache/catalina/webresources/JarContents.java ## @@ -0,0 +1,122 @@ +package org.apache.catalina.webresources; + +import

Re: [tomcat] branch master updated: Improve the quality of the health check

2020-09-11 Thread Martin Grigorov
Hi Remy, I'm not sure whether GitHub notified you about my comment on this commit: https://github.com/apache/tomcat/commit/2ff7bba79946a3716b136b0752c9fe7126b50499#r42227542 On Fri, Sep 11, 2020 at 2:27 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm

Re: [tomcat] branch master updated: Improve the quality of the health check

2020-09-11 Thread Rémy Maucherat
On Fri, Sep 11, 2020 at 2:28 PM Martin Grigorov wrote: > Hi Remy, > > I'm not sure whether GitHub notified you about my comment on this commit: > > https://github.com/apache/tomcat/commit/2ff7bba79946a3716b136b0752c9fe7126b50499#r42227542 > I think you're supposed to use the mailing list for

[tomcat] branch master updated: Implement checkContainersAvailable flag

2020-09-11 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 120bf9d Implement checkContainersAvailable flag

[tomcat] branch 9.0.x updated: Implement checkContainersAvailable flag

2020-09-11 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6916632 Implement checkContainersAvailable flag