This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit f3b75d2eddd5832b2deab423ab7d9b2415ac77f5
Author: Emmanuel Bourg
AuthorDate: Wed Dec 2 01:16:12 2020 +0100
Replace
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 24750228694b58e7631afeedf651a9f15779bad3
Author: Emmanuel Bourg
AuthorDate: Wed Dec 2 00:55:34 2020 +0100
Use
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from f3b75d2 Replace Runnable inner classes with lambda expressions
new 521b3a3 Replace Collections.sort() with
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 521b3a3e481ae121d5006124611a89a4c4a1302e
Author: Emmanuel Bourg
AuthorDate: Wed Dec 2 01:28:25 2020 +0100
Replace
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 382dffc41f4f84e6d775739f73c4a1aac1711bb8
Author: Emmanuel Bourg
AuthorDate: Wed Dec 2 01:34:34 2020 +0100
Replace
Hi Graham,
On Tue, Dec 1, 2020 at 7:43 PM Graham Leggett
wrote:
> On 01 Dec 2020, at 13:48, Rémy Maucherat wrote:
>
> > You still have years to plan a migration off the APR connector as it will
> > only be removed in 10.1 and Tomcat 9.0 continues to be supported.
> >
> > This eventual removal
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 2728f60e83b9b46b5dd2529d6efed70b29da8929
Author: Emmanuel Bourg
AuthorDate: Wed Dec 2 00:52:02 2020 +0100
Use
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 03cd304b28157cce56fdb82bd328477cd8c563cd
Author: Emmanuel Bourg
AuthorDate: Tue Dec 1 22:35:49 2020 +0100
Use the
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 9f18abee8cf0d9945e62d9a5cdeb2db3206662ce
Author: Emmanuel Bourg
AuthorDate: Wed Dec 2 01:07:51 2020 +0100
Replace
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 98fd8e1 Fix BZ 64947. NPE on custom HTTP upgrade
new 03cd304 Use the valueOf() method of the primitive
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #8 from Remy Maucherat ---
(In reply to Mark Thomas from comment #7)
> I can't fund any EG discussion to support a requirement that the upgrade
> header is set on the response before calling HttpServletRequest.upgrade().
> I'll see
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #9 from Mark Thomas ---
I have a fix for this locally. Just need to test it a little more.
--
You are receiving this mail because:
You are the assignee for the bug.
michael-o edited a comment on pull request #382:
URL: https://github.com/apache/tomcat/pull/382#issuecomment-736761640
>
>
> > > To be in any way useful the socket must be writable, and to do that it
either needs to default to being writable, or needs to explicitly set as
writable
michael-o commented on pull request #382:
URL: https://github.com/apache/tomcat/pull/382#issuecomment-736761640
>
>
> > > To be in any way useful the socket must be writable, and to do that it
either needs to default to being writable, or needs to explicitly set as
writable with
minfrin commented on pull request #382:
URL: https://github.com/apache/tomcat/pull/382#issuecomment-736746529
> > To be in any way useful the socket must be writable, and to do that it
either needs to default to being writable, or needs to explicitly set as
writable with at least
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r533488953
##
File path: java/org/apache/tomcat/util/net/LocalStrings.properties
##
@@ -88,6 +88,7 @@ endpoint.init.bind=Socket bind failed: [{0}] [{1}]
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #1 from Remy Maucherat ---
Ok, this is new code that allows collecting stats.
I cannot immediately see why the UpgradeGroupInfo ends up null so more research
could be useful [example code maybe ?], but there is a null check for
michael-o commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r533555103
##
File path: java/org/apache/tomcat/jni/Address.java
##
@@ -40,8 +40,9 @@
/**
* Create apr_sockaddr_t from hostname, address family, and
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #4 from Mark Thomas ---
To re-phrase what Rémy said, we can fix the NPE but this is still going to fail
because the response header is missing. You'll just get a nicer error message.
--
You are receiving this mail because:
You
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #5 from Peter Major ---
The Upgrade header does eventually show up in the response, but it looks like
it happens after the call to UpgradeProcessorExternal is made (added by an
async servlet). From the browser's point of view I'm
On 01 Dec 2020, at 13:48, Rémy Maucherat wrote:
> You still have years to plan a migration off the APR connector as it will
> only be removed in 10.1 and Tomcat 9.0 continues to be supported.
>
> This eventual removal or APR has been discussed for years. BTW, so that you
> know, there are also
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #7 from Mark Thomas ---
I can't fund any EG discussion to support a requirement that the upgrade header
is set on the response before calling HttpServletRequest.upgrade(). I'll see if
can find a different way to get the protocol
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
The following commit(s) were added to refs/heads/master by this push:
new 8a7568c Minimise diff with
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r533571858
##
File path: webapps/docs/config/http.xml
##
@@ -208,6 +208,24 @@
The default is POST
+
+ Where supported, the path to a unix
michael-o commented on pull request #382:
URL: https://github.com/apache/tomcat/pull/382#issuecomment-736684033
> The typical umask is 0027, meaning full access for tomcat itself, read
access for members of the tomcat group (so that logfiles can be read but not
changed), and no access for
Sumithkr commented on pull request #381:
URL: https://github.com/apache/tomcat/pull/381#issuecomment-736727209
https://mariadb.com/kb/en/installing-mariadb-on-ibm-cloud/
check this same documentation is for tomcat
On Tue, 1 Dec 2020 at 15:28, Rémy Maucherat
wrote:
> The
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #10 from Peter Major ---
FYI if you have a PR/branch for this, I can test the fix locally.
--
You are receiving this mail because:
You are the assignee for the bug.
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
The following commit(s) were added to refs/heads/master by this push:
new 780a940 One more diff with
Hi all,
I've just published the following snapshot:
https://repository.apache.org/content/groups/snapshots/org/apache/tomcat/jakartaee-migration/0.1.0-SNAPSHOT/
This isn't a formal RC as I am expecting there to be some issues. Please
take a look and report any issues back to this thread.
I
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #6 from Mark Thomas ---
Hmm. Tomcat's Javadocs for HttpServletRequest.upgrade() have language stating
the headers must be set before the method is called. The Servlet spec API does
not have that language. I wonder where that
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #11 from Mark Thomas ---
It is now in 9.0.x. Let us know how you get on.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #12 from Peter Major ---
Things are looking good so far, haven't seen my websocket requests interrupted
and catalina.out didn't show the NPE either.
Thank you for the quick turnaround.
--
You are receiving this mail because:
You
https://bz.apache.org/bugzilla/show_bug.cgi?id=64762
--- Comment #10 from Mark Thomas ---
Another month has passed and we still don't have a minimal WAR that reproduces
this issue. I'll leave this open another month but without a test case to
investigate this will get closed.
--
You are
https://bz.apache.org/bugzilla/show_bug.cgi?id=64771
--- Comment #5 from Mark Thomas ---
Two months have passed and we still don't have a minimal WAR that reproduces
this issue. I'll leave this open another month but without a test case to
investigate this will get closed.
--
You are receiving
Sumithkr commented on pull request #381:
URL: https://github.com/apache/tomcat/pull/381#issuecomment-736342539
it has instructions that how to install tomcat on ibm cloud
On Mon, 30 Nov 2020 at 17:43, Martin Grigorov
wrote:
> IMO this document should be part of IBM
Hi all,
It is the start of the month so I am going to start another round of
releases shortly.
I do want to deprecate the APR connector in 10.0.x as previously
discussed first. If anyone has anything else they want to get in to the
next set of releases, now would be the time to add it :)
Mark
martin-g closed pull request #381:
URL: https://github.com/apache/tomcat/pull/381
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
martin-g commented on pull request #381:
URL: https://github.com/apache/tomcat/pull/381#issuecomment-736353788
Tomcat cannot maintain documentation for all the cloud providers out there.
It is their responsibility to explain what they did differently than the
official Tomcat
rmaucher commented on pull request #381:
URL: https://github.com/apache/tomcat/pull/381#issuecomment-736367100
The wiki can still be a good spot for this kind of thing, as long as it is
organized properly and maintained.
On Tue, Dec 1, 2020 at 12:05 PM Graham Leggett
wrote:
> Hi all,
>
> I object to the deprecation of the tomcat-native/APR connector.
>
> Most specifically, I am -1 on the following:
>
> https://marc.info/?l=tomcat-dev=160681846808019=2
>
> Looking at past discussion on this, the justification has
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 9406b85 First pass at deprecation in
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r533367239
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the pool
On 01/12/2020 11:05, Graham Leggett wrote:
> Hi all,
>
> I object to the deprecation of the tomcat-native/APR connector.
>
> Most specifically, I am -1 on the following:
>
> https://marc.info/?l=tomcat-dev=160681846808019=2
>
> Looking at past discussion on this, the justification has been:
>
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 72323cb Deprecate the APR/Native AJP and HTTP
Hi all,
I object to the deprecation of the tomcat-native/APR connector.
Most specifically, I am -1 on the following:
https://marc.info/?l=tomcat-dev=160681846808019=2
Looking at past discussion on this, the justification has been:
"It is inherently less stable. If we get the NIO code wrong,
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
The following commit(s) were added to refs/heads/master by this push:
new c52b23c Update BCEL to
michael-o commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r533486240
##
File path: xdocs/index.xml
##
@@ -174,6 +175,14 @@ list of changes.
Please see the Apache Tomcat documentation for configuration
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #2 from Peter Major ---
Sadly I don't have access to the source code (found it when setting up a third
party reverse proxy product). The reason why upgradeGroupInfo is null, is
because AbstractHttp11Protocol#getUpgradeGroupInfo is
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
Bug ID: 64947
Summary: NPE in UpgradeProcessorExternal constructor
Product: Tomcat 9
Version: 9.0.40
Hardware: PC
OS: Mac OS X 10.4
Status: NEW
https://bz.apache.org/bugzilla/show_bug.cgi?id=64947
--- Comment #3 from Remy Maucherat ---
(In reply to Peter Major from comment #2)
> Sadly I don't have access to the source code (found it when setting up a
> third party reverse proxy product). The reason why upgradeGroupInfo is null,
> is
minfrin commented on a change in pull request #8:
URL: https://github.com/apache/tomcat-native/pull/8#discussion_r533553364
##
File path: xdocs/index.xml
##
@@ -174,6 +175,14 @@ list of changes.
Please see the Apache Tomcat documentation for configuration
michael-o commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r533484404
##
File path: java/org/apache/tomcat/util/net/AprEndpoint.java
##
@@ -292,52 +295,79 @@ public void bind() throws Exception {
// Create the
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
The following commit(s) were added to refs/heads/master by this push:
new fd0a785 Increment version
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
The following commit(s) were added to refs/heads/master by this push:
new 9a3e8a7 Update JUnit
minfrin commented on pull request #382:
URL: https://github.com/apache/tomcat/pull/382#issuecomment-736674567
> * A few nits in docs.
> * I wonder whether we should set default permissions at all and rely on
the umask.
> * Tomcat has a umask check (startup listener) which these
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
The following commit(s) were added to refs/heads/master by this push:
new fda85c2 Add scm definition
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
commit 621db72875777b2575f765a0a1b16b8e6b5c0c22
Author: Mark Thomas
AuthorDate: Tue Dec 1 16:18:45 2020
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
commit c4dc0cad8da462321f321f189be6cac47ef6217f
Author: Mark Thomas
AuthorDate: Tue Dec 1 16:07:33 2020
This is an automated email from the ASF dual-hosted git repository.
markt pushed a change to branch master
in repository
https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git.
from c52b23c Update BCEL to 6.5.0
new c4dc0ca Add ALv2 header and schema. Simplify.
new
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
commit fd3284f2b7bc303174aed40556cf72acbfe16318
Author: Mark Thomas
AuthorDate: Tue Dec 1 16:07:56 2020
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
commit 5dadb63961504044c2e029857f79e04cadf0c6bc
Author: Mark Thomas
AuthorDate: Tue Dec 1 16:10:44 2020
minfrin commented on a change in pull request #382:
URL: https://github.com/apache/tomcat/pull/382#discussion_r533567922
##
File path: java/org/apache/catalina/core/LocalStrings.properties
##
@@ -74,7 +74,7 @@ aprListener.aprInitDebug=The Apache Tomcat Native library
could
62 matches
Mail list logo
