Re: JDK 19 - Virtual Threads Testing!

2022-05-19 Thread Martin Grigorov
Hi David, The issues in Apache Tomcat have been fixed and now everything is OK with JDK 19-ea+22-1598! Regards, Martin On Mon, May 16, 2022 at 4:14 PM Martin Grigorov wrote: > Hello Tomcat devs, > > Some tests fail with JDK 19-ea+22-1598: > > [concat] Testsuites with failed tests: >

Final reminder: ApacheCon North America call for presentations closing soon

2022-05-19 Thread Rich Bowen
[Note: You're receiving this because you are subscribed to one or more Apache Software Foundation project mailing lists.] This is your final reminder that the Call for Presetations for ApacheCon North America 2022 will close at 00:01 GMT on Monday, May 23rd, 2022. Please don't wait! Get your talk

Re: JDK 19 - Virtual Threads Testing!

2022-05-19 Thread Martin Grigorov
Hi Mark, I confirm that all tests pass now! Thank you! Martin On Wed, May 18, 2022 at 1:40 PM Mark Thomas wrote: > On 18/05/2022 10:25, Mark Thomas wrote: > > Hi all, > > > > So of the three issues Martin identified, I've fixed 1 & 3 which were > > the simple ones. > > > > For 1, the import

[tomcat] branch 10.0.x updated: Fix deadlock on startup

2022-05-19 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new e910d44ce5 Fix deadlock on startup e910d44ce5 is

Re: Trying to use Loom virtual threads with Tomcat

2022-05-19 Thread Mark Thomas
On 09/05/2022 19:01, Cay Horstmann wrote: Il 03/05/2022 08:31, Cay Horstmann ha scritto: Il 03/05/2022 07:25, Rémy Maucherat ha scritto: On Tue, May 3, 2022 at 6:24 AM Cay Horstmann wrote: Hi, I am trying to experiment with Loom (https://openjdk.java.net/jeps/425) virtual threads in Tomcat

[GitHub] [tomcat] rmaucher commented on pull request #515: Bug:Deadlocks occur when both engine and host startStopThreads values are set and the latter value is larger than the former

2022-05-19 Thread GitBox
rmaucher commented on PR #515: URL: https://github.com/apache/tomcat/pull/515#issuecomment-1131378209 Good idea, the sync is overloaded in that case so this is risky, and other operations already use a servicesLock item for this reason. -- This is an automated message from the Apache Git

[tomcat] branch main updated: Fix deadlock on startup

2022-05-19 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 62594a6311 Fix deadlock on startup 62594a6311 is

[tomcat] branch 9.0.x updated: Fix deadlock on startup

2022-05-19 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 192c0e0ec6 Fix deadlock on startup 192c0e0ec6 is

[GitHub] [tomcat] aooohan commented on pull request #515: Bug:Deadlocks occur when both engine and host startStopThreads values are set and the latter value is larger than the former

2022-05-19 Thread GitBox
aooohan commented on PR #515: URL: https://github.com/apache/tomcat/pull/515#issuecomment-1131597904 @rmaucher Thank u for reviewing my PR, it's an honour to contribute PR to Tomcat. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[tomcat] branch main updated: Remove unnecessary code

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new f1253c0737 Remove unnecessary code f1253c0737 is

[tomcat] branch 10.0.x updated (e910d44ce5 -> 9aae3a2798)

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from e910d44ce5 Fix deadlock on startup new cbffa819f3 refine the log message new 13ee1503c8 change the tense of

[tomcat] 03/03: Remove unnecessary code

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 9aae3a2798a38b3d5c6e621f4106bee9d219e05a Author: Mark Thomas AuthorDate: Thu May 19 14:03:40 2022 +0100 Remove

[tomcat] branch main updated (62594a6311 -> 28db32a550)

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 62594a6311 Fix deadlock on startup new dd8c37ec8a refine the log message new 28db32a550 change the tense of

[tomcat] 01/03: refine the log message

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4f066532f462b66b42869c846c05a39c91f6809b Author: Zishuo Ding AuthorDate: Wed May 11 11:03:59 2022 -0400 refine the

[tomcat] 03/03: Remove unnecessary code

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 37adf9dc4bd38c162009cffbcbd6cecce4b91d23 Author: Mark Thomas AuthorDate: Thu May 19 14:03:40 2022 +0100 Remove

[tomcat] 02/03: change the tense of the localstrings from complete to in progress

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1d8a7bb24f4e409cdb5678a5b05a889d009f06a6 Author: Zishuo Ding AuthorDate: Wed May 11 11:06:02 2022 -0400 change the

[tomcat] branch 9.0.x updated (192c0e0ec6 -> 37adf9dc4b)

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 192c0e0ec6 Fix deadlock on startup new 4f066532f4 refine the log message new 1d8a7bb24f change the tense of

[tomcat] 01/03: refine the log message

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cbffa819f325efc7dcc77c6fe63f5459c7fdc8d8 Author: Zishuo Ding AuthorDate: Wed May 11 11:03:59 2022 -0400 refine the

[tomcat] 02/03: change the tense of the localstrings from complete to in progress

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 13ee1503c808fc9e2cdb034c35ecfd693f56cb3c Author: Zishuo Ding AuthorDate: Wed May 11 11:06:02 2022 -0400 change the

[GitHub] [tomcat] markt-asf merged pull request #514: Registry gives inaccurate log message saying "Creating MBeanServer ... " after already created the MBeanServer

2022-05-19 Thread GitBox
markt-asf merged PR #514: URL: https://github.com/apache/tomcat/pull/514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tomcat] markt-asf commented on pull request #514: Registry gives inaccurate log message saying "Creating MBeanServer ... " after already created the MBeanServer

2022-05-19 Thread GitBox
markt-asf commented on PR #514: URL: https://github.com/apache/tomcat/pull/514#issuecomment-1131660833 Note that i18n strings are managed via poeditor https://cwiki.apache.org/confluence/display/TOMCAT/Managing+translations -- This is an automated message from the Apache Git Service.

[tomcat] 01/02: refine the log message

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit dd8c37ec8ac2bba4a2988f35ca5823311e1fb96c Author: Zishuo Ding AuthorDate: Wed May 11 11:03:59 2022 -0400 refine the

[tomcat] 02/02: change the tense of the localstrings from complete to in progress

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 28db32a55077600f706cdae50024e50aef663d63 Author: Zishuo Ding AuthorDate: Wed May 11 11:06:02 2022 -0400 change the

[Bug 66060] Registry gives inaccurate log message saying "Creating MBeanServer ... " after already created the MBeanServer

2022-05-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66060 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[GitHub] [tomcat] rmaucher closed pull request #515: Bug:Deadlocks occur when both engine and host startStopThreads values are set and the latter value is larger than the former

2022-05-19 Thread GitBox
rmaucher closed pull request #515: Bug:Deadlocks occur when both engine and host startStopThreads values are set and the latter value is larger than the former URL: https://github.com/apache/tomcat/pull/515 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] rmaucher commented on pull request #515: Bug:Deadlocks occur when both engine and host startStopThreads values are set and the latter value is larger than the former

2022-05-19 Thread GitBox
rmaucher commented on PR #515: URL: https://github.com/apache/tomcat/pull/515#issuecomment-1131604290 Thanks a lot for your PR. Sorry, I forgot to close it after merging it manually. The fix will be in Tomcat 10.1.0-M16, 10.0.22, 9.0.64. Tomcat 8.5 is not affected since it doesn't have the

[tomcat] branch 8.5.x updated (7cdce2a6ea -> 818a7a0378)

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 7cdce2a6ea The ObjectStreamClass memory leak has been fixed in newer JREs new 26e2184e7f refine the log message

[tomcat] 01/03: refine the log message

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 26e2184e7f43bd8512fe5a4652651a96c3b181c5 Author: Zishuo Ding AuthorDate: Wed May 11 11:03:59 2022 -0400 refine the

[tomcat] 02/03: change the tense of the localstrings from complete to in progress

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit bb0a0279104924935ff60a5af9b258157c80ea9b Author: Zishuo Ding AuthorDate: Wed May 11 11:06:02 2022 -0400 change the

[tomcat] 03/03: Remove unnecessary code

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 818a7a03788477284ca7376026e400ab54961ea4 Author: Mark Thomas AuthorDate: Thu May 19 14:03:40 2022 +0100 Remove

[Bug 66068] Asynchronous request processing changes IP behind RemoteIpValve

2022-05-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66068 --- Comment #1 from Mark Thomas --- I think the fix for this is fairly simple. If the request is in async mode, we don't reset the request in the finally block after calling the next Valve in the pipeline. Assuming there are no objections to

svn commit: r1901074 - in /tomcat/site/trunk: docs/presentations.html xdocs/presentations.xml

2022-05-19 Thread schultz
Author: schultz Date: Thu May 19 19:00:24 2022 New Revision: 1901074 URL: http://svn.apache.org/viewvc?rev=1901074=rev Log: Add "id" to Migration from AJP -> HTTP presentation. Modified: tomcat/site/trunk/docs/presentations.html tomcat/site/trunk/xdocs/presentations.xml Modified:

[Bug 66077] Deadlock when concurrent processing of incoming HTTP/2 frames

2022-05-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66077 Ram Lakshmanan changed: What|Removed |Added CC||r...@tier1app.com -- You are

[Bug 66077] Deadlock when concurrent processing of incoming HTTP/2 frames

2022-05-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66077 Ram Lakshmanan changed: What|Removed |Added URL||https://fastthread.io/my-th

Re: Possible Connector doc update with NIO & NIO2

2022-05-19 Thread David Blevins
> On May 19, 2022, at 5:16 PM, David Blevins wrote: > > - useSendfile > Quick correction. This one seems to be common between NIO, NIO2 and Apr and has the same description in all three. Potentially it could go in the "Common Attributes" section. -David smime.p7s Description: S/MIME

[Bug 66077] New: Deadlock when concurrent processing of incoming HTTP/2 frames

2022-05-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66077 Bug ID: 66077 Summary: Deadlock when concurrent processing of incoming HTTP/2 frames Product: Tomcat 10 Version: 10.0.16 Hardware: All OS: other

[Bug 66076] Final block of encrypted response payload not being sent occasionally over TLS

2022-05-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66076 --- Comment #3 from Mark Thomas --- Thanks for the analysis. What you describe makes sense to me. It looks like the non-blocking variant of bug 65448. My current thinking is that SocketWrapper.flushNonBlocking() needs an NIO specific

[tomcat] branch main updated (f1253c0737 -> 690c559667)

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from f1253c0737 Remove unnecessary code new c48714554a Add Javadoc new 1c84dc9b43 Add @Override new 6d67ccb711

[tomcat] 02/04: Add @Override

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1c84dc9b4339a033daf1a0fc643a9d0093b20520 Author: Mark Thomas AuthorDate: Fri May 20 06:47:45 2022 +0100 Add @Override

[tomcat] 04/04: Refactor for cleaner code and to avoid NPE warnings from IDE

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 690c5596675623e498ced941d7acad2bbcb2f32b Author: Mark Thomas AuthorDate: Fri May 20 06:48:35 2022 +0100 Refactor for

[tomcat] 03/04: Remove unused code

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 6d67ccb71135f542667b7a5241f429a1272136ad Author: Mark Thomas AuthorDate: Fri May 20 06:47:57 2022 +0100 Remove unused

[tomcat] 01/04: Add Javadoc

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c48714554aaa422d16d1cbfdcc075a89252e6dc6 Author: Mark Thomas AuthorDate: Fri May 20 06:47:21 2022 +0100 Add Javadoc

[tomcat] branch 10.0.x updated (9aae3a2798 -> ebbeb0b943)

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 9aae3a2798 Remove unnecessary code new d1ac5ece13 Remove unused code new 26204b79db Add @Override new

[tomcat] 02/04: Add @Override

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 26204b79db50613eba830e3d03c8a614a3bea35b Author: Mark Thomas AuthorDate: Fri May 20 06:47:45 2022 +0100 Add

[tomcat] 01/04: Remove unused code

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d1ac5ece13f3bfe29ec8a2ea5dc8c5e8af0b08e8 Author: Mark Thomas AuthorDate: Fri May 20 06:47:57 2022 +0100 Remove

[tomcat] 03/04: Refactor for cleaner code and to avoid NPE warnings from IDE

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 16fa5e03a13a16859569c93822efc5a852b4e57d Author: Mark Thomas AuthorDate: Fri May 20 06:48:35 2022 +0100 Refactor

[tomcat] 04/04: Fix IDE warnings

2022-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ebbeb0b943d5a6f8c4e3491c48324a9b59600dfa Author: Mark Thomas AuthorDate: Fri May 20 06:55:36 2022 +0100 Fix IDE

Possible Connector doc update with NIO & NIO2

2022-05-19 Thread David Blevins
Hey All, I was picking through the connector docs generating some code from the descriptions and I noticed there are a handful of properties common between NIO and NIO2. - socket.appReadBufSize - socket.appWriteBufSize - socket.directBuffer - socket.directSslBuffer - useSendfile These