Re: what happened to the old trunk?

2007-12-07 Thread Konstantin Kolinko
That trunk was moved to sandbox/gdev6x/ See http://svn.apache.org/viewvc?view=revrevision=573772 Sat Sep 8 02:35:33 2007 UTC (2 months, 4 weeks ago) I see that in http://svn.apache.org/viewvc?view=revrevision=593649 a new trunk was created from 6.0.x/trunk but I don't see what happened to the

Re: svn commit: r615478 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/manager/LocalStrings.properties java/org/apache/catalina/manager/ManagerServlet.java webapps/docs/changelog.xml

2008-01-27 Thread Konstantin Kolinko
changelog message is misspelled. Method name is ManagerServlet.expireSessions, not exipreSession. 2008/1/26, [EMAIL PROTECTED] [EMAIL PROTECTED]: Author: pero Date: Sat Jan 26 11:52:28 2008 New Revision: 615478 URL: http://svn.apache.org/viewvc?rev=615478view=rev [...skipped]

Re: svn commit: r615750 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2008-01-28 Thread Konstantin Kolinko
One typo is fixed, but another is still there. It should be expire, not exipre. 2008/1/28, [EMAIL PROTECTED] [EMAIL PROTECTED]: Author: pero Date: Mon Jan 28 00:01:40 2008 New Revision: 615750 URL: http://svn.apache.org/viewvc?rev=615750view=rev Log: Fix typo! Modified:

Re: [VOTE] Release build 5.5.26

2008-01-31 Thread Konstantin Kolinko
The md5 files have an extra CR-LF in them. E.g. c8248787ee28cd0a80196f7cc6f57db8 *apache-tomcat-5.5.26.zip For 6.0.16 they are OK. 2008/1/31, Filip Hanik - Dev Lists [EMAIL PROTECTED]: The candidates binaries are available here: http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.26/

Re: svn commit: r618059 - in /tomcat/trunk: java/org/apache/tomcat/util/net/NioEndpoint.java webapps/docs/changelog.xml

2008-02-03 Thread Konstantin Kolinko
Just a note. The change log message does not seem to be correct. It says opposite of what is implemented by the patch. In the patch the poller thread is started first. Also, the changelog.xml of trunk is substantially outdated. 6.0.16 is nearly coming out and adding new items to 6.0.15 looks

Re: svn commit: r646076 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread Konstantin Kolinko
Well, obviously the new code is not equivalent to the old one, because Long.TYPE and other TYPE constants are the classes for the primitive types (long, int etc.), and those are not an instance of java.lang.Number. From the sources: o.a.el.lang.ELArithmetic.isNumberType() is used in

Re: svn commit: r646076 - /tomcat/trunk/java/org/apache/el/lang/ELArithmetic.java

2008-04-08 Thread Konstantin Kolinko
-03-27 when /tomcat/tc6.0.x/trunk was created? 2008/4/9 Mark Thomas [EMAIL PROTECTED]: Konstantin Kolinko wrote: Well, obviously the new code is not equivalent to the old one, because Long.TYPE and other TYPE constants are the classes for the primitive types (long, int etc.), and those

Re: svn commit: r648605 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-04-16 Thread Konstantin Kolinko
2008/4/16 [EMAIL PROTECTED]: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44766 Handle custom subtypes of java.lang.Number http://svn.apache.org/viewvc?view=revrevision=646106 - +1: markt, remm + +1: markt, remm, rjung -1: + rjung: Simply use: return

Re: Vicious Bug in the JSP code?

2008-07-10 Thread Konstantin Kolinko
It looks like you are keeping a reference to some object (like the Request or Response, or OutputStream) and reusing it, while you should not access it outside the scope of request processing. I cannot go into details now, but all these messages and stack traces look familiar. Such questions are

Re: svn commit: r772875 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-05-09 Thread Konstantin Kolinko
the whole method, closing the stream in case of error or preliminary exit (e.g. caused by if (!openJARs())). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e

Re: svn commit: r772142 - /tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java

2009-05-09 Thread Konstantin Kolinko
reference that it calculates there, like host reference that is already remembered. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: How I can move a Web App from Netscape Web Server to Tomcat?

2009-05-12 Thread Konstantin Kolinko
what you need. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r772142 - /tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java

2009-05-12 Thread Konstantin Kolinko
with that. It is reasonable. Best regards Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Terms of use for our Wiki

2009-05-13 Thread Konstantin Kolinko
Hi, all! Should there be some explicit TermsOfUse page or copyright/license clause in our wiki? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev

Re: [VOTE] Release build 6.0.20

2009-05-13 Thread Konstantin Kolinko
=jvm1 -- * C:\(...)\_ZIP\CONF\SERVER.XML !-- You should set jvmRoute to support load-balancing via AJP ie : Engine name=Catalina defaultHost=localhost jvmRoute=jvm1 -- * I have not run the binaries yet. Best regards, Konstantin Kolinko

svn commit: r775377, r775379, r775380 - /tomcat/site/

2009-05-17 Thread Konstantin Kolinko
is already solved, but I know how to reproduce it. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread Konstantin Kolinko
of anything similar for other clients, or if any other clients were respecting this setting. In general, there is http://subversion.tigris.org/issues/show_bug.cgi?id=1974 which is unlikely to be implemented any soon. Best regards, Konstantin Kolinko

Coding Guidelines, encodings, keywords

2009-05-21 Thread Konstantin Kolinko
(e.g. $Date:: 2009-05-21 08:33:21 #$) or to use $Id$ instead. Do we officially acknowledge that the sources are UTF-8? What explicit encoding should be specified in javac and javadoc tasks in our build files? ISO-8859-1 or UTF-8 ? Best regards, Konstantin Kolinko

Re: [VOTE] Release build 6.0.20

2009-05-24 Thread Konstantin Kolinko
and placed it in http://people.apache.org/~kkolinko/tomcat-6/v6.0.20/src/ md5 sum is 6a747d5bfa6b0b57605e8697ca8a4cae *apache-tomcat-6.0.20-src.tar.gz Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: [VOTE] Release build 6.0.20

2009-05-25 Thread Konstantin Kolinko
2009/5/24 sebb seb...@gmail.com: On 24/05/2009, Konstantin Kolinko knst.koli...@gmail.com wrote: 2009/5/14 Remy Maucherat r...@apache.org: The candidates binaries are available here:   http://people.apache.org/~remm/tomcat-6/v6.0.20/     According to the release process, the 6.0.20 tag

Re: [VOTE] Release build 6.0.20

2009-05-26 Thread Konstantin Kolinko
2009/5/24 Konstantin Kolinko knst.koli...@gmail.com: 2009/5/14 Remy Maucherat r...@apache.org: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.20/ According to the release process, the 6.0.20 tag is: [ ] Broken [ ] Alpha [ ] Beta [x] Stable I do

Re: [PROPOSAL] Adding support for aliases to DirContext

2009-05-26 Thread Konstantin Kolinko
://svn.apache.org/viewvc?rev=575945view=rev Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Updated procrun binaries

2009-05-29 Thread Konstantin Kolinko
scripts there. Thought it will be easy to fix. If not we should really make some more user friendly link on the download section so those files can be picked up for 64-bit JVM users. Regards -- ^(TM) Best regards, Konstantin Kolinko

Re: svn commit: r781780 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-04 Thread Konstantin Kolinko
see that it just removes generics. Tomcat 6.0 runs on JRE 1.5 or later and is built with compile.source=1.5 compile.target=1.5 There is no need to avoid generics there. Best regards, Konstantin Kolinko - To unsubscribe, e-mail

5.5.x branch cannot run

2009-06-09 Thread Konstantin Kolinko
suppose that 4.1 will have the same problem. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: 5.5.x branch cannot run

2009-06-10 Thread Konstantin Kolinko
2009/6/9 Mark Thomas ma...@apache.org: Konstantin Kolinko wrote: I built TC 5.5 distributive from current tc5.5.x, and it is broken: My bad. My port of the CVE-2008-5515 patch was too hasty. I'll fix it (and 4.1.x which will likely have the same problem0 this evening. Mark OK. It works

Re: svn commit: r783318 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-10 Thread Konstantin Kolinko
with above fix for 36923 (ie bug 47318) -  http://svn.apache.org/viewvc?rev=782168view=rev -  +1: markt, kkolinko +  http://svn.apache.org/viewvc?rev=783313view=rev +  +1: markt   -1: I think, that you meant r783316 ? http://svn.apache.org/viewvc?rev=783316view=rev Best regards, Konstantin

Re: Tagging 5.5.28

2009-06-10 Thread Konstantin Kolinko
. But the time until the end of the week should be enough to review them, isn't it? 2. I hope that the release is build on Windows, and there is no urgent need to backport all those Linux-build patches from 6.0 now? Otherwise it will take some time. Am I wrong? Best regards, Konstantin Kolinko

Re: svn commit: r783779 - /tomcat/trunk/java/org/apache/tomcat/util/buf/HexUtils.java

2009-06-11 Thread Konstantin Kolinko
, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r783570 - /tomcat/current/tc4.1.x/STATUS.txt

2009-06-11 Thread Konstantin Kolinko
effectively the same, isn't it? May be I do not understand something... Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread Konstantin Kolinko
Sorry for somewhat slow reply, but just on formal grounds it is [x] BROKEN - I found some show stoppers See http://apache.org/legal/src-headers.html#notice http://www.apache.org/dev/release.html#distribute-other-artifacts So, a copy of a LICENSE and NOTICE files is required, at least along

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread Konstantin Kolinko
2009/6/11 Konstantin Kolinko knst.koli...@gmail.com: Sorry for somewhat slow reply, but just on formal grounds it is  [x] BROKEN - I found some show stoppers See http://apache.org/legal/src-headers.html#notice http://www.apache.org/dev/release.html#distribute-other-artifacts So, a copy

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread Konstantin Kolinko
, aren't they? Unpacking a distribution and clicking those *.html files will open a document with missing images. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands

Re: svn commit: r783570 - /tomcat/current/tc4.1.x/STATUS.txt

2009-06-11 Thread Konstantin Kolinko
the error page encoding for existing applications. We cannot fix CharsetMapper, because it can be overwritten, but we can fix those places where it is called. Here is the patch: http://people.apache.org/~kkolinko/patches/2009-06-12_tc41_CharsetMapper.patch Best regards, Konstantin Kolinko

Re: svn commit: r783570 - /tomcat/current/tc4.1.x/STATUS.txt

2009-06-12 Thread Konstantin Kolinko
2009/6/12 Mark Thomas ma...@apache.org: Konstantin Kolinko wrote: Thank you for detailed explanation. My analysis is the following: hres.setLocale(locale); call -  o.a.c.Response.setLocale() - o.a.c.connector.ResponseBase.setLocale() In o.a.c.connector.ResponseBase.setLocale() it calls

HostConfig.checkResources()

2009-06-13 Thread Konstantin Kolinko
, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-18 Thread Konstantin Kolinko
); +            } +        }; + I wonder, may be we can have a single ThreadLocal that holds some object that stores all the formatters (maybe with lazy initialization), instead of wrapping each one individually? Will it make some difference? Best regards, Konstantin Kolinko

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-19 Thread Konstantin Kolinko
comes from if (xxx 1000) { part, and how many times for each second it is triggered. If it is triggered only once, the performance is better. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: svn commit: r786530 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-19 Thread Konstantin Kolinko
slipped in. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r786527 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-19 Thread Konstantin Kolinko
there. (The only reason I might see for that is to align the code with documentation). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-19 Thread Konstantin Kolinko
(Centrino Duo), running from within an IDE. The last two lines of the four are implementations using StringBuffer vs. StringBuilder. The difference is negligible (either one or the other is faster, on different runs). Best regards, Konstantin Kolinko

Re: svn commit: r786530 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-20 Thread Konstantin Kolinko
2009/6/19 Mark Thomas ma...@apache.org: Konstantin Kolinko wrote:  * Fix wrong download location of tcnative 1.1.16   Patch for build/build.properties.default:   http://people.apache.org/~kkolinko/patches/2009-05-25_fix_tcnative_download.patch   +1: kkolinko, fhanik -  -1: +  -1: markt

Re: [VOTE] Release build 4.1.40 - Take 2

2009-06-22 Thread Konstantin Kolinko
Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r787648 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-23 Thread Konstantin Kolinko
(); +ByteChunk origValue=new ByteChunk(); can be 'private' here. The rest of it looks good. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: svn commit: r787710 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-23 Thread Konstantin Kolinko
%PROCESSOR_ARCHITEW6432% 0 +5 I think it should be StrCmp $0 %PROCESSOR_ARCHITEW6432% +5 0 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r787710 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-24 Thread Konstantin Kolinko
2009/6/23 Mladen Turk mt...@apache.org: Konstantin Kolinko wrote: +  StrCmp $0 %PROCESSOR_ARCHITEW6432% 0 +5 I think it should be StrCmp $0 %PROCESSOR_ARCHITEW6432% +5 0 Thanks for spotting that. Updated the patch as well. OK. Minor issues: apache-tomcat-6.0-snapshot.tar.gz has bin

Re: svn commit: r787710 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-06-24 Thread Konstantin Kolinko
2009/6/24 Mladen Turk mt...@apache.org: Konstantin Kolinko wrote: Minor issues: apache-tomcat-6.0-snapshot.tar.gz  has bin/service.bat,  while *.zip does not have the file. Probably missing exclude rule. apache-tomcat-6.0-snapshot-windows-x86.zip  has two identical copies of each

Re: svn commit: r787955 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-24 Thread Konstantin Kolinko
: +rctxt.addWrapper(tagFileJarUrl + tagFilePath, wrapper); The first call uses tagFileJarPath while the second one uses tagFileJarUrl. I found this when comparing your patch against http://svn.apache.org/viewvc?rev=739530view=rev Best regards, Konstantin Kolinko

Re: [PROPOSAL] Use CTR for anything in the tomcat/archive in svn

2009-06-25 Thread Konstantin Kolinko
, this will make it easier. Unsurprisingly, here is my +1 +1 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-26 Thread Konstantin Kolinko
. (By the first glance, I have not noticed any problems there). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-27 Thread Konstantin Kolinko
Mark Thomas wrote: Konstantin Kolinko wrote: 2. struct.currentDateString is calculated in two different places I propose to encapsulate that code into AccessDateStruct 3. Invocation of getDate() in invoke() (the only place where getDate() is called): I think that getDate() also can

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-28 Thread Konstantin Kolinko
there. currentDate.getTime() cannot be called unless this Date instance is local to this thread, but it is not there. Also, that Date object is returned by that function and can be used by other threads while getDate() modifies it. Best regards, Konstantin Kolinko

Re: svn commit: r790292 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-01 Thread Konstantin Kolinko
+ '/' +... sequences that are building the current date string were different. I'll update the patch. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

[PROPOSAL] Remove build-webapps-precompile target from dist.xml of TC 6, TC 7. Or enable and fix it?

2009-07-02 Thread Konstantin Kolinko
/index.jsp is not included into the distributives. For trunk that does not matter) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Minimum Ant version for Tomcat 5.5 (was Re: svn commit: r791159)

2009-07-04 Thread Konstantin Kolinko
so. Though maybe it is already not possible to use it - I have not tried. If so, I would update the docs right away. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: svn commit: r791139 - in /tomcat/trunk/java/org/apache/jasper/el: ELContextWrapper.java ExpressionEvaluatorImpl.java

2009-07-04 Thread Konstantin Kolinko
not committed yet? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r791139 - in /tomcat/trunk/java/org/apache/jasper/el: ELContextWrapper.java ExpressionEvaluatorImpl.java

2009-07-04 Thread Konstantin Kolinko
2009/7/4 Konstantin Kolinko knst.koli...@gmail.com: 2009/7/4  ma...@apache.org: Author: markt Date: Sat Jul  4 15:46:47 2009 New Revision: 791139 URL: http://svn.apache.org/viewvc?rev=791139view=rev Log: Fix generics warnings Modified:    tomcat/trunk/java/org/apache/jasper/el

Re: svn commit: r791139 - in /tomcat/trunk/java/org/apache/jasper/el: ELContextWrapper.java ExpressionEvaluatorImpl.java

2009-07-05 Thread Konstantin Kolinko
2009/7/5 Mark Thomas ma...@apache.org: Konstantin Kolinko wrote: Fixed it myself, in rev.791186. Don't worry. Thanks, but I am going to have to revert. Those are spec classes. I should not have made my original change. Oh, I see that now. Best regards, Konstantin Kolinko

Re: svn commit: r791224 - in /tomcat/trunk/java/org/apache/jasper/compiler: Generator.java PageInfo.java

2009-07-05 Thread Konstantin Kolinko
to that set of variable names. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r791224 - in /tomcat/trunk/java/org/apache/jasper/compiler: Generator.java PageInfo.java

2009-07-05 Thread Konstantin Kolinko
2009/7/5 Mark Thomas ma...@apache.org: Konstantin Kolinko wrote: 2009/7/5  ma...@apache.org: Author: markt Date: Sun Jul  5 11:30:22 2009 New Revision: 791224 URL: http://svn.apache.org/viewvc?rev=791224view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797 Revert

Re: [g...@vmgump]: Project tomcat-catalina (in module jakarta-tomcat-4.0) failed

2009-07-05 Thread Konstantin Kolinko
and *_ja.properties files. The servlet.jar from TC 4.1.40 matches the old one of July 2nd. I wonder, what happened with Gump configuration. Have not dug further yet. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev

Re: [g...@vmgump]: Project tomcat-catalina (in module jakarta-tomcat-4.0) failed

2009-07-05 Thread Konstantin Kolinko
2009/7/6 Konstantin Kolinko knst.koli...@gmail.com: 2009/7/5 Stefan Bodewig bode...@apache.org: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene

[PROPOSAL] Remove SVN keywords from JavaDoc

2009-07-06 Thread Konstantin Kolinko
to such a change, please write so. I think that having SVN keywords in JavaDoc is not so useful, because - Classes do change often, but their JavaDoc do not so. - You know, to what TC release your JavaDoc corresponds to. Why to need more? Best regards, Konstantin Kolinko

Re: svn commit: r791670 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-06 Thread Konstantin Kolinko
have 5 projects (build, connectors, container, jasper, servletapi), each of them has classpathentry kind=output path=bin/ in their .classpath files and thus its own bin subdirectory. Best regards, Konstantin Kolinko

Re: Minimum Ant version for Tomcat 5.5 (was Re: svn commit: r791159)

2009-07-07 Thread Konstantin Kolinko
2009/7/4 Konstantin Kolinko kkoli...@apache.org: New Revision: 791159 URL: http://svn.apache.org/viewvc?rev=791159view=rev Log: proposal + +* Document minimum required Ant version to be 1.6.2, instead of 1.5.x +  Note, that http://tomcat.apache.org/tomcat-5.5-doc/building.html already

Re: svn commit: r792462 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-09 Thread Konstantin Kolinko
there, for consistency, and as hardly anyone uses them in production. The exe installer on Windows (I tried the 5.5 one) does not add tools.jar to the classpath. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: [PROPOSAL] Remove build-webapps-precompile target from dist.xml of TC 6, TC 7. Or enable and fix it?

2009-07-09 Thread Konstantin Kolinko
2009/7/3 Mark Thomas ma...@apache.org: Konstantin Kolinko wrote: Otherwise I'll propose removal of that build-webapps-precompile target from dist.xml of 6.0 and trunk. +1 to removing it from both Mark There are enough votes in 6.0.x STATUS. Removed it from trunk and 6.0.x in rev. 792740

Re: svn commit: r792872 - in /tomcat/container/tc5.5.x: modules/cluster/src/share/org/apache/catalina/cluster/tcp/mbeans-descriptors.xml webapps/docs/changelog.xml

2009-07-10 Thread Konstantin Kolinko
. (markt) +      /fix +      fix The svn:log message of this commit does not make sense for me. I suppose it is a copy-paste error. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: svn commit: r793766 - in /tomcat/trunk/modules/jdbc-pool: .classpath java/org/apache/tomcat/jdbc/pool/interceptor/SlowQueryReport.java

2009-07-13 Thread Konstantin Kolinko
to .classpath file in this commit was not expected. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r794671 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-07-16 Thread Konstantin Kolinko
already existed before this patch. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [PROPOSAL] Remove Realm from GenericPrincipal

2009-07-16 Thread Konstantin Kolinko
in during replication. Cannot test it, though, as I do not have relevant configuration now. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: svn commit: r795010 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-17 Thread Konstantin Kolinko
, and it builds, installs and runs OK. I plan to also test it on Vista 64-bit (x86-64), but I have yet to reach that place. I do not have an IA64 system. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: svn commit: r795010 - /tomcat/current/tc5.5.x/STATUS.txt

2009-07-17 Thread Konstantin Kolinko
2009/7/17 Rainer Jung rainer.j...@kippdata.de: On 17.07.2009 12:01, Konstantin Kolinko wrote: If we backport the second part of rev.791699 - the separate zips for different windows CPU architectures, there wouldn't be such subdirectories, but i64 will be in the name of the archive. That name

Re: svn commit: r796162 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java

2009-07-21 Thread Konstantin Kolinko
/AsyncContextImpl.java If you are wondering, this @Override on methods implementing an interface is a (not so well known) difference between Java 5 and Java 6. http://blogs.sun.com/ahe/entry/override http://blogs.sun.com/ahe/entry/override_snafu Best regards, Konstantin Kolinko

Re: 5.5.28 release candidate

2009-07-25 Thread Konstantin Kolinko
, as sebb once wrote, that RELEASE-NOTES contains clearly visible Tomcat version number, and you can see it there, if it is in the root folder, even if you replaced the ROOT webapp. Best regards, Konstantin Kolinko

Re: Adding thumbs.db to svn:ignore?

2009-07-25 Thread Konstantin Kolinko
][Bb] Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [PROPOSAL] Remove Realm from GenericPrincipal

2009-08-02 Thread Konstantin Kolinko
will be transient, and probably that issue 39231 that that commit (with some followups) fixes won't/cannot be fixed for clusters. (I suppose so, though I may be wrong). http://svn.apache.org/viewvc?view=revrevision=791900 https://issues.apache.org/bugzilla/show_bug.cgi?id=39231 Best regards, Konstantin

Re: svn commit: r803451 - /tomcat/tc5.5.x/trunk/STATUS.txt

2009-08-12 Thread Konstantin Kolinko
their history. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Making AJP secret attribute consistent

2009-08-12 Thread Konstantin Kolinko
Reference AJP , / HTTP ) I do not really mind renaming all of them to get rid of dots, but that is probably what we should not do. :/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: svn re-org complete

2009-08-12 Thread Konstantin Kolinko
://tomcat.apache.org/tomcat-5.5-doc/building.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: local changes on /www/tomcat.apache.org

2009-08-12 Thread Konstantin Kolinko
26th of March, 2009 is certainly a Tuesday this year, not a Friday. Looks like someone was making corrections in a rush before the event. By the way, Apache Tomcat - Apache Tomcat (repeated twice) is a lame title. And we have it on some other pages as well, like Apache Tomcat - Apache Tomcat --

Re: local changes on /www/tomcat.apache.org

2009-08-12 Thread Konstantin Kolinko
2009/8/13 Konstantin Kolinko knst.koli...@gmail.com: 26th of March, 2009 is certainly a Thursday this year, not a Friday. Thursday Looks like someone was making corrections in a rush before the event. By the way, Apache Tomcat - Apache Tomcat (repeated twice) is a lame title. And we have

Re: Making AJP secret attribute consistent

2009-08-13 Thread Konstantin Kolinko
, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Making AJP secret attribute consistent

2009-08-13 Thread Konstantin Kolinko
2009/8/13 Mladen Turk mt...@apache.org: On 13/08/09 19:43, Konstantin Kolinko wrote: Other option is to use required.secret instead requiredSecret Much easier because requiredSecret isn't document, so one can only find it browsing the source code. However dunno how to make it using current

Re: svn commit: r803794 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-08-15 Thread Konstantin Kolinko
with it. Maybe I shouldn't be lazy to fire up one of them next time. Thanks for testing. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: [proposal] remove worker based connector thread pools in trunk

2009-08-15 Thread Konstantin Kolinko
, there is some really cool stuff we can do with executors, such as even with the BIO connector, we can do keep alives and and still rotate the sockets among the available threads. +1 Best regards, Konstantin Kolinko

Re: local changes on /www/tomcat.apache.org

2009-08-15 Thread Konstantin Kolinko
2009/8/13 Konstantin Kolinko knst.koli...@gmail.com: 2009/8/13 Konstantin Kolinko knst.koli...@gmail.com: 26th of March, 2009 is certainly a Thursday this year, not a Friday. Thursday Looks like someone was making corrections in a rush before the event. By the way, Apache Tomcat - Apache

Regarding JAAS logout patch (for bug 39231)

2009-08-16 Thread Konstantin Kolinko
any, this feature would have to be configurable). Though logout is a bit too loud name for it. Documentation on implementing LoginModule#logout() is here: http://java.sun.com/javase/6/docs/technotes/guides/security/jaas/JAASLMDevGuide.html#logout Best regards, Konstantin Kolinko

Re: svn commit: r810132 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-10-01 Thread Konstantin Kolinko
must be encoded as %25. The protocol handler for file: protocol unescapes %-encoded symbols when opening URLConnection to the file, so if the original file name contained '%' symbol, it should have been escaped. (sun.net.www.protocol.file.Handler#openConnection(..)) Best regards, Konstantin

Re: svn commit: r821411 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-10-03 Thread Konstantin Kolinko
] and opens a new unnamed window (or tab in FF) [1] http://www.w3.org/TR/html401/types.html#type-frame-target see 6.16 Frame target names Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: svn commit: r823351 - in /tomcat/trunk/java/org/apache: coyote/http11/AbstractInputBuffer.java coyote/http11/Http11Processor.java coyote/http11/InternalInputBuffer.java coyote/http11/InternalNio

2009-10-11 Thread Konstantin Kolinko
(and that is right, because using some automatic value for keywords would be wrong) http://apache.org/dev/svn-eol-style.txt http://apache.org/dev/version-control.html#https-svn-config Best regards, Konstantin Kolinko - To unsubscribe, e

Re: [VOTE] Release Apache Tomcat 7.0.17

2011-07-03 Thread Konstantin Kolinko
a suffix to the name, e.g.: %ProgramFiles%\Apache Software Foundation\Tomcat 7.0_servicename and remove the _servicename part if the name is default one. Thus far everything else goes good. Best regards, Konstantin Kolinko

Re: [VOTE] Release Apache Tomcat 7.0.17

2011-07-05 Thread Konstantin Kolinko
2011/7/3 Konstantin Kolinko knst.koli...@gmail.com: 2011/7/3 Mark Thomas ma...@apache.org: 1) Windows Service Name field does not restrict you from putting anything there. (...) 2) Tomcat 7 now by default installs into %ProgramFiles%\Apache Software Foundation\Tomcat 7.0\Tomcat7. (...) BTW

Re: svn commit: r1142953 - in /tomcat/trunk: java/javax/el/BeanELResolver.java webapps/docs/changelog.xml

2011-07-05 Thread Konstantin Kolinko
declaring the method is public, or - the method is a public one declared in a public parent or public interface implemented by this class. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: svn commit: r1143134 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/GzipInterceptor.java test/org/apache/catalina/tribes/group/interceptors/TestGzipInterceptor.java

2011-07-05 Thread Konstantin Kolinko
; Just int length = gin.read(tmp); will save an iteration. +        while (length -1) { +            bout.write(tmp, 0, length); +            length = gin.read(tmp); +        } +        return bout.toByteArray();     }  } Best regards, Konstantin Kolinko

Re: svn commit: r1135088 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2011-07-06 Thread Konstantin Kolinko
1. JavaDoc for the method has to be updated. It still says that the name is quoted. 2. If I understand correctly, the name _is_ used directly, in AbstractConnectionHandler.register(): ... ,worker= + getProtocol().getName() + ,name= ... and MBeanUtils.destroyMBean(Connector,Service) worker =

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Konstantin Kolinko
I have doubts regarding this change. If I understand correctly, recycle() (and thus recycleInternal()) is not called when several requests are processed in a row. So, in the old code sendfile is set to null before each request, in the new code it is set to null only once after connection is

Re: svn commit: r1135088 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2011-07-06 Thread Konstantin Kolinko
2011/7/6 Rainer Jung rainer.j...@kippdata.de: Hi Konstantin, On 06.07.2011 08:03, Konstantin Kolinko wrote: 1. JavaDoc for the method has to be updated. It still says that the name is quoted. Will fix. 2. If I understand correctly, the name _is_ used directly

Something is wrong with TC7 uninstaller (Windows)

2011-07-06 Thread Konstantin Kolinko
, but I have have not looked in the nsi file yet to confirm. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Something is wrong with TC7 uninstaller (Windows)

2011-07-06 Thread Konstantin Kolinko
2011/7/6 Konstantin Kolinko knst.koli...@gmail.com: There is some bug in the uninstaller: It deleted *all* shortcuts from Windows Menu (both for me and for All Users), not only Tomcat ones. I just noticed after rebooting, that none of my Startup shortcuts did run -- they have been deleted

  1   2   3   4   5   6   7   8   9   10   >