RE: [PATCH] Catalina CGIServlet broken redirects

2005-10-16 Thread Mark Thomas
Patrick, Thanks for your contribution. However, the mailing list doesn't like attachments. Please can you open a Bugzilla item for this and attach your patch to that? Thanks, Mark _ From: May, Patrick [mailto:[EMAIL PROTECTED] Sent: Wednesday, October 12, 2005 7:55 PM To:

RE: [Fwd: Tomcat 3.3 points to the wrong location from the download page]

2005-10-26 Thread Mark Thomas
Fixed. Will be visible on the web site shortly. Mark -Original Message- From: Joshua Slive [mailto:[EMAIL PROTECTED] Sent: Wednesday, October 26, 2005 7:08 PM To: Jakarta Project Management Committee List Subject: [Fwd: Tomcat 3.3 points to the wrong location from the download

Re: tomcat source / eclipse project

2005-11-03 Thread Mark Thomas
I have something like this for TC5 TC4. I do keep the files up to date because I use them every time I look at Tomcat code. I need to migrate my development areas from the old CVS structure to the SVN set-up. Once I have updated my eclipse files, I'll add them to the repo. Anyone object to

Re: tomcat source / eclipse project

2005-11-06 Thread Mark Thomas
Peter Rossbach wrote: Hey Mark, I think we must correct the absolut Lib Paths inside all .classpath. Set a Eclipse Variable to the base.path repository and use this jars instead. Didn't know you could do this. I have updated the .classpaths accordingly. I am not sure that all jar

Re: svn commit: r331062 - in /tomcat/sandbox/java/org/apache/coyote: ./ adapters/ standalone/

2005-11-06 Thread Mark Thomas
Bill Barker wrote: What I'm looking for is a clear statement from the Tomcat PMC about MPL compatibility. The short answer is we can distribute unmodified MPL licenced binaries with some caveats. See Special Order 6B in this link.

Re: svn commit failed

2005-11-07 Thread Mark Thomas
Tim Funk wrote: I was trying to update the faq and on commit I get: svn: Commit failed (details follow): svn: MKACTIVITY of '/repos/asf/!svn/act/cbfb08b7-fd04-0410-812a-daddc51de6cc': 403 Forbidden (http://svn.apache.org) I (think I) have the correct ID and password. Am I missing karma?

Re: svn commit: r332806 - in /tomcat/jasper/tc5.5.x: .classpath .project

2005-11-12 Thread Mark Thomas
The command line build doesn't check out this directory, it checks out the jasper2 directory. That is why the .project .classpath files were created one level lower down. Are you using the latest build.xml (http://svn.apache.org/repos/asf/tomcat/build/tc5.5.x/resources/build.xml)? Mark

Re: svn commit: r332806 - in /tomcat/jasper/tc5.5.x: .classpath .project

2005-11-12 Thread Mark Thomas
Costin Manolache wrote: I'll fix this, sorry - I think I have made few changes to my properties. What is svn co .../current doing - I was using this before realizing that current doesn't work in eclipse, never used resources/build.xml It is using svn:externals to bring the various modules

Re: svn commit: r332806 - in /tomcat/jasper/tc5.5.x: .classpath .project

2005-11-13 Thread Mark Thomas
Costin Manolache wrote: How are you making subclipse see the project ? Team-share doesn't do it for me. I had to add https://svn.apache.org/asf/repos/tomcat to my list of repositories in Subclipse SVN repository view. Once I did that, it all just worked. What version are you using ? I have

Missing MD5 and PGP

2005-11-16 Thread Mark Thomas
The signatures for 5.5.12 embedded are missing from the download area. Can whoever released 5.5.12 (Yoav?) create and upload them please? Thanks, Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

Re: Labels in SVN ?

2005-11-20 Thread Mark Thomas
Costin Manolache wrote: What I want is to be able to do cvs diff -r my_label_before_sandbox_copy, so I can see what changed. I want to keep my experiments in the sandbox - instead of a branch. Costin Copies are cheap in SVN, so tags are just copies. And in a similar manner to CVS branches

Re: SVN oddities with current link

2005-11-22 Thread Mark Thomas
Yoav Shapira wrote: Hi, I like checking out the current link ( https://svn.apache.org/repos/asf/tomcat/current/tc5.5.x) which uses svn externals to grab the container, build, connectors, etc. It's nice and convenient. But for committing and updating, it kind of sucks. Doing an svn commit or svn

Re: SVN oddities with current link

2005-11-22 Thread Mark Thomas
Costin Manolache wrote: Well, can't stop myself: The right solution is to stop playing SVN tricks, and just reorganize the code as a single codebase instead of 4 (or 5). So my question remains: can we _move_ build, connectors, etc as subdirs in a single svn tree, while preserving some file

Re: getContext() - spec interpretation

2005-11-27 Thread Mark Thomas
Bill Barker wrote: I can't really dispute the interpretation of the spec, but the change is likely to break many more webapps then it fixes :(. I thought this too. However, I think we should implement the spec as is. If we start relaxing it here, then where else do we relax it? If other

Re: getContext() - spec interpretation

2005-11-27 Thread Mark Thomas
Mark Thomas wrote: The complications I referred to in the SSI commit are: 1. The definition of uripath says it is a context path which for the root context would be . In the method description it says uripath must always start with /. This is not consistent. 2. The definition of uripath

Re: Repo clean up

2005-11-28 Thread Mark Thomas
Later than I originally intended. Sorry. The candidates for clean up are: connectors/naming connectors/webapp connectors/jk/native2 container/branches/tc4.1.x/jasper/ Clean up == deletion. The nature of svn is such that we can undelete things very easily if any of this turns out to be a big

Re: getContext() - spec interpretation

2005-11-29 Thread Mark Thomas
Jan, Jan Luehe wrote: Hi Mark, snip I agree the current javadocs of ServletContext.getContext() are ambiguous, and I agree we need to present this case to the Servlet EG. Maybe there is a small chance to have this resolved in the Servlet 2.5 timeframe ... I think it would be more useful to

Re: getContext() - spec interpretation

2005-11-30 Thread Mark Thomas
Jan, This looks good to me. I have patches ready to go for TC4 and TC5. They are based on the existing code but implement the spirit of Bill's proposed solution and add handling for crossContext. I'll give people a little longer in case they want to add to this discussion and then I'll

Re: DO NOT REPLY [Bug 36318] - CRC error in compressed sample.war file

2005-12-01 Thread Mark Thomas
Yoav, Can you check your build please? It appears something isn't quite right with the sample.war you generate. Thanks, Mark [EMAIL PROTECTED] wrote: DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT

Re: DO NOT REPLY [Bug 36318] - CRC error in compressed sample.war file

2005-12-02 Thread Mark Thomas
command, the same one that virtually every other Apache project uses to sign its binaries... Yoav On 12/1/05, Mark Thomas [EMAIL PROTECTED] wrote: Yoav, Can you check your build please? It appears something isn't quite right with the sample.war you generate. Thanks, Mark [EMAIL PROTECTED] wrote

Re: DO NOT REPLY [Bug 36318] - CRC error in compressed sample.war file

2005-12-03 Thread Mark Thomas
Yoav, The one in SVN looks fine. Can you check your local copy as something is messing up the copy on the web on a regular basis? Thanks Mark Mark Thomas wrote: OK. I thought it was generated during the build. I'll just replace the one in SVN as is has got corrupted at some point. The MD5

Re: svn commit: r351977 - /tomcat/build/tc5.5.x/KEYS

2005-12-03 Thread Mark Thomas
I need to get my key into the web of trust. I am working in London, UK during the week at the moment so if anyone else is around and can spare a little time to meet up and verify my key, let me know. Mark [EMAIL PROTECTED] wrote: Author: markt Date: Sat Dec 3 08:21:59 2005 New Revision:

Re: [EMAIL PROTECTED]: Project jakarta-tomcat-4.0 (in module jakarta-tomcat-4.0) failed

2005-12-23 Thread Mark Thomas
Stefan Bodewig wrote: To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project jakarta-tomcat-4.0 has an issue affecting its

Re: about Tomcat Connector

2005-12-27 Thread Mark Thomas
This is a users question not a dev question. Please read http://tomcat.apache.org/lists.html and then repost your message correctly. Mark [EMAIL PROTECTED] pzy peng wrote: Hello: I use Tomcat Connector to forward servlet requests from IIs6 to tomcat5, my config like this: file

Re: EL and JSP 2.1

2005-12-27 Thread Mark Thomas
Jacob Hookom wrote: I'd like to get the ball rolling on a branch for JSP 2.1. I also have a new EL implementation that I would like to roll in as a replacement to the Commons-EL implementation. There's also the API modifications for JSP and the EL-API. Along the lines of project/folder

Re: EL and JSP 2.1

2005-12-27 Thread Mark Thomas
My own views in line. Mark Mark Thomas wrote: Jacob Hookom wrote: I'd like to get the ball rolling on a branch for JSP 2.1. I can get the SVN stuff set up over the next few days. There has been some debate about how we arrange things so we need to get agreement on the way forward

Re: directory listings (updated patch)

2006-01-04 Thread Mark Thomas
Patches posted to the dev list tend to get lost if none looks at them straight away. I suggest you create a bugzilla entry and add your patch to that. Mark Rafael H. Schloming wrote: Is no interest in merging this patch? I'd like to see it accepted, so if there is anything I can do, please let

Re: Missing tag in SVN

2006-01-05 Thread Mark Thomas
Yoav Shapira wrote: So I guess I should just do an svn copy of servletapi from 5.5.11 to 5.5.12 to tag it as such. I don't need to do anything fancier like an svn:prop edit, right? Correct. A straight svn copy will be fine. Mark

Re: Facing problem when 2 simultaneous requests are sent to tomcat.

2006-01-06 Thread Mark Thomas
This belongs on the users list. Please read http://tomcat.apache.org/lists.html Mark [EMAIL PROTECTED] Uttam wrote: Hi All, I am a newbei using the Tomcat server in my application. *Sorry all, I gave a wrong information*. I am using *Apache Tomcat 5.512* server and not 5.0.28. JDK

Re: tomcat 5.8.0 - weird response on HTTP OPTIONS method

2006-01-07 Thread Mark Thomas
Mauro Bertapelle wrote: Costin, you've got the point I was trying to make, this has nothing to do with webdav and the naive way in which ie implements it, but probably Tomcat should handle options better when it's acting as a static web server. Mauro I have confirmed this behaviour

Re: tomcat 5.8.0 - weird response on HTTP OPTIONS method

2006-01-07 Thread Mark Thomas
Mark Thomas wrote: Mauro Bertapelle wrote: this has nothing to do with webdav and the naive way in which ie implements it, but probably Tomcat should handle options better when it's acting as a static web server. Mauro I have confirmed this behaviour with the latest source from SVN

Re: svn commit: r367115 - /tomcat/connectors/trunk/coyote/src/java/org/apache/coyote/Response.java

2006-01-09 Thread Mark Thomas
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Fix bug 29214. containsHeader() not working for Content-Length and Content-Type Rather than adding complexity in code which is critical, I would have hacked instead the org.apache.catalina.connector.Response.containsHeader method, which is not

Re: Revisiting inclusion of startup scripts in exe distro?

2006-01-10 Thread Mark Thomas
Yoav Shapira wrote: Hi, Over the past few months I've gotten a good number of complaints that the 5.5 exe distro doesn't include the command-line startup scripts. I know we've discussed this in the past, as I pointed out to users on http://issues.apache.org/bugzilla/show_bug.cgi?id=33560.

Re: Initial EL/JSP 2.1 Contribution

2006-01-10 Thread Mark Thomas
Remy Maucherat wrote: Jacob Hookom wrote: I've been rolling this code base into JSP 2.1 within a local sandbox, but I still have questions about the particulars of the overal project packaging for Tomcat 6. Very good :) Personally, I still would like to start slow and for now create a tree

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-11 Thread Mark Thomas
Remy Maucherat wrote: Mark Thomas wrote: I thought about doing it that way but I wanted to catch the difference between Content-Length defaulting to -1 and the page developer explicitly setting it to -1. It is an edge case I admit but I don't see any harm in covering it given where

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-12 Thread Mark Thomas
Remy Maucherat wrote: I spent some time eliminating all the warnings that my Eclipse was reporting sometimes in the past, and saw that isSpace was deprecated. isWhitespace seemed to be a replacement, but is actually different. HTTP needs to stay with the non character encoded version. Ie, the

Re: svn commit: r367826 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Response.java webapps/docs/changelog.xml

2006-01-13 Thread Mark Thomas
Henri Gomez wrote: What about using JMeter ? I don't need the sophistication for this test and ab looks to have a smaller overhead. Also your test should be from a different computer, may be with 2/3 clients computers against one single server. Thanks for the tip. Time to dig out my old

Re: Error building from source - error validating cert

2006-01-13 Thread Mark Thomas
Gary Blomquist wrote: Hi, I attempted to checkout and build Tomcat based on the online documentation and received the following error: C:\Tools\Tomcat-devant Buildfile: build.xml check.source: get.source: checkout: [echo] If the checkout fails, - todo - [exec]

Re: Initial EL/JSP 2.1 Contribution

2006-01-15 Thread Mark Thomas
Mark Thomas wrote: Based on this, I propose the following changes to svn. copy /tomcat/jasper/tc5.5.x/ to /tomcat/jasper/tc6.0.x/ Slight change. I removed the jasper2 directory so /tomcat/jasper/tc5.5.x/ was copied to /tomcat/jasper/tc6.0.x/ create /tomcat/jasper/tags/tc6.0.x/ Done

Re: Initial EL/JSP 2.1 Contribution

2006-01-16 Thread Mark Thomas
Bill Barker wrote: Shouldn't we also have something under servletapi for the javax.el stuff? I was applying lazy instantiation ;) When someone shouts for it (and assuming they don't just create it themselves) I'll add it. Until then I had assumed we would build with the official jars. Mark

Re: Realm.authenticate() doesn't register Principal in Session.. use Authenticator instead?

2006-01-19 Thread Mark Thomas
Please do not cross-post. This belongs on the users list BTW. Mark [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Please give me some responses!!

2006-01-21 Thread Mark Thomas
Jack wrote: Hi, guys, please give me some responses! Intended for the users list but just as applicable here: http://tomcat.apache.org/faq/tomcatuser.html#why - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: Fwd: Help :: Running Servlet Prog. in Apache HTTP Server -reg

2006-01-21 Thread Mark Thomas
This question belongs on the users list as per http://tomcat.apache.org/lists.html Mark [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: 2 clear reasons

2006-01-22 Thread Mark Thomas
Two clear reasons for what? Mark Jack wrote: 1. The Users of a web-app might be defined in several places such as Database, or a file. 2. when we are not using ssl, but ask for client certificate. We have to map certificats to roles. Although most certificates can be mapped to a generic

Re: Mr. Thomas please check this.

2006-01-22 Thread Mark Thomas
Jack wrote: When we use client-cert, we might be not using ssl at all since we don't ask confidential transfer. This is not correct. CLIENT-CERT authentication *requires* ssl. ssl is still ssl even if NULL encryption is used. A web application may well have a mixed user community, some

Re: 2 clear reasons

2006-01-22 Thread Mark Thomas
Mark Thomas wrote: a) You can not use ssl and ask for client certificates. CLIENT-CERT requires the use of ssl. Sorry typo. This should read You can't not use ssl and... Mark - To unsubscribe, e-mail: [EMAIL PROTECTED

Re: new versions of Tomcat

2006-01-27 Thread Mark Thomas
Lucio Ribeiro wrote: Hi, I'm new here i'm having problems with new versions of Tomcat. I was using tomcat 5.0.27 and i have a web application made in Java. My code has to get URL using the following code: String url = request.getRequestURL().toString(); I use Struts and my URL is

Re: Broken Architecture documentation pdf on tomcat.apache.org

2006-01-30 Thread Mark Thomas
Mark Thomas wrote: Fred K wrote: Hi: When I look at the Architecture documentation pdf, I see only blank pages in the pdf files linked under Tomcat Architecture. These pdfs, are broken on tomcat.apache.org and when I build Tomcat 5.5.12from source (Linux/Solaris). Bugzilla says it is fixed

Re: Broken Architecture documentation pdf on tomcat.apache.org

2006-01-30 Thread Mark Thomas
Yoav Shapira wrote: Hi, It looks like the pdf files may be suffering from the same problem as the war file was. Can you take a look? I'll sort out the files on the server. Actually, I'm leaving for a couple of weeks in Israel and Italy, am packing in a rush and busy with many other

Re: Building Tomcat

2006-01-31 Thread Mark Thomas
Marsh David W Maj AFIT/ENG wrote: Also the ant build may fail when it gets to jasper because the unzipped code puts the necessary files in the .../jasper/jasper2 directory. Move the code up a directory or change the ant script at line 1419 of ${tomcat.source}/build/build.xml from I have

Re: Building Tomcat

2006-02-03 Thread Mark Thomas
Bob Herrmann wrote: yea, I might be bonkers.Now I can't even seem to get to the cvs repo. I vaguely recall an effort to get everything on svn... is this a part of that? $ cvs -d :pserver:[EMAIL PROTECTED]:/home/cvspublic login Logging in to :pserver:[EMAIL

Re: mod_jk - Apache flush stream issues

2006-02-03 Thread Mark Thomas
Please do not cross-post. This question belongs on the users list. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Building Tomcat

2006-02-03 Thread Mark Thomas
Bob Herrmann wrote: Ok, Is 5.0 a valid build target, or is its usage discouraged? I was following the build instructions for building tomcat 5.0 http://tomcat.apache.org/tomcat-5.0-doc/building.html the build.xml that it provides use CVS tags to extract the 5.0 bits. -bob You can

This commit needs a review (WAS: svn commit: r375077 - in /tomcat/connectors/trunk/jk: native/iis/jk_isapi_plugin.c xdocs/changelog.xml)

2006-02-05 Thread Mark Thomas
My C is very rusty. I *think* this is OK and doesn't do anything dangerous but I would be grateful if someone could review it. Cheers, Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL

Re: Tomcat server to host socket server as well as webclient.

2006-02-10 Thread Mark Thomas
Prabhu Baskaran wrote: If u need any clarification please let me know.. But if any one can suggest ways for me to achieve this i wud appreciate it..Thanks in advance. Regards You could start by reading http://tomcat.apache.org/lists.html and directing your question to the appropriate list

Re: svn commit: r376730 - /tomcat/connectors/trunk/util/java/org/apache/tomcat/util/buf/CharChunk.java

2006-02-10 Thread Mark Thomas
Bill Barker wrote: From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] URL: http://svn.apache.org/viewcvs?rev=376730view=rev Log: - Have CharCHunk implement CharSequence, so that a CharChunk can be given to a Java 5 regexp matcher without having to do a useless toString on it first. Typically,

Re: Tomcat errors.

2006-02-13 Thread Mark Thomas
Ángel Prieto wrote: Hello, I'm having some problems with apache+tomcat with this configuration: Could anyone tell me something about it? The question belongs on the users list as per http://tomcat.apache.org/lists.html Mark

Re: problem building 5.5.15

2006-02-13 Thread Mark Thomas
Eric Lenio wrote: All - Apologies in advance if this should go to tomcat-users but I'm suspecting a problem with the way the source code is being distributed so I'm starting here. I downloaded the source file for 5.5.15 and built it. After installing it I ran bin/version.sh which said I

Re: Request parameters straight after authentication

2006-02-13 Thread Mark Thomas
Kevin McCormack wrote: Possible Fix? == I looked through the Tomcat 5.5.12 source code and ended up in the org.apache.catalina.authentication.FormAuthenticator class and noticed that there is no code there to save the request parameters from the original request into the saved

Re: problem building 5.5.15

2006-02-13 Thread Mark Thomas
Eric Lenio wrote: OK thanks for the tip. Is there a document that goes into detail on this? BUILDING.TXT and http://tomcat.apache.org/tomcat-5.5-doc/building.html are the main documents. Documentation patches are always welcome. Mark

Re: restarting tomcat

2006-02-16 Thread Mark Thomas
Jim Manico wrote: I am using the most recent version of Tomcat. *sometimes* when I reload the server during development, it crashes and I need to do a manager/start?path=/ to restart it. Over time these manager restarts do not seem to free up the memory as it should. So after several

Re: never say never...

2006-02-20 Thread Mark Thomas
George Sexton wrote: Whilst I agree with the general thrust of the arguments made so far in this thread I do take serious issue with one of your statements. Just as a little example, several months ago I submitted a patch. One committer commented that he would -1 it for the com.sun imports.

Re: never say never...

2006-02-20 Thread Mark Thomas
George Sexton wrote: Don't misunderstand me. I'm certainly not saying a committer shouldn't say This is non-compliant and will not be addresed or We comply with the spec, and we will not be expanding the application to meet your specific need. These are legitimate responses. Agreed. When the

Re: Change process (Was: Persistent storage of sessions, why no Principal?)

2006-02-26 Thread Mark Thomas
Roland Turner (Apache) wrote: Hi all. Last week I posted the question below. It appears from the (near) complete silence that followed that no-one knows. So, my new question is about tomcat's change process. I've not submitted code to tomcat before, so don't really where to start. Is simply

Re: FW: My Query

2006-02-27 Thread Mark Thomas
This question belongs on the users list, not the dev list. See http://tomcat.apache.org/lists.html for details. Mark [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL

Re: Tomcat 6 source organisation

2006-02-28 Thread Mark Thomas
Remy Maucherat wrote: Hi, I think it is time to decide how the source repository is going to be organized, with the questions being: - how many source folders do we need (Costin wanted one, while others like Jacob seem to want modules) ? - do we continue to use Ant ? - etc I am +0 on any

Re: TCK Use

2006-03-07 Thread Mark Thomas
Jacob Hookom wrote: I'm wondering about what I'd need to do/contact for using the TCK as a committer working on JSP 2.1? Any PMC member can request a TCK by sending the request to [EMAIL PROTECTED] Mark - To unsubscribe,

Re: svn commit: r393433 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup: Bootstrap.java ClassLoaderFactory.java

2006-04-12 Thread Mark Thomas
Remy Maucherat wrote: Bill Barker wrote: Urm, I think we need svn:eol-style = native in the TC6 repo :). +1. It is quite odd that the other repositories don't behave like that. Sorry, I can't adjust my client side properties (I'm using Tortoise). Yes you can. Steps as follows: - right-click

Re: Please clear the following error.

2006-09-21 Thread Mark Thomas
Hari Kumar wrote: Hi, I am getting null when I use jsp:getProperty, Please help me. I am using Tomcat 4.1 Server. Please check the code and let me know the possible solution. This question belongs on the users mailing list. Please see http://tomcat.apache.org/lists.html for further

Re: [VOTE] 5.5.20 Release Vote

2006-09-22 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: Apache Tomcat v5.5.20 is: [X] +1 Stable - no major issues Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r451831 - in /tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/core: ApplicationDispatcher.java ApplicationFilterChain.java LocalStrings.properties

2006-10-01 Thread Mark Thomas
Bill Barker wrote: I'd have probably been less strict, and just thrown an ISE from ApplicationDispatcher.wrapRequest/wrapResponse. Mine allows somebody that really wants to program against Tomcat sidestep the check, but doesn't add as much overhead. I see how this would be lower overhead

Re: [VOTE] Split soTimeout to soTimeout and keepAliveTimeout

2006-10-02 Thread Mark Thomas
Mladen Turk wrote: [X] I'm for that proposal [ ] I'm against that proposal [ ] I don't care If you believe there is a requirement for it, the implementation can be done cleanly and you are prepared to support it then go for it. I would like to echo Yoav's comments that the docs should be

[VOTE] Tomcat 4.1.34 Stability

2006-10-03 Thread Mark Thomas
All, 4.1.34-beta has been available for just over a month. Tomcat 4.1.34 fixes all open bugs against the 4.1.x branch and updates the libraries to the latest versions. Please vote on its stability using the options below. I will also solicit feedback from the users list in case someone has found

Re: [VOTE] Tomcat 4.1.34 Stability

2006-10-03 Thread Mark Thomas
Mark Thomas wrote: Apache Tomcat 4.1.34 is: [X] Stable - no major issues [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are Mark - To unsubscribe

Re: request.getServerName()

2006-10-11 Thread Mark Thomas
[EMAIL PROTECTED] wrote: Dear All, 1) How to control the request.getServerName() value when using tomcat as webserver ? 2) How to control the request.getServerName() value when using Apache as webserver (ajp13 connector) ? These questions belong on the users list. Please read

Re: [VOTE] Tomcat 6 release plan

2006-10-17 Thread Mark Thomas
[X] +1 Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r469360 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/changelog.xml

2006-10-31 Thread Mark Thomas
Remy Maucherat wrote: Maybe it doesn't hurt much, but I'm not that happy about it anyway. Can I redo it a bit in 6.0 ? Of course. As long as the bug is fixed I have no preference for who actually writes the code ;) If I find time to port the handful of patches I have for TC6 then I'll include

Re: svn commit: r471306 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2006-11-04 Thread Mark Thomas
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: markt Date: Sat Nov 4 16:33:02 2006 New Revision: 471306 I think you should use the strict compliance flag, as only 2 people need activity checking. Good idea. One commit coming up. Mark

Re: Extracting SSL information from servlet

2006-11-08 Thread Mark Thomas
Andrew Friebel wrote: I hope I have submitted this question via the correct mechanism. I am afraid not. This is a question for the Tomcat users list since it relates to development of *with* Tomcat. The dev list is for matters relating to the development *of* Tomcat. A small but important

Re: New 6.0.x build

2006-11-08 Thread Mark Thomas
Remy Maucherat wrote: Filip Hanik - Dev Lists wrote: sure, where do you have them, or do you want me to run a build against the tag? The usual location at www/www.apache.org/dist/tomcat-6/v6.0.1. For the next build, I'll have a new key, and I'll be using gpg instead. We should not be

Re: svn commit: r471309 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2006-11-08 Thread Mark Thomas
Sandy McArthur wrote: Attached is what I think may be an even more improved fix for 37356. It does away with the accessCount which should make Remy happy. It should prevent sessions currently in use from expiring which should make those other 2 people and myself happy. It doesn't add any

[PROPOSAL] Move all facade classes to a dedicated package

2006-11-14 Thread Mark Thomas
All, The root cause of bug 40770[1] is that the default catalina.policy file does not permit reflection on the Tomcat facade classes which are exposed to applications as HttpServletRequest, HttpSession etc. The necessary permissions to enable reflection can only be granted per package. Granting

Re: [PROPOSAL] Move all facade classes to a dedicated package

2006-11-15 Thread Mark Thomas
Rainer Jung wrote: I added a comment concerning a little experiment I did to https://issues.apache.org/jira/browse/VELTOOLS-66 Regards, Rainer Thanks for this. I was planning to do this tonight but you saved me the effort. On this basis, I am going to close the Tomcat bug as invalid -

StandardManager behaviour when webapp stopped

2006-11-25 Thread Mark Thomas
Bug 40593 [1] has raised the following question: When a web app with valid sessions is stopped and the StandardManager is configured not to serialize the sessions what, if anything, should the container do in this case? As far as I can tell from the spec, the container behaviour in these

Re: StandardManager behaviour when webapp stopped

2006-11-26 Thread Mark Thomas
Remy/Filip, Thanks for your input. I'll update the bug report with a brief summary and come back to this later. Mark Filip Hanik - Dev Lists wrote: You can still cluster just using AOP without ever involving the manager, hence such solutions would be affected by this new behavior. at most,

Re: svn commit: r483329 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

2006-12-07 Thread Mark Thomas
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: markt Date: Wed Dec 6 18:51:40 2006 New Revision: 483329 URL: http://svn.apache.org/viewvc?view=revrev=483329 Log: Ensure accept-language header conforms to RFC 2616 and ignore it if it doesn't I think a for loop with a check for

Re: svn commit: r483329 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml

2006-12-07 Thread Mark Thomas
Remy Maucherat wrote: Mark Thomas wrote: Fair point. I'll apply an updated patch shortly. I can do it too if you don't have time (since I'm the one who's suggesting the change). Since you are offering, I am not going to say no ;) Cheers, Mark

Re: svn commit: r486005 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/Request.java catalina/src/share/org/apache/catalina/session/PersistentManagerBase.java webapps

2006-12-13 Thread Mark Thomas
Filip Hanik - Dev Lists wrote: Rainer Jung wrote: My impression now is, that we should backout the commit and the user should instead first try to use the existing Valve as described by Peter. I agree, Filip That sounds like the right way forward to me. I'll revert my commit later today.

Re: [VOTE] Release build 6.0.6 as alpha

2006-12-16 Thread Mark Thomas
Remy Maucherat wrote: Hi, The vote is to release Apache Tomcat 6.0.6 as alpha. The build is located here: http://people.apache.org/~remm/tomcat-6/v6.0.6/ +1 I keep meaning to say great job on the new build. Much faster than 5.5.x Mark

Re: [VOTE] Release build 6.0.6 as alpha

2006-12-16 Thread Mark Thomas
Remy Maucherat wrote: Mark Thomas wrote: Remy Maucherat wrote: Hi, The vote is to release Apache Tomcat 6.0.6 as alpha. The build is located here: http://people.apache.org/~remm/tomcat-6/v6.0.6/ +1 I keep meaning to say great job on the new build. Much faster than 5.5.x I don't see

Re: svn commit: r489910 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java webapps/docs/changelog.xml

2006-12-24 Thread Mark Thomas
[EMAIL PROTECTED] wrote: Author: markt Date: Sat Dec 23 10:07:34 2006 New Revision: 489910 URL: http://svn.apache.org/viewvc?view=revrev=489910 Log: Make ApplicationDispatcher thread safe. After a very long thread on the users list (http://marc.theaimsgroup.com/?t=11655879003r=1w=2)

Re: svn commit: r489910 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/core/ApplicationDispatcher.java webapps/docs/changelog.xml

2006-12-25 Thread Mark Thomas
Remy Maucherat wrote: Mark Thomas wrote: Just a heads up that this commit appears to have broken the admin webapp. I am taking a look now... Filip fixed the algorithm, at least in 6.0.x. Did you look at his fix ? Rémy I saw Filip's fix for the SRV.8.2 issue. Thanks for reminding me I

Re: Please review the fix I just committed to Bugzilla 40326

2006-12-25 Thread Mark Thomas
Yoav Shapira wrote: http://issues.apache.org/bugzilla/show_bug.cgi?id=40326 points out that DefaultServlet uses File#deleteOnExit which is indeed evil. I took a look at the code, it seemed like a simple alternative was available, so I went ahead and made the change. However, I'm not an

Re: [VOTE] Release build 6.0.7 as alpha

2006-12-25 Thread Mark Thomas
Remy Maucherat wrote: Hi, I've uploaded a new 6.0.7 build at http://people.apache.org/~remm/tomcat-6/v6.0.7/ which may be released as alpha. Votes ? +1 Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: svn commit: r491619 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/core/ApplicationDispatcher.java webapps/docs/changelog.xml

2007-01-03 Thread Mark Thomas
Remy Maucherat wrote: [EMAIL PROTECTED] wrote: Author: markt Date: Mon Jan 1 11:31:29 2007 New Revision: 491619 URL: http://svn.apache.org/viewvc?view=revrev=491619 Log: Port RD thread safety patch from TC5 I don't see any justification for this at the moment. Any further info ? This

Re: svn commit: r496022 - in /tomcat: container/tc5.5.x/webapps/docs/changelog.xml jasper/tc5.5.x/src/share/org/apache/jasper/servlet/JspServlet.java

2007-01-14 Thread Mark Thomas
Tim Funk wrote: Is this screaming XSS attack? Since javadocs in getRequestURI() say ... The web container does not decode this String It would be if it wasn't for line 177 of o.a.c.valves.ErrorReportValve which does: String message = RequestUtil.filter(response.getMessage()); Mark

Re: Problem running tomcat with war file, deployed with eclipse and s pring

2007-01-16 Thread Mark Thomas
SOF - Dragone Jose Luis wrote: Please , I need help ! Please use the users list for questions like this. Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Release build 6.0.8 as alpha

2007-01-18 Thread Mark Thomas
Remy Maucherat wrote: http://people.apache.org/~remm/tomcat-6/v6.0.8/ Votes ? +1 Mark - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Fix for old SAX issue causing bug 40356

2007-01-20 Thread Mark Thomas
Hi, Can anyone remember anything about the SAX bug referred to in this commit? http://marc.theaimsgroup.com/?l=tomcat-devm=105096762802715w=2 The fix appears to be the cause of http://issues.apache.org/bugzilla/show_bug.cgi?id=40356 I have spent some time searching various archives no no avail.

Re: Fix for old SAX issue causing bug 40356

2007-01-21 Thread Mark Thomas
Remy Maucherat wrote: Mark Thomas wrote: Hi, Can anyone remember anything about the SAX bug referred to in this commit? http://marc.theaimsgroup.com/?l=tomcat-devm=105096762802715w=2 No, but there's nothing in the spec which says the attributes have to be called in order. People should

  1   2   3   4   5   6   7   8   9   10   >