Re: [VOTE] Release build 6.0.19

2009-04-07 Thread sebb
On 07/04/2009, Remy Maucherat r...@apache.org wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.19/ Hashes and sigs look OK, though I only checked the main archives. There's a packaging problem with the source archives. I would expect the .zip

Re: svn commit: r763726 - in /tomcat/trunk/java/org/apache/catalina/ha/backend: HeartbeatListener.java MultiCastSender.java Proxy.java Sender.java TcpSender.java

2009-04-11 Thread sebb
On 09/04/2009, jfcl...@apache.org jfcl...@apache.org wrote: Author: jfclere Date: Thu Apr 9 16:32:04 2009 New Revision: 763726 URL: http://svn.apache.org/viewvc?rev=763726view=rev Log: Add the Tcp code... Still need the code in httpd-trunk to test it. Added:

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSuppor

2009-04-11 Thread sebb
On 10/04/2009, Mark Thomas ma...@apache.org wrote: Filip Hanik - Dev Lists wrote: I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here? Reported bug, no. Bugs uses could hit, yes. Hence why this is in trunk and not being proposed for backport. Are

Re: svn commit: r763635 - in /tomcat/trunk/java/org/apache/catalina/ha/backend: HeartbeatListener.java MultiCastSender.java Sender.java

2009-04-11 Thread sebb
On 09/04/2009, jfcl...@apache.org jfcl...@apache.org wrote: Author: jfclere Date: Thu Apr 9 13:00:21 2009 New Revision: 763635 URL: http://svn.apache.org/viewvc?rev=763635view=rev Log: Move the multi logic to MultiCastSender with the idea to TCP sockets and a list of proxy too.

Re: svn commit: r763298 - in /tomcat/trunk/java/org/apache/catalina: core/StandardContext.java core/StandardHost.java tribes/membership/Membership.java util/InstanceSupport.java util/LifecycleSuppor

2009-04-14 Thread sebb
On 12/04/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: On 10/04/2009, Mark Thomas ma...@apache.org wrote: Filip Hanik - Dev Lists wrote: I'm generally against this find bugs 'may be bugs' issues. is there an actual bug here

Re: svn commit: r764985 - in /tomcat/trunk/java/org/apache/catalina/core: Constants.java StandardWrapper.java

2009-04-14 Thread sebb
On 14/04/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Tue Apr 14 22:16:53 2009 New Revision: 764985 URL: http://svn.apache.org/viewvc?rev=764985view=rev Log: Fix secondary issue reported as part of bug47013 Which says: req.setQueryString(Constants.PRECOMPILE +

Re: Problems building 5.5.27 from source

2009-04-17 Thread sebb
On 17/04/2009, Kirk True k...@mustardgrain.com wrote: Hi all, I had some problems building 5.5.27 as pulled from http://tomcat.apache.org/download-55.cgi. The first issue was that I couldn't use a JDK 1.4.2-level compiler as it chokes on the class format of the JUnit libraries. AFAIK it

Re: DO NOT REPLY [Bug 47049] New: TOMCAT MANAGER appears in Spanish, tildes/accents are not resolved.

2009-04-20 Thread sebb
On 20/04/2009, Mark Thomas ma...@apache.org wrote: Mark Thomas wrote: Looks like we need to run native2ascii over a quite a few French and German files. Surely the ISO-8859-1 (Latin-1) character set supports most accents in Latin languages, so there should be no need to use Unicode escapes

Re: DO NOT REPLY [Bug 47049] New: TOMCAT MANAGER appears in Spanish, tildes/accents are not resolved.

2009-04-20 Thread sebb
On 20/04/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 20/04/2009, Mark Thomas ma...@apache.org wrote: Mark Thomas wrote: Looks like we need to run native2ascii over a quite a few French and German files. Surely the ISO-8859-1 (Latin-1) character set supports most

Re: jdbc pool - prepping for a first release

2009-05-01 Thread sebb
compile.source=1.5 yet there are several references to features which require Java 1.6+ On 01/05/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: I was thinking to create a release, (I know I dropped the ball on the last one), to gather feedback on the code itself. There have been

Misleading name of Tomcat commiters list in svn-authorization

2009-05-14 Thread sebb
There are two Tomcat lists in svn-authorization: tomcat-pmc tomcat-watchdog The tomcat-pmc list appears to be the standard list for giving access to the normal Tomcat SVN development directories, and does not seem to have anything to do with the Tomcat PMC. I think all the other lists with -pmc

Re: [VOTE] Release build 6.0.20

2009-05-20 Thread sebb
extras/catalina-ws.jar does not have a NOTICE or a LICENSE file. All jars should ideally have NL files, but they must be present if the jar is published separately, as appears to be the case here. The EXE fails to install the following file: RELEASE-NOTES It also fails to install RUNNING.txt

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread sebb
Here are a few more missing properties: svn ps svn:eol-style native java/javax/el/LocalStrings_es.properties svn ps svn:eol-style native java/javax/servlet/LocalStrings_es.properties svn ps svn:eol-style native java/org/apache/catalina/ha/LocalStrings_es.properties svn ps svn:eol-style native

Mutable public fields in Tomcat 6 code

2009-05-21 Thread sebb
There are quite a lot of public mutable static fields in the current Tomcat6 codebase. Such fields can allow malicious or accidental changes to occur, so should be avoided as far as possible. [And if a class has public mutable static fields it's generally impossible to make it thread-safe.] The

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread sebb
/tomcat/lite/LiteTestHelper.java svn ps svn:eol-style native modules/tomcat-lite/test/org/apache/tomcat/test/watchdog/WatchdogHttpClient.java On 21/05/2009, Rainer Jung rainer.j...@kippdata.de wrote: On 21.05.2009 23:29, sebb wrote: Here are a few more missing properties: svn ps svn:eol

Re: svn commit: r777247 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/group/interceptors/SimpleCoordinator.java

2009-05-21 Thread sebb
On 22/05/2009, Rainer Jung rainer.j...@kippdata.de wrote: On 22.05.2009 01:07, Filip Hanik - Dev Lists wrote: rj...@apache.org wrote: Guys fix your svn configuration. ;) This happens to me all the time, as I move between machines very often. Why is the ~/.subversion/config a

Re: Coding Guidelines, encodings, keywords

2009-05-21 Thread sebb
On 22/05/2009, Konstantin Kolinko kkoli...@apache.org wrote: Hi, all! Are there any Coding Guidelines that we ought to follow, or is our project on our own there? I am interested in clarifying the following question: What is the character encoding for our sources. Our build scripts

Re: Mutable public fields in Tomcat 6 code

2009-05-22 Thread sebb
On 21/05/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: There are quite a lot of public mutable static fields in the current Tomcat6 codebase. Such fields can allow malicious or accidental changes to occur, so should be avoided as far as possible. [And if a class

Re: [VOTE] Release build 6.0.20

2009-05-24 Thread sebb
On 24/05/2009, Konstantin Kolinko knst.koli...@gmail.com wrote: 2009/5/14 Remy Maucherat r...@apache.org: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.20/ According to the release process, the 6.0.20 tag is: [ ] Broken [ ] Alpha [ ]

Re: [VOTE] Release build 6.0.20

2009-05-25 Thread sebb
On 25/05/2009, Konstantin Kolinko knst.koli...@gmail.com wrote: 2009/5/24 sebb seb...@gmail.com: On 24/05/2009, Konstantin Kolinko knst.koli...@gmail.com wrote: 2009/5/14 Remy Maucherat r...@apache.org: The candidates binaries are available here: http://people.apache.org/~remm

Re: [VOTE] Release build 6.0.20

2009-06-02 Thread sebb
On 02/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Martin Dubuc wrote: What is going to happen to the 6.0.20 load? Will it be officially released? that is based on the voting results, which passed, so yes, it will be released. I've not seen the [VOTE][RESULT] e-mail ?

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-11 Thread sebb
Apart from the problems with NL files etc that have already been mentioned, I found the following: == The changelog.html file refers to Tomcat JDBC Connection Pool *v1.0.5-beta* which looks wrong. == The documentation for the Interceptors appears to be incorrect. For example: The code

Re: svn commit: r784083 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/naming/resources/ webapps/docs/config/

2009-06-12 Thread sebb
On 12/06/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Fri Jun 12 11:38:29 2009 New Revision: 784083 URL: http://svn.apache.org/viewvc?rev=784083view=rev Log: Implement alias resources. Key features: - configured at the context level in the same way as the other

Re: [VOTE] Release JDBC Pool module v1.0.3

2009-06-15 Thread sebb
On 15/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Sebb, thanks for the feedback. sebb wrote: Apart from the problems with NL files etc that have already been mentioned, I found the following: == The changelog.html file refers to Tomcat JDBC Connection Pool *v1.0.5

Re: [VOTE] Release build 4.1.40

2009-06-16 Thread sebb
The copyright year in the NOTICE files in the binary archive is still 2008; surely it should be 2009? The connectors/NOTICE file in the source archive is wrong. There are no NOTICE files for the jasper and servletapi directory sub-trees. It would be better to have a single NL file at the top of

Re: svn commit: r785164 - /tomcat/container/branches/tc4.1.x/build.xml

2009-06-16 Thread sebb
On 16/06/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Tue Jun 16 11:17:26 2009 New Revision: 785164 URL: http://svn.apache.org/viewvc?rev=785164view=rev Log: Update exclusion list for EOL filtering Modified: tomcat/container/branches/tc4.1.x/build.xml

Re: svn commit: r785164 - /tomcat/container/branches/tc4.1.x/build.xml

2009-06-16 Thread sebb
On 16/06/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 16/06/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Tue Jun 16 11:17:26 2009 New Revision: 785164 URL: http://svn.apache.org/viewvc?rev=785164view=rev Log: Update exclusion list

Re: [VOTE] [CANCELLED] Release build 4.1.40

2009-06-16 Thread sebb
[ ] Beta [ ] Stable There were enough issues to re-roll the release. For the record, I tried and failed on several machines to recreate the problem sebb saw so I can only assume it was a local JVM issue. I've just realised that it might be due to trying to install without Admin privileges

Re: [VOTE] [CANCELLED] Release build 4.1.40

2009-06-16 Thread sebb
On 16/06/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 16/06/2009, Mark Thomas ma...@apache.org wrote: Mark Thomas wrote: The candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According

Re: [VOTE] Release JDBC Pool module v1.0.4

2009-06-16 Thread sebb
On 16/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Sebb, I can't find anything that is broken. All your concerns seem invalid to me. Please revisit, especially the NOTICE files. Filip sebb wrote: On 15/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote

Re: [VOTE] Release JDBC Pool module v1.0.4

2009-06-17 Thread sebb
On 17/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: On 16/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Sebb, I can't find anything that is broken. All your concerns seem invalid to me. Please revisit, especially the NOTICE files

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-18 Thread sebb
On 18/06/2009, Mark Thomas ma...@apache.org wrote: Tim Funk wrote: I think this needs to be volatile ? In (GetDateBenchmarkTest) +private long currentMillis = 0; Same for (in TimeDateElementBenchmarkTest) +private Date currentDate = null; Of course - since

Re: svn commit: r785952 - in /tomcat/trunk/test/org/apache/catalina/valves: ./ Benchmarks.java

2009-06-18 Thread sebb
On 18/06/2009, sebb seb...@gmail.com wrote: On 18/06/2009, Mark Thomas ma...@apache.org wrote: Tim Funk wrote: I think this needs to be volatile ? In (GetDateBenchmarkTest) +private long currentMillis = 0; Same for (in TimeDateElementBenchmarkTest

Re: [VOTE] Release JDBC Pool module v1.0.4

2009-06-18 Thread sebb
On 19/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: So now that we've clarified that NOTICE and LICENSE covers the entire release as an entity, No idea what you mean by that, but anyway: As I have written several times before, the NOTICE file is incorrect. This applies to the

Duplicate code in AccessLogValve

2009-06-19 Thread sebb
Just spotted this duplicate code in AccessLogValve: 661:if (!dateStamp.equals(tsDate)) { 662:if (!dateStamp.equals(tsDate)) { Not sure this double-checked looking offers any benefit ;-)

Re: Duplicate code in AccessLogValve

2009-06-19 Thread sebb
On 19/06/2009, sebb seb...@gmail.com wrote: Just spotted this duplicate code in AccessLogValve: 661:if (!dateStamp.equals(tsDate)) { 662:if (!dateStamp.equals(tsDate)) { Not sure this double-checked looking offers any benefit ;-) Line

Re: Duplicate code in AccessLogValve

2009-06-19 Thread sebb
create a new Date unecessarily. 2009/6/19 sebb seb...@gmail.com On 19/06/2009, sebb seb...@gmail.com wrote: Just spotted this duplicate code in AccessLogValve: 661:if (!dateStamp.equals(tsDate)) { 662

Re: svn commit: r786532 - /tomcat/trunk/modules/jdbc-pool/NOTICE

2009-06-19 Thread sebb
On 19/06/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Fri Jun 19 15:05:04 2009 New Revision: 786532 URL: http://svn.apache.org/viewvc?rev=786532view=rev Log: Correct per sebb/markt Sorry, but this is still incorrect. The NOTICE is now: This product includes

Re: svn commit: r786569 - /tomcat/trunk/modules/jdbc-pool/NOTICE

2009-06-19 Thread sebb
On 19/06/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Fri Jun 19 16:16:16 2009 New Revision: 786569 URL: http://svn.apache.org/viewvc?rev=786569view=rev Log: correction Modified: tomcat/trunk/modules/jdbc-pool/NOTICE Modified:

Re: [VOTE] Release build 4.1.40 - Take 2

2009-06-19 Thread sebb
On 16/06/2009, Mark Thomas ma...@apache.org wrote: The (updated) candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release process, the release based on the 4.0.40 tag is: Did you mean 4.1.40? Also,

Re: [VOTE] Release build 4.1.40 - Take 2

2009-06-19 Thread sebb
On 19/06/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 16/06/2009, Mark Thomas ma...@apache.org wrote: The (updated) candidates source tarball and derived binaries are available here: http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ According to the release

Re: svn commit: r786631 - /tomcat/trunk/test/org/apache/catalina/valves/Benchmarks.java

2009-06-19 Thread sebb
On 19/06/2009, kkoli...@apache.org kkoli...@apache.org wrote: Author: kkolinko Date: Fri Jun 19 18:57:59 2009 New Revision: 786631 URL: http://svn.apache.org/viewvc?rev=786631view=rev Log: Add two more implementations for the second test. a) using a single ThreadLocal instead of

Re: svn commit: r786653 - /tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

2009-06-19 Thread sebb
On 19/06/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Fri Jun 19 20:21:53 2009 New Revision: 786653 URL: http://svn.apache.org/viewvc?rev=786653view=rev Log: Switch to ThreadLocal where possible. This removes all the syncs apart from those related to accessing

Re: svn commit: r787211 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2009-06-22 Thread sebb
On 22/06/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Mon Jun 22 11:58:07 2009 New Revision: 787211 URL: http://svn.apache.org/viewvc?rev=787211view=rev Log: Fix a couple of Eclipse warnings Modified:

Re: Please review JDBC Pool before vote

2009-06-22 Thread sebb
On 22/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: in the spirit of trying to get my poop right, http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Looks a lot better. the binary releases contain everything in individual jar files (including source references for IDEs)

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-25 Thread sebb
On 24/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Cleaned up and fixed. The release is located here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Exactly the same path names were used previously; I assume you are referring to the following versions of the files:

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-26 Thread sebb
On 26/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: On 24/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Cleaned up and fixed. The release is located here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Exactly the same path

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-26 Thread sebb
On 26/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: On 26/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: sebb wrote: On 24/06/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Cleaned up and fixed

Re: [VOTE] Release JDBC Pool module v1.0.5

2009-06-26 Thread sebb
When testing with Derby on Java 1.6.0 I get the following error: [junit] Running org.apache.tomcat.jdbc.test.StarvationTest [junit] Testsuite: org.apache.tomcat.jdbc.test.StarvationTest [junit] AbandonedObjectPool is used (org.apache.tomcat.dbcp.dbcp.abandonedobjectp...@1d6096)

Re: svn commit: r788214 - /tomcat/current/tc5.5.x/STATUS.txt

2009-06-27 Thread sebb
On 27/06/2009, Xie Xiaodong xxd82...@gmail.com wrote: But how could ThreadLocal be shared among all AccessLogValve instances on the same server? After all, each thread access ThreadLocal has its own. Another point, based on the java doc of ThreadLocal, maybe private

Re: svn commit: r789392 - in /tomcat/trunk/modules/jdbc-pool: ./ test/org/apache/tomcat/jdbc/test/

2009-06-29 Thread sebb
On 29/06/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Mon Jun 29 17:38:21 2009 New Revision: 789392 URL: http://svn.apache.org/viewvc?rev=789392view=rev Log: Remove all usage of GPL or LGPL downloads. +1, thanks. Use H2 for test database (EPL1.0) as it can

Re: svn commit: r789392 - in /tomcat/trunk/modules/jdbc-pool: ./ test/org/apache/tomcat/jdbc/test/

2009-06-30 Thread sebb
On 29/06/2009, sebb seb...@gmail.com wrote: On 29/06/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Mon Jun 29 17:38:21 2009 New Revision: 789392 URL: http://svn.apache.org/viewvc?rev=789392view=rev Log: Remove all usage of GPL or LGPL downloads

Re: svn commit: r789714 - in /tomcat: container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/tcp/FastAsyncSocketSender.java container/tc5.5.x/webapps/docs/changelog.xml current/tc5.5

2009-06-30 Thread sebb
On 30/06/2009, rj...@apache.org rj...@apache.org wrote: Author: rjung Date: Tue Jun 30 13:26:10 2009 New Revision: 789714 URL: http://svn.apache.org/viewvc?rev=789714view=rev Log: Separate statistics counter lock in FastAsyncSocketSender from inherited DataSender lock to reduce

Re: svn commit: r789883 - in /tomcat/trunk/modules/jdbc-pool: build.properties.default build.xml

2009-06-30 Thread sebb
On 30/06/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Tue Jun 30 19:15:28 2009 New Revision: 789883 URL: http://svn.apache.org/viewvc?rev=789883view=rev Log: Apply patch by sebb from https://issues.apache.org/bugzilla/show_bug.cgi?id=47458 Store db

Re: svn commit: r790155 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/session/ catalina/src/share/org/apache/catalina/valves/ webapps/docs/ webapps/docs/config/

2009-07-01 Thread sebb
On 01/07/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Wed Jul 1 13:19:15 2009 New Revision: 790155 URL: http://svn.apache.org/viewvc?rev=790155view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43343 Port of r656751, r778523, r778524, r784453

Re: svn commit: r790693 - /tomcat/trunk/modules/jdbc-pool/build.xml

2009-07-02 Thread sebb
On 02/07/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Thu Jul 2 17:35:26 2009 New Revision: 790693 URL: http://svn.apache.org/viewvc?rev=790693view=rev Log: break out javadoc into its own target Modified: tomcat/trunk/modules/jdbc-pool/build.xml

Re: svn commit: r790684 - /tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2009-07-02 Thread sebb
On 02/07/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Thu Jul 2 17:08:50 2009 New Revision: 790684 URL: http://svn.apache.org/viewvc?rev=790684view=rev Log: Add some doco, make shared variables volatile Modified:

Re: JDBC-POOL release candidate

2009-07-21 Thread sebb
On 14/07/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: think it should be all in order now http://people.apache.org/~fhanik/jdbc-pool/v1.0.6/ Eclipse and Findbugs show the following warnings for the non-test code: Description ResourcePathTypeLocation Class is a

Re: [PROPOSAL] Remove SVN keywords from JavaDoc

2009-07-22 Thread sebb
On 07/07/2009, Mark Thomas ma...@apache.org wrote: Konstantin Kolinko wrote: As was written early in this my thread: http://www.nabble.com/Coding-Guidelines%2C-encodings%2C-keywords-td23662661.html (http://markmail.org/thread/d6dsgrsfvnuzclt7) there are problems with Subversion

Re: svn commit: r794798 - in /tomcat/trunk/java/org/apache/catalina/filters: Constants.java FilterBase.java LocalStrings.properties LocalStrings_es.properties LocalStrings_fr.properties RemoteAddrFi

2009-07-22 Thread sebb
On 16/07/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Thu Jul 16 19:34:49 2009 New Revision: 794798 URL: http://svn.apache.org/viewvc?rev=794798view=rev Log: More GSOC work from Xie Xiadong Initial implementation of RemoteHost and RemoteAddr filters. Added:

Re: JDBC-POOL release candidate

2009-07-22 Thread sebb
On 14/07/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: think it should be all in order now http://people.apache.org/~fhanik/jdbc-pool/v1.0.6/ There are some differences between the source archives and the SVN tag: In SVN, but not in source archive:

Re: svn commit: r796739 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java

2009-07-22 Thread sebb
On 22/07/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Wed Jul 22 14:29:09 2009 New Revision: 796739 URL: http://svn.apache.org/viewvc?rev=796739view=rev Log: Restore the @Overrides. Eclipse on my Mac wasn't configured right. Sorry for the noise. The

Re: svn commit: r796739 - /tomcat/trunk/java/org/apache/catalina/connector/AsyncContextImpl.java

2009-07-23 Thread sebb
On 23/07/2009, Mark Thomas ma...@apache.org wrote: Filip Hanik - Dev Lists wrote: Correct, servlet 3.0 requires minimum 1.6 so we don't have to build down to 1.5 anymore Filip I think sebb needs to do an svn up. build.properties.default has specified 1.6 for over 6 months. I

Re: svn commit: r797151 - /tomcat/trunk/build.xml

2009-07-23 Thread sebb
On 23/07/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Thu Jul 23 17:15:55 2009 New Revision: 797151 URL: http://svn.apache.org/viewvc?rev=797151view=rev Log: Correct the file name Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL:

Re: svn commit: r797151 - /tomcat/trunk/build.xml

2009-07-24 Thread sebb
On 24/07/2009, Rainer Jung rainer.j...@kippdata.de wrote: On 23.07.2009 20:43, sebb wrote: On 23/07/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Thu Jul 23 17:15:55 2009 New Revision: 797151 URL: http://svn.apache.org/viewvc?rev=797151view=rev Log

Re: svn commit: r797529 - in /tomcat/trunk/modules/jdbc-pool/test/org/apache/tomcat/jdbc/test: AbandonPercentageTest.java BorrowWaitTest.java DefaultTestCase.java TestConcurrency.java

2009-07-24 Thread sebb
On 24/07/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Fri Jul 24 15:25:17 2009 New Revision: 797529 URL: http://svn.apache.org/viewvc?rev=797529view=rev Log: update test cases Modified:

Re: svn commit: r797528 - in /tomcat/trunk/modules/jdbc-pool: doc/ java/org/apache/tomcat/jdbc/pool/

2009-07-24 Thread sebb
On 24/07/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Fri Jul 24 15:24:52 2009 New Revision: 797528 URL: http://svn.apache.org/viewvc?rev=797528view=rev Log: Add in Linux special case for performance optimization around locking. Set default queue to be the

Re: 5.5.28 release candidate

2009-07-24 Thread sebb
On 24/07/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: http://people.apache.org/~fhanik/tomcat/tomcat-5.5/v5.5.28/ There is no .zip version of apache-tomcat-5.5.28-fulldocs.tar.gz The source archives contain the file container/webapps/admin/images/Thumbs.db which does not belong in

Re: 5.5.28 release candidate

2009-07-25 Thread sebb
On 25/07/2009, Rainer Jung rainer.j...@kippdata.de wrote: On 25.07.2009 01:44, sebb wrote: On 24/07/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Likewise, the file tomcat-users.xml looks wrong - it says that there is no user with the manager role, yet it contains the following

Re: [VOTE] jdbc-pool Release build 1.0.7

2009-07-27 Thread sebb
On 27/07/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: The candidates source and binaries are available here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.7/ According to the release process, the 1.0.7 tag is: [X] Broken Test failures and various other bugs already reported.

Re: [VOTE] Release build 5.5.28

2009-08-02 Thread sebb
On 02/08/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: Just noticed another problem - the source archive does not contain the overall build script. I don't know where you are looking, but the script is there. Sorry, my bad - I'd expanded the archives and was looking in the wrong

Re: [VOTE] jdbc-pool Release build 1.0.7

2009-08-04 Thread sebb
On 04/08/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: On 07/27/2009 02:21 PM, Filip Hanik - Dev Lists wrote: The candidates source and binaries are available here: http://people.apache.org/~fhanik/jdbc-pool/v1.0.7/ According to the release process, the 1.0.7 tag is: [ ]

Re: svn re-org complete

2009-08-11 Thread sebb
On 07/08/2009, Mark Thomas ma...@apache.org wrote: The svn re-organisation is complete. Is the file build/BUILDING.txt still accurate? I've just tried following it and Ant reports: Buildfile: build.xml check.source: get.source: checkout: [echo] If the checkout fails, see

Re: svn re-org complete

2009-08-12 Thread sebb
On 12/08/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 07/08/2009, Mark Thomas ma...@apache.org wrote: The svn re-organisation is complete. Is the file build/BUILDING.txt still accurate? Yes. It is the top-level build.xml that needs tweaking. Presumably I would need

Re: svn re-org complete

2009-08-12 Thread sebb
On 12/08/2009, Konstantin Kolinko knst.koli...@gmail.com wrote: 2009/8/12 sebb seb...@gmail.com: On 12/08/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 07/08/2009, Mark Thomas ma...@apache.org wrote: The svn re-organisation is complete. Is the file build

Re: svn commit: r804963 - /tomcat/trunk/bin/catalina.sh

2009-08-17 Thread sebb
On 17/08/2009, Mark Thomas ma...@apache.org wrote: sebb wrote: On 17/08/2009, ma...@apache.org ma...@apache.org wrote: + else +if [ $? -eq 0 ]; then Might be better to check $FORCE before sleeping? On reflection, I don't think there is any need for a sleep here at all

Fwd: DOAP Error Report

2009-08-18 Thread sebb
I've fixed the projects build to use: http://svn.apache.org/repos/asf/tomcat/taglibs/rdc/trunk/doap_rdc.rdf Please can someone on the project can check if the DOAP itself needs updating. Thanks. -- Forwarded message -- From: aps...@apache.org aps...@apache.org Date: 18 Aug 2009

Re: svn commit: r805375 - in /tomcat/trunk: conf/ java/org/apache/catalina/filters/ java/org/apache/catalina/mbeans/ java/org/apache/catalina/valves/ webapps/docs/config/ webapps/examples/WEB-INF/

2009-08-18 Thread sebb
On 18/08/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Tue Aug 18 11:49:26 2009 New Revision: 805375 URL: http://svn.apache.org/viewvc?rev=805375view=rev Log: Replace the RequestDumperValve with a RequestDumperFilter. Merge the RequestDumperFilter from the

Re: Sporadically broken Download for 2.2.13 windows binaries?

2009-08-25 Thread sebb
FYI: This is probably a manifestation of the following Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=237623 which also seems to affect IE. See also INFRA-2188 On 25/08/2009, Filip Hanik - Dev Lists devli...@hanik.com wrote: Downloaded using firefox 6034944 bytes Filip On

Re: DO NOT REPLY [Bug 47767] [PatchAvailable] mod_actions and Server-Status

2009-09-01 Thread sebb
The same person also raised a JIRA issue. [It was INFRA-2178, now deleted.] On 31/08/2009, Mark Thomas ma...@apache.org wrote: This looks like spam to me. I am going to purge it from Bugzilla and disable the account of the use that created it. Mark

Re: svn commit: r810132 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-09-01 Thread sebb
On 01/09/2009, Larry Isaacs larry.isa...@sas.com wrote: Hi Filip, I have a vague recollection about tripping over this issue while working on the Tomcat support in the Eclipse Web Tools Platform. WTP has its own version(s) of VirtualWebappLoader, called WtpWebappLoader, to address it. If

Re: svn commit: r812115 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/changelog.xml

2009-09-07 Thread sebb
On 07/09/2009, ma...@apache.org ma...@apache.org wrote: Author: markt Date: Mon Sep 7 12:45:58 2009 New Revision: 812115 URL: http://svn.apache.org/viewvc?rev=812115view=rev Log: Apply AD improvements Modified: tomcat/tc6.0.x/trunk/STATUS.txt

Re: svn commit: r814198 - /tomcat/trunk/PROPOSALS.txt

2009-09-12 Thread sebb
On 12/09/2009, idar...@apache.org idar...@apache.org wrote: Author: idarwin Date: Sat Sep 12 16:58:08 2009 New Revision: 814198 URL: http://svn.apache.org/viewvc?rev=814198view=rev Log: Trivial typo correction Modified: tomcat/trunk/PROPOSALS.txt Modified:

Re: svn commit: r818040 - /tomcat/tc6.0.x/trunk/STATUS.txt

2009-09-23 Thread sebb
thought so to, but I tested it :) That always helps :) It doesn't really matter for webapps and we do just leave the files with whatever line ending they had when the files were built. I'll look at completely re-doign this for Tomcat 7. I think Sebb proposed a patch somewhere

Re: Site build note (was Re: svn commit: r822590 [1/2])

2009-10-08 Thread sebb
On 08/10/2009, Rahul Akolkar rahul.akol...@gmail.com wrote: Mostly for the archives since I had the first observation below when I had to build the site as well: On Wed, Oct 7, 2009 at 1:24 AM, bay...@apache.org wrote: Author: bayard Date: Wed Oct 7 05:24:06 2009 New Revision:

Re: svn commit: r823713 - in /tomcat/trunk/java/org/apache/catalina: authenticator/ core/ ha/session/ ha/tcp/ valves/

2009-10-09 Thread sebb
On 09/10/2009, fha...@apache.org fha...@apache.org wrote: Author: fhanik Date: Fri Oct 9 22:02:35 2009 New Revision: 823713 URL: http://svn.apache.org/viewvc?rev=823713view=rev Log: Explicitly mark all our valves so that we can track down which ones we need to fix and make async

Re: DO NOT REPLY [Bug 51656] New: NullPointerException in host-manager application (in javax.servlet.GenericServlet.getServletContext during logging)

2011-08-12 Thread sebb
On 12 August 2011 15:34, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=51656 (Dammit this description window is too narrow...) Just drag the bottom rh corner (indicated by small dots) ... - To

Re: svn commit: r1154689 - /tomcat/trunk/java/org/apache/juli/FileHandler.java

2011-08-14 Thread sebb
On 7 August 2011 11:37, ma...@apache.org wrote: Author: markt Date: Sun Aug  7 10:37:16 2011 New Revision: 1154689 URL: http://svn.apache.org/viewvc?rev=1154689view=rev Log: Only try and create the dir if it doesn't already exist Modified:    

Re: [ANN] Apache Tomcat 6.0.33 released

2011-08-18 Thread sebb
On 18 August 2011 14:56, Jean-Frederic Clere jfcl...@apache.org wrote: The Apache Tomcat team announces the immediate availability of Apache Tomcat 6.0.33 stable. Apache Tomcat 6.0.33 is primarily a security and bug fix release. All users of older versions of the Tomcat 6.0 family should

Re: svn commit: r1146005 - in /tomcat/trunk/java/org/apache/catalina/connector: LocalStrings.properties Request.java

2011-08-22 Thread sebb
On 13 July 2011 14:28, ma...@apache.org wrote: Author: markt Date: Wed Jul 13 13:28:24 2011 New Revision: 1146005 URL: http://svn.apache.org/viewvc?rev=1146005view=rev Log: When running under a security manager and using sendfile, validate sendfile attributes to prevent sendfile being

Re: svn commit: r1166150 - /tomcat/trunk/java/org/apache/coyote/http11/AbstractHttp11Processor.java

2011-09-07 Thread sebb
On 7 September 2011 13:31, ma...@apache.org wrote: Author: markt Date: Wed Sep  7 12:31:30 2011 New Revision: 1166150 URL: http://svn.apache.org/viewvc?rev=1166150view=rev Log: async more likely than comet Modified:    

Re: svn commit: r1172689 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2011-09-19 Thread sebb
On 19 September 2011 17:30, ma...@apache.org wrote: Author: markt Date: Mon Sep 19 16:30:36 2011 New Revision: 1172689 URL: http://svn.apache.org/viewvc?rev=1172689view=rev Log: Fix threading issue with changing visibility of methods and fields Modified:    

[Taglibs] Is anyone looking after taglibs?

2011-11-03 Thread sebb
The Jakarta TLP is about to retire to the attic; however the taglibs site still refers to non-existent jakarta pages for the downloads. A bug [1] was raised for this for this some while ago, but there appears to be no-one interested in fixing the issue. [1]

Adding NOTICE and LICENSE files to bundled jars; improving the MANIFESTS

2008-09-22 Thread sebb
The Tomcat 5 and 6 releases contain quite a few jars. Some of these may well be useful outside the Tomcat project (e.g. the api jars). However the jars do not contain NOTICE or LICENSE files, and the MANIFESTs are minimal. Please could future releases be updated to fix this? The sort of

Findbugs results when run against Tomcat6

2008-09-26 Thread sebb
Just out of curiosity, I ran Findbugs 1.3.5 on Tomcat 6.0.18. The default settings generated some 1400 warnings about possible bugs. Quite a few of them look serious - assuming that the code which contains them is being used. For example, there are quite a few public static fields which are not

Re: svn commit: r700170 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-29 Thread sebb
BTW, Commons LANG has a thread-safe FastDateUtils which can be used for formatting (but not parsing) dates. Not sure why you did not just fix DateTool - e.g. by using ThreadLocal (or indeed synchronizing the use of DateFormats) - rather than fixing all calls to DateTool. Or maybe I've

Re: svn commit: r700170 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-09-29 Thread sebb
On 29/09/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: BTW, Commons LANG has a thread-safe FastDateUtils which can be used for formatting (but not parsing) dates. A whole jar for one method is somewhat overkill. Indeed, but there's lots of other useful stuff in LANG. I just

Re: svn commit: r700170 - /tomcat/tc6.0.x/trunk/STATUS.txt

2008-10-01 Thread sebb
On 29/09/2008, Mark Thomas [EMAIL PROTECTED] wrote: sebb wrote: On 29/09/2008, Mark Thomas [EMAIL PROTECTED] wrote: ThreadLocals and container classloader environments need careful handling to avoid memory leaks. I would have thought that was a good reason to keep the class - one

Re: svn commit: r702587 - /tomcat/trunk/java/org/apache/jasper/compiler/Parser.java

2008-10-07 Thread sebb
On 07/10/2008, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: markt Date: Tue Oct 7 12:10:51 2008 New Revision: 702587 URL: http://svn.apache.org/viewvc?rev=702587view=rev Log: EG confirmed that attribute values should be fully escaped, including any EL. Note this does not fix

Re: Byte Serving and PDFs with the DefaultServlet

2008-10-10 Thread sebb
On 09/10/2008, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Hello Mark, you are right. The mime extension is not working on a case insensitive basis. Now my Tomcat 5.5 does byte serving with the web.xml portion below: mime-mapping extensionpdf/extension

  1   2   3   4   5   >