[Bug 62160] Property values linking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62160

Remy Maucherat  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|REOPENED|RESOLVED

--- Comment #3 from Remy Maucherat  ---
I have reverted my patch and will leave it at that since I do not agree with
the reasoning or your expected result.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62160] Property values linking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62160

Konstantin Kolinko  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #2 from Konstantin Kolinko  ---
I am OK with the feature, but I am -1 on the approach implemented in this patch
(r1825989).

1). Consider the following properties:
first=${
second=bar}
bar=baz

If you have value="${first}${second}" my expectation is that result of
substitution will be value="${bar}". Your algorithm will yield value="baz".

I think the replacement loop should be inside of
IntrospectionUtils.replaceProperties(),
looking for replacements in the value of a property.

Instead of looping over resulting value.

2). It would be better to have some hard limit on recursion depth. E.g. 20.
(Not a showstopper requirement, but a "nice to have" one).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62160] Property values linking

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62160

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Remy Maucherat  ---
After playing it a bit, it looked better to me. The update will be in 9.0.7 and
8.5.30, unless someone complains about it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org