[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

Remy Maucherat  changed:

   What|Removed |Added

 CC||pier...@pieroxy.net

--- Comment #9 from Remy Maucherat  ---
*** Bug 67685 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

Matafagafo  changed:

   What|Removed |Added

 CC||matafag...@yahoo.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

--- Comment #8 from Remy Maucherat  ---
(In reply to Mark Thomas from comment #7)
> (In reply to Remy Maucherat from comment #4)
> > Sorry. I complained about this refactoring, but unfortunately could not find
> > anything obviously wrong with it, so it went in ...
> 
> Sorry, I missed this and pushed for this contribution to be accepted. Thanks
> for the fix and test case.

I couldn't see any problem either, probably because a lot of the code had to be
moved to compression config.

So I suppose we have to start a round of releases. Is anyone actually available
today ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

--- Comment #7 from Mark Thomas  ---
(In reply to Remy Maucherat from comment #4)
> Sorry. I complained about this refactoring, but unfortunately could not find
> anything obviously wrong with it, so it went in ...

Sorry, I missed this and pushed for this contribution to be accepted. Thanks
for the fix and test case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

Han Li  changed:

   What|Removed |Added

 CC||gr.grzy...@gmail.com

--- Comment #6 from Han Li  ---
*** Bug 67678 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Remy Maucherat  ---
Thanks Konstantin for the review of the issue.

The fix will be in 11.0.0-M13, 10.1.15, 9.0.82 and 8.5.95.

I assume the release process for the next round of releases will start soon
(likely a couple days due to the conference, we'll see).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

--- Comment #4 from Remy Maucherat  ---
Sorry. I complained about this refactoring, but unfortunately could not find
anything obviously wrong with it, so it went in ...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

--- Comment #3 from Konstantin Kolinko  ---
I have not tested yet, but I guess that Tomcat 8.5.94, 10.1.14 and 11.0.0-M12
are affected as well.

The code regarding useCompression() call (o.a.c.http11.Http11Processor,
o.a.c.CompressionConfig) is essentially the same. Commits:

8.5.x:
https://github.com/apache/tomcat/commit/7abdf0b44c79f65c4f0fc862a1ea311f81ce881a

10.1.x:
https://github.com/apache/tomcat/commit/97c58599b25107d5b5cc19dd199a4fa847e99358

main (11.0.x):
https://github.com/apache/tomcat/commit/e47d0c46fecb3745593e9b4552e4298adf8184d2

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

Konstantin Kolinko  changed:

   What|Removed |Added

   Severity|normal  |regression

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

--- Comment #2 from Konstantin Kolinko  ---
(In reply to M McClain from comment #0)

> diff --git a/java/org/apache/coyote/http11/Http11Processor.java
> b/java/org/apache/coyote/http11/Http11Processor.java
> index aab2290407..ac531ad105 100644
> --- a/java/org/apache/coyote/http11/Http11Processor.java
> +++ b/java/org/apache/coyote/http11/Http11Processor.java
> @@ -914,12 +914,6 @@ public class Http11Processor extends AbstractProcessor {
> ...
>  
> -// Check for compression
> -boolean useCompression = false;
> -if (entityBody && sendfileData == null) {
> -useCompression = protocol.useCompression(request, response);
> -}
> ...
> @@ -956,8 +950,11 @@ public class Http11Processor extends AbstractProcessor {

The lines between the two chunks in the diff above in Http11Processor are
responsible for setting the "Content-Length" header.

>930:long contentLength = response.getContentLengthLong();
>...
>937:} else if (contentLength != -1) {
>938:headers.setValue("Content-Length").setLong(contentLength);


The "protocol.useCompression(request, response)" call goes down to
org.apache.coyote.CompressionConfig#useCompression(...) that does

>// Compressed content length is unknown so mark it as such.
>response.setContentLength(-1);
>// Configure the content encoding for compressed content
>responseHeaders.setValue("Content-Encoding").setString("gzip");

As the "useCompression" was moved by that commit, line 930 no longer sees the
correct contentLength value.


Note: The workaround for this issue is to turn off compression on a Connector.
(Remove the "compression" attribute from a  element, or set it to
"off").

https://tomcat.apache.org/tomcat-9.0-doc/config/http.html#Standard_Implementation

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

--- Comment #1 from Konstantin Kolinko  ---
>From a mail by Amit Pande on users' list
> Subject: Tomcat upgrade from 9.0.80 to 9.0.81
https://lists.apache.org/thread/hh84wdgmvfkgs0zof14ly8vxgrh1no4j

org.apache.http.ConnectionClosedException: Premature end of Content-Length
delimited message body (expected: 4,999; received: 3,040)

Thus apparently the Content-Length header is set to a wrong value when GZip
compression is enabled.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 67670] 20 seconds to download some JS files with 9.0.81

2023-10-10 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=67670

Michael Osipov  changed:

   What|Removed |Added

 CC||micha...@apache.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org