[Bug 68559] BadRequestException doesn't send back a 400 when using Async servlets

2024-02-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68559

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #9 from Mark Thomas  ---
I've made a modification that should allow async error handling to write to the
response. The provided test case now passes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68559] BadRequestException doesn't send back a 400 when using Async servlets

2024-02-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68559

--- Comment #8 from Mark Thomas  ---
I've been able to look at this some more. Thanks so much for the test case. It
really speeds up the process.

The processing paths for sync and async are distinct. Currently the error
handling in async is handled much further up the stack than sync. That is a
factor in why async is more blunt in its error handling. I'm looking to see if
I can make the error handling more nuanced for async.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68559] BadRequestException doesn't send back a 400 when using Async servlets

2024-02-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68559

--- Comment #7 from Christopher Schultz  ---
How do you get a valid HTTP request (not a 400) but then find yourself in a
"Bad Request" state once async gets started?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68559] BadRequestException doesn't send back a 400 when using Async servlets

2024-02-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68559

--- Comment #6 from adwsingh  ---
I agree on the closing connection part. Its just weird that sync and async
behave differently, one sends out a 400 and other doesn't.

Also the way you suggested in
https://bz.apache.org/bugzilla/show_bug.cgi?id=68037#c7, doesn't work for BRE
but works for SocketTimeout.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68559] BadRequestException doesn't send back a 400 when using Async servlets

2024-02-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68559

--- Comment #5 from Mark Thomas  ---
I haven't looked at this yet but I suspect it may end up as WONTFIX.

A bad request indicates a syntactically invalid request. At that point, it can
be argued that given that the request is invalid, Tomcat can't tell what is
going on so the only safe thing to do is to close the connection.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68559] BadRequestException doesn't send back a 400 when using Async servlets

2024-02-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68559

--- Comment #4 from adwsingh  ---
Any update on this? I can give fixing this a shot if no one else is planning
to.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68559] BadRequestException doesn't send back a 400 when using Async servlets

2024-01-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68559

adwsingh  changed:

   What|Removed |Added

 Resolution|WONTFIX |---
 Status|RESOLVED|REOPENED

--- Comment #3 from adwsingh  ---
I have already read the comment you are referencing. The solution by Mark works
for SocketTimeout, but doesn't work for BadRequest.

Further even if Tomcat doesn't allow setting a status on BadRequest, it should
at the least send back a 404 instead of just closing the connection.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68559] BadRequestException doesn't send back a 400 when using Async servlets

2024-01-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68559

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #2 from Remy Maucherat  ---
https://bz.apache.org/bugzilla/show_bug.cgi?id=68037#c7

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68559] BadRequestException doesn't send back a 400 when using Async servlets

2024-01-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68559

adwsingh  changed:

   What|Removed |Added

 CC||adwsi...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 68559] BadRequestException doesn't send back a 400 when using Async servlets

2024-01-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=68559

--- Comment #1 from adwsingh  ---
Also similar to https://bz.apache.org/bugzilla/show_bug.cgi?id=68228

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org