Gallrax commented on a change in pull request #228: Correct header too large
status to 414
URL: https://github.com/apache/tomcat/pull/228#discussion_r353049202
##########
File path: java/org/apache/coyote/http11/Http11InputBuffer.java
##########
@@ -723,7 +723,7 @@ private boolean fill(boolean block) throws IOException {
// Avoid unknown protocol triggering an additional error
request.protocol().setString(Constants.HTTP_11);
}
- throw new
IllegalArgumentException(sm.getString("iib.requestheadertoolarge.error"));
+ throw new
HeadersTooLargeException(sm.getString("iib.requestheadertoolarge.error"));
}
Review comment:
> This will trigger both if the request line is too long (OK) and if the
HTTP headers are too big (bad).
> What about https://tools.ietf.org/html/rfc6585#section-5?
How about if I change it to 431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
