[GitHub] [tomcat] markt-asf commented on issue #194: fix typo

2019-09-11 Thread GitBox
markt-asf commented on issue #194: fix typo URL: https://github.com/apache/tomcat/pull/194#issuecomment-530322410 I'm about 2/3 of the way through the commits. With the benefit of experience, 1 PR vs multiple PRs doesn't make that much of a difference. What would have helped was re-basing

[GitHub] [tomcat] markt-asf commented on issue #194: fix typo

2019-09-11 Thread GitBox
markt-asf commented on issue #194: fix typo URL: https://github.com/apache/tomcat/pull/194#issuecomment-530252907 Wow. There are a lot of changes here. Thank you. It is too much to review in one go. I took a quick look at the first few changes files and things look good. My current