[GitHub] [tomcat] martin-g commented on a change in pull request #276: Add s390x Travis support

[GitBox]

martin-g commented on a change in pull request #276:
URL: https://github.com/apache/tomcat/pull/276#discussion_r412708978



##
File path: .travis.yml
##
@@ -15,8 +15,12 @@
 
 dist: bionic
 language: java
-jdk: oraclejdk8
-arch: arm64
+jobs:
+include:
+  - arch: s390x
+jdk: openjdk11

Review comment:
   My concern is that Tomcat (even version 10.x) is supposed to be build 
with JDK 8. 
   But since Travis is not the main CI I think it is OK to use JDK 11 as an 
exception here.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] martin-g commented on a change in pull request #276: Add s390x Travis support

[GitBox]

martin-g commented on a change in pull request #276:
URL: https://github.com/apache/tomcat/pull/276#discussion_r411923652



##
File path: .travis.yml
##
@@ -32,14 +36,7 @@ addons:
 - libtool-bin
 
 install:
-- ARCH=`uname -p`
-- echo $ARCH
-- 
JDK_X64="https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u242-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u242b08.tar.gz;
-- 
JDK_ARM64="https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u232-b09/OpenJDK8U-jdk_aarch64_linux_hotspot_8u232b09.tar.gz;
-- if test "X$ARCH" = "Xaarch64"; then JDK_URL=$JDK_ARM64; else 
JDK_URL=$JDK_X64; fi
-- wget -q $JDK_URL && tar xzf OpenJDK*.tar.gz
-- mv jdk8* jdk
-- export JAVA_HOME=`pwd`/jdk

Review comment:
   The above was here for two reasons:
   1) because TravisCI is really inconsistent in what is available in the 
different types of VMs
   1.1) JAVA_HOME is exported for AMD64, but not for ARM64
   1.2) `mvn` is available for AMD64, but not for ARM
   1.3.) most important - to keep the version of the used JDK the same for all 
environments. The one provided by Travis for ARM64 was older than the one for 
AMD64
   
   For the above reasons I'd prefer to keep the control

##
File path: .travis.yml
##
@@ -15,8 +15,12 @@
 
 dist: bionic
 language: java
-jdk: oraclejdk8
-arch: arm64
+jobs:
+include:
+  - arch: s390x
+jdk: openjdk11

Review comment:
   any reason to use JDK 11 for s390x ? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org