[GitHub] [tomcat] philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings

philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings URL: https://github.com/apache/tomcat/pull/143#issuecomment-470668078 @markt-asf Thanks Mark! This is an automated message from the

[GitHub] [tomcat] philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings

philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings URL: https://github.com/apache/tomcat/pull/143#issuecomment-470667817 @rmannibucau I've opened another issue for that https://bz.apache.org/bugzilla/show_bug.cgi?id=63237. If I get a second I'll

[GitHub] [tomcat] philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings

philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings URL: https://github.com/apache/tomcat/pull/143#issuecomment-470381178 I've pushed an update that uses `String.intern` for those two places. With this change 2192 duplicates are reduced to 300 and

[GitHub] [tomcat] philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings

philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings URL: https://github.com/apache/tomcat/pull/143#issuecomment-470210052 The other option would be to use `String.intern` for these limited cases. Either way, I'm happy to rework the PR if you have a

[GitHub] [tomcat] philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings

philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings URL: https://github.com/apache/tomcat/pull/143#issuecomment-470145284 Sure. I discovered these by using the "Inspections" feature from [YourKit](https://www.yourkit.com/) on an [embedded Tomcat