[GitHub] [tomcat] sakshamverma commented on a change in pull request #346: Bug 64644 add custom properties to close connections on readIdletimeout
sakshamverma commented on a change in pull request #346: URL: https://github.com/apache/tomcat/pull/346#discussion_r479406856 ## File path: java/org/apache/tomcat/websocket/Constants.java ## @@ -114,6 +114,22 @@ // Milliseconds so this is 20 seconds public static final long DEFAULT_BLOCKING_SEND_TIMEOUT = 20 * 1000; +// Configuration for idle read timeout on websocket channel +public static final String WS_READ_IDLE_TIMEOUT = +"org.apache.tomcat.websocket.WS_READ_IDLE_TIMEOUT"; + +// Configuration for idle write timeout on websocket channel +public static final String WS_WRITE_IDLE_TIMEOUT = +"org.apache.tomcat.websocket.WS_WRITE_IDLE_TIMEOUT"; + +// Configuration for idle write timeout on websocket channel +public static final String WS_CLOSE_READ_IDLE_TIMEOUT = +"org.apache.tomcat.websocket.WS_CLOSE_READ_IDLE_TIMEOUT"; + +// Configuration for idle write timeout on websocket channel Review comment: Removed the parameters which are not used This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] sakshamverma commented on a change in pull request #346: Bug 64644 add custom properties to close connections on readIdletimeout
sakshamverma commented on a change in pull request #346: URL: https://github.com/apache/tomcat/pull/346#discussion_r479393276 ## File path: java/org/apache/tomcat/websocket/Constants.java ## @@ -114,6 +114,22 @@ // Milliseconds so this is 20 seconds public static final long DEFAULT_BLOCKING_SEND_TIMEOUT = 20 * 1000; +// Configuration for idle read timeout on websocket channel +public static final String WS_READ_IDLE_TIMEOUT = +"org.apache.tomcat.websocket.WS_READ_IDLE_TIMEOUT"; + +// Configuration for idle write timeout on websocket channel +public static final String WS_WRITE_IDLE_TIMEOUT = +"org.apache.tomcat.websocket.WS_WRITE_IDLE_TIMEOUT"; + +// Configuration for idle write timeout on websocket channel Review comment: These were part of initial draft. I intended to remove them. Will do in next commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
