[GitHub] [tomcat] sephiroth-j commented on pull request #311: support schemes "wss" and "ws" in WsHandshakeRequest.buildRequestUri()

2020-07-07 Thread GitBox


sephiroth-j commented on pull request #311:
URL: https://github.com/apache/tomcat/pull/311#issuecomment-654992932


   you are welcome



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] sephiroth-j commented on pull request #311: support schemes "wss" and "ws" in WsHandshakeRequest.buildRequestUri()

2020-07-02 Thread GitBox


sephiroth-j commented on pull request #311:
URL: https://github.com/apache/tomcat/pull/311#issuecomment-653173711


   i observed the exception in Spring Boot Project with Vaadin with an enabled 
`ForwardedHeaderFilter`. The setup was Traefik as reverse proxy with TLS 
termination forwarding the request from the client to the backend listening on 
plain HTTP. The client starts a websocket request using the URI scheme 
"wss://". Traefik adds the header "X-Forwared-Proto: wss" (_among others_). 
`ForwardedHeaderFilter` alters the scheme property of the `HttpServletRequest` 
to the value from the "X-Forwared-Proto" header. The result is an internal 
server error (500) caused by that `IllegalArgumentException`.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org