[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools

DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1291438441 Awesome, thanks much for the feedback! It's a much better PR for it. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools

DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1289917738 All done here @aooohan. Let me know if there's anything else you'd like changed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools

DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1289903755 Great, I'll make those changes! > BTW, for the use of migrators, I believe that a task should correspond to a migrator, rather than one migrator being used

[GitHub] [tomcat-jakartaee-migration] DanielThomas commented on pull request #36: Improve composability when using from other tools

DanielThomas commented on PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#issuecomment-1288624526 The migrator was stateless in terms of the result, so I figured that was a goal, which is why I went with method returns. Would this method throw if execute()