[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...
Github user solomax commented on the issue: https://github.com/apache/tomcat/pull/122 @markt-asf ping :) --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...
Github user martin-g commented on the issue: https://github.com/apache/tomcat/pull/122 s/edge/age/ --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...
Github user bitstorm commented on the issue: https://github.com/apache/tomcat/pull/122 To me specs are a little contradictory about this. They state that the default value is JSESSIONID but at the same time they allow to return a null if a custom value is not set for this parameter. Since ApplicationSessionCookieConfig already exposes a default value for max edge it would be nice to do the same for session cookie name and don't leave the responsibility for handling this situation to application code. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...
Github user solomax commented on the issue: https://github.com/apache/tomcat/pull/122 +1 no-one like NPE :) --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...
Github user martin-g commented on the issue: https://github.com/apache/tomcat/pull/122 There is also nothing that says not to do it. The question is which behavior is better. IMO returning the actual value that is in use is much better than `null`. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/122 There is nothing in the spec that says Tomcat is required to do that. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...
Github user martin-g commented on the issue:
https://github.com/apache/tomcat/pull/122
The new question is "Should Tomcat call `#setName("JSESSIONID")` during
start of an application (just after creation of `SessionCookieConfig`) ?" With
the current behavior every application/framework should make checks for `null`
and assume `JSESSIONID`.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...
Github user bitstorm commented on the issue: https://github.com/apache/tomcat/pull/122 @kkolinko Thank you for the clarification! --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/122 Closing the PR as the requested change is not correct. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #122: Added a default value for ApplicationSessionCookieConfig#...
Github user kkolinko commented on the issue: https://github.com/apache/tomcat/pull/122 The javadoc that you linked https://docs.oracle.com/javaee/7/api/javax/servlet/SessionCookieConfig.html says "Returns: [...] or null if setName(java.lang.String) was never called" Thus it documents null as the default value. BTW, the cookie name can be overwritten by sessionCookieName attribute on Context, http://tomcat.apache.org/tomcat-9.0-doc/config/context.html#Common_Attributes --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
