Re: [PR] Make Cluster digester rules fully conditional on ha and tribes JARs [tomcat]
dsoumis merged PR #1021: URL: https://github.com/apache/tomcat/pull/1021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Make Cluster digester rules fully conditional on ha and tribes JARs [tomcat]
csutherl commented on PR #1021: URL: https://github.com/apache/tomcat/pull/1021#issuecomment-4660644087 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Make Cluster digester rules fully conditional on ha and tribes JARs [tomcat]
ChristopherSchultz commented on PR #1021: URL: https://github.com/apache/tomcat/pull/1021#issuecomment-4660601283 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] Make Cluster digester rules fully conditional on ha and tribes JARs [tomcat]
dsoumis opened a new pull request, #1021: URL: https://github.com/apache/tomcat/pull/1021 The ObjectCreate rules for the element were registered unconditionally in EngineRuleSet and HostRuleSet, while the child element rules in ClusterRuleSet were already guarded behind a try/catch in Catalina.addClusterRuleSet(). This caused a NoClassDefFoundError crash when catalina-tribes.jar was removed but catalina-ha.jar was present and was enabled in server.xml. Move the Cluster element rules into addClusterRuleSet() alongside the child element rules, and add a probe for tribes availability. Either both JARs are present and clustering works, or the element is ignored with an INFO log. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
