RE: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk
> -Original Message- > From: Huxing Zhang [mailto:huxing@alibaba-inc.com] > Sent: Friday, September 23, 2016 12:58 PM > To: Tomcat Developers List <dev@tomcat.apache.org>; gavin > <ga...@16degrees.com.au> > Subject: Re: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk > > Hi Gavin, > > Please file the patch to trunk, and it will be backported to 8.5.x, 8.x if > possible. That isn’t what I meant. There are 3 patches , one for trunk, one for 8.0 and one for 8.5 - they are all the same file. but have different tweaks made to them. There is nothing to backport as such. My question was, when filing a Bugzilla Issue - which Product do I use - I'm going to use 'Tomcat8' as that is the closest match and it gives me more Components to choose from - 'Documentation' being wrong but still the closest thing to what my patch is about so using that. (To be clear the rat-excludes file being patched in all 3 versions does not get included in any release) I created Bug 60170 HTH Gav... > > -- > From:Gavin McDonald <ga...@16degrees.com.au> > Time:2016 Sep 23 (Fri) 07:17 > To:Tomcat Developers List <dev@tomcat.apache.org> > Subject:RE: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk > > > > > > -Original Message- > > From: Christopher Schultz [mailto:ch...@christopherschultz.net] > > Sent: Friday, September 23, 2016 3:25 AM > > To: Tomcat Developers List <dev@tomcat.apache.org> > > Subject: Re: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk > > > > Gavin, > > > > On 9/22/16 1:03 AM, Gavin McDonald wrote: > > > Please find attached 3 patches for tweaks to the rat-excludes file > > > in trunk and the 8.0 and 8.5 branches. > > > > > > RAT tests are currently producing invalid xml reports due to files > > > that should be excluded (and therefore xml parser cant convert to > > > html for pretty reports etc) > > > > > > HTH > > > > > > Gav... > > > > The attachment(s) must have been stripped. > > Yeah I noticed :( > > > Would you like to file a BZ issue > > and attach to that? > > Sure, not sure what component to put it under. Ideas ? > > The patches affect versions 8, 8.5 and trunk , which version do you want me > to use? > > Thanks > > Gav... > > > > > -chris > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional > commands, e-mail: dev-h...@tomcat.apache.org > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional > commands, e-mail: dev-h...@tomcat.apache.org > > > > - > No virus found in this message. > Checked by AVG - www.avg.com > Version: 2016.0.7640 / Virus Database: 4656/13064 - Release Date: 09/22/16 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk
Hi Gavin, Please file the patch to trunk, and it will be backported to 8.5.x, 8.x if possible. -- From:Gavin McDonald <ga...@16degrees.com.au> Time:2016 Sep 23 (Fri) 07:17 To:Tomcat Developers List <dev@tomcat.apache.org> Subject:RE: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk > -Original Message- > From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Sent: Friday, September 23, 2016 3:25 AM > To: Tomcat Developers List <dev@tomcat.apache.org> > Subject: Re: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk > > Gavin, > > On 9/22/16 1:03 AM, Gavin McDonald wrote: > > Please find attached 3 patches for tweaks to the rat-excludes file in > > trunk and the 8.0 and 8.5 branches. > > > > RAT tests are currently producing invalid xml reports due to files > > that should be excluded (and therefore xml parser cant convert to html > > for pretty reports etc) > > > > HTH > > > > Gav... > > The attachment(s) must have been stripped. Yeah I noticed :( > Would you like to file a BZ issue > and attach to that? Sure, not sure what component to put it under. Ideas ? The patches affect versions 8, 8.5 and trunk , which version do you want me to use? Thanks Gav... > > -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk
> -Original Message- > From: Christopher Schultz [mailto:ch...@christopherschultz.net] > Sent: Friday, September 23, 2016 3:25 AM > To: Tomcat Developers List <dev@tomcat.apache.org> > Subject: Re: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk > > Gavin, > > On 9/22/16 1:03 AM, Gavin McDonald wrote: > > Please find attached 3 patches for tweaks to the rat-excludes file in > > trunk and the 8.0 and 8.5 branches. > > > > RAT tests are currently producing invalid xml reports due to files > > that should be excluded (and therefore xml parser cant convert to html > > for pretty reports etc) > > > > HTH > > > > Gav... > > The attachment(s) must have been stripped. Yeah I noticed :( > Would you like to file a BZ issue > and attach to that? Sure, not sure what component to put it under. Ideas ? The patches affect versions 8, 8.5 and trunk , which version do you want me to use? Thanks Gav... > > -chris - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk
Gavin, On 9/22/16 1:03 AM, Gavin McDonald wrote: > Please find attached 3 patches for tweaks to the rat-excludes file in trunk > and the 8.0 and 8.5 branches. > > RAT tests are currently producing invalid xml reports due to files that > should be excluded > (and therefore xml parser cant convert to html for pretty reports etc) > > HTH > > Gav... The attachment(s) must have been stripped. Would you like to file a BZ issue and attach to that? -chris signature.asc Description: OpenPGP digital signature
