Re: [PR] Add a Maven-style test profile system for selective test execution [tomcat]
csutherl merged PR #921: URL: https://github.com/apache/tomcat/pull/921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Add a Maven-style test profile system for selective test execution [tomcat]
csutherl commented on PR #921: URL: https://github.com/apache/tomcat/pull/921#issuecomment-3576606881 I updated the commit to change the `build.properties.test-profiles` to `test-profiles.properties` and fixed all the relevant references. I also add a few more property file settings so that the behavior of `test-profiles.properties` matches `build.properties` and `build.properties.default`. The PR has been open for long enough without objection, so I'll go ahead and commit when I can. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Add a Maven-style test profile system for selective test execution [tomcat]
markt-asf commented on PR #921: URL: https://github.com/apache/tomcat/pull/921#issuecomment-3558507133 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Add a Maven-style test profile system for selective test execution [tomcat]
rmaucher commented on PR #921: URL: https://github.com/apache/tomcat/pull/921#issuecomment-3553692110 The properties file with the profiles look really good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Add a Maven-style test profile system for selective test execution [tomcat]
csutherl commented on PR #921: URL: https://github.com/apache/tomcat/pull/921#issuecomment-3549502978 I forgot to mention that I tried using `$$` expansion to eliminate the need to have the sequential logic in the `build.xml` and define everything in the properties file but that didn't work out and needed additional libraries to do it the way I wanted (antlib's property expansion library, specifically). Any thoughts on how to make the macro a bit nicer and more extendable would be great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
