Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.6
On 02/12/2022 10:24, Mark Thomas wrote: The proposed 1.0.6 release is: [ ] -1: Broken. Do not release because... [X] +1: Acceptable. Go ahead and release. Tomcat 9 examples work on Tomcat 11.0.x when converted at deployment using the shaded JAR. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.6
On 04/12/2022 10:05, Felix Schumacher wrote: Am 02.12.22 um 11:24 schrieb Mark Thomas: The proposed Apache Tomcat migration tool for Jakarta EE 1.0.6 is now available for voting. The significant changes since 1.0.5 are: - Correct regression in handling of javax.annotation package introduced in 1.0.5. PR provided by Danny Thomas. - Allow parallel use of ClassConverter. PR provided by Danny Thomas. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.6/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1411/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.6 3339fc418974bd5ce3432ea9503abda52d96a435 The proposed 1.0.6 release is: [ ] -1: Broken. Do not release because... [x] +1: Acceptable. Go ahead and release. Unit tests run successfully with Java 11 (On Java 8 `mvn verify` fails, which is probably expected, but should not we state this in the pom.xml by setting the source/target to Java 11 instead of 8?) That isn't expected. The tool targets Java 8. Try: mvn clean verify Mark Felix Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.6
Am 02.12.22 um 11:24 schrieb Mark Thomas: The proposed Apache Tomcat migration tool for Jakarta EE 1.0.6 is now available for voting. The significant changes since 1.0.5 are: - Correct regression in handling of javax.annotation package introduced in 1.0.5. PR provided by Danny Thomas. - Allow parallel use of ClassConverter. PR provided by Danny Thomas. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.6/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1411/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.6 3339fc418974bd5ce3432ea9503abda52d96a435 The proposed 1.0.6 release is: [ ] -1: Broken. Do not release because... [x] +1: Acceptable. Go ahead and release. Unit tests run successfully with Java 11 (On Java 8 `mvn verify` fails, which is probably expected, but should not we state this in the pom.xml by setting the source/target to Java 11 instead of 8?) Felix Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org OpenPGP_0xEA6C3728EA91C4AF.asc Description: OpenPGP public key OpenPGP_signature Description: OpenPGP digital signature
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.6
> On Dec 2, 2022, at 18:24, Mark Thomas wrote: > > The proposed Apache Tomcat migration tool for Jakarta EE 1.0.6 is now > available for voting. > > The significant changes since 1.0.5 are: > > - Correct regression in handling of javax.annotation package introduced > in 1.0.5. PR provided by Danny Thomas. > > - Allow parallel use of ClassConverter. PR provided by Danny Thomas. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.6/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1411/ > > The tag is: > https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.6 > 3339fc418974bd5ce3432ea9503abda52d96a435 > > The proposed 1.0.6 release is: > > [ ] -1: Broken. Do not release because… > [X ] +1: Acceptable. Go ahead and release. Han > > Thanks, > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.6
On Fri, Dec 2, 2022 at 11:24 AM Mark Thomas wrote: > > The proposed Apache Tomcat migration tool for Jakarta EE 1.0.6 is now > available for voting. > > The significant changes since 1.0.5 are: > > - Correct regression in handling of javax.annotation package introduced >in 1.0.5. PR provided by Danny Thomas. > > - Allow parallel use of ClassConverter. PR provided by Danny Thomas. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.6/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1411/ > > The tag is: > https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.6 > 3339fc418974bd5ce3432ea9503abda52d96a435 > > The proposed 1.0.6 release is: > > [ ] -1: Broken. Do not release because... > [X] +1: Acceptable. Go ahead and release. Tested with examples webapp from Tomcat 9. Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
