Re: [VOTE] Release Apache Tomcat 7.0.107

2020-11-23 Thread Mark Thomas 
On 23/11/2020 13:29, Konstantin Kolinko wrote:

> 1. Configuration of HttpHeaderSecurityFilter in examples is broken -
> it is missing a
> true
> As such, all async examples stopped working, failing with error 500.

Good catch. The other versions are affected as well. I've committed a fix.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.107

2020-11-23 Thread Konstantin Kolinko 
ср, 18 нояб. 2020 г. в 16:00, Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.107 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.107/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1286/
> The git tag is:
> https://github.com/apache/tomcat/tree/7.0.107
> b4237e4390895ad8880c7bf6a96ca2fdc2cd8507
>
> The proposed 7.0.107 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 7.0.107 Stable

1. Configuration of HttpHeaderSecurityFilter in examples is broken -
it is missing a
true
As such, all async examples stopped working, failing with error 500.
[[[
java.lang.IllegalStateException: A filter or servlet of the current
chain does not support asynchronous operations.
org.apache.catalina.connector.Request.startAsync(Request.java:1726)
org.apache.catalina.connector.Request.startAsync(Request.java:1719)
org.apache.catalina.connector.RequestFacade.startAsync(RequestFacade.java:1022)
async.Async0.service(Async0.java:44)
javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
org.apache.catalina.filters.HttpHeaderSecurityFilter.doFilter(HttpHeaderSecurityFilter.java:126)
]]]

Not a showstopper, but ugly.

2. Unit tests - OK. Tested on Windows 10,
Java 6u45, 7u80 (32-bit, Oracle)
Java 8u275, 11.0.9. (64-bit, AdoptOpenJDK), Java 15.0.1 (64-bit,
OpenJDK). (running only, code was compiled with Java 6/7 earlier).

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.107

2020-11-23 Thread Violeta Georgieva 
На ср, 18.11.2020 г. в 15:00 Violeta Georgieva 
написа:
>
> The proposed Apache Tomcat 7.0.107 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.107/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1286/
> The git tag is:
> https://github.com/apache/tomcat/tree/7.0.107
> b4237e4390895ad8880c7bf6a96ca2fdc2cd8507
>
> The proposed 7.0.107 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.107 Stable

+1

Regards,
Violeta

>

Re: [VOTE] Release Apache Tomcat 7.0.107

2020-11-19 Thread Rémy Maucherat 
On Wed, Nov 18, 2020 at 2:00 PM Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.107 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.107/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1286/
> The git tag is:
> https://github.com/apache/tomcat/tree/7.0.107
> b4237e4390895ad8880c7bf6a96ca2fdc2cd8507
>
> The proposed 7.0.107 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.107 Stable
>
> Rémy

Re: [VOTE] Release Apache Tomcat 7.0.107

2020-11-19 Thread Martin Grigorov 
On Wed, Nov 18, 2020 at 3:00 PM Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.107 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.107/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1286/
> The git tag is:
> https://github.com/apache/tomcat/tree/7.0.107
> b4237e4390895ad8880c7bf6a96ca2fdc2cd8507
>
> The proposed 7.0.107 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 7.0.107 Stable
>

Tested with Apache Wicket 8.x examples application.

Regards,
Martin


>
> Regards,
> Violeta
>