Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Martin Grigorov
Hi,

Broken - do not release.

It seems WebSocket support is broken for Google Chrome 32+.

I tested Apache Wicket integration and it failed with:
WebSocket connection to
'ws://localhost:8080/ws/wicket/websocket?pageId=0wicket-ajax-baseurl=behavior?0'
failed: Invalid UTF-8 sequence in header value

So I tested Tomcat's demo apps:
http://localhost:8080/examples/websocket/echo.xhtml

And I see the same error.

Joakin from Jetty team recently informed me that there is a breaking change
in Chrome's behavior in ver. 32:
https://issues.apache.org/jira/browse/WICKET-5453?focusedCommentId=13853464page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13853464

I run Ubuntu 13.10 and my Chrome version is 32.0.1700.77

Martin Grigorov
Wicket Training and Consulting


On Tue, Jan 28, 2014 at 9:28 PM, Mark Thomas ma...@apache.org wrote:

 The proposed Apache Tomcat 8.0.0 release is now available for voting.

 This is the first non-RC release so I am leaving all the stability
 options open to get an idea of where folks think we currently stand.

 The main changes since RC10 are:
 - Fix broken sendfile support in NIO
 - Add a readOnly option for WebResourceSet
 - Fix the regression in handling ternary expressions
 - Separate out JARs for EL, JSP and WebSocket for embedded
 - Remove svn keywords from source
 - Numerous bug fixes and improvements

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-1002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0/

 The proposed 8.0.0 release is:
 [ ] Broken - do not release
 [ ] Alpha  - go ahead and release as 8.0.0 (alpha)
 [ ] Beta   - go ahead and release as 8.0.0 (beta)
 [ ] Stable - go ahead and release as 8.0.0 (stable)

 Cheers,

 Mark

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Rémy Maucherat
2014-01-28 Mark Thomas ma...@apache.org

 The proposed Apache Tomcat 8.0.0 release is now available for voting.

 This is the first non-RC release so I am leaving all the stability
 options open to get an idea of where folks think we currently stand.

 The main changes since RC10 are:
 - Fix broken sendfile support in NIO
 - Add a readOnly option for WebResourceSet
 - Fix the regression in handling ternary expressions
 - Separate out JARs for EL, JSP and WebSocket for embedded
 - Remove svn keywords from source
 - Numerous bug fixes and improvements

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-1002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0/

 The proposed 8.0.0 release is:
 [ ] Broken - do not release
 [ ] Alpha  - go ahead and release as 8.0.0 (alpha)
 [X] Beta   - go ahead and release as 8.0.0 (beta)
 [ ] Stable - go ahead and release as 8.0.0 (stable)


Rémy


Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Mark Thomas
On 29/01/2014 10:11, Martin Grigorov wrote:
 Hi,
 
 Broken - do not release.
 
 It seems WebSocket support is broken for Google Chrome 32+.
 
 I tested Apache Wicket integration and it failed with:
 WebSocket connection to
 'ws://localhost:8080/ws/wicket/websocket?pageId=0wicket-ajax-baseurl=behavior?0'
 failed: Invalid UTF-8 sequence in header value
 
 So I tested Tomcat's demo apps:
 http://localhost:8080/examples/websocket/echo.xhtml
 
 And I see the same error.

Thanks for the report. Tomcat was incorrectly sending back a value of 
rather than not sending the header at all. I've fixed that for 7.0.x and
8.0.x.

I'm currently leaning towards not cancelling the release solely because
of this issue. I think there is value in making 8.0.0 available even if
8.0.1 follows fairly quickly. My main reasoning is that this issue
exists in both 8.0.0-RC10 and 8.0.0 and overall, 8.0.0 is better quality
than 8.0.0.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Martin Grigorov
On Wed, Jan 29, 2014 at 12:37 PM, Mark Thomas ma...@apache.org wrote:

 On 29/01/2014 10:11, Martin Grigorov wrote:
  Hi,
 
  Broken - do not release.
 
  It seems WebSocket support is broken for Google Chrome 32+.
 
  I tested Apache Wicket integration and it failed with:
  WebSocket connection to
 
 'ws://localhost:8080/ws/wicket/websocket?pageId=0wicket-ajax-baseurl=behavior?0'
  failed: Invalid UTF-8 sequence in header value
 
  So I tested Tomcat's demo apps:
  http://localhost:8080/examples/websocket/echo.xhtml
 
  And I see the same error.

 Thanks for the report. Tomcat was incorrectly sending back a value of 
 rather than not sending the header at all. I've fixed that for 7.0.x and
 8.0.x.

 I'm currently leaning towards not cancelling the release solely because
 of this issue. I think there is value in making 8.0.0 available even if
 8.0.1 follows fairly quickly. My main reasoning is that this issue
 exists in both 8.0.0-RC10 and 8.0.0 and overall, 8.0.0 is better quality
 than 8.0.0.


I'm OK with this. I can use Firefox or older Chrome until the next release.
Thanks!



 Mark


 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Rainer Jung
I'm seeing consistent unit test failures in TestAsyncContextImpl when
using APR:

Testcase: testDispatchErrorWithThreadSingleThenComplete took 5.171 sec
Testcase: testDispatchErrorSingleThenComplete took 2.226 sec
Testcase: testTimeoutListenerCompleteNonAsyncDispatch took 2.257 sec
FAILED
Uri: /start, Status: 200, Time: 1005 duration needed = 2900
junit.framework.AssertionFailedError: Uri: /start, Status: 200, Time:
1005 duration needed = 2900
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:85)
at
org.apache.catalina.core.TestAsyncContextImpl.doTestTimeout(TestAsyncContextImpl.java:523)
at
org.apache.catalina.core.TestAsyncContextImpl.testTimeoutListenerCompleteNonAsyncDispatch(TestAsyncContextImpl.java:401)

The request is indeed logged as

127.0.0.1 - - 15:23:33.224 GET /start HTTP/1.1 200 96
http-apr-127.0.0.1-auto-3-exec-3 1005

(I have added some info to the access log) and the whole test output
around that request looks pretty simple:

29-Jan-2014 15:23:31.220 INFO [main]
org.apache.catalina.core.AprLifecycleListener.init Loaded APR based
Apache Tomcat Native library 1.1.29 using APR version 1.5.0.
29-Jan-2014 15:23:31.221 INFO [main]
org.apache.catalina.core.AprLifecycleListener.init APR capabilities:
IPv6 [true], sendfile [true], accept filters [false], random [true].
29-Jan-2014 15:23:32.175 INFO [main]
org.apache.catalina.core.AprLifecycleListener.initializeSSL OpenSSL
successfully initialized (OpenSSL 1.0.1f 6 Jan 2014)
29-Jan-2014 15:23:32.178 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
[http-apr-127.0.0.1-auto-3]
29-Jan-2014 15:23:32.180 INFO [main]
org.apache.catalina.core.StandardService.startInternal Starting service
Tomcat
29-Jan-2014 15:23:32.180 INFO [main]
org.apache.catalina.core.StandardEngine.startInternal Starting Servlet
Engine: Apache Tomcat/8.0.X-rXX-dev
29-Jan-2014 15:23:32.210 INFO [main]
org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
[http-apr-127.0.0.1-auto-3-51922]
29-Jan-2014 15:23:33.326 INFO [main]
org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler
[http-apr-127.0.0.1-auto-3-51922]
29-Jan-2014 15:23:33.377 INFO [main]
org.apache.catalina.core.StandardService.stopInternal Stopping service
Tomcat
29-Jan-2014 15:23:33.392 INFO [main]
org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler
[http-apr-127.0.0.1-auto-3-51922]
29-Jan-2014 15:23:33.459 INFO [main]
org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler
[http-apr-127.0.0.1-auto-3-51922]


so only startup and - after 1 second - shutdown messages.

After that failure, more show up, I have just looked at this first one.

Testcase: testTimeoutListenerNoCompleteAsyncDispatch took 5.049 sec
FAILED
Uri: /start, Status: 200, Time: 4006 duration needed = 5900
junit.framework.AssertionFailedError: Uri: /start, Status: 200, Time:
4006 duration needed = 5900
at
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:85)
at
org.apache.catalina.core.TestAsyncContextImpl.doTestTimeout(TestAsyncContextImpl.java:523)
at
org.apache.catalina.core.TestAsyncContextImpl.testTimeoutListenerNoCompleteAsyncDispatch(TestAsyncContextImpl.java:420)

Testcase: testDispatchErrorWithThreadMultiple took 1.453 sec
Testcase: testDispatchErrorMultiple took 1.123 sec
Testcase: testDispatchMultiple took 2.239 sec
Testcase: testBug49528 took 2.47 sec
FAILED
expected:OK but was:null
junit.framework.AssertionFailedError: expected:OK but was:null
at
org.apache.catalina.core.TestAsyncContextImpl.testBug49528(TestAsyncContextImpl.java:93)

Testcase: testBug49567 took 1.665 sec
FAILED
expected:OK but was:null
junit.framework.AssertionFailedError: expected:OK but was:null
at
org.apache.catalina.core.TestAsyncContextImpl.testBug49567(TestAsyncContextImpl.java:131)

Testcase: testBug50352 took 1.822 sec
FAILED
expected:[Runnable]-onComplete- but was:[onTimeout]-onComplete-
junit.framework.AssertionFailedError: expected:[Runnable]-onComplete-
but was:[onTimeout]-onComplete-
at
org.apache.catalina.core.TestAsyncContextImpl.testBug50352(TestAsyncContextImpl.java:1032)


and some more.


Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Rossen Stoyanchev
I can confirm that the issue with the empty Sec-WebSocket-Protocol header
also affects Chrome 31.0.1650.63.

The actual issue appears as an Invalid UTF-8 sequence in header value
message in the Chrome dev tool. Although I had read what Martin reported
for Chrome 32, I couldn't confirm it's the same issue since I'm on Chrome
31 and the dev tools don't even show the response headers and Firefox for
some reason doesn't show the empty header. I had to use Wireshark to
confirm it's the same issue.

A (non-binding) vote not to release this way. This a pretty bad first-time
user experience for anyone who tries 8.0.

Rossen


Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Yoav Shapira
On Wed, Jan 29, 2014 at 9:55 AM, Rossen Stoyanchev
rstoyanc...@gopivotal.com wrote:
 I can confirm that the issue with the empty Sec-WebSocket-Protocol header
 also affects Chrome 31.0.1650.63.

I haven't tested 8.0.0 myself yet, but if it's broken on Chrome 31,
that's a far bigger problem than Chrome 32:
http://www.netmarketshare.com/browser-market-share.aspx?qprid=2qpcustomd=0.

Yoav



 The actual issue appears as an Invalid UTF-8 sequence in header value
 message in the Chrome dev tool. Although I had read what Martin reported
 for Chrome 32, I couldn't confirm it's the same issue since I'm on Chrome
 31 and the dev tools don't even show the response headers and Firefox for
 some reason doesn't show the empty header. I had to use Wireshark to
 confirm it's the same issue.

 A (non-binding) vote not to release this way. This a pretty bad first-time
 user experience for anyone who tries 8.0.

 Rossen

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Brian Clozel
I've reproduced this issue with Chrome 32.0.1700.102 and Chrome canary
34.0.1811.0.

Chrome 32 is already mainstream anyway (thanks evergreen browsers):
http://clicky.com/marketshare/global/web-browsers/google-chrome/

--
Brian Clozel


On Wed, Jan 29, 2014 at 4:38 PM, Yoav Shapira yo...@apache.org wrote:

 On Wed, Jan 29, 2014 at 9:55 AM, Rossen Stoyanchev
 rstoyanc...@gopivotal.com wrote:
  I can confirm that the issue with the empty Sec-WebSocket-Protocol header
  also affects Chrome 31.0.1650.63.

 I haven't tested 8.0.0 myself yet, but if it's broken on Chrome 31,
 that's a far bigger problem than Chrome 32:
 http://www.netmarketshare.com/browser-market-share.aspx?qprid=2qpcustomd=0
 .

 Yoav


 
  The actual issue appears as an Invalid UTF-8 sequence in header value
  message in the Chrome dev tool. Although I had read what Martin reported
  for Chrome 32, I couldn't confirm it's the same issue since I'm on Chrome
  31 and the dev tools don't even show the response headers and Firefox for
  some reason doesn't show the empty header. I had to use Wireshark to
  confirm it's the same issue.
 
  A (non-binding) vote not to release this way. This a pretty bad
 first-time
  user experience for anyone who tries 8.0.
 
  Rossen

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Mark Thomas
On 29/01/2014 14:32, Rainer Jung wrote:
 I'm seeing consistent unit test failures in TestAsyncContextImpl when
 using APR:

I can reproduce these and have hopefully found a fix. This is a serious
enough regression (async timeouts are broken in some cases) to justify
dropping 8.0.0 and tagging 8.0.1.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Konstantin Kolinko
2014-01-29 Mark Thomas ma...@apache.org:
 The proposed Apache Tomcat 8.0.0 release is now available for voting.

(...)

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-1002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0/


By the way,
1. I think Tomcat 8 tags should go into
/tomcat/tc8.0.x/tags/

instead of tomcat/tags.  It is better to move them there earlier.

2. The exe installer has not been signed.

Did you intent to sign it after testing, or that just did not happen?

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-29 Thread Mark Thomas
On 29/01/2014 21:03, Konstantin Kolinko wrote:
 2014-01-29 Mark Thomas ma...@apache.org:
 The proposed Apache Tomcat 8.0.0 release is now available for voting.

 (...)

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-1002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0/

 
 By the way,
 1. I think Tomcat 8 tags should go into
 /tomcat/tc8.0.x/tags/
 
 instead of tomcat/tags.  It is better to move them there earlier.
 
 2. The exe installer has not been signed.
 
 Did you intent to sign it after testing, or that just did not happen?

Hmm. That should have happened automatically. I'll check the results
when I build 8.0.1.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-28 Thread Mark Thomas
On 28/01/2014 20:28, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release is now available for voting.

FYI, the production ASF Jira instance is now running on Tomcat 8.0.0. It
is early days (more like minutes than days) and I have already had to
work around one Jira bug [1]. Apart from that, so far everything looks good.

Mark


[1] https://jira.atlassian.com/browse/JRA-35713

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0

2014-01-28 Thread Henri Gomez
Good to know.

We're still using Tomcat 6 to host Jira and Confluence and I wasn't
aware Tomcat 7 and soon Tomcat 8 could be used.
Thanks for the clue.

I'll test Tomcat 8 on a bunch of common CI apps and will told you.

Cheers

2014-01-29 Mark Thomas ma...@apache.org:
 On 28/01/2014 20:28, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release is now available for voting.

 FYI, the production ASF Jira instance is now running on Tomcat 8.0.0. It
 is early days (more like minutes than days) and I have already had to
 work around one Jira bug [1]. Apart from that, so far everything looks good.

 Mark


 [1] https://jira.atlassian.com/browse/JRA-35713

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-26 Thread Mark Thomas
On 24/12/2013 23:42, Rainer Jung wrote:
 On 19.12.2013 19:38, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.

As always, many thanks for the detailed review.

   - One special observation in unit tests: Test
 org.apache.catalina.core.TestDefaultInstanceManager throws 3
 NullPointerExceptions, that seem to indicate a broken test (see below).

Fixed.

   - JMX shows that websocket filter is configured for all default apps.
 I didn't check, where this comes from, but should it really be
 active by default?

It is working as designed - whether the design is right is a different
question. I have a TODO to provide a container specific way to disable
unwanted SCIs on a per context basis.


   - MBeans Catalina:context=/...,host=localhost,type=WebResourceRoot
 and
 Catalina:context=/...,host=localhost,name=Cache,type=WebResourceRoot
 very similar in name (same type).
 All of the numeric data moved from the first to the second
 (plus additional interesting data in the second), in the first it
 is only left traceLockedFiles, stateName, cachingAllowed,
 traceResources and allowLinking which is all boolean or enum type.
 Should we make the two MBeans differ by type?

My primary motivation here was to a) move all the caching attributes to
a new JMX object and b) have the cache appear as a sub-object to the
resources when using JConsole with default options. I'm happy with any
tweaks folks want to make as long as those two requirements are met.

   - Same MBean: new attributes traceLockedFiles (boolean) and
 traceResources (Array): should the second be named tracedResources
 (additional d) to distinguish the Array list of resources from the
 boolean to trace or not to trace switch?

I need to do some clean-up here. I also need to align attribute names
between the Context and the Cache. This is on my TODO list for the next
release.

Thanks again,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-24 Thread Rainer Jung
On 19.12.2013 19:38, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/
 
 The proposed 8.0.0-RC10 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC10 alpha

+1 as alpha.

Overview:

  - One special observation in unit tests: Test
org.apache.catalina.core.TestDefaultInstanceManager throws 3
NullPointerExceptions, that seem to indicate a broken test (see below).

  - JMX shows that websocket filter is configured for all default apps.
I didn't check, where this comes from, but should it really be
active by default?

  - MBeans Catalina:context=/...,host=localhost,type=WebResourceRoot
and
Catalina:context=/...,host=localhost,name=Cache,type=WebResourceRoot
very similar in name (same type).
All of the numeric data moved from the first to the second
(plus additional interesting data in the second), in the first it
is only left traceLockedFiles, stateName, cachingAllowed,
traceResources and allowLinking which is all boolean or enum type.
Should we make the two MBeans differ by type?

  - Same MBean: new attributes traceLockedFiles (boolean) and
traceResources (Array): should the second be named tracedResources
(additional d) to distinguish the Array list of resources from the
boolean to trace or not to trace switch?

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag
- builds fine but
  - Very few warnings about unsafe or unchecked operations,
a little less than for RC5.
See full list at end of mail.
- build result looks consistent with binaries
- no checkstyle complaints
- no Javadoc warnings
- No unit test failures, great!
- Warnings a bit lower than RC 5, errors and exception counts during
  unit tests higher than for RC 5, mostly in
TestHostConfigAutomaticDeployment.

- JMX MBean-Comparison with RC 5:
  - 5 new MBeans
Catalina:context=/...,host=localhost,name=Cache,type=WebResourceRoot
  - Old MBeans Catalina:context=/...,host=localhost,type=WebResourceRoot
dropped attributes cacheMaxObjectSize, cacheTtl and cacheMaxSize
moved to the new MBean, attributes objectName and domain completely
removed, attributes traceLockedFiles (boolean) and
traceResources (Array) added.
  - ordering of tokens in ObjectName and attributes objectName,
children and servlets changed to be more logical
  - some filter name changes
- from org.apache.tomcat.websocket.server.WsFilter to
  Tomcat WebSocket (JSR356) Filter
- from Timing filter to Timing Filter (upper case f)
  - MBean j2eeType=WebModule removed attribute antiJARLocking,
added attribute tldValidation with value false
  - MBean ThreadPool added attribute executorTerminationTimeoutMillis
with value 5000
  - MBean WebappClassLoader removed attributes jarPath and
antiJARLocking
For the examples webapp also changed order of URLs
(jstl.jar and standard.jar switched position)
  - MBean Loader attribute loaderRepositoriesString simple path names
like /WEB-INF/classes/ changed to file URLs like
file:/.../output/build/webapps/examples/WEB-INF/classes/.
The same in the loaderRepositories array.
  - MBean OperatingSystem attribute OpenFileDescriptorCount up
from 86 to 87


Build and tests were done using Java 1.7.0_45. OS was Solaris 10 Sparc,
tcnative was 1.1.29 based on APR 1.4.8 and OpenSSL 1.0.1e (plus a few
patches).


Maybe broken test org.apache.catalina.core.TestDefaultInstanceManager
=

Running org.apache.catalina.core.TestDefaultInstanceManager
20-Dec-2013 11:08:00.021 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
[http-bio-127.0.0.1-auto-1]
20-Dec-2013 11:08:00.125 INFO [main]
org.apache.catalina.core.StandardService.startInternal Starting service
Tomcat
20-Dec-2013 11:08:00.126 INFO [main]

Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-23 Thread Konstantin Kolinko
2013/12/23 Andrew Carr andrewlanec...@gmail.com:
 Wine not found??  im on a headless server, what did i do wrong?  See
 error below...

 Clean setup to test:

 Fresh VM with Ubuntu 13.10 64 bit server
 Apache Ant(TM) version 1.9.2 compiled on July 14 2013
 OpenJDK Runtime Environment (IcedTea 2.3.12) (7u25-2.3.12-4ubuntu3)
 fresh checkout of 8_0_0RC10

 [X] Broken - do not release
 [] Alpha - go ahead and release as 8.0.0-RC10 alpha



 BUILD FAILED
 /home/support/TOMCAT_8_0_0_RC10/build.xml:2011: Execute failed:
 java.io.IOException: Cannot run program wine (in directory

You cannot build a Windows Installer on an Unix system without wine.
(The installer is built by NSIS which is a Windows executable).

You can skip the step by setting skip.installer property in Ant configuration.
(This option is not mentioned in BUILDING.txt though).

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-23 Thread Andrew Carr
Hello Konstantin,

Thank you very much for the reply.  I understand what Wine is and why
you can't build the installer without it.  What I don't understand is
why the configuration tries to build it by default.  Wine is not a
prerequesite in the documentation.  Maybe the default build.properties
should contain the skip.installer=true.

Also, retrying the build right now.

Thank you again,
Andrew Carr

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-23 Thread Mark Thomas
On 23/12/2013 14:54, Andrew Carr wrote:
 Hello Konstantin,
 
 Thank you very much for the reply.  I understand what Wine is and why
 you can't build the installer without it.  What I don't understand is
 why the configuration tries to build it by default.

A release build needs to build the Windows installer. Failing if it
can't is intentional so a release manager knows something is wrong (we
used to have all sorts of issues with optional components that failed
silently during a release build).

 Wine is not a prerequesite in the documentation.

That can be fixed.

 Maybe the default build.properties
 should contain the skip.installer=true.

-1, for the reasons stated above.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-23 Thread Andrew Carr
Thank you for the clarification Mark.  That all makes sense.

On Mon, Dec 23, 2013 at 10:08 AM, Mark Thomas ma...@apache.org wrote:
 On 23/12/2013 14:54, Andrew Carr wrote:
 Hello Konstantin,

 Thank you very much for the reply.  I understand what Wine is and why
 you can't build the installer without it.  What I don't understand is
 why the configuration tries to build it by default.

 A release build needs to build the Windows installer. Failing if it
 can't is intentional so a release manager knows something is wrong (we
 used to have all sorts of issues with optional components that failed
 silently during a release build).

 Wine is not a prerequesite in the documentation.

 That can be fixed.

 Maybe the default build.properties
 should contain the skip.installer=true.

 -1, for the reasons stated above.

 Mark


 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




-- 
With Regards,
Andrew Carr

e. andrewlanec...@gmail.com
w. andrew.c...@openlogic.com
h. 4235255668
c. 4239489852
a. 101 Francis Drive, Greeneville, TN, 37743

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-22 Thread Andrew Carr
Wine not found??  im on a headless server, what did i do wrong?  See
error below...

Clean setup to test:

Fresh VM with Ubuntu 13.10 64 bit server
Apache Ant(TM) version 1.9.2 compiled on July 14 2013
OpenJDK Runtime Environment (IcedTea 2.3.12) (7u25-2.3.12-4ubuntu3)
fresh checkout of 8_0_0RC10

 [X] Broken - do not release
 [] Alpha - go ahead and release as 8.0.0-RC10 alpha



BUILD FAILED
/home/support/TOMCAT_8_0_0_RC10/build.xml:2011: Execute failed:
java.io.IOException: Cannot run program wine (in directory
/home/support/TOMCAT_8_0_0_RC10/output/dist): error=2, No such file
or directory
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1041)
at java.lang.Runtime.exec(Runtime.java:617)
at 
org.apache.tools.ant.taskdefs.launcher.Java13CommandLauncher.exec(Java13CommandLauncher.java:41)
at org.apache.tools.ant.taskdefs.Execute.launch(Execute.java:428)
at org.apache.tools.ant.taskdefs.Execute.execute(Execute.java:442)
at org.apache.tools.ant.taskdefs.ExecTask.runExecute(ExecTask.java:628)
at org.apache.tools.ant.taskdefs.ExecTask.runExec(ExecTask.java:669)
at org.apache.tools.ant.taskdefs.ExecTask.execute(ExecTask.java:495)
at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
at org.apache.tools.ant.Task.perform(Task.java:348)
at org.apache.tools.ant.Target.execute(Target.java:435)
at org.apache.tools.ant.Target.performTasks(Target.java:456)
at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393)
at org.apache.tools.ant.Project.executeTarget(Project.java:1364)
at 
org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
at org.apache.tools.ant.Project.executeTargets(Project.java:1248)
at org.apache.tools.ant.Main.runBuild(Main.java:851)
at org.apache.tools.ant.Main.startAnt(Main.java:235)
at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280)
at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109)
Caused by: java.io.IOException: error=2, No such file or directory
at java.lang.UNIXProcess.forkAndExec(Native Method)
at java.lang.UNIXProcess.init(UNIXProcess.java:135)
at java.lang.ProcessImpl.start(ProcessImpl.java:130)
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1022)
... 23 more

On Sat, Dec 21, 2013 at 2:21 PM, Violeta Georgieva miles...@gmail.com wrote:
 2013/12/19 Mark Thomas ma...@apache.org

 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/

 The proposed 8.0.0-RC10 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC10 alpha


 Checked with applications that use the new specifications features.
 Regards
 Violeta


 Cheers,

 Mark

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




-- 
With Regards,
Andrew Carr

e. andrewlanec...@gmail.com
w. andrew.c...@openlogic.com
h. 4235255668
c. 4239489852
a. 101 Francis Drive, Greeneville, TN, 37743

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-22 Thread Andrew Carr
My aPologIzes, While ThE build floundered with a fail message, the
output folder dist was intact.   Ran some tests and all appears good.

Still the build failure thingy threw me off.

Flip flopping on my vote =)

 [] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC10 alpha

On Mon, Dec 23, 2013 at 2:35 AM, Andrew Carr andrewlanec...@gmail.com wrote:
 Wine not found??  im on a headless server, what did i do wrong?  See
 error below...

 Clean setup to test:

 Fresh VM with Ubuntu 13.10 64 bit server
 Apache Ant(TM) version 1.9.2 compiled on July 14 2013
 OpenJDK Runtime Environment (IcedTea 2.3.12) (7u25-2.3.12-4ubuntu3)
 fresh checkout of 8_0_0RC10

 [X] Broken - do not release
 [] Alpha - go ahead and release as 8.0.0-RC10 alpha



 BUILD FAILED
 /home/support/TOMCAT_8_0_0_RC10/build.xml:2011: Execute failed:
 java.io.IOException: Cannot run program wine (in directory
 /home/support/TOMCAT_8_0_0_RC10/output/dist): error=2, No such file
 or directory
 at java.lang.ProcessBuilder.start(ProcessBuilder.java:1041)
 at java.lang.Runtime.exec(Runtime.java:617)
 at 
 org.apache.tools.ant.taskdefs.launcher.Java13CommandLauncher.exec(Java13CommandLauncher.java:41)
 at org.apache.tools.ant.taskdefs.Execute.launch(Execute.java:428)
 at org.apache.tools.ant.taskdefs.Execute.execute(Execute.java:442)
 at org.apache.tools.ant.taskdefs.ExecTask.runExecute(ExecTask.java:628)
 at org.apache.tools.ant.taskdefs.ExecTask.runExec(ExecTask.java:669)
 at org.apache.tools.ant.taskdefs.ExecTask.execute(ExecTask.java:495)
 at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
 at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
 at java.lang.reflect.Method.invoke(Method.java:606)
 at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
 at org.apache.tools.ant.Task.perform(Task.java:348)
 at org.apache.tools.ant.Target.execute(Target.java:435)
 at org.apache.tools.ant.Target.performTasks(Target.java:456)
 at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1393)
 at org.apache.tools.ant.Project.executeTarget(Project.java:1364)
 at 
 org.apache.tools.ant.helper.DefaultExecutor.executeTargets(DefaultExecutor.java:41)
 at org.apache.tools.ant.Project.executeTargets(Project.java:1248)
 at org.apache.tools.ant.Main.runBuild(Main.java:851)
 at org.apache.tools.ant.Main.startAnt(Main.java:235)
 at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280)
 at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109)
 Caused by: java.io.IOException: error=2, No such file or directory
 at java.lang.UNIXProcess.forkAndExec(Native Method)
 at java.lang.UNIXProcess.init(UNIXProcess.java:135)
 at java.lang.ProcessImpl.start(ProcessImpl.java:130)
 at java.lang.ProcessBuilder.start(ProcessBuilder.java:1022)
 ... 23 more

 On Sat, Dec 21, 2013 at 2:21 PM, Violeta Georgieva miles...@gmail.com wrote:
 2013/12/19 Mark Thomas ma...@apache.org

 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/

 The proposed 8.0.0-RC10 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC10 alpha


 Checked with applications that use the new specifications features.
 Regards
 Violeta


 Cheers,

 Mark

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




 --
 With Regards,
 Andrew Carr

 e. andrewlanec...@gmail.com
 w. andrew.c...@openlogic.com
 h. 4235255668
 c. 4239489852
 a. 101 Francis Drive, Greeneville, TN, 37743



-- 
With Regards,
Andrew Carr

e. andrewlanec...@gmail.com
w. andrew.c...@openlogic.com
h. 4235255668
c. 4239489852
a. 101 Francis Drive, Greeneville, TN, 37743

-
To unsubscribe, e-mail: 

Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-21 Thread Violeta Georgieva
2013/12/19 Mark Thomas ma...@apache.org

 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/

 The proposed 8.0.0-RC10 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC10 alpha


Checked with applications that use the new specifications features.
Regards
Violeta


 Cheers,

 Mark

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Mark Thomas
On 20/12/2013 01:40, Andrew Carr wrote:
 On Thu, Dec 19, 2013 at 3:04 PM, sebb seb...@gmail.com wrote:
 On 19 December 2013 18:38, Mark Thomas ma...@apache.org wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/

 I get 404 for that URL

 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/

 
 Getting 404 for this page, like sebb, parent folder only shows a rc9 folder

Sorry - looks like the svn commit to replace RC9 with RC10 failed and I
didn't notice. Re-trying now. There will be a commit notification to the
dev list when it is complete.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Jeanfrancois Arcand


On 2013-12-19 1:38 PM, Mark Thomas wrote:


The proposed 8.0.0-RC10 release is:
[ ] Broken - do not release
[X] Alpha - go ahead and release as 8.0.0-RC10 alpha


Tested jsr356  AsyncContext with Atmosphere, no issue.

-- Jeanfrancois




Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Rainer Jung
Can you please add the signature files for
apache-tomcat-8.0.0-RC10.tar.gz and apache-tomcat-8.0.0-RC10.zip. The
other signature files are present, but not for those two files.

Thanks!

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Mark Thomas
On 20/12/2013 12:36, Rainer Jung wrote:
 Can you please add the signature files for
 apache-tomcat-8.0.0-RC10.tar.gz and apache-tomcat-8.0.0-RC10.zip. The
 other signature files are present, but not for those two files.

Done. No idea how they got missed. I'll keep an eye on the next release.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Rémy Maucherat
2013/12/19 Mark Thomas ma...@apache.org

 The proposed 8.0.0-RC10 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC10 alpha

 Rémy


Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-20 Thread Yoav Shapira
On Thu, Dec 19, 2013 at 1:38 PM, Mark Thomas ma...@apache.org wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/

 The proposed 8.0.0-RC10 release is:
 [ ] Broken - do not release
 [ X ] Alpha - go ahead and release as 8.0.0-RC10 alpha

Looks good to me -- home-brewed app, mostly default config.

Yoav

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-19 Thread Mark Thomas
On 19/12/2013 18:38, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/
 
 The proposed 8.0.0-RC10 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC10 alpha

Unit tests pass on Linux, Windows and OSX (all 64-bit, all three connectors)

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-19 Thread Violeta Georgieva
Mark,


2013/12/19 Mark Thomas ma...@apache.org

 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/

I think that there are no artifacts uploaded to dist.apache.org

Regards
Violeta

 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/

 The proposed 8.0.0-RC10 release is:
 [ ] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC10 alpha

 Cheers,

 Mark

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-19 Thread sebb
On 19 December 2013 18:38, Mark Thomas ma...@apache.org wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/

I get 404 for that URL

 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/

The NOTICE  LICENSE files in the source archive mention various 3rd
party items of software that are not actually included in the source
archive.
AIUI, it is vital that the NL files *only* reference the bits that
are actually included in the distribution to which they apply [1]

Also, some of the NOTICE entries look as though they may be
superfluous anyway [2]


[1] http://www.apache.org/dev/licensing-howto.html#step-by-step (see 3.)
[2] http://www.apache.org/dev/licensing-howto.html#mod-notice

 The proposed 8.0.0-RC10 release is:
 [ ] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC10 alpha

 Cheers,

 Mark

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC10

2013-12-19 Thread Andrew Carr
On Thu, Dec 19, 2013 at 3:04 PM, sebb seb...@gmail.com wrote:
 On 19 December 2013 18:38, Mark Thomas ma...@apache.org wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 10 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC10/

 I get 404 for that URL

 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-002/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC10/


Getting 404 for this page, like sebb, parent folder only shows a rc9 folder


-- 
With Regards,
Andrew Carr

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC9

2013-12-18 Thread Rémy Maucherat
2013/12/18 Mark Thomas ma...@apache.org

 The proposed Apache Tomcat 8.0.0 release candidate 9 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC9/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-063/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC9/

 The proposed 8.0.0-RC9 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC9 alpha


Rémy


Re: [VOTE] Release Apache Tomcat 8.0.0-RC9

2013-12-18 Thread Mark Thomas
On 18/12/2013 00:59, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 9 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC9/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-063/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC9/
 
 The proposed 8.0.0-RC9 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC9 alpha

Unit tests pass on 64-bit Windows, Linux and OSX.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC9

2013-12-18 Thread Daniel Mikusa
On Dec 17, 2013, at 7:59 PM, Mark Thomas ma...@apache.org wrote:

 The proposed Apache Tomcat 8.0.0 release candidate 9 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
  tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC9/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-063/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC9/
 
 The proposed 8.0.0-RC9 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC9 alpha

Dan

 
 Cheers,
 
 Mark
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC9

2013-12-18 Thread Jeanfrancois Arcand


On 2013-12-17 7:59 PM, Mark Thomas wrote:


The proposed 8.0.0-RC9 release is:
[X] Broken - do not release
[ ] Alpha - go ahead and release as 8.0.0-RC9 alpha
Atmosphere stopped working with 8.0.0-RC9. With all previous RC from 1 
to 7 it worked (didn't test 8) and websockets properly handled for this 
request


   https://gist.github.com/jfarcand/8023402

You can test it by downloading the .war from here

  http://goo.gl/36PSaz

It seems this line:

container.addEndpoint(ServerEndpointConfig.Builder.create(JSR356Endpoint.class, 
b.toString()).configurator(configurator).build());


has no effect anymore (see: http://goo.gl/POL9Ce).

Ping me if you need more information.

-- Jeanfrancois



Cheers,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC9

2013-12-18 Thread Mark Thomas
On 18/12/2013 14:51, Jeanfrancois Arcand wrote:
 
 On 2013-12-17 7:59 PM, Mark Thomas wrote:

 The proposed 8.0.0-RC9 release is:
 [X] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC9 alpha
 Atmosphere stopped working with 8.0.0-RC9. With all previous RC from 1
 to 7 it worked (didn't test 8) and websockets properly handled for this
 request
 
https://gist.github.com/jfarcand/8023402
 
 You can test it by downloading the .war from here
 
   http://goo.gl/36PSaz
 
 It seems this line:
 
 container.addEndpoint(ServerEndpointConfig.Builder.create(JSR356Endpoint.class,
 b.toString()).configurator(configurator).build());
 
 has no effect anymore (see: http://goo.gl/POL9Ce).
 
 Ping me if you need more information.

That should be enough for me to track this down. The likely culprit is
the change I made to switch to lazy init for WebSocket. I'll take a look.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC8

2013-12-17 Thread Daniel Mikusa
On Dec 17, 2013, at 6:32 AM, Mark Thomas ma...@apache.org wrote:

 The proposed Apache Tomcat 8.0.0 release candidate 8 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
  tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC8/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-052/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC8/
 
 The proposed 8.0.0-RC8 release is:
 [ ] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC8 alpha
 
 Cheers,
 
 Mark

I'm seeing the following error when running with a security manager enabled.

$ cat logs/catalina.out
java.lang.ClassNotFoundException: 
org.apache.tomcat.util.net.AbstractEndpoint$PrivilegedSetTccl
at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
at 
org.apache.catalina.security.SecurityClassLoad.loadTomcatPackage(SecurityClassLoad.java:283)
at 
org.apache.catalina.security.SecurityClassLoad.securityClassLoad(SecurityClassLoad.java:49)
at org.apache.catalina.startup.Bootstrap.init(Bootstrap.java:261)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:456)

Steps to reproduce:

  1.) Download and unzip.
  2.) ./bin/startup.sh -security
  3.) cat logs/catalina.out

Dan

 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC8

2013-12-17 Thread Mark Thomas
On 17/12/2013 14:27, Daniel Mikusa wrote:
 On Dec 17, 2013, at 6:32 AM, Mark Thomas ma...@apache.org wrote:
 
 The proposed Apache Tomcat 8.0.0 release candidate 8 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
  tracking
 - Update to a post Commons Pool 2.0 release snapshot
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Performance improvements
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC8/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-052/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC8/

 The proposed 8.0.0-RC8 release is:
 [ ] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC8 alpha

 Cheers,

 Mark
 
 I'm seeing the following error when running with a security manager enabled.
 
 $ cat logs/catalina.out
 java.lang.ClassNotFoundException: 
 org.apache.tomcat.util.net.AbstractEndpoint$PrivilegedSetTccl
   at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
   at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
   at java.security.AccessController.doPrivileged(Native Method)
   at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
   at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
   at 
 org.apache.catalina.security.SecurityClassLoad.loadTomcatPackage(SecurityClassLoad.java:283)
   at 
 org.apache.catalina.security.SecurityClassLoad.securityClassLoad(SecurityClassLoad.java:49)
   at org.apache.catalina.startup.Bootstrap.init(Bootstrap.java:261)
   at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:456)
 
 Steps to reproduce:
 
   1.) Download and unzip.
   2.) ./bin/startup.sh -security
   3.) cat logs/catalina.out

I know what that is. The fix is easy. RC9 coming up.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-16 Thread Mark Thomas
On 14/12/2013 15:37, Konstantin Preißer wrote:

 If more info is needed to debug the problem, please let me know.

No more info needed at the moment.

I can re-create the problem.

The issues appear to be related to the changes I made to support
non-blocking IO with AJP so they should be limited to Tomcat 8.

Actually, I think there is more than one problem here.

I've fixed the first issue in r1551211.

With that fix I still see corrupted downloads but not the memory leak.
I'm still looking into this.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-16 Thread Mark Thomas
On 16/12/2013 14:07, Mark Thomas wrote:
 On 14/12/2013 15:37, Konstantin Preißer wrote:
 
 If more info is needed to debug the problem, please let me know.
 
 No more info needed at the moment.
 
 I can re-create the problem.

The additional issues I thought I was seeing were user error rather than
a problem. I think the issue is fixed - at least I can't reproduce it
with httpd + mod_proxy_ajp + Tomcat trunk.

It is possible that there is still a bug or two lurking in Tomcat, the
ISAPI Redirector or maybe IIS. Can you retest and let me know how you
get on.

Thanks,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



RE: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-16 Thread Konstantin Preißer
Hi Mark,

 -Original Message-
 From: Mark Thomas [mailto:ma...@apache.org]
 Sent: Monday, December 16, 2013 3:44 PM
 To: Tomcat Developers List
 Subject: Re: [VOTE] Release Apache Tomcat 8.0.0-RC7
 
 On 16/12/2013 14:07, Mark Thomas wrote:
  On 14/12/2013 15:37, Konstantin Preißer wrote:
 
  If more info is needed to debug the problem, please let me know.
 
  No more info needed at the moment.
 
  I can re-create the problem.
 
 The additional issues I thought I was seeing were user error rather than
 a problem. I think the issue is fixed - at least I can't reproduce it
 with httpd + mod_proxy_ajp + Tomcat trunk.
 
 It is possible that there is still a bug or two lurking in Tomcat, the
 ISAPI Redirector or maybe IIS. Can you retest and let me know how you
 get on.

Thanks a lot.

I verified that the problems do not occur any more with trunk r1551211. I also 
verified that they don't occur with Tomcat 7.0.47.


Regards,
Konstantin Preißer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



RE: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-14 Thread Konstantin Preißer
Hi Mark,

 -Original Message-
 From: Mark Thomas [mailto:ma...@apache.org]
 Sent: Thursday, December 12, 2013 12:28 AM


  The proposed 8.0.0-RC7 release is:
  [ ] Broken - do not release
  [ ] Alpha - go ahead and release as 8.0.0-RC7 alpha


While the issue with large static files that I got with 8.0.0-RC6 is now solved 
when using the http (NIO) connector, I got another problem with downloading 
large files on Tomcat 8.0.0-RC7 when using the AJP NIO connector.

I was using IIS 8.5 on Windows Server 2012 R2 with Java 1.7.0_45 x64, and 
configured the ISAPI Redirector 1.2.37 to forward all requests to Tomcat.


1)

I placed a static file with a size of 208,687,239 bytes into a web application. 
If I request this file over Tomcat's HTTP connector, everything works. But if I 
request it over IIS's HTTP connector (which forwards the request to Tomcat over 
AJP), then the first time I get an download dialog in the browser (I canceled 
it), but Tomcat starts to use ~ 100% CPU in one core. If I request the file 
again, I get lots of OOMs in Tomcat's log:


14-Dec-2013 13:09:56.960 SEVERE [ajp-nio-8019-exec-8] 
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun 
 java.lang.OutOfMemoryError: Java heap space
at java.nio.HeapByteBuffer.init(HeapByteBuffer.java:57)
at java.nio.ByteBuffer.allocate(ByteBuffer.java:331)
at 
org.apache.coyote.ajp.AbstractAjpProcessor.addToBuffers(AbstractAjpProcessor.java:1590)
at 
org.apache.coyote.ajp.AbstractAjpProcessor.writeData(AbstractAjpProcessor.java:1582)
at 
org.apache.coyote.ajp.AbstractAjpProcessor.access$200(AbstractAjpProcessor.java:62)
at 
org.apache.coyote.ajp.AbstractAjpProcessor$SocketOutputBuffer.doWrite(AbstractAjpProcessor.java:1724)
at org.apache.coyote.Response.doWrite(Response.java:520)
at 
org.apache.catalina.connector.OutputBuffer.realWriteBytes(OutputBuffer.java:391)
at org.apache.tomcat.util.buf.ByteChunk.flushBuffer(ByteChunk.java:426)
at org.apache.tomcat.util.buf.ByteChunk.append(ByteChunk.java:339)
at 
org.apache.catalina.connector.OutputBuffer.writeBytes(OutputBuffer.java:421)
at 
org.apache.catalina.connector.OutputBuffer.write(OutputBuffer.java:409)
at 
org.apache.catalina.connector.CoyoteOutputStream.write(CoyoteOutputStream.java:97)
at 
org.apache.catalina.servlets.DefaultServlet.copyRange(DefaultServlet.java:1951)
at 
org.apache.catalina.servlets.DefaultServlet.copy(DefaultServlet.java:1791)
at 
org.apache.catalina.servlets.DefaultServlet.serveResource(DefaultServlet.java:919)
at 
org.apache.catalina.servlets.DefaultServlet.doGet(DefaultServlet.java:400)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at 
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at 
org.tuckey.web.filters.urlrewrite.RuleChain.handleRewrite(RuleChain.java:176)
at 
org.tuckey.web.filters.urlrewrite.RuleChain.doRules(RuleChain.java:145)
at 
org.tuckey.web.filters.urlrewrite.UrlRewriter.processRequest(UrlRewriter.java:92)
at 
org.tuckey.web.filters.urlrewrite.UrlRewriteFilter.doFilter(UrlRewriteFilter.java:394)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at 
common.XUaCompatibleHeaderFilter.doFilter(XUaCompatibleHeaderFilter.java:27)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)

14-Dec-2013 13:09:58.694 SEVERE [ajp-nio-8019-ClientPoller-0] 
org.apache.tomcat.util.net.NioEndpoint$Poller.run 
 java.lang.OutOfMemoryError: Java heap space
at 
org.apache.tomcat.util.net.NioEndpoint.reclaimParachute(NioEndpoint.java:313)
at 
org.apache.tomcat.util.net.NioEndpoint.checkParachute(NioEndpoint.java:298)
at 
org.apache.tomcat.util.net.NioEndpoint$Poller.run(NioEndpoint.java:1128)
at java.lang.Thread.run(Thread.java:744)

14-Dec-2013 13:09:58.694 SEVERE [ajp-nio-8019-ClientPoller-1] 
org.apache.tomcat.util.net.NioEndpoint$Poller.run 
 java.lang.OutOfMemoryError: Java heap space
at 
org.apache.tomcat.util.net.NioEndpoint.reclaimParachute(NioEndpoint.java:313)
at 
org.apache.tomcat.util.net.NioEndpoint.checkParachute(NioEndpoint.java:298)
at 

RE: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-14 Thread Konstantin Preißer

 -Original Message-
 From: Konstantin Preißer [mailto:kpreis...@apache.org]
 Sent: Saturday, December 14, 2013 1:53 PM
 To: 'Tomcat Developers List'
 Subject: RE: [VOTE] Release Apache Tomcat 8.0.0-RC7
 
 Hi Mark,
 
  -Original Message-
  From: Mark Thomas [mailto:ma...@apache.org]
  Sent: Thursday, December 12, 2013 12:28 AM
 
 
   The proposed 8.0.0-RC7 release is:
   [ ] Broken - do not release
   [ ] Alpha - go ahead and release as 8.0.0-RC7 alpha
 
 
 While the issue with large static files that I got with 8.0.0-RC6 is now 
 solved
 when using the http (NIO) connector, I got another problem with
 downloading large files on Tomcat 8.0.0-RC7 when using the AJP NIO
 connector.
 
 I was using IIS 8.5 on Windows Server 2012 R2 with Java 1.7.0_45 x64, and
 configured the ISAPI Redirector 1.2.37 to forward all requests to Tomcat.
 
 
 1)
 
 I placed a static file with a size of 208,687,239 bytes into a web 
 application. If I
 request this file over Tomcat's HTTP connector, everything works. But if I
 request it over IIS's HTTP connector (which forwards the request to Tomcat
 over AJP), then the first time I get an download dialog in the browser (I
 canceled it), but Tomcat starts to use ~ 100% CPU in one core. If I request 
 the
 file again, I get lots of OOMs in Tomcat's log:

snip

 2)
 
 I had an issue today morning (also with Tomcat 8.0.0-RC7) where the ISAPI
 Redirector was only serving empty responses (but with correct headers). The
 raw request/response to IIS looked like this:
 
 Request:
 GET / HTTP/1.1
 Host: mydomain.de
 Connection: keep-alive
 
 Response:
 HTTP/1.1 200 OK
 Transfer-Encoding: chunked
 Content-Type: application/xhtml+xml;charset=UTF-8
 Expires: Sat, 01 Jan 2000 00:00:00 GMT
 Server: Microsoft-IIS/8.5
 X-UA-Compatible: IE=edge
 Date: Sat, 14 Dec 2013 10:43:00 GMT
 
 0

OK, I could reproduce both 1) and 2) in a local virtual machine running Windows 
Server 2012 R2, IIS 8.5, ISAPI Redirector 1.2.37 and Tomcat 8.0.0-RC7 with Java 
1.7.0_45 x64.

For 1: I could easily reproduce it by trying to download a ~200 MB file in 
Tomcat's ROOT webapp through IIS a few times.

For 2: I could reproduce this by:

1) Setting the ISAPI redirector to allow chunked encoding, then limiting the 
response buffer for the IsapiModule in IIS to 1 byte by using the following 
web.config (otherwise IIS would buffer the whole response from Tomcat before 
starting to send it to the client):

?xml version=1.0 encoding=UTF-8?
configuration
system.webServer
handlers
remove name=ISAPI-dll /
add name=ISAPI-dll path=*.dll verb=* modules=IsapiModule 
resourceType=File requireAccess=Execute allowPathInfo=true 
responseBufferLimit=1 /
/handlers
/system.webServer
/configuration

2) Placing a ~ 20 MB file in Tomcat's ROOT webapp.

3) Try to download and cancel this zip file with a slow client a few times (I 
used my own Tcp forwarder tool to intercept the TCP connection between Firefox 
and IIS and to slow down the data transfer).

4) After some time, if I now request Tomcat's ROOT index page 
(http://localhost/), I only get a blank page.

A raw request to IIS shows:

GET / HTTP/1.1
Host: local2
Connection: keep-alive

HTTP/1.1 200 OK
Transfer-Encoding: chunked
Content-Type: text/html;charset=UTF-8
Server: Microsoft-IIS/8.5
Date: Sat, 14 Dec 2013 15:30:48 GMT

0

If I do the same request directly to Tomcat's HTTP NIO connector, the response 
is:

GET / HTTP/1.1
Host: local2
Connection: keep-alive

HTTP/1.1 200 OK
Server: Apache-Coyote/1.1
Content-Type: text/html;charset=UTF-8
Transfer-Encoding: chunked
Date: Sat, 14 Dec 2013 15:31:22 GMT

2000



!DOCTYPE html
html lang=en
head
meta charset=UTF-8 /
titleApache Tomcat/8.0.0-RC7/title
link href=favicon.ico rel=icon type=image/x-icon /
link href=favicon.ico rel=shortcut icon type=image/x-icon /
link href=tomcat.css rel=stylesheet type=text/css /
/head
[rest of index.jsp ...]

So it seems the AJP NIO connector is in some weird state, as the HTTP NIO 
connector is working normally, but AJP only shows an empty content.

I then intercepted the AJP conncetion between the ISAPI redirector and Tomcat's 
AJP connector to record the data that was sent and received.

This is the log of sender channel:

[ID 1] Local connection established from 127.0.0.1:49914.
[ID 1] Data - Offset: 0x0, Count: 0x1A0.
12 34 01 9C 02 02 00 08 48 54 54 50 2F 31 2E 31 00 00 01 2F   
.4.œHTTP/1.1.../
00 00 09 31 32 37 2E 30 2E 30 2E 31 00 00 09 31 32 37 2E 30   
...127.0.0.1...127.0
2E 30 2E 31 00 00 06 6C 6F 63 61 6C 32 00 00 50 00 00 08 00   
.0.1...local2..P
0D 43 61 63 68 65 2D 43 6F 6E 74 72 6F 6C 00 00 09 6D 61 78   
.Cache-Control...max
2D 61 67 65 3D 30 00 A0 06 00 0A 6B 65 65 70 2D 61 6C 69 76   -age=0. 
...keep-aliv
65 00 A0 08 00 01 30 00 A0 01 00 3F 74 65 78 74 2F 68 74 6D   e. ...0. 
..?text/htm
6C 2C 61 70 70 6C 69 63 61 74 69 6F 6E 2F 78 68 74 6D 6C 2B   
l,application

Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Violeta Georgieva
2013/12/12 Mark Thomas ma...@apache.org

 The proposed Apache Tomcat 8.0.0 release candidate 7 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to Commons Pool 2.0 release
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC7/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-047/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC6/

 The proposed 8.0.0-RC7 release is:
 [ ] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC7 alpha



I'm receiving NPE when testing an application with jsp that specifies tld
location with relative path:

java.lang.NullPointerException
org.apache.jasper.compiler.TldCache.getTaglibXml(TldCache.java:97)

org.apache.jasper.compiler.TagLibraryInfoImpl.init(TagLibraryInfoImpl.java:150)
org.apache.jasper.compiler.Parser.parseTaglibDirective(Parser.java:411)
org.apache.jasper.compiler.Parser.parseDirective(Parser.java:469)
org.apache.jasper.compiler.Parser.parseElements(Parser.java:1455)
org.apache.jasper.compiler.Parser.parse(Parser.java:139)

org.apache.jasper.compiler.ParserController.doParse(ParserController.java:229)

org.apache.jasper.compiler.ParserController.parse(ParserController.java:100)
org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:200)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:375)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:355)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:342)

org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:557)


Here is a test case that I used:

Index: test/org/apache/jasper/runtime/TestPageContextImpl.java
===
--- test/org/apache/jasper/runtime/TestPageContextImpl.java (revision 
1549955)
+++ test/org/apache/jasper/runtime/TestPageContextImpl.java (working copy)
@@ -50,4 +50,19 @@
 Assert.assertTrue(body.contains(OK));
 Assert.assertFalse(body.contains(FAIL));
 }
+
+@Test
+public void testRelativeTldLocation() throws Exception {
+Tomcat tomcat = getTomcatInstance();
+
+File appDir = new File(test/webapp);
+tomcat.addWebapp(null, /test, appDir.getAbsolutePath());
+
+tomcat.start();
+
+ByteChunk res = new ByteChunk();
+
+int rc = getUrl(http://localhost:; + getPort() +
+/test/jsp/test.jsp, res, null);
+}
 }
Index: test/webapp/jsp
===
--- test/webapp/jsp (revision 0)
+++ test/webapp/jsp (working copy)

Property changes on: test/webapp/jsp
___
Added: bugtraq:label
## -0,0 +1 ##
+Bugzilla ID (optional)
\ No newline at end of property
Added: bugtraq:url
## -0,0 +1 ##
+https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID%
\ No newline at end of property
Added: bugtraq:message
## -0,0 +1 ##
+Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID%
\ No newline at end of property
Added: bugtraq:append
## -0,0 +1 ##
+false
\ No newline at end of property
Index: test/webapp/jsp/test.jsp
===
--- test/webapp/jsp/test.jsp(revision 0)
+++ test/webapp/jsp/test.jsp(working copy)
@@ -0,0 +1,2 @@
+%@ page contentType=text/plain %
+%@ taglib uri=../WEB-INF/test.tld prefix=test %
\ No newline at end of file
Index: test/webapp/jsp/test.jsp
===
--- test/webapp/jsp/test.jsp(revision 0)
+++ test/webapp/jsp/test.jsp(working copy)

Property changes on: test/webapp/jsp/test.jsp
___
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property


Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Rémy Maucherat
2013/12/13 Violeta Georgieva miles...@gmail.com

 I'm receiving NPE when testing an application with jsp that specifies tld
 location with relative path:

 java.lang.NullPointerException
 org.apache.jasper.compiler.TldCache.getTaglibXml(TldCache.java:97)

 org.apache.jasper.compiler.TagLibraryInfoImpl.init(TagLibraryInfoImpl.java:150)

 org.apache.jasper.compiler.Parser.parseTaglibDirective(Parser.java:411)
 org.apache.jasper.compiler.Parser.parseDirective(Parser.java:469)
 org.apache.jasper.compiler.Parser.parseElements(Parser.java:1455)
 org.apache.jasper.compiler.Parser.parse(Parser.java:139)

 org.apache.jasper.compiler.ParserController.doParse(ParserController.java:229)

 org.apache.jasper.compiler.ParserController.parse(ParserController.java:100)
 org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:200)
 org.apache.jasper.compiler.Compiler.compile(Compiler.java:375)
 org.apache.jasper.compiler.Compiler.compile(Compiler.java:355)
 org.apache.jasper.compiler.Compiler.compile(Compiler.java:342)

 org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:557)

 There used to be some normalization code for the taglib uri, like uri =
RequestUtil.normalize(uri); in TagLibraryInfoImpl.generateTLDLocation (now
generateTldResourcePath), and since the uri is used to match the catch
entry, I don't see how it can work without it. I'll add it back.

Rémy


Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Violeta Georgieva
2013/12/12 Mark Thomas ma...@apache.org

 The proposed Apache Tomcat 8.0.0 release candidate 7 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to Commons Pool 2.0 release
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC7/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-047/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC6/

 The proposed 8.0.0-RC7 release is:
 [ ] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC7 alpha


I found another issue:
If a tag file is placed in a jar file in WEB-INF/lib and then is used, the
following exception appears:

org.apache.jasper.JasperException: Illegal tag file path:
/META-INF/tags/my.tag, must start with /WEB-INF/tags or /META-INF/tags
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:56)
org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:278)
org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:76)

org.apache.jasper.compiler.TagLibraryInfoImpl.createTagFileInfo(TagLibraryInfoImpl.java:287)
  
org.apache.jasper.compiler.TagLibraryInfoImpl.init(TagLibraryInfoImpl.java:171)
org.apache.jasper.compiler.Parser.parseTaglibDirective(Parser.java:411)
org.apache.jasper.compiler.Parser.parseDirective(Parser.java:469)
org.apache.jasper.compiler.Parser.parseElements(Parser.java:1455)
org.apache.jasper.compiler.Parser.parse(Parser.java:139)
org.apache.jasper.compiler.ParserController.doParse(ParserController.java:229)
org.apache.jasper.compiler.ParserController.parse(ParserController.java:100)
org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:200)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:375)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:355)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:342)
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:557)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357)


The change in the code is introduced with r1541960

Besides that the message is wrong because we check only for WEB-INF/tags
[1], what should be done in addition?

[1]
org.apache.jasper.compiler.TagLibraryInfoImpl.createTagFileInfo(TagFileXml,
Jar)

286} else if (!path.startsWith(/WEB-INF/tags)) {
287err.jspError(jsp.error.tagfile.illegalPath, path);
288}


Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Rémy Maucherat
2013/12/13 Violeta Georgieva miles...@gmail.com

 I found another issue:
 If a tag file is placed in a jar file in WEB-INF/lib and then is used, the
 The change in the code is introduced with r1541960

 Besides that the message is wrong because we check only for WEB-INF/tags
 [1], what should be done in addition?

 [1]
 org.apache.jasper.compiler.TagLibraryInfoImpl.createTagFileInfo(TagFileXml,
 Jar)

 286} else if (!path.startsWith(/WEB-INF/tags)) {
 287err.jspError(jsp.error.tagfile.illegalPath, path);
 288}


It looks like the condition was not refactored correctly.

Rémy


Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Mark Thomas
On 13/12/2013 14:35, Rémy Maucherat wrote:
 2013/12/13 Violeta Georgieva miles...@gmail.com
 
 I found another issue:
 If a tag file is placed in a jar file in WEB-INF/lib and then is used, the
 The change in the code is introduced with r1541960

 Besides that the message is wrong because we check only for WEB-INF/tags
 [1], what should be done in addition?

 [1]
 org.apache.jasper.compiler.TagLibraryInfoImpl.createTagFileInfo(TagFileXml,
 Jar)

 286} else if (!path.startsWith(/WEB-INF/tags)) {
 287err.jspError(jsp.error.tagfile.illegalPath, path);
 288}

 
 It looks like the condition was not refactored correctly.

Thanks for the fix. I'll roll an RC8 later today.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Violeta Georgieva
2013/12/13 Rémy Maucherat r...@apache.org

 2013/12/13 Violeta Georgieva miles...@gmail.com

  I found another issue:
  If a tag file is placed in a jar file in WEB-INF/lib and then is used,
the
  The change in the code is introduced with r1541960
 
  Besides that the message is wrong because we check only for WEB-INF/tags
  [1], what should be done in addition?
 
  [1]
 
org.apache.jasper.compiler.TagLibraryInfoImpl.createTagFileInfo(TagFileXml,
  Jar)
 
  286} else if (!path.startsWith(/WEB-INF/tags)) {
  287err.jspError(jsp.error.tagfile.illegalPath, path);
  288}
 

 It looks like the condition was not refactored correctly.


Unfortunately with that fix I'm receiving FNF:

java.io.FileNotFoundException: /META-INF/tags/my.tag
org.apache.jasper.servlet.JspServletWrapper.loadTagFile(JspServletWrapper.java:235)
org.apache.jasper.compiler.TagFileProcessor.loadTagFile(TagFileProcessor.java:579)
org.apache.jasper.compiler.TagFileProcessor.access$000(TagFileProcessor.java:50)
org.apache.jasper.compiler.TagFileProcessor$TagFileLoaderVisitor.visit(TagFileProcessor.java:661)
org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1521)
org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2359)
org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2411)
org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2417)
org.apache.jasper.compiler.Node$Root.accept(Node.java:464)
org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2359)
org.apache.jasper.compiler.TagFileProcessor.loadTagFiles(TagFileProcessor.java:679)
org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:231)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:375)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:355)
org.apache.jasper.compiler.Compiler.compile(Compiler.java:342)
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:557)
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357)


I'll try to create a test case for that.


Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Rémy Maucherat
2013/12/13 Violeta Georgieva miles...@gmail.com

 Unfortunately with that fix I'm receiving FNF:

 java.io.FileNotFoundException: /META-INF/tags/my.tag

 org.apache.jasper.servlet.JspServletWrapper.loadTagFile(JspServletWrapper.java:235)

 org.apache.jasper.compiler.TagFileProcessor.loadTagFile(TagFileProcessor.java:579)

 org.apache.jasper.compiler.TagFileProcessor.access$000(TagFileProcessor.java:50)

 org.apache.jasper.compiler.TagFileProcessor$TagFileLoaderVisitor.visit(TagFileProcessor.java:661)
 org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1521)
 org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2359)
 org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2411)
 org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2417)
 org.apache.jasper.compiler.Node$Root.accept(Node.java:464)
 org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2359)

 org.apache.jasper.compiler.TagFileProcessor.loadTagFiles(TagFileProcessor.java:679)
 org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:231)
 org.apache.jasper.compiler.Compiler.compile(Compiler.java:375)
 org.apache.jasper.compiler.Compiler.compile(Compiler.java:355)
 org.apache.jasper.compiler.Compiler.compile(Compiler.java:342)

 org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:557)

 org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357)


 I'll try to create a test case for that.


The JspCompilationContext used to keep a map of the JarResource
corresponding to the tags:
public JarResource getTagFileJarResource(String tagFile) {
return this.tagFileJarUrls.get(tagFile);
}

public void setTagFileJarResource(String tagFile, JarResource
jarResource) {
this.tagFileJarUrls.put(tagFile, jarResource);
}

This was set in TagLibraryInfoImpl.createTagFileInfo and then used by the
TagFileProcessor.loadTagFile. This should be ok without it because the code
keeps around the Jar instead and uses the entry name now, but apparently
something is still missing and the removed flag gets set (this is what
causes this exception).

So I guess add a test, it can't hurt.

Rémy


Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Violeta Georgieva
2013/12/13 Rémy Maucherat r...@apache.org

 2013/12/13 Violeta Georgieva miles...@gmail.com

  Unfortunately with that fix I'm receiving FNF:
 
  java.io.FileNotFoundException: /META-INF/tags/my.tag
 
 
org.apache.jasper.servlet.JspServletWrapper.loadTagFile(JspServletWrapper.java:235)
 
 
org.apache.jasper.compiler.TagFileProcessor.loadTagFile(TagFileProcessor.java:579)
 
 
org.apache.jasper.compiler.TagFileProcessor.access$000(TagFileProcessor.java:50)
 
 
org.apache.jasper.compiler.TagFileProcessor$TagFileLoaderVisitor.visit(TagFileProcessor.java:661)
  org.apache.jasper.compiler.Node$CustomTag.accept(Node.java:1521)
  org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2359)
  org.apache.jasper.compiler.Node$Visitor.visitBody(Node.java:2411)
  org.apache.jasper.compiler.Node$Visitor.visit(Node.java:2417)
  org.apache.jasper.compiler.Node$Root.accept(Node.java:464)
  org.apache.jasper.compiler.Node$Nodes.visit(Node.java:2359)
 
 
org.apache.jasper.compiler.TagFileProcessor.loadTagFiles(TagFileProcessor.java:679)
  org.apache.jasper.compiler.Compiler.generateJava(Compiler.java:231)
  org.apache.jasper.compiler.Compiler.compile(Compiler.java:375)
  org.apache.jasper.compiler.Compiler.compile(Compiler.java:355)
  org.apache.jasper.compiler.Compiler.compile(Compiler.java:342)
 
 
org.apache.jasper.JspCompilationContext.compile(JspCompilationContext.java:557)
 
 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:357)
 
 
  I'll try to create a test case for that.
 

 The JspCompilationContext used to keep a map of the JarResource
 corresponding to the tags:
 public JarResource getTagFileJarResource(String tagFile) {
 return this.tagFileJarUrls.get(tagFile);
 }

 public void setTagFileJarResource(String tagFile, JarResource
 jarResource) {
 this.tagFileJarUrls.put(tagFile, jarResource);
 }

 This was set in TagLibraryInfoImpl.createTagFileInfo and then used by the
 TagFileProcessor.loadTagFile. This should be ok without it because the
code
 keeps around the Jar instead and uses the entry name now, but apparently
 something is still missing and the removed flag gets set (this is what
 causes this exception).

 So I guess add a test, it can't hurt.

Here [1] is the test

[1] https://www.dropbox.com/s/3zd106lpqfb3ytv/test.zip


Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Rémy Maucherat
2013/12/13 Violeta Georgieva miles...@gmail.com

 Here [1] is the test

 [1] https://www.dropbox.com/s/3zd106lpqfb3ytv/test.zip


Fixed. I didn't add the test yet since I suppose adding a binary should be
avoided.

Rémy


Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-13 Thread Violeta Georgieva
2013/12/13 Rémy Maucherat r...@apache.org

 2013/12/13 Violeta Georgieva miles...@gmail.com

  Here [1] is the test
 
  [1] https://www.dropbox.com/s/3zd106lpqfb3ytv/test.zip
 

 Fixed. I didn't add the test yet since I suppose adding a binary should be
 avoided.

Thanks it is working now.


Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-12 Thread Daniel Mikusa
On Dec 11, 2013, at 6:24 PM, Mark Thomas ma...@apache.org wrote:

 The proposed Apache Tomcat 8.0.0 release candidate 7 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
  tracking
 - Update to Commons Pool 2.0 release
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Numerous bug fixes
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC7/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-047/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC6/
 
 The proposed 8.0.0-RC7 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC7 alpha

Ran some basic tests with non-blocking io, web sockets and EL 3.0.  All worked 
fine.

Dan

 
 Cheers,
 
 Mark
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-12 Thread Jeanfrancois Arcand


On 2013-12-11 6:24 PM, Mark Thomas wrote:


The proposed 8.0.0-RC7 release is:
[ ] Broken - do not release
[X] Alpha - go ahead and release as 8.0.0-RC7 alpha


-- Jeanfrancois

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-12 Thread Mark Thomas
On 11/12/2013 23:24, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 7 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to Commons Pool 2.0 release
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Numerous bug fixes
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC7/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-047/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC7/
 
 The proposed 8.0.0-RC7 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC7 alpha

Unit tests pass on Windows, Linux and OSX.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-12 Thread Keiichi Fujino
2013/12/12 Mark Thomas ma...@apache.org

 The proposed Apache Tomcat 8.0.0 release candidate 7 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to Commons Pool 2.0 release
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Numerous bug fixes

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC7/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-047/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC6/

 The proposed 8.0.0-RC7 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC7 alpha



 +1
Tested on some test applications (use DeltaManager and BackupManager).

-- 
Keiichi.Fujino


Re: [VOTE] Release Apache Tomcat 8.0.0-RC7

2013-12-11 Thread Mark Thomas
On 11/12/2013 23:24, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 7 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to Commons Pool 2.0 release
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Much more detailed visibility of DBCP connections pools in JMX
 - Better organisation of JMX beans in the default JConsole view
 - Numerous bug fixes
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC7/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-047/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC6/

Bah - missed one, That should be:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC7/

Mark

 
 The proposed 8.0.0-RC7 release is:
 [ ] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC7 alpha
 
 Cheers,
 
 Mark
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



RE: [VOTE] Release Apache Tomcat 8.0.0-RC6

2013-12-10 Thread Konstantin Preißer
Hi,

 -Original Message-
 From: Mark Thomas [mailto:ma...@apache.org]
 Sent: Tuesday, December 10, 2013 1:22 AM

 snip/

  Any idea what is going on there? Why would Tomcat create such a big
  byte array for a static file?
 
 Lots of things going on here.
 
 1. The content of resources was still being cached on access even if it
 was bigger than the maximum object size.
 
 2. The test of object size was checking against the total limit for the
 cache rather than the single object limit.
 
 3. The DefaultServlet was working on assumptions that were true in the
 7.0.x resources implementation but not true in the new 8.0.x
 implementation.
 
 All of the above - and few additional issues spotted along the way -
 have been fixed in trunk.
 
 Thanks for the report.

Thanks, Mark. I can confirm that with r1549832, downloading the large static 
file works as expected.


Regards,
Konstantin Preißer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC6

2013-12-09 Thread Mark Thomas
On 09/12/2013 20:18, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 6 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to Commons Pool 2.0 release
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Numerous bug fixes
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC6/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-029/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC6/
 
 The proposed 8.0.0-RC6 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC6 alpha

Unit tests pass win 64-bit Java 7 on Windows, Linux and OSX.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



RE: [VOTE] Release Apache Tomcat 8.0.0-RC6

2013-12-09 Thread Konstantin Preißer
Hi Mark,

 -Original Message-
 From: Mark Thomas [mailto:ma...@apache.org]
 Sent: Monday, December 9, 2013 9:19 PM
 To: Tomcat Developers List
 Subject: [VOTE] Release Apache Tomcat 8.0.0-RC6
 
 The proposed Apache Tomcat 8.0.0 release candidate 6 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC5 are:
 - Better handling of generic types in the WebSocket 1.0 implementation
 - Refactor resource handling for the class loader
 - Add Cobertura support to the unit tests
 - Remove anti-Jar locking feature and replace it with open stream
   tracking
 - Update to Commons Pool 2.0 release
 - Complete refactoring of TLD handling including caching of parsed TLDs
 - More consistent handling of XML validation options
 - Numerous bug fixes
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC6/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-029/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC6/
 
 The proposed 8.0.0-RC6 release is:
 [ ] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC6 alpha

With Tomcat 8.0.0-RC6, I seem to have problems serving large static files in 
one of my webapps.

I've run it on a Windows Server 2012 R2 system with Java 1.7.0_45 (64-Bit) and 
the NIO HTTP connector.
The webapp contains a large static file with a size of 4,582,875,812 bytes.

When I try to download that file in the browser, I get the following exception:

09-Dec-2013 22:21:22.511 SEVERE [http-nio-8006-exec-2] 
org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() for 
servlet [default] in context with path [] threw exception
 java.lang.ArrayIndexOutOfBoundsException: Unable to return [/temp/file.bin] as 
a byte array since the resource is [4,582,875,812] bytes in size which is 
larger than the maximum size of a byte array
at 
org.apache.catalina.webresources.FileResource.getContent(FileResource.java:143)
at 
org.apache.catalina.webresources.CachedResource.getContent(CachedResource.java:235)
at 
org.apache.catalina.servlets.DefaultServlet.copy(DefaultServlet.java:1793)
at 
org.apache.catalina.servlets.DefaultServlet.serveResource(DefaultServlet.java:919)
at 
org.apache.catalina.servlets.DefaultServlet.doGet(DefaultServlet.java:400)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:621)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:728)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at 
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at 
org.tuckey.web.filters.urlrewrite.RuleChain.handleRewrite(RuleChain.java:176)
at 
org.tuckey.web.filters.urlrewrite.RuleChain.doRules(RuleChain.java:145)
at 
org.tuckey.web.filters.urlrewrite.UrlRewriter.processRequest(UrlRewriter.java:92)
at 
org.tuckey.web.filters.urlrewrite.UrlRewriteFilter.doFilter(UrlRewriteFilter.java:394)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at 
common.XUaCompatibleHeaderFilter.doFilter(XUaCompatibleHeaderFilter.java:27)
at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:221)
at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:107)
at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:155)
at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:76)
at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:90)
at 
org.apache.catalina.valves.CrawlerSessionManagerValve.invoke(CrawlerSessionManagerValve.java:180)
at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:522)
at 
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1015)
at 
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:646)
at 
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223)
at 

Re: [VOTE] Release Apache Tomcat 8.0.0-RC6

2013-12-09 Thread Christopher Schultz
Konstantin,

On 12/9/13, 4:40 PM, Konstantin Preißer wrote:
 The webapp contains a large static file with a size of 4,582,875,812 bytes.

I believe that static file is better-described as huge, enormous,
[bleeping] gigantic. Anything bigger than 2^32 bytes deserves a proper
adjective. :)

-chris



signature.asc
Description: OpenPGP digital signature


Re: [VOTE] Release Apache Tomcat 8.0.0-RC6

2013-12-09 Thread Mark Thomas
On 09/12/2013 21:40, Konstantin Preißer wrote:

 With Tomcat 8.0.0-RC6, I seem to have problems serving large static
 files in one of my webapps.
 
 I've run it on a Windows Server 2012 R2 system with Java 1.7.0_45
 (64-Bit) and the NIO HTTP connector. The webapp contains a large
 static file with a size of 4,582,875,812 bytes.
 
 When I try to download that file in the browser, I get the following
 exception:
 
 09-Dec-2013 22:21:22.511 SEVERE [http-nio-8006-exec-2]
 org.apache.catalina.core.StandardWrapperValve.invoke
 Servlet.service() for servlet [default] in context with path [] threw
 exception java.lang.ArrayIndexOutOfBoundsException: Unable to return
 [/temp/file.bin] as a byte array since the resource is
 [4,582,875,812] bytes in size which is larger than the maximum size
 of a byte array

snip/

 However, I am unable to reproduce this exception when placing the
 file in Tomcat's default ROOT webapp. I suspect that the filters
 could have some effect. I think I did not get such errors with the
 same webapp and Tomcat 7.0.42. I have not yet tested other Tomcat
 versions. The XUaCompatibleHeaderFilter in the stacktrace just
 appends an X-UA-Compatible: IE=Edge header to the response, then
 invokes chain.doFilter(request, response). The Tuckey
 UrlRewriteFilter is configured to rewrite some URLs that start with a
 capital letter (but not the URL which requests the static file).
 
 Any idea what is going on there? Why would Tomcat create such a big
 byte array for a static file?

Lots of things going on here.

1. The content of resources was still being cached on access even if it
was bigger than the maximum object size.

2. The test of object size was checking against the total limit for the
cache rather than the single object limit.

3. The DefaultServlet was working on assumptions that were true in the
7.0.x resources implementation but not true in the new 8.0.x implementation.

All of the above - and few additional issues spotted along the way -
have been fixed in trunk.

Thanks for the report.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC5

2013-10-19 Thread Mark Thomas
On 16/10/2013 19:21, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 5 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC4 are:
 - Stability fixes in the APR/native connector
 - Stability fixes for non-blocking IO and WebSocket
 - Improvements to unit tests to reduce incidence of false reports
 - Add a drawing board example to the WebSocket examples
 - A handful of bug fixes
 - A small number of enhancements including direct gzip support in the
   default Servlet
 - More HTML clean-up
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC5/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-186/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC5/
 
 The proposed 8.0.0-RC5 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC5 alpha

Unit tests pass consistently on Windows, Linux and OSX.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC5

2013-10-18 Thread Ognjen Blagojevic

Mark,

On 16.10.2013 20:21, Mark Thomas wrote:

The proposed Apache Tomcat 8.0.0 release candidate 5 is now available
for voting.

...

The proposed 8.0.0-RC5 release is:
[ ] Broken - do not release
[X] Alpha - go ahead and release as 8.0.0-RC5 alpha


Tested .zip distribution on Windows 7 64-bit, and .tar.gz on CentOS 5 
64-bit:


- Tested SSL/TLS connectivity for BIO, NIO and APR connectors (Windows).

- Crawled all links (except /manager, /host-manager and 
/examples/async*). No broken links found, except links to JavaDocs 
(Windows).


- Smoke tests of BIO, NIO and APR, with and without TLS, all passed 
(Windows).


- Tested with several webapps that are in active development (Linux).


-Ognjen


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC5

2013-10-18 Thread Yoav Shapira
On Wed, Oct 16, 2013 at 2:21 PM, Mark Thomas ma...@apache.org wrote:
 The proposed 8.0.0-RC5 release is:
 [ ] Broken - do not release
 [ X ] Alpha - go ahead and release as 8.0.0-RC5 alpha

Yoav

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC5

2013-10-18 Thread Violeta Georgieva
2013/10/16 Mark Thomas ma...@apache.org

 The proposed Apache Tomcat 8.0.0 release candidate 5 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC4 are:
 - Stability fixes in the APR/native connector
 - Stability fixes for non-blocking IO and WebSocket
 - Improvements to unit tests to reduce incidence of false reports
 - Add a drawing board example to the WebSocket examples
 - A handful of bug fixes
 - A small number of enhancements including direct gzip support in the
   default Servlet
 - More HTML clean-up

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC5/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-186/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC5/

 The proposed 8.0.0-RC5 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC5 alpha

Checked with applications that use the new specifications features.

Regards
Violeta


Re: [VOTE] Release Apache Tomcat 8.0.0-RC5

2013-10-17 Thread Rainer Jung
On 16.10.2013 20:21, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 5 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC4 are:
 - Stability fixes in the APR/native connector
 - Stability fixes for non-blocking IO and WebSocket
 - Improvements to unit tests to reduce incidence of false reports
 - Add a drawing board example to the WebSocket examples
 - A handful of bug fixes
 - A small number of enhancements including direct gzip support in the
   default Servlet
 - More HTML clean-up
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC5/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-186/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC5/
 
 The proposed 8.0.0-RC5 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC5 alpha

+1 as alpha.

Overview:

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag
- builds fine but
  - Few warning about unsafe or unchecked operations.
Only 0 or 1 new one, some of the RC1 ones are fixed.
See full list at end of mail.
- build result looks consistent with binaries
- no checkstyle complaints
- no Javadoc warnings
- some tiny MBean data changes
- No unit test failures, great!

- Warnings, errors and exception counts during unit tests a bit
  higher than for RC 3

- JMX MBean-Comparison with RC 3 (all expected):
  - MBean example webapp new welcome file index.xhtml
  - MBean example webapp ignoreAnnotations changed from false to true
  - Runtime MBean common.loader system property all entries are now
quoted.

Build and tests were done using Java 1.7.0_40. OS was Solaris 10 Sparc,
tcnative was 1.1.29 based on APR 1.4.8 and OpenSSL 1.0.1e (plus a few
patches).


Unit test warnings: 95
  - 29 more than RC1, 13 less than RC3
  - most additional ones in tribes, especially from 27 (RC1) resp.
59 (RC3) to 46 (RC5):
org.apache.catalina.tribes.group.interceptors.NonBlockingCoordinator.sendElectionMsgToNextInline
Unable to send election message
to:org.apache.catalina.tribes.membership.MemberImpl[tcp://
  - 8 ones new in RC3, still in RC5:
  org.apache.tomcat.util.net.AbstractEndpoint.shutdownExecutor The
executor associated with thread pool [http-apr-127.0.0.1-auto-I] has not
fully shutdown. Some application threads may still be running.
  - up from 4 (RC3) to 6:
  IOException in replication worker, unable to drain channel.
Probable cause: Keep alive socket closed[null].


Unit test SEVERE messages: 420 total (-19 rel RC1, -37 rel RC3).

Here's the top 20 SEVERE messages:

Count  Message
  48 org.apache.catalina.startup.HostConfig.deployDescriptor Error
deploying configuration descriptor
/.../output/test-tmp/conf/Tomcat/localhost/myapp.xml
  48 org.apache.catalina.core.ContainerBase.addChildInternal
ContainerBase.addChild: start:
  36 org.apache.catalina.core.StandardWrapperValve.invoke
Servlet.service() for servlet [dispatch] in context with path [] threw
exception [Opps.] with root cause
  36 org.apache.catalina.core.ApplicationDispatcher.invoke
Servlet.service() for servlet error threw exception
  27 org.apache.tomcat.util.digester.Digester.startElement Begin event
threw exception
  15 org.apache.catalina.loader.WebappClassLoader.clearReferencesThreads
The web application [] appears to have started a thread named
[pool-N-thread-M] but has failed to stop it. This is very likely to
create a memory leak.
  15 org.apache.catalina.core.StandardWrapperValve.invoke
Servlet.service() for servlet [servlet] in context with path [] threw
exception
  12
org.apache.tomcat.util.descriptor.web.SecurityConstraint.findUncoveredHttpMethods
For security constraints with URL pattern [/] only the HTTP methods
[POST] are covered. All other methods are uncovered.
   9
org.apache.tomcat.util.descriptor.web.SecurityConstraint.findUncoveredHttpMethods
For security constraints with URL pattern [/test] only the HTTP methods
[POST] are covered. All other methods are uncovered.
   9 org.apache.catalina.startup.ContextConfig.beforeStart Exception
fixing docBase for context [/myapp]
   9 org.apache.catalina.core.StandardContext.startInternal Error
listenerStart
   6
org.apache.tomcat.util.descriptor.web.SecurityConstraint.findUncoveredHttpMethods
For security constraints with URL pattern [/] only the HTTP methods
[GET] are covered. All other methods are uncovered.
   6
org.apache.catalina.tribes.group.interceptors.NonBlockingCoordinator.messageReceived
Error processing coordination message. Could be fatal.
   6 org.apache.catalina.loader.WebappClassLoader.clearReferencesThreads
The web application [] is still processing a request that has yet to
finish. This is very likely to create a memory leak. You can control the
time allowed for requests to finish 

RE: [VOTE] Release Apache Tomcat 8.0.0-RC5

2013-10-16 Thread Konstantin Preißer
Hi Mark,

 -Original Message-
 From: Mark Thomas [mailto:ma...@apache.org]
 Sent: Wednesday, October 16, 2013 8:21 PM
 To: Tomcat Developers List
 Subject: [VOTE] Release Apache Tomcat 8.0.0-RC5
 
 The proposed Apache Tomcat 8.0.0 release candidate 5 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC4 are:
 - Stability fixes in the APR/native connector
 - Stability fixes for non-blocking IO and WebSocket
 - Improvements to unit tests to reduce incidence of false reports
 - Add a drawing board example to the WebSocket examples
 - A handful of bug fixes
 - A small number of enhancements including direct gzip support in the
   default Servlet
 - More HTML clean-up
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC5/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-186/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC5/
 
 The proposed 8.0.0-RC5 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC5 alpha

(non-binding)

Looks good to me.


Regards,
Konstantin Preißer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC4

2013-10-15 Thread Daniel Mikusa
On Oct 15, 2013, at 8:48 AM, Mark Thomas ma...@apache.org wrote:

 The proposed Apache Tomcat 8.0.0 release candidate 4 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC3 are:
 - Stability fixes in the APR/native connector
 - Stability fixes for non-blocking IO and WebSocket
 - Improvements to unit tests to reduce incidence of false reports
 - Add a drawing board example to the WebSocket examples
 - A handful of bug fixes
 - A small number of enhancements including direct gzip support in the
  default Servlet
 - More HTML clean-up
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC4/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-176/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC4/
 
 The proposed 8.0.0-RC4 release is:
 [ ] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC4 alpha
 
 Cheers,
 
 Mark
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 

Tested a couple apps that I have and everything worked OK for me.  One note 
though, there are some errors with the examples when I run with the security 
manager enabled.

Here are the steps to replicate the issues:

1.) Downloaded Tomcat 8.0.0-RC4 and unzip.
2.) Run ./bin/catalina.sh start -security.

Here are the errors:

1.) On startup, you'll see this error.  Adding the permission that is listed in 
the stack trace allows the server to start without any errors.

15-Oct-2013 10:05:18.699 SEVERE [localhost-startStop-1] 
org.apache.catalina.core.ContainerBase.addChildInternal ContainerBase.addChild: 
start:
 org.apache.catalina.LifecycleException: Failed to start component 
[StandardEngine[Catalina].StandardHost[localhost].StandardContext[/examples]]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:154)
at 
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:726)
at 
org.apache.catalina.core.ContainerBase.access$000(ContainerBase.java:130)
at 
org.apache.catalina.core.ContainerBase$PrivilegedAddChild.run(ContainerBase.java:152)
at 
org.apache.catalina.core.ContainerBase$PrivilegedAddChild.run(ContainerBase.java:142)
at java.security.AccessController.doPrivileged(Native Method)
at 
org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:700)
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:698)
at 
org.apache.catalina.startup.HostConfig.deployDirectory(HostConfig.java:1119)
at 
org.apache.catalina.startup.HostConfig$DeployDirectory.run(HostConfig.java:1760)
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:724)
Caused by: java.security.AccessControlException: access denied 
(java.lang.RuntimePermission 
accessClassInPackage.org.apache.tomcat.websocket.server)
at 
java.security.AccessControlContext.checkPermission(AccessControlContext.java:372)
at 
java.security.AccessController.checkPermission(AccessController.java:559)
at java.lang.SecurityManager.checkPermission(SecurityManager.java:549)
at 
java.lang.SecurityManager.checkPackageAccess(SecurityManager.java:1529)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:305)
at java.lang.ClassLoader.loadClass(ClassLoader.java:411)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:190)
at 
javax.websocket.server.ServerEndpointConfig$Configurator.loadDefault(ServerEndpointConfig.java:174)
at 
javax.websocket.server.ServerEndpointConfig$Configurator.fetchContainerDefaultConfigurator(ServerEndpointConfig.java:151)
at 
javax.websocket.server.ServerEndpointConfig$Builder.init(ServerEndpointConfig.java:68)
at 
javax.websocket.server.ServerEndpointConfig$Builder.create(ServerEndpointConfig.java:56)
at websocket.ExamplesConfig.getEndpointConfigs(ExamplesConfig.java:38)
at org.apache.tomcat.websocket.server.WsSci.onStartup(WsSci.java:99)
at 
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5265)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
... 14 more


2.) After resolving #1, you'll see this error when you access one of the web 
socket examples and the example tries to make a 

RE: [VOTE] Release Apache Tomcat 8.0.0-RC4

2013-10-15 Thread Konstantin Preißer
 -Original Message-
 From: Mark Thomas [mailto:ma...@apache.org]
 Sent: Tuesday, October 15, 2013 2:49 PM
 To: Tomcat Developers List
 Subject: [VOTE] Release Apache Tomcat 8.0.0-RC4
 
 The proposed Apache Tomcat 8.0.0 release candidate 4 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC3 are:
 - Stability fixes in the APR/native connector
 - Stability fixes for non-blocking IO and WebSocket
 - Improvements to unit tests to reduce incidence of false reports
 - Add a drawing board example to the WebSocket examples
 - A handful of bug fixes
 - A small number of enhancements including direct gzip support in the
   default Servlet
 - More HTML clean-up
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC4/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-176/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC4/
 
 The proposed 8.0.0-RC4 release is:
 [ ] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC4 alpha
 
 Cheers,
 
 Mark

Note, that the documentation index.html included in the binaries says:

Apache Tomcat version @VERSION_MAJOR_MINOR@ implements the Servlet 3.1 and 
JavaServer Pages 2.3 specifications from the Java Community Process [...]

I guess this is because the XSLT And task does not have a version.filters 
filterset (and with r1527315 the explicit version number was replaced with the 
@VERSION_MAJOR_MINOR@ variable), but I don't know if it's possible to add a 
filter to the XSLT task (maybe one would need to copy the .xml files elsewhere 
for applying the filter and then start the XSLT task).


Regards,
Konstantin Preißer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC4

2013-10-15 Thread Jeanfrancois Arcand

[X] Alpha - go ahead and release as 8.0.0-RC4 alpha

Focused on websocket testing, default configuration.

-- Jeanfrancois


On 2013-10-15 8:48 AM, Mark Thomas wrote:

The proposed Apache Tomcat 8.0.0 release candidate 4 is now available
for voting.

Given this is a release candidate I am working on the basis that it is
equivalent to an alpha. The main changes since RC3 are:
- Stability fixes in the APR/native connector
- Stability fixes for non-blocking IO and WebSocket
- Improvements to unit tests to reduce incidence of false reports
- Add a drawing board example to the WebSocket examples
- A handful of bug fixes
- A small number of enhancements including direct gzip support in the
   default Servlet
- More HTML clean-up

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC4/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-176/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC4/

The proposed 8.0.0-RC4 release is:
[ ] Broken - do not release
[ ] Alpha - go ahead and release as 8.0.0-RC4 alpha

Cheers,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC4

2013-10-15 Thread Mark Thomas
On 15/10/2013 17:31, Konstantin Preißer wrote:

 Note, that the documentation index.html included in the binaries
 says:
 
 Apache Tomcat version @VERSION_MAJOR_MINOR@ implements the Servlet
 3.1 and JavaServer Pages 2.3 specifications from the Java Community
 Process [...]
 
 I guess this is because the XSLT And task does not have a
 version.filters filterset (and with r1527315 the explicit version
 number was replaced with the @VERSION_MAJOR_MINOR@ variable), but I
 don't know if it's possible to add a filter to the XSLT task (maybe
 one would need to copy the .xml files elsewhere for applying the
 filter and then start the XSLT task).

I just added support for some new elements to the stylesheet. That
seemed like the cleanest solution.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC4

2013-10-15 Thread Mark Thomas
On 15/10/2013 15:23, Daniel Mikusa wrote:
 Tested a couple apps that I have and everything worked OK for me.
 One note though, there are some errors with the examples when I run
 with the security manager enabled.
 
 Here are the steps to replicate the issues:
 
 1.) Downloaded Tomcat 8.0.0-RC4 and unzip. 2.) Run ./bin/catalina.sh
 start -security.
 
 Here are the errors:
 
 1.) On startup, you'll see this error.  Adding the permission that is
 listed in the stack trace allows the server to start without any
 errors.

Fixed.

 2.) After resolving #1, you'll see this error when you access one of
 the web socket examples and the example tries to make a connection.
 Adding the permission listed in the stack trace resolves the errors
 and the web socket examples then work fine.

Fixed.

 3.) Go to the Number Writer Non-Blocking IO example.  You'll get
 the following error.  Again, adding the permission listed in the
 stack trace to catalina.policy seems to resolve the issue and the
 example works OK.

Fixed.

Thanks for the quick feedback.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-23 Thread Mark Thomas
On 20/09/2013 12:35, Mark Thomas wrote:
 On 20/09/2013 11:36, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 3 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC1 are:
 - Updated spec implementations with results of various grey area
 discussions from the EG mailing lists
 - Now uses UTF-8 by default
 - Switch to async logging and one-line log format by default
 - New doc style
 - Refactored TLD parsing (work in progress)
 - Fixed all the issues reported against RC1  RC2
 - Add Servlet 3.1 non-blocking support to the AJP connectors
 - Fix an issue with the new WebResources and packed WAR files

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC3/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-080/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC3/

 The proposed 8.0.0-RC3 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC3 alpha
 
 It passes the unit tests on Windows, Linux and OSX.

ping.

Any more votes?

I know Rainer has found some issues with APR on Solaris but since this
is at most an alpha release I'm not minded to cancel the release at this
point. Of course, if no more votes are forthcoming soon, then the
release will fail.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-23 Thread Henri Gomez
Hi Mark

What kind of tests, specific to TC 8.0 are awaited to 'qualify' ?


2013/9/23 Mark Thomas ma...@apache.org

 On 20/09/2013 12:35, Mark Thomas wrote:
  On 20/09/2013 11:36, Mark Thomas wrote:
  The proposed Apache Tomcat 8.0.0 release candidate 3 is now available
  for voting.
 
  Given this is a release candidate I am working on the basis that it is
  equivalent to an alpha. The main changes since RC1 are:
  - Updated spec implementations with results of various grey area
  discussions from the EG mailing lists
  - Now uses UTF-8 by default
  - Switch to async logging and one-line log format by default
  - New doc style
  - Refactored TLD parsing (work in progress)
  - Fixed all the issues reported against RC1  RC2
  - Add Servlet 3.1 non-blocking support to the AJP connectors
  - Fix an issue with the new WebResources and packed WAR files
 
  It can be obtained from:
  https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC3/
  The Maven staging repo is:
  https://repository.apache.org/content/repositories/orgapachetomcat-080/
  The svn tag is:
  http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC3/
 
  The proposed 8.0.0-RC3 release is:
  [ ] Broken - do not release
  [X] Alpha - go ahead and release as 8.0.0-RC3 alpha
 
  It passes the unit tests on Windows, Linux and OSX.

 ping.

 Any more votes?

 I know Rainer has found some issues with APR on Solaris but since this
 is at most an alpha release I'm not minded to cancel the release at this
 point. Of course, if no more votes are forthcoming soon, then the
 release will fail.

 Mark


 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




Re: [VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-23 Thread Mark Thomas
On 23/09/2013 06:20, Henri Gomez wrote:
 Hi Mark
 
 What kind of tests, specific to TC 8.0 are awaited to 'qualify' ?

Not sure what you mean.

The only tests we have are the unit tests. We do not have access to the
Java EE 7 TCKs.

In terms of this release, I am personally happy if the unit tests pass
on all three platforms I have available. I'm keen to get wider feedback
from our users and that needs a formal release.

In terms of the alpha - beta - stable transition, I plan on including
beta in the options once we have an RC that doesn't have any show
stopper issues. i.e. I'm expecting 8.0.0 to be beta.

For beta - stable, that will depend on the rate and severity of bug
reports we get. My guess it stable will be early next year but who
knows. Tomcat is pretty stable already and then unit tests seem to be
doing a good job catching issues with the new functionality so maybe it
could be sooner.

Mark

 
 
 2013/9/23 Mark Thomas ma...@apache.org
 
 On 20/09/2013 12:35, Mark Thomas wrote:
 On 20/09/2013 11:36, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 3 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC1 are:
 - Updated spec implementations with results of various grey area
 discussions from the EG mailing lists
 - Now uses UTF-8 by default
 - Switch to async logging and one-line log format by default
 - New doc style
 - Refactored TLD parsing (work in progress)
 - Fixed all the issues reported against RC1  RC2
 - Add Servlet 3.1 non-blocking support to the AJP connectors
 - Fix an issue with the new WebResources and packed WAR files

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC3/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-080/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC3/

 The proposed 8.0.0-RC3 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC3 alpha

 It passes the unit tests on Windows, Linux and OSX.

 ping.

 Any more votes?

 I know Rainer has found some issues with APR on Solaris but since this
 is at most an alpha release I'm not minded to cancel the release at this
 point. Of course, if no more votes are forthcoming soon, then the
 release will fail.

 Mark


 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org


 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-23 Thread Violeta Georgieva
2013/9/20 Mark Thomas ma...@apache.org

 The proposed Apache Tomcat 8.0.0 release candidate 3 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC1 are:
 - Updated spec implementations with results of various grey area
 discussions from the EG mailing lists
 - Now uses UTF-8 by default
 - Switch to async logging and one-line log format by default
 - New doc style
 - Refactored TLD parsing (work in progress)
 - Fixed all the issues reported against RC1  RC2
 - Add Servlet 3.1 non-blocking support to the AJP connectors
 - Fix an issue with the new WebResources and packed WAR files

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC3/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-080/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC3/

 The proposed 8.0.0-RC3 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC3 alpha


Checked with some applications that are using the new specifications
features.


Regards
Violeta


Re: [VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-23 Thread Martin Grigorov
On Fri, Sep 20, 2013 at 12:36 PM, Mark Thomas ma...@apache.org wrote:

 The proposed Apache Tomcat 8.0.0 release candidate 3 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC1 are:
 - Updated spec implementations with results of various grey area
 discussions from the EG mailing lists
 - Now uses UTF-8 by default
 - Switch to async logging and one-line log format by default
 - New doc style
 - Refactored TLD parsing (work in progress)
 - Fixed all the issues reported against RC1  RC2
 - Add Servlet 3.1 non-blocking support to the AJP connectors
 - Fix an issue with the new WebResources and packed WAR files

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC3/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-080/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC3/

 The proposed 8.0.0-RC3 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC3 alpha


Apache Wicket Native WebSockets based on JSR356 works fine.


 Cheers,

 Mark

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




Re: [VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-23 Thread Christopher Schultz
Mark,

On 9/20/13 6:36 AM, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 3 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC1 are:
 - Updated spec implementations with results of various grey area
 discussions from the EG mailing lists
 - Now uses UTF-8 by default
 - Switch to async logging and one-line log format by default
 - New doc style
 - Refactored TLD parsing (work in progress)
 - Fixed all the issues reported against RC1  RC2
 - Add Servlet 3.1 non-blocking support to the AJP connectors
 - Fix an issue with the new WebResources and packed WAR files
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC3/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-080/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC3/
 
 The proposed 8.0.0-RC3 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC3 alpha

Debian Linux 2.6, x86_84
Oracle Java 1.7.0_40, 64-bit Server VM

Binary ZIP and tarball are the same
Source ZIP and tarball are the same
MD5 sums are okay
GPG sigs are okay
Checkstyle is happy
tcnative builds fine, with some notes
Unit tests pass (except Tribes, known to fail in my environment)

Quick smoke test on my own web application (no new features e.g.
Websocket are in use) shows no problems (and the hundreds of WARNING
logs are now gone).

Looks good to me.

-chris



signature.asc
Description: OpenPGP digital signature


Re: [VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-23 Thread Rainer Jung
On 20.09.2013 12:36, Mark Thomas wrote:

 The proposed 8.0.0-RC3 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC3 alpha

+1 as alpha.

Overview:

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag
- builds fine but
  - Few warning about unsafe or unchecked operations.
Only 0 or 1 new one, some of the RC1 ones are fixed.
See full list at end of mail.
- build result looks consistent with binaries
- no checkstyle complaints
- no Javadoc warnings
- some small MBean data changes
! One unit test failure in TestWebappClassLoaderExecutorMemoryLeak
  - analysis ongoing, not a regression
  Repeated execution also sometimes show a hang in the unit test.
- Warnings, errors and exception counts during unit tests a bit
  higher than for RC 1
- JMX MBean-Comparison with RC 1:
  - 2 new MBeans for Example servlets numberwriter and bytecounter
  - MBean j2eeType=Filter,name=Set Character Encoding,
   WebModule=//localhost/examples, ...
attribute filterInitParameterMap changed from
  {encoding=EUC_JP, ignore=true} to
  {encoding=UTF-8, ignore=false}
  - MBean Catalina:j2eeType=WebModule,*
- attributes tldNamespaceAware and tldValidation are gone
- attribute tldScanTime is always 0
  - MBean Catalina:type=Connector,*
   new attribute URIEncoding value UTF-8
  - MBean Catalina:type=ProtocolHandler,port=8080
new attribute maxExtensionSize value 8192
(attribute does not exist for 8009 AJP ProtocolHandler
 but the attribute structure for those two MBeans is quite
 different from each other)
  - platform MBean java.lang:type=Runtime in system property
tomcat.util.scan.StandardJarScanFilter.jarsToSkip
new entry websocket-api.jar
  - platform MBean java.lang:type=OperatingSystem show 87 open file
descriptors instead of 88
  - platform MBean java.lang:type=Threading shows 19 threads instead of
18 threads


Build and tests were done using Java 1.7.0_40. OS was Solaris 10 Sparc,
tcnative was 1.1.28 based on APR 1.4.8 and OpenSSL 1.0.1e (plus a few
patches).


Unit test warnings: 108
  - 42 more than RC1
  - most additional ones in tribes, especially going up from 27 to 59:
org.apache.catalina.tribes.group.interceptors.NonBlockingCoordinator.sendElectionMsgToNextInline
Unable to send election message
to:org.apache.catalina.tribes.membership.MemberImpl[tcp://
  - 8 new ones:
  org.apache.tomcat.util.net.AbstractEndpoint.shutdownExecutor The
executor associated with thread pool [http-apr-127.0.0.1-auto-I] has not
fully shutdown. Some application threads may still be running.
  - 2 ones gone:
  IOException in replication worker, unable to drain channel.
Probable cause: Keep alive socket closed[null].


Unit test SEVERE messages: 457 total (+18 rel RC1).

- 6 times SEVERE: Servlet.service() for servlet [regular] in context
with path [] threw exception

- 3 times SEVERE: Servlet.service() for servlet [servlet] in context
with path [] threw exception

- 7 times SEVERE: The web application [] appears to have started a
thread named [pool-1-thread-X] but has failed to stop it. This is very
likely to create a memory leak.

- 2 times SEVERE: Exception while processing an asynchronous request

- 4 times SEVERE: Error processing coordination message. Could be fatal.

- 4 times less SEVERE: Error reading request, ignored

- 4 times SEVERE: Error configuring application listener of class
org.apache.tomcat.util.descriptor.web.ApplicationListener@HEX replaced
with SEVERE: Error configuring application listener of class
org.apache.catalina.core.NoSuchListener

Here's the top 20 SEVERE messages:

Count  Message
  48 org.apache.catalina.startup.HostConfig.deployDescriptor Error
deploying configuration descriptor
/.../output/test-tmp/conf/Tomcat/localhost/myapp.xml
  48 org.apache.catalina.core.ContainerBase.addChildInternal
ContainerBase.addChild: start:
  36 org.apache.catalina.core.StandardWrapperValve.invoke
Servlet.service() for servlet [dispatch] in context with path [] threw
exception [Opps.] with root cause
  36 org.apache.catalina.core.ApplicationDispatcher.invoke
Servlet.service() for servlet error threw exception
  27 org.apache.tomcat.util.digester.Digester.startElement Begin event
threw exception
  21 org.apache.catalina.core.StandardContext.startInternal Error
listenerStart
  15 org.apache.catalina.core.StandardWrapperValve.invoke
Servlet.service() for servlet [servlet] in context with path [] threw
exception
  13 org.apache.catalina.loader.WebappClassLoader.clearReferencesThreads
The web application [] appears to have started a thread named
[pool-x-thread-y] but has failed to stop it. This is very likely to
create a memory leak.
  12
org.apache.tomcat.util.descriptor.web.SecurityConstraint.findUncoveredHttpMethods
For security constraints with URL pattern [/] only the HTTP methods
[POST] are covered. All other methods are uncovered.
  12 

Re: [VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-23 Thread Jeanfrancois Arcand

[X] Alpha - go ahead and release as 8.0.0-RC3 alpha

Tested with Atmosphere jsr356 and Servlet 3 Async API.

-- Jeanfrancois

On 2013-09-20 6:36 AM, Mark Thomas wrote:

The proposed Apache Tomcat 8.0.0 release candidate 3 is now available
for voting.

Given this is a release candidate I am working on the basis that it is
equivalent to an alpha. The main changes since RC1 are:
- Updated spec implementations with results of various grey area
discussions from the EG mailing lists
- Now uses UTF-8 by default
- Switch to async logging and one-line log format by default
- New doc style
- Refactored TLD parsing (work in progress)
- Fixed all the issues reported against RC1  RC2
- Add Servlet 3.1 non-blocking support to the AJP connectors
- Fix an issue with the new WebResources and packed WAR files

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC3/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-080/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC3/

The proposed 8.0.0-RC3 release is:
[ ] Broken - do not release
[ ] Alpha - go ahead and release as 8.0.0-RC3 alpha

Cheers,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-20 Thread Mark Thomas
On 20/09/2013 11:36, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 3 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC1 are:
 - Updated spec implementations with results of various grey area
 discussions from the EG mailing lists
 - Now uses UTF-8 by default
 - Switch to async logging and one-line log format by default
 - New doc style
 - Refactored TLD parsing (work in progress)
 - Fixed all the issues reported against RC1  RC2
 - Add Servlet 3.1 non-blocking support to the AJP connectors
 - Fix an issue with the new WebResources and packed WAR files
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC3/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-080/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC3/
 
 The proposed 8.0.0-RC3 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC3 alpha

It passes the unit tests on Windows, Linux and OSX.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC2

2013-09-19 Thread Rainer Jung
I get a crash when using tcnative 1.1.28 and JDK 1.7.0_40 on Solaris 10:

WARN: Test failure in
'output/build/logs/TEST-org.apache.tomcat.websocket.TestWsWebSocketContainer.APR.txt':
Testsuite: org.apache.tomcat.websocket.TestWsWebSocketContainer
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec

Testcase: testSessionExpiryContainer took 0.006 sec
Caused an ERROR
Forked Java VM exited abnormally. Please note the time in the report
does not reflect the time until the VM exit.
junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
Please note the time in the report does not reflect the time until the
VM exit.

Stack from HotSpot error file:

Stack: [0xb280,0xb288],  sp=0xb287cfa8,  free space=499k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code,
C=native code)
C  [libtcnative-1.so.0.1.28+0x100fc]
Java_org_apache_tomcat_jni_Socket_recv+0x40
j  org.apache.tomcat.jni.Socket.recv(J[BII)I+1
j  org.apache.tomcat.jni.Socket.recv(J[BII)I+0
j  org.apache.coyote.http11.upgrade.AprServletInputStream.doRead(Z[BII)I+83
j
org.apache.coyote.http11.upgrade.AbstractServletInputStream.read([BII)I+20
j  org.apache.tomcat.websocket.server.WsFrameServer.onDataAvailable()V+46
j
org.apache.tomcat.websocket.server.WsHttpUpgradeHandler$WsReadListener.onDataAvailable()V+4
j
org.apache.coyote.http11.upgrade.AbstractServletInputStream.onDataAvailable()V+11
j
org.apache.coyote.http11.upgrade.AbstractProcessor.upgradeDispatch(Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;
+11
j
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/ut
il/net/AbstractEndpoint$Handler$SocketState;+212
j
org.apache.coyote.http11.Http11AprProtocol$Http11ConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tom
cat/util/net/AbstractEndpoint$Handler$SocketState;+76
j  org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.doRun()V+26
j  org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run()V+55
J
java.util.concurrent.ThreadPoolExecutor.runWorker(Ljava/util/concurrent/ThreadPoolExecutor$Worker;)V
j  java.util.concurrent.ThreadPoolExecutor$Worker.run()V+5
j  java.lang.Thread.run()V+11
v  ~StubRoutines::call_stub
V  [libjvm.so+0x1bc72c]  void
JavaCalls::call_helper(JavaValue*,methodHandle*,JavaCallArguments*,Thread*)+0x320
V  [libjvm.so+0x6bd888]  void
JavaCalls::call_virtual(JavaValue*,Handle,KlassHandle,Symbol*,Symbol*,Thread*)+0x1a0
V  [libjvm.so+0x267820]  void thread_entry(JavaThread*,Thread*)+0x170
V  [libjvm.so+0xb0bf98]  void JavaThread::thread_main_inner()+0x9c
V  [libjvm.so+0x263250]  void JavaThread::run()+0x494
V  [libjvm.so+0x9e30f0]  java_start+0x338


Note that there's another error only happening with apr:

WARN: Test failure in
'output/build/logs/TEST-org.apache.catalina.connector.TestCoyoteAdapter.APR.txt':
Testsuite: org.apache.catalina.connector.TestCoyoteAdapter
Tests run: 18, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 48.535 sec
- Standard Output ---
HTTP/1.1 200 OK
Server: Apache-Coyote/1.1
Content-Type: text/plain;charset=UTF-8
Transfer-Encoding: chunked
Date: Wed, 18 Sep 2013 22:16:04 GMT

4
TEST
4
TEST
-  ---
- Standard Error -
19-Sep-2013 00:15:56.939 INFO [main]
org.apache.catalina.core.AprLifecycleListener.init Loaded APR based
Apache Tomcat Native library 1.1.28 using APR version 1.4.8.
19-Sep-2013 00:15:56.945 INFO [main]
org.apache.catalina.core.AprLifecycleListener.init APR capabilities:
IPv6 [true], sendfile [true], accept filters [false], random [true].
19-Sep-2013 00:15:57.238 INFO [main]
org.apache.catalina.core.AprLifecycleListener.initializeSSL OpenSSL
successfully initialized (OpenSSL 1.0.1esp1 12 Feb 2013)
19-Sep-2013 00:15:58.510 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
[http-apr-127.0.0.1-auto-1]
19-Sep-2013 00:15:58.555 INFO [main]
org.apache.catalina.core.StandardService.startInternal Starting service
Tomcat
...
19-Sep-2013 00:16:18.685 INFO [main]
org.apache.catalina.core.StandardService.startInternal Starting service
Tomcat
19-Sep-2013 00:16:18.685 INFO [main]
org.apache.catalina.core.StandardEngine.startInternal Starting Servlet
Engine: Apache Tomcat/8.0.0-RC2
19-Sep-2013 00:16:18.709 INFO [main]
org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
[http-apr-127.0.0.1-auto-13-62683]
19-Sep-2013 00:16:28.796 SEVERE [http-apr-127.0.0.1-auto-13-Poller]
org.apache.tomcat.util.net.AprEndpoint$Poller.run Poller failed with
error [81] : [File descriptor in bad state]
19-Sep-2013 00:16:38.806 INFO [main]
org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler
[http-apr-127.0.0.1-auto-13-62683]
19-Sep-2013 00:16:38.858 INFO [main]

Re: [VOTE] Release Apache Tomcat 8.0.0-RC2

2013-09-19 Thread Mark Thomas
On 19/09/2013 07:18, Rainer Jung wrote:
 I get a crash when using tcnative 1.1.28 and JDK 1.7.0_40 on Solaris 10:
 
 WARN: Test failure in
 'output/build/logs/TEST-org.apache.tomcat.websocket.TestWsWebSocketContainer.APR.txt':
 Testsuite: org.apache.tomcat.websocket.TestWsWebSocketContainer
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec
 
 Testcase: testSessionExpiryContainer took 0.006 sec
 Caused an ERROR
 Forked Java VM exited abnormally. Please note the time in the report
 does not reflect the time until the VM exit.
 junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
 Please note the time in the report does not reflect the time until the
 VM exit.
 
 Stack from HotSpot error file:
 
 Stack: [0xb280,0xb288],  sp=0xb287cfa8,  free space=499k
 Native frames: (J=compiled Java code, j=interpreted, Vv=VM code,
 C=native code)
 C  [libtcnative-1.so.0.1.28+0x100fc]
 Java_org_apache_tomcat_jni_Socket_recv+0x40
 j  org.apache.tomcat.jni.Socket.recv(J[BII)I+1
 j  org.apache.tomcat.jni.Socket.recv(J[BII)I+0
 j  org.apache.coyote.http11.upgrade.AprServletInputStream.doRead(Z[BII)I+83

That looks like the error I thought I had fixed.

I've had some ideas for a more robust fix. I'll try implementing them to
see how practical they are.

How repeatable is this failure? If you run the single test case for APR
do you always get the crash?

snip/

 Note that there's another error only happening with apr:
 WARN: Test failure in
 'output/build/logs/TEST-org.apache.catalina.connector.TestCoyoteAdapter.APR.txt':

snip/

 Testcase: testPathParamsRedirect took 20.782 sec
 Caused an ERROR
 Unexpected end of file from server
 java.net.SocketException: Unexpected end of file from server

That is very strange. Looks like a connection timeout. I'm inclined to
view this one as a false positive.

Again, how repeatable is it?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC2

2013-09-19 Thread Mark Thomas
On 19/09/2013 09:12, Mark Thomas wrote:
 On 19/09/2013 07:18, Rainer Jung wrote:
 I get a crash when using tcnative 1.1.28 and JDK 1.7.0_40 on Solaris 10:

 WARN: Test failure in
 'output/build/logs/TEST-org.apache.tomcat.websocket.TestWsWebSocketContainer.APR.txt':
 Testsuite: org.apache.tomcat.websocket.TestWsWebSocketContainer
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec

 Testcase: testSessionExpiryContainer took 0.006 sec
 Caused an ERROR
 Forked Java VM exited abnormally. Please note the time in the report
 does not reflect the time until the VM exit.
 junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
 Please note the time in the report does not reflect the time until the
 VM exit.

 Stack from HotSpot error file:

 Stack: [0xb280,0xb288],  sp=0xb287cfa8,  free space=499k
 Native frames: (J=compiled Java code, j=interpreted, Vv=VM code,
 C=native code)
 C  [libtcnative-1.so.0.1.28+0x100fc]
 Java_org_apache_tomcat_jni_Socket_recv+0x40
 j  org.apache.tomcat.jni.Socket.recv(J[BII)I+1
 j  org.apache.tomcat.jni.Socket.recv(J[BII)I+0
 j  org.apache.coyote.http11.upgrade.AprServletInputStream.doRead(Z[BII)I+83
 
 That looks like the error I thought I had fixed.
 
 I've had some ideas for a more robust fix. I'll try implementing them to
 see how practical they are.

Can you try the latest 8.0.x trunk with Solaris?

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC2

2013-09-19 Thread Rainer Jung
On 19.09.2013 13:01, Mark Thomas wrote:
 On 19/09/2013 09:12, Mark Thomas wrote:
 On 19/09/2013 07:18, Rainer Jung wrote:
 I get a crash when using tcnative 1.1.28 and JDK 1.7.0_40 on Solaris 10:

 WARN: Test failure in
 'output/build/logs/TEST-org.apache.tomcat.websocket.TestWsWebSocketContainer.APR.txt':
 Testsuite: org.apache.tomcat.websocket.TestWsWebSocketContainer
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec

 Testcase: testSessionExpiryContainer took 0.006 sec
 Caused an ERROR
 Forked Java VM exited abnormally. Please note the time in the report
 does not reflect the time until the VM exit.
 junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
 Please note the time in the report does not reflect the time until the
 VM exit.

 Stack from HotSpot error file:

 Stack: [0xb280,0xb288],  sp=0xb287cfa8,  free space=499k
 Native frames: (J=compiled Java code, j=interpreted, Vv=VM code,
 C=native code)
 C  [libtcnative-1.so.0.1.28+0x100fc]
 Java_org_apache_tomcat_jni_Socket_recv+0x40
 j  org.apache.tomcat.jni.Socket.recv(J[BII)I+1
 j  org.apache.tomcat.jni.Socket.recv(J[BII)I+0
 j  org.apache.coyote.http11.upgrade.AprServletInputStream.doRead(Z[BII)I+83

 That looks like the error I thought I had fixed.

 I've had some ideas for a more robust fix. I'll try implementing them to
 see how practical they are.
 
 Can you try the latest 8.0.x trunk with Solaris?

Mark, sorry I was afk the whole day and am now again until late. So can
probably only test Friday. Will do as soon as I can and then use either
RC3 or head whatever is available then.

Regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC2

2013-09-19 Thread Rainer Jung
On 19.09.2013 18:32, Rainer Jung wrote:
 On 19.09.2013 13:01, Mark Thomas wrote:
 On 19/09/2013 09:12, Mark Thomas wrote:
 On 19/09/2013 07:18, Rainer Jung wrote:
 I get a crash when using tcnative 1.1.28 and JDK 1.7.0_40 on Solaris 10:

 WARN: Test failure in
 'output/build/logs/TEST-org.apache.tomcat.websocket.TestWsWebSocketContainer.APR.txt':
 Testsuite: org.apache.tomcat.websocket.TestWsWebSocketContainer
 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec

 Testcase: testSessionExpiryContainer took 0.006 sec
 Caused an ERROR
 Forked Java VM exited abnormally. Please note the time in the report
 does not reflect the time until the VM exit.
 junit.framework.AssertionFailedError: Forked Java VM exited abnormally.
 Please note the time in the report does not reflect the time until the
 VM exit.

 Stack from HotSpot error file:

 Stack: [0xb280,0xb288],  sp=0xb287cfa8,  free space=499k
 Native frames: (J=compiled Java code, j=interpreted, Vv=VM code,
 C=native code)
 C  [libtcnative-1.so.0.1.28+0x100fc]
 Java_org_apache_tomcat_jni_Socket_recv+0x40
 j  org.apache.tomcat.jni.Socket.recv(J[BII)I+1
 j  org.apache.tomcat.jni.Socket.recv(J[BII)I+0
 j  org.apache.coyote.http11.upgrade.AprServletInputStream.doRead(Z[BII)I+83

 That looks like the error I thought I had fixed.

 I've had some ideas for a more robust fix. I'll try implementing them to
 see how practical they are.

 Can you try the latest 8.0.x trunk with Solaris?
 
 Mark, sorry I was afk the whole day and am now again until late. So can
 probably only test Friday. Will do as soon as I can and then use either
 RC3 or head whatever is available then.

Reran tests for RC 3 and the original failures didn't happen. Either
they happen only sporadically or they are fixed now. Will let it run in
a loop later today.

There was another test failure for RC 3, but I think that one isn't a
regression and I expect it to happen only sporadically (timing issue):

INFO: Failures in
output/build/logs/TEST-org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak.APR.txt
WARN: Test failure in
'output/build/logs/TEST-org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak.APR.txt':
Testsuite:
org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.337 sec
- Standard Error -
19-Sep-2013 23:16:22.176 INFO [main]
org.apache.catalina.core.AprLifecycleListener.init Loaded APR based
Apache Tomcat Native library 1.1.28 using APR version 1.4.8.
19-Sep-2013 23:16:22.181 INFO [main]
org.apache.catalina.core.AprLifecycleListener.init APR capabilities:
IPv6 [true], sendfile [true], accept filters [false], random [true].
19-Sep-2013 23:16:23.117 INFO [main]
org.apache.catalina.core.AprLifecycleListener.initializeSSL OpenSSL
successfully initialized (OpenSSL 1.0.1esp1 12 Feb 2013)
19-Sep-2013 23:16:24.480 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
[http-apr-127.0.0.1-auto-1]
19-Sep-2013 23:16:24.525 INFO [main]
org.apache.catalina.core.StandardService.startInternal Starting service
Tomcat
19-Sep-2013 23:16:24.525 INFO [main]
org.apache.catalina.core.StandardEngine.startInternal Starting Servlet
Engine: Apache Tomcat/8.0.0-RC3
19-Sep-2013 23:16:25.579 INFO [localhost-startStop-1]
org.apache.catalina.util.SessionIdGenerator.createSecureRandom Creation
of SecureRandom instance for session ID generation
using [INSECURE] took [495] milliseconds.
19-Sep-2013 23:16:25.598 INFO [main]
org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
[http-apr-127.0.0.1-auto-1-38188]
19-Sep-2013 23:16:26.390 SEVERE [main]
org.apache.catalina.loader.WebappClassLoader.clearReferencesThreads The
web application [] appears to have started a thread named [pool-1-
thread-1] but has failed to stop it. This is very likely to create a
memory leak.
19-Sep-2013 23:16:26.397 SEVERE [main]
org.apache.catalina.loader.WebappClassLoader.clearReferencesThreads The
web application [] appears to have started a thread named [pool-1-
thread-2] but has failed to stop it. This is very likely to create a
memory leak.
19-Sep-2013 23:16:26.400 SEVERE [main]
org.apache.catalina.loader.WebappClassLoader.clearReferencesThreads The
web application [] appears to have started a thread named [pool-1-
thread-3] but has failed to stop it. This is very likely to create a
memory leak.
19-Sep-2013 23:16:26.402 SEVERE [main]
org.apache.catalina.loader.WebappClassLoader.clearReferencesThreads The
web application [] appears to have started a thread named [pool-1-
thread-4] but has failed to stop it. This is very likely to create a
memory leak.
19-Sep-2013 23:16:26.404 SEVERE [main]
org.apache.catalina.loader.WebappClassLoader.clearReferencesThreads The
web application [] appears to have started a thread named [pool-1-
thread-5] but has failed to stop it. This is very likely to create a
memory leak.
19-Sep-2013 23:16:27.420 INFO [main]

Re: [VOTE] Release Apache Tomcat 8.0.0-RC2

2013-09-18 Thread Konstantin Kolinko
2013/9/17 Mark Thomas ma...@apache.org:
 The proposed Apache Tomcat 8.0.0 release candidate 2 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC1 are:
 - Updated spec implementations with results of various grey area
 discussions from the EG mailing lists
 - Now uses UTF-8 by default
 - Switch to async logging and one-line log format by default
 - New doc style
 - Refactored TLD parsing (work in progress)
 - Fixed all the issues reported against RC1
 - Add Servlet 3.1 non-blocking support to the AJP connectors
 - Fix an issue with the new WebResources and packed WAR files

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC2/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-066/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC2/

 The proposed 8.0.0-RC2 release is:
 [x] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC2 alpha


WinXP, Java 7u25, trying to start with security being enabled Tomcat
just dies at bootstrap time.

 catalina.bat run -security
results in
[[[
java.lang.ClassNotFoundException:
org.apache.tomcat.util.net.JIoEndpoint$PrivilegedSetTccl
at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at 
org.apache.catalina.security.SecurityClassLoad.loadTomcatPackage(SecurityClassLoad.java
:282)
at 
org.apache.catalina.security.SecurityClassLoad.securityClassLoad(SecurityClassLoad.java
:49)
at org.apache.catalina.startup.Bootstrap.init(Bootstrap.java:266)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:461)
]]]
and Tomcat dies.

(I was going to test ClassLoaderLogManager after recent changed by
Chris, but it just dies before reaching there.)

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC2

2013-09-18 Thread Christopher Schultz
Mark,

On 9/17/13 1:53 PM, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 2 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC1 are:
 - Updated spec implementations with results of various grey area
 discussions from the EG mailing lists
 - Now uses UTF-8 by default
 - Switch to async logging and one-line log format by default
 - New doc style
 - Refactored TLD parsing (work in progress)
 - Fixed all the issues reported against RC1
 - Add Servlet 3.1 non-blocking support to the AJP connectors
 - Fix an issue with the new WebResources and packed WAR files
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC2/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-066/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC2/
 
 The proposed 8.0.0-RC2 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC2 alpha

Works fine in dev environment with some of my webapps. Specifically
configured with NIO connector, no SSL, no Websocket usage, small heap
(-Xmx128M, compressed OOPs). Mac OS X on Oracle 1.7.0_40-b43 (64-bit).

 - Now uses UTF-8 by default

Yay! Did anything actually change? I think this had been done before, no?

 - Switch to async logging and one-line log format by default

Does this affect catalina.out? I'm still seeing multi-line messages
going to catalina.out (stderr/stdout).

 - New doc style

Nice!

Strangely, I got 2171 of these in catalina.out when launching:

Sep 18, 2013 4:03:42 PM org.apache.catalina.webresources.Cache getResource
WARNING: Unable to add the resource at [{0}] to the cache because there
was insufficient free space available after evicting expired cache
entries - consider increasing the maximum size of the cache

I don't have anything cache-related defined in my server.xml (nor
META-INF/context.xml) so I suspect I have whatever defaults are

Of primary concern is that I have not specifically configured anything,
and with what I consider to be a modestly-small-sizes webapp, I got 2171
warnings on startup. Yikes. The 'resource' isn't named, which is a
slight concern, too.

After using my webapp for a bit, I started getting more of the above
warnings in catalina.out. I'm up to 2299 at this point.

-chris



signature.asc
Description: OpenPGP digital signature


Re: [VOTE] Release Apache Tomcat 8.0.0-RC2

2013-09-18 Thread Mark Thomas
On 18/09/2013 21:18, Christopher Schultz wrote:
 Mark,
 
 On 9/17/13 1:53 PM, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 2 is now
 available for voting.
 
 Given this is a release candidate I am working on the basis that
 it is equivalent to an alpha. The main changes since RC1 are: -
 Updated spec implementations with results of various grey area 
 discussions from the EG mailing lists - Now uses UTF-8 by
 default - Switch to async logging and one-line log format by
 default - New doc style - Refactored TLD parsing (work in
 progress) - Fixed all the issues reported against RC1 - Add
 Servlet 3.1 non-blocking support to the AJP connectors - Fix an
 issue with the new WebResources and packed WAR files
 
 It can be obtained from: 
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC2/

 
The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-066/

 
The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC2/
 
 The proposed 8.0.0-RC2 release is: [ ] Broken - do not release 
 [X] Alpha - go ahead and release as 8.0.0-RC2 alpha
 
 Works fine in dev environment with some of my webapps.
 Specifically configured with NIO connector, no SSL, no Websocket
 usage, small heap (-Xmx128M, compressed OOPs). Mac OS X on Oracle
 1.7.0_40-b43 (64-bit).
 
 - Now uses UTF-8 by default
 
 Yay! Did anything actually change? I think this had been done
 before, no?
 
 - Switch to async logging and one-line log format by default
 
 Does this affect catalina.out? I'm still seeing multi-line
 messages going to catalina.out (stderr/stdout).
 
 - New doc style
 
 Nice!
 
 Strangely, I got 2171 of these in catalina.out when launching:
 
 Sep 18, 2013 4:03:42 PM org.apache.catalina.webresources.Cache
 getResource WARNING: Unable to add the resource at [{0}] to the
 cache because there was insufficient free space available after
 evicting expired cache entries - consider increasing the maximum
 size of the cache
 
 I don't have anything cache-related defined in my server.xml (nor 
 META-INF/context.xml) so I suspect I have whatever defaults are
 
 Of primary concern is that I have not specifically configured
 anything, and with what I consider to be a modestly-small-sizes
 webapp, I got 2171 warnings on startup. Yikes. The 'resource' isn't
 named, which is a slight concern, too.
 
 After using my webapp for a bit, I started getting more of the
 above warnings in catalina.out. I'm up to 2299 at this point.

See the users list.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC2

2013-09-18 Thread Mark Thomas
On 18/09/2013 20:49, Konstantin Kolinko wrote:
 2013/9/17 Mark Thomas ma...@apache.org:
 The proposed Apache Tomcat 8.0.0 release candidate 2 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. The main changes since RC1 are:
 - Updated spec implementations with results of various grey area
 discussions from the EG mailing lists
 - Now uses UTF-8 by default
 - Switch to async logging and one-line log format by default
 - New doc style
 - Refactored TLD parsing (work in progress)
 - Fixed all the issues reported against RC1
 - Add Servlet 3.1 non-blocking support to the AJP connectors
 - Fix an issue with the new WebResources and packed WAR files

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC2/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-066/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC2/

 The proposed 8.0.0-RC2 release is:
 [x] Broken - do not release
 [ ] Alpha - go ahead and release as 8.0.0-RC2 alpha

 
 WinXP, Java 7u25, trying to start with security being enabled Tomcat
 just dies at bootstrap time.
 
 catalina.bat run -security
 results in
 [[[
 java.lang.ClassNotFoundException:
 org.apache.tomcat.util.net.JIoEndpoint$PrivilegedSetTccl
 at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
 at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
 at java.security.AccessController.doPrivileged(Native Method)
 at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
 at 
 org.apache.catalina.security.SecurityClassLoad.loadTomcatPackage(SecurityClassLoad.java
 :282)
 at 
 org.apache.catalina.security.SecurityClassLoad.securityClassLoad(SecurityClassLoad.java
 :49)
 at org.apache.catalina.startup.Bootstrap.init(Bootstrap.java:266)
 at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:461)
 ]]]
 and Tomcat dies.
 
 (I was going to test ClassLoaderLogManager after recent changed by
 Chris, but it just dies before reaching there.)

Whoops. I've just fixed that locally and I now see some warnings related
to Chris's changes. I'll commit the first fix and then look at the
remaining warnings from the security manager.

It isn't as if the release process takes much effort so I'll roll RC3
anyway to pick up this and the cache fixes. I might get to that tonight
- it might wait until tomorrow.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-05 Thread Rainer Jung
Hi Mark,

thanks for the thorough inspection of my results. I'll try to make sure
that I won't include now known false positives in future reports.

Some few remarks inline.

On 04.08.2013 18:14, Mark Thomas wrote:
 On 03/08/2013 12:06, Rainer Jung wrote:
 Overview:

 - one crash in tcnative during unit tests
 - MBeans indicate common loader is gone (is that expected?
   At least the common.loader entry still exists in catalina.properties)
 Expected as StandardClassLoader has been removed. That decision is
 reversible of there is a use case for having the class loader visible in
 JMX.

So the common loader still exists but is a URLClassLoader? Otherwise I
guess we should remove to common.loader property in catalina.properties?

 ! Unit tests few failures and errors:
 These need looking at. Note: Many of the tests are timing sensitive and
 do not fail consistently. Making the tests less sensitive to timing is
 an ongoing task.

.. and my build and test system is especially slow (sometimes helpful to
detect race conditions).

The APR crash is probably PR 51813. I added the crash info to BZ after
Chris pointed me to it.

   - Catalina:j2eeType=WebModule,name=//localhost attribute
 ignoreAnnotations switched from true to false,
 Need to look in to that.

I double checked, it is really like that.

   - platform MBean java.lang:type=Threading shows 4 more (daemon)
 threads
 OK.

Here are the details, which look OK to me, except for Thread-4:

Directly after start:

only for TC 7
- ajp-bio-8009-AsyncTimeout
- http-bio-8080-AsyncTimeout
- Low Memory Detector (JVM internal)

only for TC 8a
- ajp-nio-8009-ClientPoller-0
- ajp-nio-8009-ClientPoller-1
- http-nio-8080-ClientPoller-0
- http-nio-8080-ClientPoller-1
- NioBlockingSelector.BlockPoller-1
- NioBlockingSelector.BlockPoller-2
- Service Thread (JVM internal)
- Thread-4

and after the first request was handled TC 7 also shows
SnakeWebSocketServlet Timer.

The Thread-4 has stack

   java.lang.Thread.State: RUNNABLE
at sun.nio.ch.SolarisEventPort.portGet(Native Method)
at sun.nio.ch.SolarisEventPort.access$400(SolarisEventPort.java:38)
at
sun.nio.ch.SolarisEventPort$EventHandlerTask.run(SolarisEventPort.java:167)
at java.lang.Thread.run(Thread.java:724)

and gets started between NioBlockingSelector.BlockPoller-2 and
ContainerBackgroundProcessor[StandardEngine[Catalina]]. Not sure whether
it is started by the JVM under the hood, but if we create it ourselves
we should probably give it a name.

   - platform MBean java.lang:type=OperatingSystem show 88 open file
 descriptors instead of 61
 Worth just checking what those files are.

I checked again and those are:

- multiple times poll devices and FIFOs (probably due to NIO)
- some additional TC jars (websocket, spdy, jni, storeconfig)
- some addition JDK jars (JDK 7 vs. 6)

So it looks OK to me.

What I noticed: the global web.xml directly after start has 9 FDs open
for it (TC 7) resp. 5 (TC 8). After the first GC those are gone, so
probably only a finalizer thing and not problematic.

 - org.apache.tomcat.util.net.TestCustomSsl
   - (old) BIO twice Exception getting SSL attributes
 in org.apache.coyote.http11.Http11Processor actionInternal
 exception is:
 javax.net.ssl.SSLProtocolException: handshake alert: no_certificate
   - (old) NIO twice Exception re-negotiating SSL connection
 in org.apache.coyote.http11.Http11NioProcessor actionInternal
 Need to check.

Note that those also exist for TC 7 at least since 7.0.11.

 - tribes: several warnings (41), numbers up by 22 from 7.0.42.
   Mostly same types of messages.
 Probably OK but should check.

The types of messages are the same as for TC 7.


Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-05 Thread Mark Thomas
On 05/08/2013 11:49, Rainer Jung wrote:
 Hi Mark,
 
 thanks for the thorough inspection of my results. I'll try to make sure
 that I won't include now known false positives in future reports.

No problem. I'd rather a few false positives than a few false negatives.

 On 04.08.2013 18:14, Mark Thomas wrote:
 On 03/08/2013 12:06, Rainer Jung wrote:
 Overview:

 - one crash in tcnative during unit tests
 - MBeans indicate common loader is gone (is that expected?
   At least the common.loader entry still exists in catalina.properties)
 Expected as StandardClassLoader has been removed. That decision is
 reversible of there is a use case for having the class loader visible in
 JMX.
 
 So the common loader still exists but is a URLClassLoader?

Correct.

 ! Unit tests few failures and errors:
 These need looking at. Note: Many of the tests are timing sensitive and
 do not fail consistently. Making the tests less sensitive to timing is
 an ongoing task.
 
 .. and my build and test system is especially slow (sometimes helpful to
 detect race conditions).
 
 The APR crash is probably PR 51813. I added the crash info to BZ after
 Chris pointed me to it.
 
   - Catalina:j2eeType=WebModule,name=//localhost attribute
 ignoreAnnotations switched from true to false,
 Need to look in to that.
 
 I double checked, it is really like that.

OK. Still on the TODO list.

   - platform MBean java.lang:type=Threading shows 4 more (daemon)
 threads
 OK.
 
 Here are the details, which look OK to me, except for Thread-4:
 
 Directly after start:
 
 only for TC 7
 - ajp-bio-8009-AsyncTimeout
 - http-bio-8080-AsyncTimeout
 - Low Memory Detector (JVM internal)
 
 only for TC 8a
 - ajp-nio-8009-ClientPoller-0
 - ajp-nio-8009-ClientPoller-1
 - http-nio-8080-ClientPoller-0
 - http-nio-8080-ClientPoller-1
 - NioBlockingSelector.BlockPoller-1
 - NioBlockingSelector.BlockPoller-2
 - Service Thread (JVM internal)
 - Thread-4
 
 and after the first request was handled TC 7 also shows
 SnakeWebSocketServlet Timer.
 
 The Thread-4 has stack
 
java.lang.Thread.State: RUNNABLE
 at sun.nio.ch.SolarisEventPort.portGet(Native Method)
 at sun.nio.ch.SolarisEventPort.access$400(SolarisEventPort.java:38)
 at
 sun.nio.ch.SolarisEventPort$EventHandlerTask.run(SolarisEventPort.java:167)
 at java.lang.Thread.run(Thread.java:724)
 
 and gets started between NioBlockingSelector.BlockPoller-2 and
 ContainerBackgroundProcessor[StandardEngine[Catalina]]. Not sure whether
 it is started by the JVM under the hood, but if we create it ourselves
 we should probably give it a name.

+1.

   - platform MBean java.lang:type=OperatingSystem show 88 open file
 descriptors instead of 61
 Worth just checking what those files are.
 
 I checked again and those are:
 
 - multiple times poll devices and FIFOs (probably due to NIO)
 - some additional TC jars (websocket, spdy, jni, storeconfig)
 - some addition JDK jars (JDK 7 vs. 6)
 
 So it looks OK to me.
 
 What I noticed: the global web.xml directly after start has 9 FDs open
 for it (TC 7) resp. 5 (TC 8). After the first GC those are gone, so
 probably only a finalizer thing and not problematic.
 
 - org.apache.tomcat.util.net.TestCustomSsl
   - (old) BIO twice Exception getting SSL attributes
 in org.apache.coyote.http11.Http11Processor actionInternal
 exception is:
 javax.net.ssl.SSLProtocolException: handshake alert: no_certificate
   - (old) NIO twice Exception re-negotiating SSL connection
 in org.apache.coyote.http11.Http11NioProcessor actionInternal
 Need to check.
 
 Note that those also exist for TC 7 at least since 7.0.11.

OK. Expected then.

 - tribes: several warnings (41), numbers up by 22 from 7.0.42.
   Mostly same types of messages.
 Probably OK but should check.
 
 The types of messages are the same as for TC 7.

OK.

Thanks,

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-05 Thread Rainer Jung
On 05.08.2013 18:22, Mark Thomas wrote:
 On 05/08/2013 11:49, Rainer Jung wrote:

 The Thread-4 has stack

java.lang.Thread.State: RUNNABLE
 at sun.nio.ch.SolarisEventPort.portGet(Native Method)
 at sun.nio.ch.SolarisEventPort.access$400(SolarisEventPort.java:38)
 at
 sun.nio.ch.SolarisEventPort$EventHandlerTask.run(SolarisEventPort.java:167)
 at java.lang.Thread.run(Thread.java:724)

 and gets started between NioBlockingSelector.BlockPoller-2 and
 ContainerBackgroundProcessor[StandardEngine[Catalina]]. Not sure whether
 it is started by the JVM under the hood, but if we create it ourselves
 we should probably give it a name.

Unfortunately we can't :(

Stack at thread creation is:

at java.lang.Thread.init(Thread.java:439)
at java.lang.Thread.init(Thread.java:479)
at sun.nio.ch.ThreadPool$1.newThread(ThreadPool.java:45)
at
sun.nio.ch.AsynchronousChannelGroupImpl$2.run(AsynchronousChannelGroupImpl.java:123)
at
sun.nio.ch.AsynchronousChannelGroupImpl$2.run(AsynchronousChannelGroupImpl.java:118)
at java.security.AccessController.doPrivileged(Native Method)
at
sun.nio.ch.AsynchronousChannelGroupImpl.startInternalThread(AsynchronousChannelGroupImpl.java:118)
at
sun.nio.ch.AsynchronousChannelGroupImpl.startThreads(AsynchronousChannelGroupImpl.java:132)
at sun.nio.ch.SolarisEventPort.start(SolarisEventPort.java:82)
at
sun.nio.ch.SolarisAsynchronousChannelProvider.openAsynchronousChannelGroup(SolarisAsynchronousChannelProvider.java:65)
at
java.nio.channels.AsynchronousChannelGroup.withCachedThreadPool(AsynchronousChannelGroup.java:233)
at
org.apache.tomcat.websocket.WsWebSocketContainer.clinit(WsWebSocketContainer.java:116)
at org.apache.tomcat.websocket.server.WsSci.init(WsSci.java:130)
at org.apache.tomcat.websocket.server.WsSci.onStartup(WsSci.java:47)

and the code in WsWebSocketContainer provides a thread factory that does
set a sensible name. But Thread-4 is some JDK internal thread we can't
influence. Here's the relevant snippet of JDK code:

117 private void startInternalThread(final Runnable task) {
118 AccessController.doPrivileged(new PrivilegedActionVoid() {
119 @Override
120 public Void run() {
121 // internal threads should not be visible to
application so
122 // cannot use user-supplied thread factory
123
ThreadPool.defaultThreadFactory().newThread(task).start();
124 return null;
125 }
126  });
127 }
128
./jdk/src/share/classes/sun/nio/ch/AsynchronousChannelGroupImpl.java

So we have to live with that. Code looks the same in Java 8.

Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-04 Thread Olivier Lamy
2013/8/2 Mark Thomas ma...@apache.org:
 The proposed Apache Tomcat 8.0.0 release candidate 1 is now available
 for voting.

 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. That said:
 - Servlet 3.1 is complete
 - JSP 2.3 is complete
 - EL 3.0 is complete
 - WebSocket 1.0 is complete
 - DBCP2 is working but in a state of flux but the early stages of JMX
   monitoring are available


 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-048/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC1/

 The proposed 8.0.0-RC1 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC1 alpha

Tested with some applications


 Cheers,

 Mark

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




-- 
Olivier Lamy
Ecetera: http://ecetera.com.au
http://twitter.com/olamy | http://linkedin.com/in/olamy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-04 Thread Mark Thomas
On 03/08/2013 12:06, Rainer Jung wrote:
 Overview:
 
 - one crash in tcnative during unit tests
 - MBeans indicate common loader is gone (is that expected?
   At least the common.loader entry still exists in catalina.properties)
Expected as StandardClassLoader has been removed. That decision is
reversible of there is a use case for having the class loader visible in
JMX.

 - some MBean data gone (resource cache statistics, environment content)
Resource cache is expected. Env is not. Might need to add more JMX stats
to new WebResource implementation.

 - Catalina:j2eeType=WebModule,name=//localhost attribute
   workDir switched from work/Catalina/localhost/_
   to work/Catalina/localhost/ROOT
Expected.

 - new SEVERE and Exceptions in unit test output, maybe expected
Unless the test fails then these should be expected.

 - bayeaux and tomcat-lite modules not bundled
Expected. I won't be copying these to tc8.0.x/trunk

 - MD5 OK
 - signatures OK
 - key in KEYS file
 - gz and zip for src and bin consistent
 ! src consistent with svn tag except:
   - modules bayeux and tomcat-lite not in src
See above.

   - file
 res/META-INF/tomcat-websocket.jar/services/javax.servlet.ServletContainerInitializer
 has Unix line ends in svn, but the src archives
 for Unix and Windows both contain it with DOS line ends
It wasn't treated as a text file. Now fixed.

 ! builds fine but
   - several warning about unsafe or unchecked operations.
 See full list at end of mail.
I was expecting all of those to be unfixable. To double-check I disabled
Eclipse's hide unavoidable generics errors and to my surprise ~30% were
easily fixable. These have been fixed. The rest do look to be unavoidable.

Digging into the 'fixes' all they appear to be doing is using a JRE
method that already has @SupressWarnings so arguably Eclipse was right.
Even so, I am no longer as strongly +1 for using this option as I have been.

 - build result looks consistent with binaries
 - no checkstyle complaints
 - only few Javadoc warnings, I fixed those
 ! Unit tests few failures and errors:
These need looking at. Note: Many of the tests are timing sensitive and
do not fail consistently. Making the tests less sensitive to timing is
an ongoing task.

 
   - Timing: TestWebSocketFrameClient.testConnectToServerEndpointSSL()
 took 63-66 seconds, but expects only 60 seconds.
 
 
   - On NIO in addition (same test):
 
 java.lang.NullPointerException
 at
 org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:276)
 at
 org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:692)
 at
 org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223)
 at
 org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1592)
 at
 org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550)
 at
 java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
 at
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
 at java.lang.Thread.run(Thread.java:724)
 
 
   - On APR in addition a crash (core) in:
 
  b76dfe74 Java_org_apache_tomcat_jni_Socket_recv (30b528, b30ff188,
 b30fd09c, b29500, b30ff214, 0) + 34
  fbc0f780 * org/apache/tomcat/jni/Socket.recv(J[BII)I+32362
  fbc0f72c * org/apache/tomcat/jni/Socket.recv(J[BII)I+0
  fbc068ec *
 org/apache/coyote/http11/upgrade/AprServletInputStream.doRead(Z[BII)I+73
 (line 101)
  fbc068ec *
 org/apache/coyote/http11/upgrade/AbstractServletInputStream.read([BII)I+20
 (line 229)
  fbc068ec *
 org/apache/tomcat/websocket/server/WsFrameServer.onDataAvailable()V+46
 (line 89)
  fbc06b84 *
 org/apache/tomcat/websocket/server/WsHttpUpgradeHandler$WsReadListener.onDataAvailable()V+4
 (line 384)
  fbc0771c *
 org/apache/coyote/http11/upgrade/AbstractServletInputStream.onDataAvailable()V+11
 (line 337)
  fbc06b84 *
 org/apache/coyote/http11/upgrade/AbstractProcessor.upgradeDispatch(Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+11
 (line 189)
  fbc073e0 *
 org/apache/coyote/AbstractProtocol$AbstractConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+171
 (line 1221)
  fbc06848 *
 org/apache/coyote/http11/Http11AprProtocol$Http11ConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+76
 (line 546)
  fbc073e0 *
 org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.doRun()V+26 (line
 4492)
  fbc06b84 *
 org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.run()V+55 (line 4468)
 ...
 
 GDB tells my:
 
 #7  0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528,

Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-04 Thread Christopher Schultz
Rainer,

On 8/3/13 6:06 AM, Rainer Jung wrote:
   - On APR in addition a crash (core) in:
 
  b76dfe74 Java_org_apache_tomcat_jni_Socket_recv (30b528, b30ff188,
 b30fd09c, b29500, b30ff214, 0) + 34
  fbc0f780 * org/apache/tomcat/jni/Socket.recv(J[BII)I+32362
  fbc0f72c * org/apache/tomcat/jni/Socket.recv(J[BII)I+0
  fbc068ec *
 org/apache/coyote/http11/upgrade/AprServletInputStream.doRead(Z[BII)I+73
 (line 101)
  fbc068ec *
 org/apache/coyote/http11/upgrade/AbstractServletInputStream.read([BII)I+20
 (line 229)
  fbc068ec *
 org/apache/tomcat/websocket/server/WsFrameServer.onDataAvailable()V+46
 (line 89)
  fbc06b84 *
 org/apache/tomcat/websocket/server/WsHttpUpgradeHandler$WsReadListener.onDataAvailable()V+4
 (line 384)
  fbc0771c *
 org/apache/coyote/http11/upgrade/AbstractServletInputStream.onDataAvailable()V+11
 (line 337)
  fbc06b84 *
 org/apache/coyote/http11/upgrade/AbstractProcessor.upgradeDispatch(Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+11
 (line 189)
  fbc073e0 *
 org/apache/coyote/AbstractProtocol$AbstractConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+171
 (line 1221)
  fbc06848 *
 org/apache/coyote/http11/Http11AprProtocol$Http11ConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+76
 (line 546)
  fbc073e0 *
 org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.doRun()V+26 (line
 4492)
  fbc06b84 *
 org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.run()V+55 (line 4468)
 ...
 
 GDB tells my:
 
 #7  0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528,
 o=0xb30ff188, sock=optimized out, buf=0xb30ff214, offset=0,
 toread=8192) at src/network.c:733
 733 if ((ss = (*s-net-recv)(s-opaque, sb, nbytes)) ==
 APR_SUCCESS)
 
 #7  0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528,
 o=0xb30ff188, sock=optimized out, buf=0xb30ff214, offset=0,
 toread=8192) at src/network.c:733
 sb =
 \000\006\026\200\000\fÞ̳\017Ñ\000·\205{Í·\205{س\017Ñ\234³\017Ñ\030³\017Ш·\227(p»\204H\200ò\032\226x\000\000\000\023\000\000\000\000ûÁ\227hò\032\227\020³\017Ñ8³\017Ñ8ûÀhH\000\000\b¹³\017Ñh³\017ÑHûÀhH³\017ÑP\000\000\002°·\211+Ø\000\000\000u\000\000\000\000ò\032\227
 ò\032\226\210ò\032\226\210\000\000\000u\000\000\000\000³\017ÑhûÀhH»\204Hh¼Ð¬h\000\000\001\032\000\000\000\000³\017Ñ\230·\225x'·\225xH³\017Ò$³\017Ñ
  
 ³\017Ñ8·\225}ø\000\060´\000\000\000\000\000\000\000\000¶\000\000\000\000ûÁÄÀ...
 s = 0xb29500
 nbytes = 8192
 ss = optimized out
 
 (gdb) print *s
 $5 = {pool = 0xb294c0, child = 0x0, sock = 0x0, opaque = 0xb297d8,
   jsbbuff = 0x330398 HTTP/1.1 101 Switching Protocols\r\nServer:
 Apache-Coyote/1.1\r\nUpgrade: websocket\r\nConnection:
 upgrade\r\nSec-WebSocket-Accept: tPEj68f24a5073zco+NHsEUCKpY=\r\nDate:
 Fri, 02 Aug 2013 12:52:53 GMT\r\n\r\n,
   jrbbuff = 0xbfbc78 GET /firehose HTTP/1.1\r\nSec-WebSocket-Version:
 13\r\nUpgrade: websocket\r\nHost: localhost:59353\r\nSec-WebSocket-Key:
 qzlX6/aQxs4TAKyKCb+XLg==\r\nConnection: upgrade\r\n\r\n, net = 0x0, pe
 = 0xb87958, last_active = 0, timeout = -2}
 
 The reason for the crash is likely:
 
 (gdb) print s-net
 $7 = (tcn_nlayer_t *) 0x0
 
 So dereferencing it in (*s-net-recv) gives a segfault.

Sounds like https://issues.apache.org/bugzilla/show_bug.cgi?id=51813

I haven't committed a patch for this, yet. Can you add this same
information to that bug to make sure I get that particular call? I think
it's already there, but just in case.

-chris



signature.asc
Description: OpenPGP digital signature


Re: [VOTE] Release Apache Tomcat 8.0.0-RC1

2013-08-03 Thread Rainer Jung
On 01.08.2013 22:53, Mark Thomas wrote:
 The proposed Apache Tomcat 8.0.0 release candidate 1 is now available
 for voting.
 
 Given this is a release candidate I am working on the basis that it is
 equivalent to an alpha. That said:
 - Servlet 3.1 is complete
 - JSP 2.3 is complete
 - EL 3.0 is complete
 - WebSocket 1.0 is complete
 - DBCP2 is working but in a state of flux but the early stages of JMX
   monitoring are available
 
 
 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/
 The Maven staging repo is:
 https://repository.apache.org/content/repositories/orgapachetomcat-048/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC1/
 
 The proposed 8.0.0-RC1 release is:
 [ ] Broken - do not release
 [X] Alpha - go ahead and release as 8.0.0-RC1 alpha

+1 as an alpha and congrats!

Overview:

- one crash in tcnative during unit tests
- MBeans indicate common loader is gone (is that expected?
  At least the common.loader entry still exists in catalina.properties)
- some MBean data gone (resource cache statistics, environment content)
- Catalina:j2eeType=WebModule,name=//localhost attribute
  workDir switched from work/Catalina/localhost/_
  to work/Catalina/localhost/ROOT
- new SEVERE and Exceptions in unit test output, maybe expected
- bayeaux and tomcat-lite modules not bundled


- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
! src consistent with svn tag except:
  - modules bayeux and tomcat-lite not in src
  - file
res/META-INF/tomcat-websocket.jar/services/javax.servlet.ServletContainerInitializer
has Unix line ends in svn, but the src archives
for Unix and Windows both contain it with DOS line ends
! builds fine but
  - several warning about unsafe or unchecked operations.
See full list at end of mail.
- build result looks consistent with binaries
- no checkstyle complaints
- only few Javadoc warnings, I fixed those
! Unit tests few failures and errors:

  - Timing: TestWebSocketFrameClient.testConnectToServerEndpointSSL()
took 63-66 seconds, but expects only 60 seconds.


  - On NIO in addition (same test):

java.lang.NullPointerException
at
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:276)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:692)
at
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1592)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:724)


  - On APR in addition a crash (core) in:

 b76dfe74 Java_org_apache_tomcat_jni_Socket_recv (30b528, b30ff188,
b30fd09c, b29500, b30ff214, 0) + 34
 fbc0f780 * org/apache/tomcat/jni/Socket.recv(J[BII)I+32362
 fbc0f72c * org/apache/tomcat/jni/Socket.recv(J[BII)I+0
 fbc068ec *
org/apache/coyote/http11/upgrade/AprServletInputStream.doRead(Z[BII)I+73
(line 101)
 fbc068ec *
org/apache/coyote/http11/upgrade/AbstractServletInputStream.read([BII)I+20
(line 229)
 fbc068ec *
org/apache/tomcat/websocket/server/WsFrameServer.onDataAvailable()V+46
(line 89)
 fbc06b84 *
org/apache/tomcat/websocket/server/WsHttpUpgradeHandler$WsReadListener.onDataAvailable()V+4
(line 384)
 fbc0771c *
org/apache/coyote/http11/upgrade/AbstractServletInputStream.onDataAvailable()V+11
(line 337)
 fbc06b84 *
org/apache/coyote/http11/upgrade/AbstractProcessor.upgradeDispatch(Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+11
(line 189)
 fbc073e0 *
org/apache/coyote/AbstractProtocol$AbstractConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+171
(line 1221)
 fbc06848 *
org/apache/coyote/http11/Http11AprProtocol$Http11ConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+76
(line 546)
 fbc073e0 *
org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.doRun()V+26 (line
4492)
 fbc06b84 *
org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.run()V+55 (line 4468)
...

GDB tells my:

#7  0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528,
o=0xb30ff188, sock=optimized out, buf=0xb30ff214, offset=0,
toread=8192) at src/network.c:733
733 if ((ss = (*s-net-recv)(s-opaque, sb, nbytes)) ==
APR_SUCCESS)

#7  0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528,
o=0xb30ff188, sock=optimized out, buf=0xb30ff214, 

  1   2   >