Re: [tomcat] branch main updated: Many improvements.

2023-02-20 Thread Mark Thomas
On 18/02/2023 05:43, Han Li wrote: On Feb 17, 2023, at 17:17, Rémy Maucherat wrote: On Fri, Feb 17, 2023 at 4:32 AM wrote: -ciphers.removeAll(movedCiphers); +movedCiphers.forEach(ciphers::remove); Ok for some of them maybe, but I don't understand why one this is better.

Re: [tomcat] branch main updated: Many improvements.

2023-02-17 Thread Han Li
> On Feb 17, 2023, at 17:17, Rémy Maucherat wrote: > > On Fri, Feb 17, 2023 at 4:32 AM wrote: >> -ciphers.removeAll(movedCiphers); >> +movedCiphers.forEach(ciphers::remove); > > Ok for some of them maybe, but I don't understand why one this is better.

Re: [tomcat] branch main updated: Many improvements.

2023-02-17 Thread Rémy Maucherat
On Fri, Feb 17, 2023 at 4:32 AM wrote: > -ciphers.removeAll(movedCiphers); > +movedCiphers.forEach(ciphers::remove); Ok for some of them maybe, but I don't understand why one this is better. Rémy > ciphers.addAll(movedCiphers); > } > > @@ -582,7 +582,7 @@ public