Re: DEBUG binaries for win32/win64

2019-02-25 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Mark,

On 2/25/19 09:42, Mark Thomas wrote:
> On 25/02/2019 14:17, Christopher Schultz wrote:
>> All,
>> 
>> At the risk of making the build for Windows even more onerous,
>> would it be possible to distribute DEBUG builds along with the
>> standard ones?
>> 
>> The native stack trace in this bug report[1] for example is 
>> non-existent and useless because it just says:
>> 
>> # Problematic frame: # C  [tcnative-1.dll+0x60895]
>> 
>> If I had a Windows development environment and that same version
>> from the svn branch and my compiler settings were exactly what
>> was used by the Release Manager for that particular version, I
>> might be able to resolve tcnative-1.dll+0x60895 to the right
>> function and, nf I'm lucky, the right line of code.
>> 
>> But the compiler can build all that into the binary, so why
>> bother fiddling with all that nonsense? We should be able to tell
>> the bug-reporter "please replace the regular build with the DEBUG
>> one and try again to get better data" and, likely, we'll get
>> better data.
>> 
>> WDYT?
> 
> It probably means debug builds for OpenSSL and APR as well.
> 
> Speaking as the current RM, if someone updates [2] I have no
> objection to turning the handle. If the expectation is that I
> figure out what changes are required then it will happen (I think
> it is a good idea) but it is going to take longer.

I think (*think*!) that building a debug version of a binary with
msvc++ just requires adding /DEBUG to the command-line, so it should
be fairly straightforward. Building tcnative with /DEBUG should be
easy even if we don't bundle a DEBUG version of APR and/or OpenSSL.
Can we try that to begin with?

Thanks,
- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlx0BOQACgkQHPApP6U8
pFgQmQ/+LaZX5vRFlrKEGfkCdcy14atOBL0mxwQT7g42wkiCqiyc+RwEkXcoVj0D
tiSKGm/7cha4Vp20Ni+jVMsHff1oaOhY5i/5KJTWaPwH7FCpMcfkH7dPyOJVMqc3
fofyWxgr/41kRI2HPDgkKrF+e87xrrOF+Z2JGEnLnoSWAGxv02Bd6oevE0VYEpH1
6tCCRVIUzCdsnzouMzn2kIUhtYvyb3v1uYTqWvxIlnRgSB2OtIzweM07PNyOhse9
GiVn0EahK3wHy9Wm7V07g7TI1JckZZaxIpmmAEzxfZFCw2nm1rhnCHc2ldPgyWMS
/2bbN+oEqwJiIZRVM3r2NhZn35UXcFS9s/tkM/69WFMho81oFYylk/eFfhDqtkpU
UBXdQ2svsTyIfNJNFzIDSCjOLttmfKjC+8NIeiTK3eEoBTBW5q/PAcPhOqYaEwje
ZtSAeqwrnmNwXU1sZ6EiiyafK0uFmWDgREaF+M8QjGBsacv21DdqqKlQIEWDMiFk
Y0QaVKGfAycYLYkPHdvvGkAOVsvBuY5SIFrJja00MBXfqHSgMjSPPo3xBCEGyISa
OAVVad9AMVRMPLHgvf/5kuDm71YpgYBQxWZZQP6eU7r9e9qQmYgvvRdl6LAGSxZi
3cd513CXHEBqPrrxhQKG1p8oE76BVsThF9K6TLlktubr8jqGLZI=
=ak/E
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: DEBUG binaries for win32/win64

2019-02-25 Thread Mark Thomas
On 25/02/2019 14:17, Christopher Schultz wrote:
> All,
> 
> At the risk of making the build for Windows even more onerous, would
> it be possible to distribute DEBUG builds along with the standard ones?
> 
> The native stack trace in this bug report[1] for example is
> non-existent and useless because it just says:
> 
> # Problematic frame:
> # C  [tcnative-1.dll+0x60895]
> 
> If I had a Windows development environment and that same version from
> the svn branch and my compiler settings were exactly what was used by
> the Release Manager for that particular version, I might be able to
> resolve tcnative-1.dll+0x60895 to the right function and, nf I'm
> lucky, the right line of code.
> 
> But the compiler can build all that into the binary, so why bother
> fiddling with all that nonsense? We should be able to tell the
> bug-reporter "please replace the regular build with the DEBUG one and
> try again to get better data" and, likely, we'll get better data.
> 
> WDYT?

It probably means debug builds for OpenSSL and APR as well.

Speaking as the current RM, if someone updates [2] I have no objection
to turning the handle. If the expectation is that I figure out what
changes are required then it will happen (I think it is a good idea) but
it is going to take longer.

Mark


[2]
https://cwiki.apache.org/confluence/display/TOMCAT/Building+the+Tomcat+Native+Connector+binaries+for+Windows


> 
> Thanks,
> -chris
> 
> [1] https://bz.apache.org/bugzilla/show_bug.cgi?id=63199#c0
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org