Re: Plans for 9.0.0.M24 / 8.5.18

2017-07-17 Thread Christopher Schultz 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Rémy,

On 7/17/17 8:41 AM, Rémy Maucherat wrote:
> On Mon, Jul 17, 2017 at 1:43 PM, Mark Thomas 
> wrote:
> 
>> On 17/07/17 11:20, Rémy Maucherat wrote:
>>> On Mon, Jul 17, 2017 at 9:59 AM, Mark Thomas 
>>> wrote:
>>> 
 Hi,
 
 I plan to check that the unit tests pass for the current
 trunks and then tag these. If everything goes well, this
 should happen later today.
 
>>> +1
>>> 
>>> Should we continue cleaning up findbugs after that ?
>> 
>> I thought I had fixed all of those...
>> 
>> Ah, I always run FindBugs from the IDE rather than the command
>> line. I've just run it from the command line. Ouch.
>> 
>> Looks like the command line is configured to report Low
>> confidence issues and above whereas my IDE reports Medium
>> confidence issues and above by default.
>> 
>> The first handful of issues I looked at seemed valid but of
>> (very) low severity so it looks like there is some work to do
>> there :(
>> 
>> I'm currently thinking that I'll look at these after tagging.
>> Given the number of issues, it might be a couple of releases
>> before they are all resolved.
>> 
> 
> I was looking at the report produced from the command line. Coty
> was looking at beginner stuff, so there's plenty of that here (when
> the issues are valid enough) :)

There are a lot of things in the Coverty scan, too -- many of which
are either non-issues or false-positives.

- -chris
-BEGIN PGP SIGNATURE-
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCAAGBQJZbRO7AAoJEBzwKT+lPKRYPZ8QALSPEQrECeNITwuMD1h4bS3T
9KRv+Gterxv5UEQIbb95DZsFTSMDCCYqxl2dnoruCay/AZekUuEmYQP30ot+yQ13
2OhL3/3WiKsG5HhQFl2ZbKjqOz9YK59xddSjRFtm0McKveNvWx5dHrz7G4DoFYfc
Sxbq9Giqh19g9lL7XJHlOyCEkATQ2kst3eS7qViqO4k/HDMdiW+5tQoODyIkhMfK
dZUNe5sMD6dVHguxCYKlAulFco6Lov1+h154J+O4gMO6dpi384oL7+DJ7qWMrBV/
AJEoiyR/RNaxg+yneUMUh9oYKTcgU8AabXlpmGo8tJ2V6HPSMtY8jKh+kH08nS67
O6PjG5dwjmdr6mHDfG2hYJgvUKW1R73S2Xv35zwAqT9wl0L/sa5yiCU8DjzCw6Nc
pIIr4HwPfBEJdW8PuWjwlWnv0jackKwMxatTjTATIGdwwaq7qYy4rf337b5QcHUu
PAC45pmtc+pvZAwzeEEUuOadIvWTQceFpM/zkiZsM5ld87DwAVJ4sZ8UcXaaWfhq
2vfpnxFsCg3kNNKAfcRjXcJEO2FEBZkMxy4wt3c4053+lo9MzTUDRPaBFSLV/Cz7
7OniJ69/Dr/w8k4AySTjPI1QNHdiITHkG0UPhWz54xEbY4GyvOmOh1VW/of/uBfT
kUy/ciR18T2WgwmvWrCx
=1x7M
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Plans for 9.0.0.M24 / 8.5.18

2017-07-17 Thread Rémy Maucherat 
On Mon, Jul 17, 2017 at 1:43 PM, Mark Thomas  wrote:

> On 17/07/17 11:20, Rémy Maucherat wrote:
> > On Mon, Jul 17, 2017 at 9:59 AM, Mark Thomas  wrote:
> >
> >> Hi,
> >>
> >> I plan to check that the unit tests pass for the current trunks and then
> >> tag these. If everything goes well, this should happen later today.
> >>
> > +1
> >
> > Should we continue cleaning up findbugs after that ?
>
> I thought I had fixed all of those...
>
> Ah, I always run FindBugs from the IDE rather than the command line.
> I've just run it from the command line. Ouch.
>
> Looks like the command line is configured to report Low confidence
> issues and above whereas my IDE reports Medium confidence issues and
> above by default.
>
> The first handful of issues I looked at seemed valid but of (very) low
> severity so it looks like there is some work to do there :(
>
> I'm currently thinking that I'll look at these after tagging. Given the
> number of issues, it might be a couple of releases before they are all
> resolved.
>

I was looking at the report produced from the command line. Coty was
looking at beginner stuff, so there's plenty of that here (when the issues
are valid enough) :)

>
> On a related note, I think I've found the root cause of some of the
> intermittent HTTP/2 test failures. I'm investigating a possible fix.
>
> Of course, there is nothing stopping anyone starting on the FindBugs
> issues now if they feel the urge to scratch that itch.
>
> Rémy

Re: Plans for 9.0.0.M24 / 8.5.18

2017-07-17 Thread Mark Thomas 
On 17/07/17 11:20, Rémy Maucherat wrote:
> On Mon, Jul 17, 2017 at 9:59 AM, Mark Thomas  wrote:
> 
>> Hi,
>>
>> I plan to check that the unit tests pass for the current trunks and then
>> tag these. If everything goes well, this should happen later today.
>>
> +1
> 
> Should we continue cleaning up findbugs after that ?

I thought I had fixed all of those...

Ah, I always run FindBugs from the IDE rather than the command line.
I've just run it from the command line. Ouch.

Looks like the command line is configured to report Low confidence
issues and above whereas my IDE reports Medium confidence issues and
above by default.

The first handful of issues I looked at seemed valid but of (very) low
severity so it looks like there is some work to do there :(

I'm currently thinking that I'll look at these after tagging. Given the
number of issues, it might be a couple of releases before they are all
resolved.

On a related note, I think I've found the root cause of some of the
intermittent HTTP/2 test failures. I'm investigating a possible fix.

Of course, there is nothing stopping anyone starting on the FindBugs
issues now if they feel the urge to scratch that itch.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Plans for 9.0.0.M24 / 8.5.18

2017-07-17 Thread Rémy Maucherat 
On Mon, Jul 17, 2017 at 9:59 AM, Mark Thomas  wrote:

> Hi,
>
> I plan to check that the unit tests pass for the current trunks and then
> tag these. If everything goes well, this should happen later today.
>
> +1

Should we continue cleaning up findbugs after that ?

Rémy