Re: svn commit: r1832936 - /tomcat/native/trunk/native/src/sslutils.c
On 05/06/18 15:21, Mark Thomas wrote: > On 05/06/18 13:55, jfcl...@apache.org wrote: >> Author: jfclere >> Date: Tue Jun 5 12:55:05 2018 >> New Revision: 1832936 >> >> URL: http://svn.apache.org/viewvc?rev=1832936=rev >> Log: >> ssl_ocsp_request() sets the error correctly already. >> >> Modified: >> tomcat/native/trunk/native/src/sslutils.c >> >> Modified: tomcat/native/trunk/native/src/sslutils.c >> URL: >> http://svn.apache.org/viewvc/tomcat/native/trunk/native/src/sslutils.c?rev=1832936=1832935=1832936=diff >> == >> --- tomcat/native/trunk/native/src/sslutils.c (original) >> +++ tomcat/native/trunk/native/src/sslutils.c Tue Jun 5 12:55:05 2018 >> @@ -532,7 +532,7 @@ static int ssl_verify_OCSP(int ok, X509_ >> break; >> case OCSP_STATUS_UNKNOWN: >> /* correct error code for application errors? */ >> -X509_STORE_CTX_set_error(ctx, >> X509_V_ERR_APPLICATION_VERIFICATION); >> +// X509_STORE_CTX_set_error(ctx, >> X509_V_ERR_APPLICATION_VERIFICATION); > > Better to remove these two lines and replace with a comment along the > lines of the log message above? Fixed thanks. Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1832936 - /tomcat/native/trunk/native/src/sslutils.c
On 05/06/18 13:55, jfcl...@apache.org wrote: > Author: jfclere > Date: Tue Jun 5 12:55:05 2018 > New Revision: 1832936 > > URL: http://svn.apache.org/viewvc?rev=1832936=rev > Log: > ssl_ocsp_request() sets the error correctly already. > > Modified: > tomcat/native/trunk/native/src/sslutils.c > > Modified: tomcat/native/trunk/native/src/sslutils.c > URL: > http://svn.apache.org/viewvc/tomcat/native/trunk/native/src/sslutils.c?rev=1832936=1832935=1832936=diff > == > --- tomcat/native/trunk/native/src/sslutils.c (original) > +++ tomcat/native/trunk/native/src/sslutils.c Tue Jun 5 12:55:05 2018 > @@ -532,7 +532,7 @@ static int ssl_verify_OCSP(int ok, X509_ > break; > case OCSP_STATUS_UNKNOWN: > /* correct error code for application errors? */ > -X509_STORE_CTX_set_error(ctx, > X509_V_ERR_APPLICATION_VERIFICATION); > +// X509_STORE_CTX_set_error(ctx, > X509_V_ERR_APPLICATION_VERIFICATION); Better to remove these two lines and replace with a comment along the lines of the log message above? Mark > break; > } > } > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
