Re: svn commit: r498053 - in /tomcat/container/tc5.5.x/catalina: build.xml src/share/org/apache/catalina/core/StandardWrapper.java

2007-01-22 Thread Tim Funk
Does this introduces a new dependency on the jsp-api - which could be a regression for people who embed tomcat without using jsp's. Also the checking is not that aggressive any more in the case of nested exceptions. This may leave the root cause still unexposed. This patch seems better:

Re: svn commit: r498053 - in /tomcat/container/tc5.5.x/catalina: build.xml src/share/org/apache/catalina/core/StandardWrapper.java

2007-01-22 Thread Filip Hanik - Dev Lists
did you really wanna add in the JSP-API dependency? Filip [EMAIL PROTECTED] wrote: Author: markt Date: Fri Jan 19 19:07:36 2007 New Revision: 498053 URL: http://svn.apache.org/viewvc?view=revrev=498053 Log: Put the fix back for 39088 now the build is fixed. Sorry for the noise. Modified:

Re: svn commit: r498053 - in /tomcat/container/tc5.5.x/catalina: build.xml src/share/org/apache/catalina/core/StandardWrapper.java

2007-01-22 Thread Mark Thomas
Tim Funk wrote: Does this introduces a new dependency on the jsp-api - which could be a regression for people who embed tomcat without using jsp's. Yes, it does add an additional dependency. I didn't consider the embedded use case. Also the checking is not that aggressive any more in the case

Re: svn commit: r498053 - in /tomcat/container/tc5.5.x/catalina: build.xml src/share/org/apache/catalina/core/StandardWrapper.java

2007-01-22 Thread Tim Funk
I guess one could do this: Create instance variable called JspException which is initialized to protected jspExceptionClazz = Class.forName(javax.servlet.jsp.JspException); Then findRootCause could be this (missing the exception checking) - in this version theRootCause is unneeded but can