Re: org.apache.tomcat.jdbc.pool.ConnectionPool interface?

2023-10-10 Thread Romain Manni-Bucau
Thanks a lot Mark. In the mean time using tomcat-jdbc v10.1.13 works as a
workaround (but needs to take care of transitive deps).

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mar. 10 oct. 2023 à 18:30, Mark Thomas  a écrit :

> On 10/10/2023 10:13, Mark Thomas wrote:
> > On 10/10/2023 09:38, Romain Manni-Bucau wrote:
> >> PS: if it eases the analyzis I guess it is an autoimport/refactor issue:
> >>
> https://github.com/apache/tomcat/commit/a5821ce8ec4626b615a71c9920279a3066735b11#diff-6ec6f1cfd5466f7bef8987d0931a9847d1691c5a81385e4ffd6a7fdb6ddb6cecL371
> >
> > Thanks. That is my fault for thinking the tool I used was smarter than
> > it really was.
> >
> > I'll review the entire commit. I may be some time...
>
> Should be fixed now.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: org.apache.tomcat.jdbc.pool.ConnectionPool interface?

2023-10-10 Thread Mark Thomas

On 10/10/2023 10:13, Mark Thomas wrote:

On 10/10/2023 09:38, Romain Manni-Bucau wrote:

PS: if it eases the analyzis I guess it is an autoimport/refactor issue:
https://github.com/apache/tomcat/commit/a5821ce8ec4626b615a71c9920279a3066735b11#diff-6ec6f1cfd5466f7bef8987d0931a9847d1691c5a81385e4ffd6a7fdb6ddb6cecL371


Thanks. That is my fault for thinking the tool I used was smarter than 
it really was.


I'll review the entire commit. I may be some time...


Should be fixed now.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: org.apache.tomcat.jdbc.pool.ConnectionPool interface?

2023-10-10 Thread Mark Thomas

On 10/10/2023 09:38, Romain Manni-Bucau wrote:

PS: if it eases the analyzis I guess it is an autoimport/refactor issue:
https://github.com/apache/tomcat/commit/a5821ce8ec4626b615a71c9920279a3066735b11#diff-6ec6f1cfd5466f7bef8987d0931a9847d1691c5a81385e4ffd6a7fdb6ddb6cecL371


Thanks. That is my fault for thinking the tool I used was smarter than 
it really was.


I'll review the entire commit. I may be some time...

Mark




Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mar. 10 oct. 2023 à 16:35, Romain Manni-Bucau  a
écrit :


Hi,

in 10.1.14  PooledConnection is a class but it is used to create a jvm
proxy (org.apache.tomcat.jdbc.pool.ConnectionPool#getProxyConstructor) so
it does not work, is it a typo?

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github
 | LinkedIn
 | Book






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: org.apache.tomcat.jdbc.pool.ConnectionPool interface?

2023-10-10 Thread Romain Manni-Bucau
PS: if it eases the analyzis I guess it is an autoimport/refactor issue:
https://github.com/apache/tomcat/commit/a5821ce8ec4626b615a71c9920279a3066735b11#diff-6ec6f1cfd5466f7bef8987d0931a9847d1691c5a81385e4ffd6a7fdb6ddb6cecL371

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mar. 10 oct. 2023 à 16:35, Romain Manni-Bucau  a
écrit :

> Hi,
>
> in 10.1.14  PooledConnection is a class but it is used to create a jvm
> proxy (org.apache.tomcat.jdbc.pool.ConnectionPool#getProxyConstructor) so
> it does not work, is it a typo?
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github
>  | LinkedIn
>  | Book
> 
>


org.apache.tomcat.jdbc.pool.ConnectionPool interface?

2023-10-10 Thread Romain Manni-Bucau
Hi,

in 10.1.14  PooledConnection is a class but it is used to create a jvm
proxy (org.apache.tomcat.jdbc.pool.ConnectionPool#getProxyConstructor) so
it does not work, is it a typo?

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book